Tue, 09 Feb 2016 12:46:23 +0100Related to issue 31354: Difference for price variant calculation
Víctor Martínez Romanos <victor.martinez@openbravo.com> [Tue, 09 Feb 2016 12:46:23 +0100] rev 28597
Related to issue 31354: Difference for price variant calculation

The difference for price variants is now calculated and posted in the Acct. Schema currency as it was originally done

Tue, 17 Nov 2015 17:32:11 +0100Fixed bug 31354: Wrong amtsourcedr and amtsourcecr when posting Matched Invoice
Víctor Martínez Romanos <victor.martinez@openbravo.com> [Tue, 17 Nov 2015 17:32:11 +0100] rev 28596
Fixed bug 31354: Wrong amtsourcedr and amtsourcecr when posting Matched Invoice

The cost is always calculated and posted in the organization's currency.
The expense is calculated and posted in the invoice's currency.

The conversion date from the cost currency to the acct. schema currency uses the shipment accounting date.
The conversion date from the invoice currency to the acct. schema currency uses the invoice accounting date.

The difference for the price variant is calculated and posted in the cost currency.

In case there is a difference in the conversion rate between the order and the invoice, the usual currency balance entry is automatically created

Fri, 12 Feb 2016 09:01:15 +0100related to issue 31766: put correct location selector title
Carlos Aristu <carlos.aristu@openbravo.com> [Fri, 12 Feb 2016 09:01:15 +0100] rev 28595
related to issue 31766: put correct location selector title

Thu, 11 Feb 2016 16:31:20 +0100Fixed bug 32203: Not possible to post a remittance and the settlement of that remittance
Víctor Martínez Romanos <victor.martinez@openbravo.com> [Thu, 11 Feb 2016 16:31:20 +0100] rev 28594
Fixed bug 32203: Not possible to post a remittance and the settlement of that remittance

The way to retrieve the payment detail object was wrong. Instead we can take it directly from the paymentDetails list

Thu, 11 Feb 2016 16:16:57 +0530Fixes Issue 0032157: Not possible to sort by unit price in Return from
Atul Gaware <atul.gaware@openbravo.com> [Thu, 11 Feb 2016 16:16:57 +0530] rev 28593
Fixes Issue 0032157: Not possible to sort by unit price in Return from
Customer p&e

In case of the Return From Customer for a numeric value of unit Price COALESCE
was being use with '' which should have been 0 instead, COALESCE for order no
was missing for RTC, additonal ReturnReasonLeftClause2 added to replace
EntityAlias.name in the transformeredHQL Query.

Thu, 11 Feb 2016 15:57:36 +0100fixes issue 32202: Error in add payment when editing the amount of a record
Carlos Aristu <carlos.aristu@openbravo.com> [Thu, 11 Feb 2016 15:57:36 +0100] rev 28592
fixes issue 32202: Error in add payment when editing the amount of a record

The entered value is being set on the changed method for number items. This is done in order to prevent placing the decimal separator in a wrong place. This problem only affects to standard windows.

To solve the problem we only set the number item value in the changed method when we are not in a pick and edit window but in a standard window.

Fri, 05 Feb 2016 12:02:24 +0100Fixes issue 32089: Reservations with stock in second UOM will not be created
Alvaro Ferraz <alvaro.ferraz@openbravo.com> [Fri, 05 Feb 2016 12:02:24 +0100] rev 28591
Fixes issue 32089: Reservations with stock in second UOM will not be created

M_RESERVE_STOCK_AUTO will exclude lines from m_storage_detail with second uom to avoid create stock reservation lines for products with stock in second UOM, as it is done in M_CREATE_RESERVE_FROM_SOL.

Wed, 10 Feb 2016 17:08:23 +0100Related to issue 32038: code review improvements
Víctor Martínez Romanos <victor.martinez@openbravo.com> [Wed, 10 Feb 2016 17:08:23 +0100] rev 28590
Related to issue 32038: code review improvements

* startingDate is a mandatory column, so there is no need to validate whether it's null or not
* The promotion is applied for the period of time between the Starting and Ending Dates (both inclusive). For example, for a promotion available only in a concrete date, the starting and ending dates must be equal.
The date received as parameter to this query might have a time (hours/minutes/seconds). To control that situation the comparation is truncating the promotion starting and ending date (that should already be truncated because it's linked to a Date reference), it adds 1 day to the promotion ending date and removes the equal clause. Thus we can properly control the scenario of a one-day promotion with a datetime parameter.

Mon, 01 Feb 2016 16:54:12 -0500Fixes Issue 32038: "Price Adjustment" promotion type is applied to a line only
Nono Carballo <f.carballo@nectus.com> [Mon, 01 Feb 2016 16:54:12 -0500] rev 28589
Fixes Issue 32038: "Price Adjustment" promotion type is applied to a line only
if the order/invoice date falls into the promotion period.

The HQL query was tuned to take into account the starting and ending date of the
promotion when selecting a product for a line in a purchase order/invoice.
The line only gets the promotion if the period encloses the order/invoice date,
start and end date included.
The line hql += "and (endingDate is null or endingDate>:date) "; was replaced with

hql += "and (endingDate is null or endingDate>=:date) ";
hql += "and (startingDate is null or startingDate<=:date) ";

Thu, 04 Feb 2016 12:24:30 +0100Fixes issue 32109: Review allow filtering and allow sorting in computed columns
Alvaro Ferraz <alvaro.ferraz@openbravo.com> [Thu, 04 Feb 2016 12:24:30 +0100] rev 28588
Fixes issue 32109: Review allow filtering and allow sorting in computed columns

Computed columns belonging to a table with high volumes or having a complex query have been disabled for filtering and sorting.
Only computed columns in low volume tables and with a simple query will allow filtering and sorting.

Thu, 28 Jan 2016 11:52:33 +0100Fixes issue 32012:Error when validating a costing rule under some circumstances
Alvaro Ferraz <alvaro.ferraz@openbravo.com> [Thu, 28 Jan 2016 11:52:33 +0100] rev 28587
Fixes issue 32012:Error when validating a costing rule under some circumstances

Update M_TRANSACTION_TRG to avoid raise @DocUOMMismatch@ error in case transaction has been created from a opening or closing inventory.

Tue, 09 Feb 2016 13:51:35 +0100Related to issue 31876: Fix format
Alvaro Ferraz <alvaro.ferraz@openbravo.com> [Tue, 09 Feb 2016 13:51:35 +0100] rev 28586
Related to issue 31876: Fix format

Thu, 28 Jan 2016 09:24:21 +0100Fixes issue 31772: Improve performance in Costing Rule validation
Alvaro Ferraz <alvaro.ferraz@openbravo.com> [Thu, 28 Jan 2016 09:24:21 +0100] rev 28585
Fixes issue 31772: Improve performance in Costing Rule validation

Update M_TRANSACTION_TRG to execute M_UPDATE_INVENTORY only when updated columns are not related to costing (like transactioncost, m_costing_algorithm_id, iscostcalculated, c_currency_id, costing_status, isprocessed, checkpricedifference, manualcostadjustment and iscostpermanent).
Update some methods in CostingRuleProcess and CostingRuleProcessOnProcessHandler to use query.uniqueResult() != null instead of query.count() > 0.
Update initializeOldTrx method in CostingRuleProcess to do an insert and an update in hql instead of doing a loop in java.
Change second loop in updateInventoriesCostAndProcessInitInventories method in CostingRuleProcess to use a scroll instead of looping over a list.
Use new getInventoryLineTransactions method in CostingRuleProcess instead of getInventoryLineTransaction method, which returns a scroll.
Use trx.getPhysicalInventoryLine().getRelatedInventory() instead of getInitIcl(cri.getInitInventory(), icl) in CostingRuleProcess.
Change updateInitInventoriesTrxDate method in CostingRuleProcess to do an update in hql instead of doing a loop in java.

Mon, 01 Feb 2016 18:49:06 +0100Fixes issue 31876 & Fixes issue 31902 & Fixes issue 31956: Cannot void shipment
Alvaro Ferraz <alvaro.ferraz@openbravo.com> [Mon, 01 Feb 2016 18:49:06 +0100] rev 28584
Fixes issue 31876 & Fixes issue 31902 & Fixes issue 31956: Cannot void shipment

Cannot void shipment related to reservation.
New reservation to replace the closed related one when voiding a shipment will be done after update m_storage_detail, in order to have voided shipment quantity available.
Reservation stock lines will be created with related shipment line movement quantity in case this quantity is less than pending order quantity.
Reservation will be created with the least quantity between ordered quantity and movement quantity.

Tue, 09 Feb 2016 08:53:35 +0100fixes issue 32149: Upgrade Jackson JSON Processor libraries
Carlos Aristu <carlos.aristu@openbravo.com> [Tue, 09 Feb 2016 08:53:35 +0100] rev 28583
fixes issue 32149: Upgrade Jackson JSON Processor libraries

Fri, 22 Jan 2016 10:12:49 +0100Fixed issue 31943: Add new check in Payment Report to exclude payments with amount = 0
Adrián Romero <adrianromero@openbravo.com> [Fri, 22 Jan 2016 10:12:49 +0100] rev 28582
Fixed issue 31943: Add new check in Payment Report to exclude payments with amount = 0
* Fixing API in PaymentReportDao

Thu, 21 Jan 2016 12:34:54 +0100Fixed issue 31943: Add new check in Payment Report to exclude payments with amount = 0
Adrián Romero <adrianromero@openbravo.com> [Thu, 21 Jan 2016 12:34:54 +0100] rev 28581
Fixed issue 31943: Add new check in Payment Report to exclude payments with amount = 0
* Added translation data

Wed, 20 Jan 2016 09:09:21 -0500Fixed issue 31943: Add new check in Payment Report to exclude payments with amount = 0
Fernando Soto <fernando.soto@peoplewalking.com> [Wed, 20 Jan 2016 09:09:21 -0500] rev 28580
Fixed issue 31943: Add new check in Payment Report to exclude payments with amount = 0

Mon, 08 Feb 2016 13:04:07 +0100related to issue 32091: Covered case when window is opened with a a pre-filter
Carlos Aristu <carlos.aristu@openbravo.com> [Mon, 08 Feb 2016 13:04:07 +0100] rev 28579
related to issue 32091: Covered case when window is opened with a a pre-filter

Mon, 08 Feb 2016 09:33:15 +0100related to issue 32091: Added missing comparator
Carlos Aristu <carlos.aristu@openbravo.com> [Mon, 08 Feb 2016 09:33:15 +0100] rev 28578
related to issue 32091: Added missing comparator

Mon, 08 Feb 2016 09:06:40 +0100related to issue 32091: code review improvements
Carlos Aristu <carlos.aristu@openbravo.com> [Mon, 08 Feb 2016 09:06:40 +0100] rev 28577
related to issue 32091: code review improvements

After sorting the grid without having any filter applied, the selection was not being kept on top. To solve this, now we check if there is a criteria present in the request and also if there are selected records. In that case, a new criteria is included in the request with the ids of the selected records.

Besides, two methods are deleted from AddPaymentOrderInvoicesTransformer as they are no longer needed. And a new check is added when retrieving the selected records in the backend, in order to avoid a possible JSONException.

Tue, 02 Feb 2016 13:45:46 -0500Fixes issue 32084: Process Price Difference adjustment breaks menu
Mark <m.molina@nectus.com> [Tue, 02 Feb 2016 13:45:46 -0500] rev 28576
Fixes issue 32084: Process Price Difference adjustment breaks menu

Were fixed the 3 problems of "Process Price Difference adjustment" menu entry found:

1. It is included into menu folder Warehouse Management | Setup
2. Was renamed to "Process Price Difference Adjustment" to follow the capitalization rule
3. Was included a description and help.

Fri, 05 Feb 2016 11:37:39 +0100Fixes issue 32078: Reserved quantity is not correct
Alvaro Ferraz <alvaro.ferraz@openbravo.com> [Fri, 05 Feb 2016 11:37:39 +0100] rev 28575
Fixes issue 32078: Reserved quantity is not correct

In ManageReservationActionHandler, when clicking Done in Manage Reservation P&E, it was first reserving what the user was typing in the P&E, and if it was not processed the reservation, it was processing it. As the M_RESERVATION_POST tries always to reserve as much as possible, it was overriding the previously set amounts. In order to prevent this, now first the reservation is being processed and after that the values typed in the UI are being set to the reservation.
In case no stock reservation is created by m_reservation_post when processing the reservation, res_status will be Draft. To be sure reservation is set as completed, force status after call ReservationUtils.processReserve method.
Reservation will only be kept as draft in case it has no lines after execute manageReservedStockLines.

Fri, 05 Feb 2016 13:14:11 +0100fixes issue 31766: Application unexpectedly closed using some selectors in Edge
Carlos Aristu <carlos.aristu@openbravo.com> [Fri, 05 Feb 2016 13:14:11 +0100] rev 28574
fixes issue 31766: Application unexpectedly closed using some selectors in Edge

Now selectors based on OBSearchItem class are opened inside an Smartclient pop-up instead of using a new browser window.

Fri, 05 Feb 2016 10:05:58 +0100related to issue 32110: fixes for .fo reports
Carlos Aristu <carlos.aristu@openbravo.com> [Fri, 05 Feb 2016 10:05:58 +0100] rev 28573
related to issue 32110: fixes for .fo reports

Fri, 05 Feb 2016 10:04:46 +0100fixes issue 32110: Upgrade FOP library
Carlos Aristu <carlos.aristu@openbravo.com> [Fri, 05 Feb 2016 10:04:46 +0100] rev 28572
fixes issue 32110: Upgrade FOP library

Fri, 05 Feb 2016 08:58:12 +0100related to issue 32039: reuse constant for upaged ds requests
Asier Lostalé <asier.lostale@openbravo.com> [Fri, 05 Feb 2016 08:58:12 +0100] rev 28571
related to issue 32039: reuse constant for upaged ds requests

Thu, 04 Feb 2016 10:14:27 +0100related to issue 32092: updated copyright year
Carlos Aristu <carlos.aristu@openbravo.com> [Thu, 04 Feb 2016 10:14:27 +0100] rev 28570
related to issue 32092: updated copyright year

Wed, 03 Feb 2016 19:42:14 +0100fixes issue 32092: hidden fields space not restored after reopening form view
Carlos Aristu <carlos.aristu@openbravo.com> [Wed, 03 Feb 2016 19:42:14 +0100] rev 28569
fixes issue 32092: hidden fields space not restored after reopening form view

The alwaysTakeSpace property of the form items was only being set after opening the form view the first time. This property is used to keep space for the displayed field (including the hidden ones by display logic). This property is being set to false when closing form view, and then, never restored again.

Now this property is set every time the UI switches into the form view.

Wed, 03 Feb 2016 19:29:23 +0100fixes issue 32091: The Order/Invoices grid now sorts by selected records first
Carlos Aristu <carlos.aristu@openbravo.com> [Wed, 03 Feb 2016 19:29:23 +0100] rev 28568
fixes issue 32091: The Order/Invoices grid now sorts by selected records first

Now the AddPaymentOrderInvoicesTransformer places first the selected record criteria for ordering, put it just before the ordering criteria selected by the user in the grid.