Wed, 29 Apr 2015 17:33:40 +0200Fixes issue 28668: Pressing Cancel in Match Statement or in Process Reconciliation does not trigger a refresh.
Eduardo Argal Guibert <eduardo.argal@openbravo.com> [Wed, 29 Apr 2015 17:33:40 +0200] rev 26392
Fixes issue 28668: Pressing Cancel in Match Statement or in Process Reconciliation does not trigger a refresh.
Cancel button has been removed as it was considered confusing. Now there are two buttons, one for closing the window called 'OK', as it was before, and another one called 'Reconcile'.

Both triggers refresh. Messages have been added to improve user understanding on how the window works. New message to inform the user any change will be persisted. This message can be disabled once clear and will not popup again. Message to run algorithm as well improved.

Wed, 29 Apr 2015 18:21:34 +0200Related to issue 29687: Added QUnit test cases - Fixed JSLint problem
David Baz Fayos <david.baz@openbravo.com> [Wed, 29 Apr 2015 18:21:34 +0200] rev 26391
Related to issue 29687: Added QUnit test cases - Fixed JSLint problem

Wed, 29 Apr 2015 09:31:14 +0200Related to bug 28927: Fix unmatching error
Unai Martirena <unai.martirena@openbravo.com> [Wed, 29 Apr 2015 09:31:14 +0200] rev 26390
Related to bug 28927: Fix unmatching error

An error was being raised while doing unmatch when using 'addSelectedIDsToCriteria' method. The call to this method has been removed because it is not necessary as the criteria already has the selected ids.

Wed, 29 Apr 2015 17:45:24 +0200related to issue 29719: fixed property store test
Asier Lostalé <asier.lostale@openbravo.com> [Wed, 29 Apr 2015 17:45:24 +0200] rev 26389
related to issue 29719: fixed property store test

CCU property is expected to be present

Wed, 29 Apr 2015 16:24:29 +0200Related to issue 29687: Added QUnit test cases
David Baz Fayos <david.baz@openbravo.com> [Wed, 29 Apr 2015 16:24:29 +0200] rev 26388
Related to issue 29687: Added QUnit test cases

Thu, 26 Feb 2015 17:46:48 +0100Fixed issue 28513: Error message wrongly shown when processing an inventory.
Jorge Garcia <jorge.garcia@openbravo.com> [Thu, 26 Feb 2015 17:46:48 +0100] rev 26387
Fixed issue 28513: Error message wrongly shown when processing an inventory.

The error message when processing an inventory is wrongly shown with a product
with % in its name and a negative stock.

The issue occurs when we are parsing the error message and detects the % symbol
and try to find the string format in the next character.

The proposal solution is to eliminate the String.format() method from the
code.

Now, the error message is shown properly with the correct name.

Tue, 28 Apr 2015 14:05:35 +0530Fixes Issue 28895:Cannot process an invoice if the role does not have access
Atul Gaware <atul.gaware@openbravo.com> [Tue, 28 Apr 2015 14:05:35 +0530] rev 26386
Fixes Issue 28895:Cannot process an invoice if the role does not have access
to FIN_Payment and the business partner has credit left

Changed OBContext to Admin mode when accessing Description field of Payment
and lastly restored it back again.

Tue, 28 Apr 2015 17:08:24 +0200Fixes issue 29338: Payment navigation from Transaction tab is working wrong
Alvaro Ferraz <alvaro.ferraz@openbravo.com> [Tue, 28 Apr 2015 17:08:24 +0200] rev 26385
Fixes issue 29338: Payment navigation from Transaction tab is working wrong

Issotrx auxiliary input query in Transaction tab has been changed to get into account related payment isreceipt field, when navigating from it to Payment In/Out window
Also, SE_Payment_Transaction and SE_Trxtype_Transaction callouts have been changed to overwrite issotrx session value when updating payment or transactiontype fields

Wed, 29 Apr 2015 10:22:24 +0200Related to bug 29091: Code Review
Unai Martirena <unai.martirena@openbravo.com> [Wed, 29 Apr 2015 10:22:24 +0200] rev 26384
Related to bug 29091: Code Review

[1]: Fix copyright
[2]: Change != for <>

Mon, 02 Mar 2015 11:02:02 +0100Fixed issue 29091: Fully depreciated field is not updated
Jorge Garcia <jorge.garcia@openbravo.com> [Mon, 02 Mar 2015 11:02:02 +0100] rev 26383
Fixed issue 29091: Fully depreciated field is not updated

The process didn't update the Fully Depreciated field when one or more
asset amortization lines were unprocessed.

The problem was in the amortization process.

Now the process changes the isFullyDepreciated field if the Depreciated
Value and the Depreciated Plan fields are differents.

Wed, 29 Apr 2015 08:55:42 +0200fixes issue 29667: NPE Error when a child tab is based on an HQL Query table
Carlos Aristu <carlos.aristu@openbravo.com> [Wed, 29 Apr 2015 08:55:42 +0200] rev 26382
fixes issue 29667: NPE Error when a child tab is based on an HQL Query table

The NPE was raised because the code was retrieving the entity for a table not based on a db table. This kind of tables do not have BaseOBObjects.
The FIC was already controlling this when the tab has a related table of this type but it was not considering the case when the parent table is related to a table of this type.

Wed, 29 Apr 2015 08:53:03 +0200fixes issue 29665: NP Error raised when using HQL Based Tables on a level 2 tab
Carlos Aristu <carlos.aristu@openbravo.com> [Wed, 29 Apr 2015 08:53:03 +0200] rev 26381
fixes issue 29665: NP Error raised when using HQL Based Tables on a level 2 tab

A unnecessary request was being done when accessing to the HQL query based subtab. This was caused because the tab was not being identified properly as a subtab.
The view.parentProperty was used to identify if we are on a child tab. This property could be undefined depending on the configuration of the tab in the application dictionary.
Now view.parentView is used instead of view.parentProperty because it does not return undefined in this cases

Wed, 29 Apr 2015 08:44:27 +0200related to issue 29719: fixed jsLint
Asier Lostalé <asier.lostale@openbravo.com> [Wed, 29 Apr 2015 08:44:27 +0200] rev 26380
related to issue 29719: fixed jsLint

- Do not use global functions exposed by QUnit but use the ones defined within
the QUnit global object
- Define QUnit as /*global*/ directive JSLint not to complain about it use

Tue, 28 Apr 2015 16:56:17 +0200fixed issue 29270: prevent table recreation in update.database
Asier Lostalé <asier.lostale@openbravo.com> [Tue, 28 Apr 2015 16:56:17 +0200] rev 26379
fixed issue 29270: prevent table recreation in update.database

When adding or removing columns to existing tables update.database does not
recreate the table but just appends the new columns. In order to do this,
column phyisical position wihtin the table is no longer important, being relative
only to the time they were created but not to the module they belong to.

Tue, 28 Apr 2015 16:54:06 +0200[recreation] prevent table recreation
Asier Lostalé <asier.lostale@openbravo.com> [Tue, 28 Apr 2015 16:54:06 +0200] rev 26378
[recreation] prevent table recreation

Tue, 28 Apr 2015 07:39:15 +0200[recreation] added parameter to update.database to force recreation i
Asier Lostalé <asier.lostale@openbravo.com> [Tue, 28 Apr 2015 07:39:15 +0200] rev 26377
[recreation] added parameter to update.database to force recreation i


All/specific tables can be forced to be recreated when database is updated in
case they have model changes.

Tue, 28 Apr 2015 16:36:59 +0200fixed issue 29719: Recover QUnit JavaSript test cases
Asier Lostalé <asier.lostale@openbravo.com> [Tue, 28 Apr 2015 16:36:59 +0200] rev 26376
fixed issue 29719: Recover QUnit JavaSript test cases

QUnit test cases are now ready to be included in CI:
-QUnit library has been updated to latest version (1.1.18)
-JavaScript files are loaded in a proper order to guarantee dependencies
-Test cases create an Openbravo session not requiring to use a 2nd tab
-Results are kept in a js object so Selenium can easily access

Tue, 28 Apr 2015 16:24:55 +0200[jsTest] reorganize OBTest object to be easier managed by Selenium
Asier Lostalé <asier.lostale@openbravo.com> [Tue, 28 Apr 2015 16:24:55 +0200] rev 26375
[jsTest] reorganize OBTest object to be easier managed by Selenium

Tue, 28 Apr 2015 11:13:04 +0200[jsTest] fixed test cases
Asier Lostalé <asier.lostale@openbravo.com> [Tue, 28 Apr 2015 11:13:04 +0200] rev 26374
[jsTest] fixed test cases

Tue, 28 Apr 2015 11:08:15 +0200[jsTest] fixed test case
Asier Lostalé <asier.lostale@openbravo.com> [Tue, 28 Apr 2015 11:08:15 +0200] rev 26373
[jsTest] fixed test case

Tue, 28 Apr 2015 10:16:28 +0200[jsTest] proper js load and execution, create session before StaticResources
Asier Lostalé <asier.lostale@openbravo.com> [Tue, 28 Apr 2015 10:16:28 +0200] rev 26372
[jsTest] proper js load and execution, create session before StaticResources

Tue, 28 Apr 2015 10:12:29 +0200[jsTest] adapted tests to new QUnit version
Asier Lostalé <asier.lostale@openbravo.com> [Tue, 28 Apr 2015 10:12:29 +0200] rev 26371
[jsTest] adapted tests to new QUnit version

Tue, 28 Apr 2015 10:08:55 +0200[jsTest] Updated QUnit to 1.18.0
Asier Lostalé <asier.lostale@openbravo.com> [Tue, 28 Apr 2015 10:08:55 +0200] rev 26370
[jsTest] Updated QUnit to 1.18.0

Tue, 28 Apr 2015 12:07:49 +0200Fixed issue 29687: DateTime now works ok with 12:XX:XX times
David Baz Fayos <david.baz@openbravo.com> [Tue, 28 Apr 2015 12:07:49 +0200] rev 26369
Fixed issue 29687: DateTime now works ok with 12:XX:XX times

The root of the problem was that there was a 'typo' and the
'minus' sign was missing in the 'if' statement in charge
of evaluate if it was in 24h mode or not. This was used later
to substract 12h to the entered date if this was in the
12:XX:XX form, change that obviously doesn't apply in the
24h mode

Tue, 28 Apr 2015 11:49:51 +0200Fixes bug 28934:Error when launching "Create AP Expense Invoices".
Inigo Sanchez <inigo.sanchez@openbravo.com> [Tue, 28 Apr 2015 11:49:51 +0200] rev 26368
Fixes bug 28934:Error when launching "Create AP Expense Invoices".

The problem wasn't related with "Openbravo External Connection Pools module". This issue
has been reproduced without using "Apache JDBC Connection Pool", this is the error log:

Apr 27, 2015 12:51:47 PM org.apache.catalina.core.StandardWrapperValve invoke
SEVERE: Servlet.service() for servlet P801268 threw exception
org.hibernate.TransactionException: JDBC commit failed
at org.hibernate.transaction.JDBCTransaction.commit(JDBCTransaction.java:157)
at org.openbravo.dal.core.SessionHandler.commitAndClose(SessionHandler.java:258)
.........................
at org.apache.tomcat.util.net.JIoEndpoint$Worker.run(JIoEndpoint.java:489)
at java.lang.Thread.run(Thread.java:701)
Caused by: org.postgresql.util.PSQLException: Cannot commit when autoCommit is enabled.
at org.postgresql.jdbc2.AbstractJdbc2Connection.commit(AbstractJdbc2Connection.java:705)
at org.hibernate.transaction.JDBCTransaction.commitAndResetAutoCommit(JDBCTransaction.java:166)
at org.hibernate.transaction.JDBCTransaction.commit(JDBCTransaction.java:142)

In both cases (default connection pool or apache jdbc connection pool) there was an error
related with the way of manage connections in "Create AP Expense Invoices" process.

This connection is obtained with getConnection() method and finally it is closed in
realeaseCommitConnection() method. This method gets the connection from the session.
In following uses of "getConnection()" there is an error because this process closed
the connection of the session.

To fix this, using "getTransactionConnection()" instead of "getConnection()" method. This method
creates a new connection instead of using the connection of the session. For this reason, it can
be closed without any problem.

Mon, 27 Apr 2015 13:51:37 +0200Fixes Issue 29680:Add details pop up in Payment Out window filters records
Eduardo Argal Guibert <eduardo.argal@openbravo.com> [Mon, 27 Apr 2015 13:51:37 +0200] rev 26367
Fixes Issue 29680:Add details pop up in Payment Out window filters records
with supplier reference

having clause fixed to take into account supplier reference

Mon, 27 Apr 2015 16:52:31 +0200Fixed issue 29697: Description field is set with "null" in the FA Transaction
Jorge Garcia <jorge.garcia@openbravo.com> [Mon, 27 Apr 2015 16:52:31 +0200] rev 26366
Fixed issue 29697: Description field is set with "null" in the FA Transaction

Description field is filled in with "null" in the FA Transaction when matched
to GL Item.

The problem was in the Match Statement process, more specifically, in the
Add new transaction button. The AddTransanctionActionHandler didn't
take in consideration that the received description could be null.

The fix for this issue is to check if the received description is null
or blank.

Now, the description field fill in the correct description.

Mon, 30 Mar 2015 21:27:03 -0500Fixed bug 28702: Assets Organization should not be changed if it has lines
Reinaldo Guerra <reinaldo.guerra@peoplewalking.com> [Mon, 30 Mar 2015 21:27:03 -0500] rev 26365
Fixed bug 28702: Assets Organization should not be changed if it has lines

Like happens in other windows such as Products and Business Partner, the organization's field behaviour in Assets window was changed to not be updatable.
Now when the Assets record is saved, it is not possible to change its organization, so there will not be inconsistencies with previous created lines if the amortizations are recalculated.

Mon, 27 Apr 2015 18:58:05 +0200Fixed bug 28927: Filter is removed when cancel transactions from Match process
Unai Martirena <unai.martirena@openbravo.com> [Mon, 27 Apr 2015 18:58:05 +0200] rev 26364
Fixed bug 28927: Filter is removed when cancel transactions from Match process

Changed OB.APRM.MatchStatement.onRefresh function in a similar way to OB.APRM.AddPayment.currencyOnChange function.
The previous criteria is kept (including the selected record) and used again to refresh the grid records and redraw the form.

Thu, 16 Apr 2015 18:33:31 +0200Fixes issue 29616: Error in GLJournalAccountingCheck validation
Alvaro Ferraz <alvaro.ferraz@openbravo.com> [Thu, 16 Apr 2015 18:33:31 +0200] rev 26363
Fixes issue 29616: Error in GLJournalAccountingCheck validation

Query in GLJournalAccountingCheck build validation has been changed to avoid build validation fail, when exists a negative gl journal line and system is configured to "not allow negative amount" during posting, although accounting information is correct