Thu, 25 Aug 2016 20:38:42 +0000CI: update AD_MODULE to version 29914
RM packaging bot <staff.rm@openbravo.com> [Thu, 25 Aug 2016 20:38:42 +0000] rev 29915
CI: update AD_MODULE to version 29914

Thu, 25 Aug 2016 16:06:43 +0200fixes issue 33814: backed out initialization prevention changes
Carlos Aristu <carlos.aristu@openbravo.com> [Thu, 25 Aug 2016 16:06:43 +0200] rev 29914
fixes issue 33814: backed out initialization prevention changes

Thu, 25 Aug 2016 15:08:57 +0200Related to issue 33790: Update copyright
Alvaro Ferraz <alvaro.ferraz@openbravo.com> [Thu, 25 Aug 2016 15:08:57 +0200] rev 29913
Related to issue 33790: Update copyright

Thu, 25 Aug 2016 15:08:40 +0200Related to issue 33705: Update copyright
Alvaro Ferraz <alvaro.ferraz@openbravo.com> [Thu, 25 Aug 2016 15:08:40 +0200] rev 29912
Related to issue 33705: Update copyright

Thu, 25 Aug 2016 13:06:59 +0000CI: merge back from main
RM packaging bot <staff.rm@openbravo.com> [Thu, 25 Aug 2016 13:06:59 +0000] rev 29911
CI: merge back from main

Thu, 25 Aug 2016 12:53:06 +0000CI: update AD_MODULE to version 29907
RM packaging bot <staff.rm@openbravo.com> [Thu, 25 Aug 2016 12:53:06 +0000] rev 29910
CI: update AD_MODULE to version 29907

Thu, 25 Aug 2016 11:22:44 +0200related to issue 33707: reverting limit removal
Carlos Aristu <carlos.aristu@openbravo.com> [Thu, 25 Aug 2016 11:22:44 +0200] rev 29909
related to issue 33707: reverting limit removal

Thu, 25 Aug 2016 11:01:24 +0200related to issue 33707: code review improvements
Carlos Aristu <carlos.aristu@openbravo.com> [Thu, 25 Aug 2016 11:01:24 +0200] rev 29908
related to issue 33707: code review improvements

Thu, 25 Aug 2016 10:23:29 +0200fixes issue 33622: Selection lost on table/view based P&E having >100 records
Carlos Aristu <carlos.aristu@openbravo.com> [Thu, 25 Aug 2016 10:23:29 +0200] rev 29907
fixes issue 33622: Selection lost on table/view based P&E having >100 records

Selection could be lost on P&E windows based on a table or a view, having more than 100 records selected. This problem was solved on issue 31989 for those P&E windows based on HQL query tables (this kind of P&E windows make use of a ReadOnlyDataSourceService).

P&E windows based on a table or a view make use of the DefaultDataSourceService which uses DefaultJsonDataService to retrieve data. So, in order to solve the problem, a similar mechanism to the existing one on ReadOnlyDataSourceService has been implemented within DefaultJsonDataService.

Thus, those P&E which use DefaultDataSourceService to retrieve data, now increase the page size dynamically in order to get all selected records in the same request.

Thu, 25 Aug 2016 03:04:09 +0000CI: merge back from main
RM packaging bot <staff.rm@openbravo.com> [Thu, 25 Aug 2016 03:04:09 +0000] rev 29906
CI: merge back from main

Thu, 25 Aug 2016 02:50:19 +0000CI: update AD_MODULE to version 29904
RM packaging bot <staff.rm@openbravo.com> [Thu, 25 Aug 2016 02:50:19 +0000] rev 29905
CI: update AD_MODULE to version 29904

Wed, 24 Aug 2016 14:54:57 -0400Fixes issue 33636: Error should be raised when running "Modify Payment Plan"
Rafael Queralta Pozo <rqueralta@nauta.cu> [Wed, 24 Aug 2016 14:54:57 -0400] rev 29904
Fixes issue 33636: Error should be raised when running "Modify Payment Plan"

Now "The invoice is already included in a Remittance." message is shown when running Modify Payment Plan process from an invoice included in a remittance.

Wed, 24 Aug 2016 20:46:44 +0000CI: merge back from main
RM packaging bot <staff.rm@openbravo.com> [Wed, 24 Aug 2016 20:46:44 +0000] rev 29903
CI: merge back from main

Wed, 24 Aug 2016 20:32:36 +0000CI: update AD_MODULE to version 29901
RM packaging bot <staff.rm@openbravo.com> [Wed, 24 Aug 2016 20:32:36 +0000] rev 29902
CI: update AD_MODULE to version 29901

Wed, 24 Aug 2016 15:49:21 +0200related to issue 33706: code review improvements
Carlos Aristu <carlos.aristu@openbravo.com> [Wed, 24 Aug 2016 15:49:21 +0200] rev 29901
related to issue 33706: code review improvements

Wed, 24 Aug 2016 12:59:17 +0000CI: merge back from main
RM packaging bot <staff.rm@openbravo.com> [Wed, 24 Aug 2016 12:59:17 +0000] rev 29900
CI: merge back from main

Wed, 24 Aug 2016 12:45:07 +0000CI: update AD_MODULE to version 29890
RM packaging bot <staff.rm@openbravo.com> [Wed, 24 Aug 2016 12:45:07 +0000] rev 29899
CI: update AD_MODULE to version 29890

Wed, 24 Aug 2016 14:39:03 +0200Fixed 33771. Avoid double .list() call to not run query twice.
Stefan Hühner <stefan.huehner@openbravo.com> [Wed, 24 Aug 2016 14:39:03 +0200] rev 29898
Fixed 33771. Avoid double .list() call to not run query twice.

Old code ran following a OBCriteria
if (obc.list() == null || obc.list().size() == 0) {

However .list() does not return null as per Hibernate javadoc but empty or
non-empty list (of method raising an exception).

So remove the extra null check to avoid double .list() call.

Also improve .list().size() check slightly by using .list().isEmpty()

Add note that filter is on unique constraint so .list().size()<=1 also

Wed, 24 Aug 2016 14:23:41 +0200Fixed 33794. Avoid double .list() call by using .uniqueResult() instead.
Stefan Hühner <stefan.huehner@openbravo.com> [Wed, 24 Aug 2016 14:23:41 +0200] rev 29897
Fixed 33794. Avoid double .list() call by using .uniqueResult() instead.

Code did check for >1 result rows while reading from obserds_datasource.
However as the filter is on the name column and that column has an unique
constraint that case of >1 cannot happen.

So simplify to just call .uniqueResult() removing both .list() calls.

Wed, 24 Aug 2016 13:54:17 +0200Issue 33774. Apply review feedback, change .size() > 0 to !isEmpty()
Stefan Hühner <stefan.huehner@openbravo.com> [Wed, 24 Aug 2016 13:54:17 +0200] rev 29896
Issue 33774. Apply review feedback, change .size() > 0 to !isEmpty()

Wed, 24 Aug 2016 13:51:59 +0200Issue 33773. Apply review feedback replace .size() >0 with !isEmpty()
Stefan Hühner <stefan.huehner@openbravo.com> [Wed, 24 Aug 2016 13:51:59 +0200] rev 29895
Issue 33773. Apply review feedback replace .size() >0 with !isEmpty()

Tue, 23 Aug 2016 17:58:45 +0200Fixed 33774. Fixed accidental double query by not calling .list() twice
Stefan Hühner <stefan.huehner@openbravo.com> [Tue, 23 Aug 2016 17:58:45 +0200] rev 29894
Fixed 33774. Fixed accidental double query by not calling .list() twice

Tue, 23 Aug 2016 17:34:51 +0200Fixed 33773. Avoid double query by not calling .list() twice
Stefan Hühner <stefan.huehner@openbravo.com> [Tue, 23 Aug 2016 17:34:51 +0200] rev 29893
Fixed 33773. Avoid double query by not calling .list() twice

First case reading from ad_language can be simplified to single .uniqueResult
call as filters are unique.

2nd case just saves list() result to avoid 2nd call easily.

Wed, 24 Aug 2016 11:54:52 +0200Fixed 33790. Avoid double query with .count() + .list(). Add limit 1 to query
Stefan Hühner <stefan.huehner@openbravo.com> [Wed, 24 Aug 2016 11:54:52 +0200] rev 29892
Fixed 33790. Avoid double query with .count() + .list(). Add limit 1 to query

Query did .count() + then retrieve 1 record after adding extra order by.

This change removes the count as it only adds extra overhead and directly
does the real .list() query.
As the code only uses single row of result add extra limit 1 to reduce
number of result rows loaded into memory if many match the filter.
Simply code to use .uniqueResult() instead of .list().get(0)

Wed, 24 Aug 2016 11:08:58 +0200Fixed 33789. Avoid accidental double query by not calling .list() twice
Stefan Hühner <stefan.huehner@openbravo.com> [Wed, 24 Aug 2016 11:08:58 +0200] rev 29891
Fixed 33789. Avoid accidental double query by not calling .list() twice

Wed, 24 Aug 2016 10:12:12 +0200related to issue 33622: apply correct format
Carlos Aristu <carlos.aristu@openbravo.com> [Wed, 24 Aug 2016 10:12:12 +0200] rev 29890
related to issue 33622: apply correct format

Wed, 24 Aug 2016 00:56:21 +0000CI: merge back from main
RM packaging bot <staff.rm@openbravo.com> [Wed, 24 Aug 2016 00:56:21 +0000] rev 29889
CI: merge back from main

Wed, 24 Aug 2016 00:42:26 +0000CI: update AD_MODULE to version 29887
RM packaging bot <staff.rm@openbravo.com> [Wed, 24 Aug 2016 00:42:26 +0000] rev 29888
CI: update AD_MODULE to version 29887

Tue, 23 Aug 2016 17:20:57 +0200Fixed 33772. Remove double query by saving .list() result
Stefan Hühner <stefan.huehner@openbravo.com> [Tue, 23 Aug 2016 17:20:57 +0200] rev 29887
Fixed 33772. Remove double query by saving .list() result

instead of calling .count() and then .list() which does 2 selects for the same.

Tue, 23 Aug 2016 16:42:13 +0200Fixed 33769. Avoid double query in ModuleManagement window (settings tab)
Stefan Hühner <stefan.huehner@openbravo.com> [Tue, 23 Aug 2016 16:42:13 +0200] rev 29886
Fixed 33769. Avoid double query in ModuleManagement window (settings tab)