Mon, 08 Feb 2016 09:06:40 +0100related to issue 32091: code review improvements
Carlos Aristu <carlos.aristu@openbravo.com> [Mon, 08 Feb 2016 09:06:40 +0100] rev 28577
related to issue 32091: code review improvements

After sorting the grid without having any filter applied, the selection was not being kept on top. To solve this, now we check if there is a criteria present in the request and also if there are selected records. In that case, a new criteria is included in the request with the ids of the selected records.

Besides, two methods are deleted from AddPaymentOrderInvoicesTransformer as they are no longer needed. And a new check is added when retrieving the selected records in the backend, in order to avoid a possible JSONException.

Tue, 02 Feb 2016 13:45:46 -0500Fixes issue 32084: Process Price Difference adjustment breaks menu
Mark <m.molina@nectus.com> [Tue, 02 Feb 2016 13:45:46 -0500] rev 28576
Fixes issue 32084: Process Price Difference adjustment breaks menu

Were fixed the 3 problems of "Process Price Difference adjustment" menu entry found:

1. It is included into menu folder Warehouse Management | Setup
2. Was renamed to "Process Price Difference Adjustment" to follow the capitalization rule
3. Was included a description and help.

Fri, 05 Feb 2016 11:37:39 +0100Fixes issue 32078: Reserved quantity is not correct
Alvaro Ferraz <alvaro.ferraz@openbravo.com> [Fri, 05 Feb 2016 11:37:39 +0100] rev 28575
Fixes issue 32078: Reserved quantity is not correct

In ManageReservationActionHandler, when clicking Done in Manage Reservation P&E, it was first reserving what the user was typing in the P&E, and if it was not processed the reservation, it was processing it. As the M_RESERVATION_POST tries always to reserve as much as possible, it was overriding the previously set amounts. In order to prevent this, now first the reservation is being processed and after that the values typed in the UI are being set to the reservation.
In case no stock reservation is created by m_reservation_post when processing the reservation, res_status will be Draft. To be sure reservation is set as completed, force status after call ReservationUtils.processReserve method.
Reservation will only be kept as draft in case it has no lines after execute manageReservedStockLines.

Fri, 05 Feb 2016 13:14:11 +0100fixes issue 31766: Application unexpectedly closed using some selectors in Edge
Carlos Aristu <carlos.aristu@openbravo.com> [Fri, 05 Feb 2016 13:14:11 +0100] rev 28574
fixes issue 31766: Application unexpectedly closed using some selectors in Edge

Now selectors based on OBSearchItem class are opened inside an Smartclient pop-up instead of using a new browser window.

Fri, 05 Feb 2016 10:05:58 +0100related to issue 32110: fixes for .fo reports
Carlos Aristu <carlos.aristu@openbravo.com> [Fri, 05 Feb 2016 10:05:58 +0100] rev 28573
related to issue 32110: fixes for .fo reports

Fri, 05 Feb 2016 10:04:46 +0100fixes issue 32110: Upgrade FOP library
Carlos Aristu <carlos.aristu@openbravo.com> [Fri, 05 Feb 2016 10:04:46 +0100] rev 28572
fixes issue 32110: Upgrade FOP library

Fri, 05 Feb 2016 08:58:12 +0100related to issue 32039: reuse constant for upaged ds requests
Asier Lostalé <asier.lostale@openbravo.com> [Fri, 05 Feb 2016 08:58:12 +0100] rev 28571
related to issue 32039: reuse constant for upaged ds requests

Thu, 04 Feb 2016 10:14:27 +0100related to issue 32092: updated copyright year
Carlos Aristu <carlos.aristu@openbravo.com> [Thu, 04 Feb 2016 10:14:27 +0100] rev 28570
related to issue 32092: updated copyright year

Wed, 03 Feb 2016 19:42:14 +0100fixes issue 32092: hidden fields space not restored after reopening form view
Carlos Aristu <carlos.aristu@openbravo.com> [Wed, 03 Feb 2016 19:42:14 +0100] rev 28569
fixes issue 32092: hidden fields space not restored after reopening form view

The alwaysTakeSpace property of the form items was only being set after opening the form view the first time. This property is used to keep space for the displayed field (including the hidden ones by display logic). This property is being set to false when closing form view, and then, never restored again.

Now this property is set every time the UI switches into the form view.

Wed, 03 Feb 2016 19:29:23 +0100fixes issue 32091: The Order/Invoices grid now sorts by selected records first
Carlos Aristu <carlos.aristu@openbravo.com> [Wed, 03 Feb 2016 19:29:23 +0100] rev 28568
fixes issue 32091: The Order/Invoices grid now sorts by selected records first

Now the AddPaymentOrderInvoicesTransformer places first the selected record criteria for ordering, put it just before the ordering criteria selected by the user in the grid.

Wed, 03 Feb 2016 19:26:25 +0100fixes issue 31989: Wrong behavior in P&E grids having > 100 records selected
Carlos Aristu <carlos.aristu@openbravo.com> [Wed, 03 Feb 2016 19:26:25 +0100] rev 28567
fixes issue 31989: Wrong behavior in P&E grids having > 100 records selected
After performing a filter/ordering action, the selected records could go out of the first page, causing the Add Payment process crash inside updateInvOrderTotal function (executed on grid load), because the selected record could not be found on the local data.
To avoid the problem now the ReadOnlyDataSource fetches all the selected records in the first page, increasing the page size if necessary. Together with this, all the P&E processes must ensure that the data is always ordered by showing first the selected records.

Wed, 03 Feb 2016 11:18:59 +0100[Product Services] Update AD_SEQUENCE for Standard Order document in QA Testing
Alvaro Ferraz <alvaro.ferraz@openbravo.com> [Wed, 03 Feb 2016 11:18:59 +0100] rev 28566
[Product Services] Update AD_SEQUENCE for Standard Order document in QA Testing

Sun, 31 Jan 2016 17:05:32 +0100Fixed bug 31977: Performance problem in ReturnMaterialShipmentPickEdit
Víctor Martínez Romanos <victor.martinez@openbravo.com> [Sun, 31 Jan 2016 17:05:32 +0100] rev 28565
Fixed bug 31977: Performance problem in ReturnMaterialShipmentPickEdit

The "HQL where" and "HQL order by" clauses in RM Shipment Pick and Edit | Pick Edit Lines tab created a non-optimal SQL query with important performance issues in high volume environments, specially in the ones with many order lines and order headers. In particular, the query included unnecessary:
* Left join to m_product
* Cross join to c_orderline
* Cross join to c_order

The solution:
* Add the c_bpartner_id column to the M_RM_SHIPMENT_PICK_EDIT view and filter by this column in the tab's HQL where clause, so we avoid the need to cross join over c_orderline and c_order tables.
* The "HQL order by" orders by lineNo (instead of product), so we avoid the need to left join over m_product and we show a better default order (selected, RM Order No. and Line No.)

With these changes, the SQL cost calculated by the planner has been reduced a 88% in our internal testing (from 5100 to 609)

Mon, 01 Feb 2016 15:40:17 +0100Fixes issue 32074: The import entry manager can be shut down and restarted
Augusto Mauch <augusto.mauch@openbravo.com> [Mon, 01 Feb 2016 15:40:17 +0100] rev 28564
Fixes issue 32074: The import entry manager can be shut down and restarted

There were two problems:
- The isShutdown attribute was not being set to false after restarting the ImportEntryManager
- The ImportEntryManger was not being stopped properly, there were processes that kept being run after shutting it down, specially when shutting the ImportEntryManager down just after having started it, but before the initialWaitTime, that is when the manager actually starts working.

Sun, 31 Jan 2016 12:59:02 +0100Merged heads
Martin Taal <martin.taal@openbravo.com> [Sun, 31 Jan 2016 12:59:02 +0100] rev 28563
Merged heads

Sun, 31 Jan 2016 12:57:47 +0100Updated copyright year to 2016
Martin Taal <martin.taal@openbravo.com> [Sun, 31 Jan 2016 12:57:47 +0100] rev 28562
Updated copyright year to 2016

Sun, 31 Jan 2016 12:49:38 +0100Fixed bug 31866: code review improvements
Víctor Martínez Romanos <victor.martinez@openbravo.com> [Sun, 31 Jan 2016 12:49:38 +0100] rev 28561
Fixed bug 31866: code review improvements

Applied Openbravo format style
Updated copyright

Thu, 21 Jan 2016 15:36:07 -0500Fixes Issue 31866: Emptied Translation List after copying generic product
Nono <f.carballo@nectus.com> [Thu, 21 Jan 2016 15:36:07 -0500] rev 28560
Fixes Issue 31866: Emptied Translation List after copying generic product

If Multilingual Document is checked in Client window, when managing variants,
after copying the generic product, the translation list is emptied, the
m_product_trg trigger will insert the proper values when inserting
the new product.

Thu, 28 Jan 2016 01:01:58 +0530Fixes Issue 24355:In case of processing POS Order with Immediate Invoice
Atul Gaware <atul.gaware@openbravo.com> [Thu, 28 Jan 2016 01:01:58 +0530] rev 28559
Fixes Issue 24355:In case of processing POS Order with Immediate Invoice
Terms, Invoice Line is not set with Goods Shipment Line information.

In case of POS Order get M_InOutLine_ID for OrderLine, making sure exactly
one record is retreived using Max, Qty compared to get full shipped line
reference only as there could a case where Order Line is split into two or
more based on available stock in different storage bins in that case no
reference would be set in Invoice Line.

Sat, 30 Jan 2016 19:07:17 +0100Related to issue 32033: Fixed db inconsistency
Víctor Martínez Romanos <victor.martinez@openbravo.com> [Sat, 30 Jan 2016 19:07:17 +0100] rev 28558
Related to issue 32033: Fixed db inconsistency
Run Synchronize Terminology and exported db to fix inconsistency

Fri, 29 Jan 2016 11:50:14 +0530Fixes Issue 32033:[SERQA 606] Payment method is not shown when looking for
Atul Gaware <atul.gaware@openbravo.com> [Fri, 29 Jan 2016 11:50:14 +0530] rev 28557
Fixes Issue 32033:[SERQA 606] Payment method is not shown when looking for
a payment to add to a transaction in the financial account

Added Payment Method column in Add Multiple Payments P&E and Payment
Selector Transaction reference used in Payment Field of Financial Account
Transaction Tab. Could filter payments with payment method.

Sat, 30 Jan 2016 10:26:12 +0100Fixed bug 30235: Extension point at the end of aprm_gen_paymentschedule_inv
Víctor Martínez Romanos <victor.martinez@openbravo.com> [Sat, 30 Jan 2016 10:26:12 +0100] rev 28556
Fixed bug 30235: Extension point at the end of aprm_gen_paymentschedule_inv

Added Extension point at the end of aprm_gen_paymentschedule_inv procedure, so it now has an extension point at the beginning and at the end of the process.

Solution contributed by partner

Fri, 29 Jan 2016 14:31:54 +0100Fixes issue 32011: Trigger can be recreated with triggers to follow list (ORA)
Augusto Mauch <augusto.mauch@openbravo.com> [Fri, 29 Jan 2016 14:31:54 +0100] rev 28555
Fixes issue 32011: Trigger can be recreated with triggers to follow list (ORA)

Now it is possible to recreate an existing trigger, specifying a list of triggers of the same type that should be invoked before it. This development only affects Oracle database
s, as in postgres the trigger execution order is given by the trigger's name.

The Oracle8Builder has been updated to include a follows clause if the trigger being created must be executed before it. For instance, to create a trigger named TEST_TRIGGER_SECO
ND that must be executed after a trigger called TEST_TRIGGER_FIRST, the builder constructs the following statement:

CREATE TRIGGER TEST_TRIGGER_FIRST
AFTER INSERT OR UPDATE
ON TEST FOR EACH ROW
FOLLOWS TEST_TRIGGER_SECOND
DECLARE
BEGIN
END TEST_TRIGGER_FIRST
;

Fri, 29 Jan 2016 14:21:19 +0100Fixes issue 31712: Foreign keys and constraints can be disabled per table
Augusto Mauch <augusto.mauch@openbravo.com> [Fri, 29 Jan 2016 14:21:19 +0100] rev 28554
Fixes issue 31712: Foreign keys and constraints can be disabled per table

Before this change the Platform class only offered methods to disable all the constraints and foreign keys of the whole database. Now it is possible to do it also on a table to table basis.

Changes done:
- Platform.java: Added public methods disableAllFkForTable, enableAllFkForTable, disableCheckConstraintsForTable, enableCheckConstraintsForTable
- PlatformImplBase.java: Provides a functional default implementation for disableCheckConstraintsForTable and enableCheckConstraintsForTable, possible because the .disableAllChecks(table) was already implemented. Also provides an implementation for disableAllFkForTable and enableAllFkForTable that just returns throw new DatabaseOperationException("Error: Operation not supported"), because it needs to be implemented in each specific platform.
- Oracle8Platform and PostgreSqlPlatform: Implementations for disableAllFkForTable and enableAllFkForTable.

Some tests have been added to check that the foreign keys and constraints can be disabled and enabled for the whole database and also for a specific table.

Fri, 29 Jan 2016 13:34:12 +0100fixes issue 32039: Add generic mechanism to have multiple cached preferences
Carlos Aristu <carlos.aristu@openbravo.com> [Fri, 29 Jan 2016 13:34:12 +0100] rev 28553
fixes issue 32039: Add generic mechanism to have multiple cached preferences

The new CachedPreference class can be used to keep the value of a preference defined at system level. The value of the 'Allow Unpaged Datasource Manual Request' preference is already handled by this class. So the UnpagedRequestCachedPreference is not needed anymore.

Fri, 29 Jan 2016 12:56:36 +0100fixes issue 31180: openDirectTab action now works if the tab is already opened
Carlos Aristu <carlos.aristu@openbravo.com> [Fri, 29 Jan 2016 12:56:36 +0100] rev 28552
fixes issue 31180: openDirectTab action now works if the tab is already opened

When the opening tab was already opened, the openDirectTab method was not waiting properly to the new tab be refreshed/opened. This was caused because the callout of OB.Utilities.openDirectTab method was invoked after the line that checks if the action needs to wait.
Now if the tab is already opened the action is called again with a delay of 100ms, giving OB.Utilities.openDirectTab enough time to execute its callout.

Fri, 29 Jan 2016 09:55:26 +0100related to issue 31180: backed out changeset
Carlos Aristu <carlos.aristu@openbravo.com> [Fri, 29 Jan 2016 09:55:26 +0100] rev 28551
related to issue 31180: backed out changeset

Wed, 27 Jan 2016 00:44:55 -0500Fixes Issue 31936: The SQL query of M_INVENTORY_LISTCREATE store procedure was
Nono Carballo <f.carballo@nectus.com> [Wed, 27 Jan 2016 00:44:55 -0500] rev 28550
Fixes Issue 31936: The SQL query of M_INVENTORY_LISTCREATE store procedure was
tuned to take care about null values.

The SQL query to retrieve the products that will be part of the lines was tuned
to take care about null values in aset.isoneattrsetvalrequired field.
The line AND aset.isoneattrsetvalrequired = 'Y' was replaced with
AND COALESCE(aset.isoneattrsetvalrequired, '-') = 'Y'

Fri, 29 Jan 2016 09:17:02 +0100related to bug 32007: use single qoutes to enclose js strings
Asier Lostalé <asier.lostale@openbravo.com> [Fri, 29 Jan 2016 09:17:02 +0100] rev 28549
related to bug 32007: use single qoutes to enclose js strings

Thu, 28 Jan 2016 18:48:27 +0100fixes issue 31180: openDirectTab action now works if the tab is already opened
Carlos Aristu <carlos.aristu@openbravo.com> [Thu, 28 Jan 2016 18:48:27 +0100] rev 28548
fixes issue 31180: openDirectTab action now works if the tab is already opened

Now the 'openDirectTab' response action takes into account if the 'Allow Multiple Tabs of a Window' preference is enabled. In that case when this action tries to open a tab which is already opened it opens a new tab in the last position instead of refreshing the old one.