Thu, 25 Sep 2014 17:06:26 +0530Fixes Issue 27679: can't use FK drop down if grid is already filtered by a relative date
Shankar Balachandran <shankar.balachandran@openbravo.com> [Thu, 25 Sep 2014 17:06:26 +0530] rev 25792
Fixes Issue 27679: can't use FK drop down if grid is already filtered by a relative date

Convert relative dates in criteria to absolute dates.

Tue, 30 Dec 2014 12:57:04 +0100Fixes issue 28501: Window is property loaded having read only tabs
Augusto Mauch <augusto.mauch@openbravo.com> [Tue, 30 Dec 2014 12:57:04 +0100] rev 25791
Fixes issue 28501: Window is property loaded having read only tabs

There was a problem in the way read only tabs were initialized. It was caused by this changeset [1], which fixed a problem related with read only tabs loaded lazily. The problem is that under some circumstances the setReadOnly function of the standard view was called without it being fully initialized. The setReadOnly invokation ended up calling the OBViewGrid.resetEmptyMessage function, and tried to execute this line:

this.view.parentView.isShowingTree

The problem is that the parentView property of the view was not set yet, so an error was thrown. To fix this, now the code to update some view properties based in its uiPattern value is executed after the parentView property is properly set.

[1] https://code.openbravo.com/erp/devel/pi/rev/052c07be4a9ddd2b2a61bd60e948370c53482cb4

Wed, 24 Dec 2014 13:29:10 +0100Fixed bug 28482: Exchange rate and Converted Amt in Add Payment
Víctor Martínez Romanos <victor.martinez@openbravo.com> [Wed, 24 Dec 2014 13:29:10 +0100] rev 25790
Fixed bug 28482: Exchange rate and Converted Amt in Add Payment

The Exchange rate and Converted amount fields were not properly updated when 2 financial accounts (the first one of them with different currency than the invoice and the second one with the same currency) are selected sequentially into the Add Payment process.

Casue: the conversion rate was wrongly sent back to the JS as a String ("1") instead of using a number. The OB.APRM.AddPayment.paymentMethodMulticurrency function checks the received conversion rate is a number before updating the converted amount. Since the converted amount wasn't a number but a string, the amounts were not updated.
After the fix, the conversion rate is sent back using a integer 1

Mon, 22 Dec 2014 12:06:48 +0100Related with issue 28454: Add comments to function
Augusto Mauch <augusto.mauch@openbravo.com> [Mon, 22 Dec 2014 12:06:48 +0100] rev 25789
Related with issue 28454: Add comments to function

Fri, 19 Dec 2014 09:45:01 +0100fixed bug 28454: can't nullify fields when 1st edition is in grid
Asier Lostalé <asier.lostale@openbravo.com> [Fri, 19 Dec 2014 09:45:01 +0100] rev 25788
fixed bug 28454: can't nullify fields when 1st edition is in grid

When the first edition in a tab was done in grid view, it was not possible to
nullify any field.

The problem was null values are only sent to backend for fields present in the
standard view. To get those fields form.getFields() method was invoked, in order
to improve performance, form fields are only loaded when the form is opened 1st
time, so if the form view was not opened before this check, all nulls were
removed from the request. As this was cached, all further editions were using this
incorrect cache.

The fix consists in not using form.getFields() methods but to get the fields from
view.formFields which is guaranteed to be loaded one the window is opened.

Tue, 09 Dec 2014 18:59:11 +0100Fixed bug 28362 c_invoice_post creates unnecesary contentions
Sandra Huguet <sandra.huguet@openbravo.com> [Tue, 09 Dec 2014 18:59:11 +0100] rev 25787
Fixed bug 28362 c_invoice_post creates unnecesary contentions

Avoiding the join with m_pricelist and c_doctype contentions are solved

Tue, 09 Dec 2014 18:55:38 +0100Fixed bug 28360 c_order_post creates unnecesary contentions
Sandra Huguet <sandra.huguet@openbravo.com> [Tue, 09 Dec 2014 18:55:38 +0100] rev 25786
Fixed bug 28360 c_order_post creates unnecesary contentions

Avoiding the join with m_pricelist the m_pricelist contention is solved

For update sentence is deleted in c_orderline selects because the
c_orderline is bloqued with the main select and is redundant and
causes unnecessary contentions.

Fri, 30 Jan 2015 19:43:37 -0500Fixed bug 28698: Not possible to remove variants, right after creation process.
Reinaldo Guerra <reinaldo.guerra@peoplewalking.com> [Fri, 30 Jan 2015 19:43:37 -0500] rev 25785
Fixed bug 28698: Not possible to remove variants, right after creation process.

The validation for existent values associated with product's characteristics was removed to make possible to delete a product variant. So now it is possible to delete the product (variant of another product) unless this product is already in use. In this case the standard message will be shown.

Mon, 02 Feb 2015 17:32:26 +0100Fixed issue 28797: Added 'or higher...' text to recommended browsers msg
David Baz Fayos <david.baz@openbravo.com> [Mon, 02 Feb 2015 17:32:26 +0100] rev 25784
Fixed issue 28797: Added 'or higher...' text to recommended browsers msg

Wed, 28 Jan 2015 18:31:08 -0500Fixed bug 19052: Create AP Expense Invoices error is unclear.
Reinaldo Guerra <reinaldo.guerra@peoplewalking.com> [Wed, 28 Jan 2015 18:31:08 -0500] rev 25783
Fixed bug 19052: Create AP Expense Invoices error is unclear.

The Create AP Expense Invoices manual window's class, was changed to process also error message catched by the exception: "PayementMethodNotdefined".
Now all possible exceptions when creating invoices from expenses are processed, and error messages are shown in a clear way.

Mon, 02 Feb 2015 16:50:49 +0100Related with issue 28736: Updates copyright year
Augusto Mauch <augusto.mauch@openbravo.com> [Mon, 02 Feb 2015 16:50:49 +0100] rev 25782
Related with issue 28736: Updates copyright year

Mon, 02 Feb 2015 16:24:33 +0100Fixes issue 28736: Selected record in parent tab criteria is applied to trees
Augusto Mauch <augusto.mauch@openbravo.com> [Mon, 02 Feb 2015 16:24:33 +0100] rev 25781
Fixes issue 28736: Selected record in parent tab criteria is applied to trees

In order to show the proper records in the subtabs, a criteria is applied based on the record selected in the parent tab. This criteria was automatically being added in the trees based
on the ADTree structure, but not in those based on the LinkToParent structure.

Now this criteria is also added in the LinkToParent trees if the following conditions are met:
- The tab is not a header tab
- The tree does not define a HQL clause for root nodes
- The parameters contains the info needed to build the new criteria

The getParentRecordIdFromCriteria method, which was used in the ADTreeDatasourceService for this purpose, has been moved up to TreeDatasourceService so that it can be reused by LinkToPa
rentTreeDatasourceService.

Mon, 02 Feb 2015 16:12:43 +0100related to issue 27160 update Copyright
Sandra Huguet <sandra.huguet@openbravo.com> [Mon, 02 Feb 2015 16:12:43 +0100] rev 25780
related to issue 27160 update Copyright

Fri, 30 Jan 2015 11:44:11 +0100Related to issue 27160 code review
Sandra Huguet <sandra.huguet@openbravo.com> [Fri, 30 Jan 2015 11:44:11 +0100] rev 25779
Related to issue 27160 code review

fixed pls to work with oracle, update Copyright,
add missing .class files.

Wed, 21 Jan 2015 13:14:46 +0100Fixed issue 27160: C_Order_Post poor performance
Eduardo Argal Guibert <eduardo.argal@openbravo.com> [Wed, 21 Jan 2015 13:14:46 +0100] rev 25778
Fixed issue 27160: C_Order_Post poor performance

Fri, 30 Jan 2015 14:01:23 +0100Fixes issue 28010: Some labels defined on js files can not be traslated
Inigo Sanchez <inigo.sanchez@openbravo.com> [Fri, 30 Jan 2015 14:01:23 +0100] rev 25777
Fixes issue 28010: Some labels defined on js files can not be traslated

It have been added capability to also translate 'Auto fit all columns'
and 'Auto fit' strings.

Fri, 30 Jan 2015 12:40:30 +0100Fixes bug 28776:Disable multiple sorting in UI of Grids(non-standard windows)
Inigo Sanchez <inigo.sanchez@openbravo.com> [Fri, 30 Jan 2015 12:40:30 +0100] rev 25776
Fixes bug 28776:Disable multiple sorting in UI of Grids(non-standard windows)

It has been added the "canMultiSort" property to false in OBGrids non-standard
windows (such as widgets, alerts, etc...).

Now, it has been disabled multiple sorting.

Thu, 29 Jan 2015 23:14:48 +0100Fixes issue 28747: Numeric field textual value is also rounded
Augusto Mauch <augusto.mauch@openbravo.com> [Thu, 29 Jan 2015 23:14:48 +0100] rev 25775
Fixes issue 28747: Numeric field textual value is also rounded

The problem was that even though the value of the field was being properly rounded, its textual value - sent as the propertyName_textualValue - was being kept unrounded. To fix it, now when the value of a numeric field is entered using a formula both its numeric and its textual value are updated.

Thu, 29 Jan 2015 19:04:28 +0100Fixes bug 28814: NPE fixed in Costing Background for a production product
Unai Martirena <unai.martirena@openbravo.com> [Thu, 29 Jan 2015 19:04:28 +0100] rev 25774
Fixes bug 28814: NPE fixed in Costing Background for a production product

When a product is defined as production the costing records created in the system are always for * organization. If a transaction of this product it was creating a backdated cost adjustment, in one place of the code a NPE exception error was happening because a costing record of legal entity org it was being trying to get. This has been fixed always filtering by client instead of organization when the product is of production type.

Thu, 22 Jan 2015 23:38:18 +0530Fixes Issue 25421:Stock availability not updated when a product has no
Atul Gaware <atul.gaware@openbravo.com> [Thu, 22 Jan 2015 23:38:18 +0530] rev 25773
Fixes Issue 25421:Stock availability not updated when a product has no
previous stock transaction

If product does not have records in m_storage_detail then they are skipped
in the view as m_storage_pending come after left join.

A solution implements a union of m_storage_detail and m_storage_pending
and grouping is done for qtyonhand, qtyordered, qtyreserved based on
m_product_id and m_warehouse_id

Thu, 29 Jan 2015 17:22:12 +0100Fixed bug 27570 updateBpPaymentLineInvoice is not correct for all scenarios
Sandra Huguet <sandra.huguet@openbravo.com> [Thu, 29 Jan 2015 17:22:12 +0100] rev 25772
Fixed bug 27570 updateBpPaymentLineInvoice is not correct for all scenarios

Wed, 28 Jan 2015 14:09:37 +0100Fix issue 28681: Return to Vendor Shipment pick/edit shows lines of any org
Alvaro Ferraz <alvaro.ferraz@openbravo.com> [Wed, 28 Jan 2015 14:09:37 +0100] rev 25771
Fix issue 28681: Return to Vendor Shipment pick/edit shows lines of any org

An extra condition has been added to Return to Vendor Shipment Pick/Edit Lines HQL Where Clause, in order to show only lines with warehouse belonging to natural organization's tree. Also M_RM_SHIPMENT_PICK_EDIT view has been modified to add a hack, to avoid having errors with pendingqty column when querying the view in Oracle

Tue, 27 Jan 2015 20:28:05 +0100Fixes bug 28421: No of rows exceed when export journal entries report to excel
Alvaro Ferraz <alvaro.ferraz@openbravo.com> [Tue, 27 Jan 2015 20:28:05 +0100] rev 25770
Fixes bug 28421: No of rows exceed when export journal entries report to excel

Modified ReportGeneralLedgerJournal class to chek if data is empty or if it contains more than 65532 rows

Wed, 28 Jan 2015 17:29:42 +0100fixed bug 28779: value of combo not displayed after setting it with a trigger
Asier Lostalé <asier.lostale@openbravo.com> [Wed, 28 Jan 2015 17:29:42 +0100] rev 25769
fixed bug 28779: value of combo not displayed after setting it with a trigger

When creating/refreshing a record, if the value of a FK drop down (table, tableDir
and selector references) is changed in the backed (ie. through a trigger) and that
drop down was not previously opened the value was seen as empty. The problem was
the actual value was set but not is identifier in the valueMap.

The fix handles this case on the dataSource reponse. It adds the new values to the
valueMap if it is not present.

setEntries method has been moved from OBFKComboItem to OBSelectorItem to handle it
both for selectors and table/tableDir references.

Wed, 28 Jan 2015 09:31:53 +0100Fixes bug 28426: A product without sales price can be added to a commision
Unai Martirena <unai.martirena@openbravo.com> [Wed, 28 Jan 2015 09:31:53 +0100] rev 25768
Fixes bug 28426: A product without sales price can be added to a commision

Filter expression of Product Selector has been changed for Commission window, to not to filter by Sales flag, displaying in this way Purchase and Sales Products.

Tue, 27 Jan 2015 19:06:57 -0500Fixed bug 28506: Create Credit does not work for closed return from customer.
Reinaldo Guerra <reinaldo.guerra@peoplewalking.com> [Tue, 27 Jan 2015 19:06:57 -0500] rev 25767
Fixed bug 28506: Create Credit does not work for closed return from customer.

Creating invoice stored procedure, called from Create Credit process for a closed Return From Customer document, was changed to take into account also closed orders, not only documents with status completed and under way.
Now it is possible to create invoices, when Create Credit process is launched from Return From Customer documents with status as closed.
This change also affects the Generate Invoices process called from application menu.

Wed, 28 Jan 2015 17:37:00 +0100Related to issue 28755: Fix copyright
Unai Martirena <unai.martirena@openbravo.com> [Wed, 28 Jan 2015 17:37:00 +0100] rev 25766
Related to issue 28755: Fix copyright

Wed, 28 Jan 2015 14:19:04 +0100[Costing] Fix assertDocumentPost in Costing automated tests
Alvaro Ferraz <alvaro.ferraz@openbravo.com> [Wed, 28 Jan 2015 14:19:04 +0100] rev 25765
[Costing] Fix assertDocumentPost in Costing automated tests

Mon, 26 Jan 2015 23:28:17 -0500Fixed bug 27822: Price List is not created and no error message is shown.
Reinaldo Guerra <reinaldo.guerra@peoplewalking.com> [Mon, 26 Jan 2015 23:28:17 -0500] rev 25764
Fixed bug 27822: Price List is not created and no error message is shown.

Create Price List stored procedure, was changed to launch an error message when the price list schema, defined in the price list version, have no lines defined.
Now, when creating a price list for a schema without lines, no product prices are added and an error message indicating that price list schema lines are required to execute the process.

Tue, 27 Jan 2015 13:16:28 +0100Fixed bug 28755 It is impossible leaving credit when adding a payment in match statement
Sandra Huguet <sandra.huguet@openbravo.com> [Tue, 27 Jan 2015 13:16:28 +0100] rev 25763
Fixed bug 28755 It is impossible leaving credit when adding a payment in match statement

Properly default value in actual payment field when add payment popup
runs from match statement.

Disabled "+" button and "magnifying glass" when line record is
linked to a transaction.