Fri, 23 Jan 2015 15:00:12 +0100Fixes issue 28427: Numbers are always rounded on blur
Augusto Mauch <augusto.mauch@openbravo.com> [Fri, 23 Jan 2015 15:00:12 +0100] rev 25747
Fixes issue 28427: Numbers are always rounded on blur

The blur function of the OBNumberItems only did the rounding when the getValue function of the item returned a string. This worked in most of the cases (i.e. standard grids and forms, d
ue to the edit form of the grid having a setTextualValue function, see [1]), but not in the parameter windows. In those windows, both numeric parameters and numeric columns in grid para
meters did not round the entered numbers before saving them.

To fix this, now the numbers are rounded on blur even if the value entered is already a number. To found the number these two functions are invoked:

value = OB.Utilities.Number.JSToOBMasked(this.getValue(), this.typeInstance.maskNumeric, this.typeInstance.decSeparator, this.typeInstance.groupSeparator);
this.setValue(OB.Utilities.Number.OBMaskedToJS(value, this.typeInstance.decSeparator, this.typeInstance.groupSeparator));

The first one converts the number to a string representation of the rounded number. The second one converts the rounded string number to a javascript number.

Fri, 23 Jan 2015 12:21:36 +0100Fixed issue 28722: Not possible to create invoiced receipts for customers created in WebPOS
Aaron Calero <aaron.calero@openbravo.com> [Fri, 23 Jan 2015 12:21:36 +0100] rev 25746
Fixed issue 28722: Not possible to create invoiced receipts for customers created in WebPOS

Modified the event handler used to set the BP currency to work not only on update events, but on save events too.
Now when BPs are saved from the POS, the currency is automatically assigned to these business partners and they can be used to generate invoices.

Fri, 23 Jan 2015 12:02:44 +0100Fixed bug 28456 Return orders does not appear in Create Invoices From Orders
Sandra Huguet <sandra.huguet@openbravo.com> [Fri, 23 Jan 2015 12:02:44 +0100] rev 25745
Fixed bug 28456 Return orders does not appear in Create Invoices From Orders

It has been deleted return= 'N' filter in the query because the filter
it is not necessary.

Thu, 22 Jan 2015 17:34:24 +0100Fix issue 28154: Accounting Dimensions are not shown in Expense Sheet Lines
Alvaro Ferraz <alvaro.ferraz@openbravo.com> [Thu, 22 Jan 2015 17:34:24 +0100] rev 25744
Fix issue 28154: Accounting Dimensions are not shown in Expense Sheet Lines

An Auxiliary Input of type DOCBASETYPE has been added in order to be able to show accounting dimensions in Expense Sheet Lines tab

Tue, 13 Jan 2015 12:59:52 +0530Fixes Issue 27289:"Not Balance" error received when posting a multi-currency
Atul Gaware <atul.gaware@openbravo.com> [Tue, 13 Jan 2015 12:59:52 +0530] rev 25743
Fixes Issue 27289:"Not Balance" error received when posting a multi-currency
OUT transaction (although suspense balancing no needs to be used)

Problem was a negate value (in case of payments where isReceipt=No) was being
subtracted.

Thu, 22 Jan 2015 17:05:07 +0100Fixes bug 28640:Res. line with amt released not duplicated in Manage Reservation
Unai Martirena <unai.martirena@openbravo.com> [Thu, 22 Jan 2015 17:05:07 +0100] rev 25742
Fixes bug 28640:Res. line with amt released not duplicated in Manage Reservation

The problem is that when opening Manage Reservations P&E from sales order line, the property 'reservationStock' comes blank, even when a reservation stock line exists (When there is no reservation for the sales orderline a temporary one is created just to display lines in the selector selected correctly, and after that is deleted. This happens in the datasource of the P&E). In this cases the Manage Reservations action handler deletes these lines y they exists and creates new ones. But this is not possible for already released lines, so it was creating a duplicate of those.

In order to fix this, the property 'id' is used (allways comes with a value) in the case that the reservation is released, because in this case for sure that the reservation stock line exists, so it will update the existing one instead of creating a new one.

Thu, 22 Jan 2015 11:14:24 +0100fixed bug 28720: callouts incorrectly set big non integer numbers
Asier Lostalé <asier.lostale@openbravo.com> [Thu, 22 Jan 2015 11:14:24 +0100] rev 25741
fixed bug 28720: callouts incorrectly set big non integer numbers

When a big non integer number was set by a callout, decimal separator was removed
resulting in a different number, ie. 10200500.45 resulted in 1020050045.00.

The problem was in the OB.Utilities.Number.ScientificToDecimal JavaScript function
which wrongly assumed scientific exponent always added zeroes to coefficient, which
is not true in this case where exponent determines where the decimal separator is
inserted in the coefficient.

Tue, 20 Jan 2015 09:23:02 -0500Fixed bug 28331: After completing a G/L Journal Reactivate should be the option.
Reinaldo Guerra <reinaldo.guerra@peoplewalking.com> [Tue, 20 Jan 2015 09:23:02 -0500] rev 25740
Fixed bug 28331: After completing a G/L Journal Reactivate should be the option.

Gl_journal_post stored procedure now updates required field in Gl_Journal table to pass from Complete to Reactivate Document Action. So now when GL/Journal is completed, DocAction field is updated with RE value and the button option in GL/Journal header window will be Reactivate. Also default option will be Reactivate, instead of Close, when clicking the button.

Wed, 21 Jan 2015 13:29:26 +0530Related to Issue 28591:Removed unwanted code from the modulescript to update
Atul Gaware <atul.gaware@openbravo.com> [Wed, 21 Jan 2015 13:29:26 +0530] rev 25739
Related to Issue 28591:Removed unwanted code from the modulescript to update
payment plan and payment plan details

Tue, 20 Jan 2015 15:59:49 +0100fixed bug 28684: incorrect check constraint export in pg 9.3 and 9.4
Asier Lostalé <asier.lostale@openbravo.com> [Tue, 20 Jan 2015 15:59:49 +0100] rev 25738
fixed bug 28684: incorrect check constraint export in pg 9.3 and 9.4

The differences appear for check constraints in character varying columns,
restoring DB adds extra casting in this case.

The fix takes care of these cases.

Tue, 20 Jan 2015 14:57:35 +0530Fixes Issue 28591:Reversing a payment is creating wrong invoice payment plan
Atul Gaware <atul.gaware@openbravo.com> [Tue, 20 Jan 2015 14:57:35 +0530] rev 25737
Fixes Issue 28591:Reversing a payment is creating wrong invoice payment plan
details

Problem is Schedule detail was being updated by payment amount now it is taken
care to update using individual schedule detail amount while creating reverse
payment schedule and payment schedule details. Modulescript to fix errorneous data
consists of update invoice paid, outstanding amt, update payment schedule received
and outstanding amount, update payment credit generated info if in case required.

Wed, 21 Jan 2015 08:26:08 +0530Backout 9c12d1443b20 changeset
Atul Gaware <atul.gaware@openbravo.com> [Wed, 21 Jan 2015 08:26:08 +0530] rev 25736
Backout 9c12d1443b20 changeset

Breaks int-inc-oracle test and is a old fix sent during review.

Mon, 19 Jan 2015 14:42:57 +0100Fixed issue 28623: Window's behaviour changes when creating a new record.
Naroa Iriarte <naroa.iriarte@openbravo.com> [Mon, 19 Jan 2015 14:42:57 +0100] rev 25735
Fixed issue 28623: Window's behaviour changes when creating a new record.

When a window is opened using the "quick create new" widget, the same window in the recent views layout
does not allow to create a new record (the green small button for creating a new record, which should be
by the window name, disappears).

The problem was in the "ob-utilities.js", inside the "{OB.Utilities.openView}" function, the logic for
setting the "singleRecord" value (this is the Edit Only attribute) was wrong. If the value of the
variable singleRecord of that function was undefined or null, as it was in the case of clicking the "quick create new"
widget, that value was set to true and the window became an "edit only" window.That was why the small
green "create new" icon disappeared from the recent views layout.

For fixing this the condition has been removed, so we know that the value of the variable "singleRecord" is not
going to be modified and it will be set correctly.

Tue, 20 Jan 2015 15:42:13 +0100Fixes Issue 28591:Reversing a payment is creating wrong invoice payment plan
Atul Gaware <atul.gaware@openbravo.com> [Tue, 20 Jan 2015 15:42:13 +0100] rev 25734
Fixes Issue 28591:Reversing a payment is creating wrong invoice payment plan
details

Problem is Schedule detail was being updated by payment amount now it is taken
care to update using individual schedule detail amount while creating reverse
payment schedule and payment schedule details.

Tue, 20 Jan 2015 18:10:14 +0100Fixed bug 28675: AccessibleOrgTree wrongly used in some reports.
Reinaldo Guerra <reinaldo.guerra@peoplewalking.com> [Tue, 20 Jan 2015 18:10:14 +0100] rev 25733
Fixed bug 28675: AccessibleOrgTree wrongly used in some reports.

Organization combo in some manual reports now includes organizations accessed by logged role.
In some cases Utility getContext method when creating organizations combo, was changed to use User_Org instead of AccessibleOrgTree. Also for Balance sheet and P&L structure report (GeneralAccountingReports java class), organizations list was taken from OBContext's role due to the organization's combo, in this case, is filled in a different way. For Customer Statement process, a new validation was created to obtain organizations accessed by logged role.

Tue, 20 Jan 2015 17:33:57 +0100Fixes issue 28686: Reversing a payment is creating wrong invoice payment plan
Ander Iraceburu <ander.iraceburu@openbravo.com> [Tue, 20 Jan 2015 17:33:57 +0100] rev 25732
Fixes issue 28686: Reversing a payment is creating wrong invoice payment plan

Thu, 15 Jan 2015 17:46:57 -0500Fixed bug 28452: Wrong Trial Balance having standard accounting in Opening date.
Reinaldo Guerra <reinaldo.guerra@peoplewalking.com> [Thu, 15 Jan 2015 17:46:57 -0500] rev 25731
Fixed bug 28452: Wrong Trial Balance having standard accounting in Opening date.

The method calculateTree, in Report Trial Balance process class, was calculating in a wrong way the balance of accounting's credits and debits in opening dates. So the method was changed to not just overwrite credit and debit values but to increase them with the accumulate, when initial balance information is requested.
Now when executing Trial Balance report, for opening dates, accounting's credits and debits are calculated properly and balance is set to 0.

Mon, 19 Jan 2015 20:26:34 +0100[Costing] Remove some asserts in Costing automated tests
Alvaro Ferraz <alvaro.ferraz@openbravo.com> [Mon, 19 Jan 2015 20:26:34 +0100] rev 25730
[Costing] Remove some asserts in Costing automated tests

Tue, 13 Jan 2015 11:52:49 -0500Fixed bug 28031: Performance problems on the payment monitor process.
Fernando Soto <fernando.soto@peoplewalking.com> [Tue, 13 Jan 2015 11:52:49 -0500] rev 25729
Fixed bug 28031: Performance problems on the payment monitor process.

Created new index c_invoice_paid in c_invoice table using ispaid column.

Mon, 19 Jan 2015 19:04:16 +0100Fixed bug 28061: Performance problems on the payment monitor process.
Unai Martirena <unai.martirena@openbravo.com> [Mon, 19 Jan 2015 19:04:16 +0100] rev 25728
Fixed bug 28061: Performance problems on the payment monitor process.

Changed FIN_PaymentMonitorProcess class to use a ScrollableResults instead of a list.

Wed, 07 Jan 2015 18:55:41 -0500Fixed bug 28325: Journal Entries Detail fails depending on the date format.
Reinaldo Guerra <reinaldo.guerra@peoplewalking.com> [Wed, 07 Jan 2015 18:55:41 -0500] rev 25727
Fixed bug 28325: Journal Entries Detail fails depending on the date format.

When retrieving Fact Acct Group information in ReportGeneralLedgerJournalDetail class in a direct command request, now is taken into account that the date format defined could be dd/MM/yyyy, instead of default one dd-MM-yyyy, so the called of split function getValue, was changed to separate the string parameter by the position that realy marks the end of the date and the begins of the Group Id.
Now the complete date is read no matter the format defined, and the Journal Entries Detail form shows the information successfuly.

Mon, 19 Jan 2015 17:01:01 +0100Related to issue 28673:Allow partial shipments on book process
Guillermo Gil <guillermo.gil@openbravo.com> [Mon, 19 Jan 2015 17:01:01 +0100] rev 25726
Related to issue 28673:Allow partial shipments on book process

Query for looking AllowPartialShipment out of the loop

Mon, 19 Jan 2015 15:09:26 +0100Related to issue 28673:It should be possible to allow partial shipments on book process
Guillermo Gil <guillermo.gil@openbravo.com> [Mon, 19 Jan 2015 15:09:26 +0100] rev 25725
Related to issue 28673:It should be possible to allow partial shipments on book process

Modified constant value

Mon, 19 Jan 2015 12:53:22 +0100Fixed issue 28673:It should be possible to allow partial shipments on book process
Guillermo Gil <guillermo.gil@openbravo.com> [Mon, 19 Jan 2015 12:53:22 +0100] rev 25724
Fixed issue 28673:It should be possible to allow partial shipments on book process

AllowPartialShipment preference created
If Y, c_order_post would ship all the available items

Mon, 19 Jan 2015 12:35:25 +0100fixed bug 27957: new child grid record fails after parent new grid record
Asier Lostalé <asier.lostale@openbravo.com> [Mon, 19 Jan 2015 12:35:25 +0100] rev 25723
fixed bug 27957: new child grid record fails after parent new grid record

When a new record was created in child grid view for a child tab just after
creating its parent in grid view, it failed creating the second record for
that child tab.

The problem was caused by an extra request to child tab due to incorrect sync
between lastSelectedRecord and getSelectedRecord for parent tab, lastSelectedRecord
kept the temporary id for new records.

The solution updates the selection once the parent one has been saved.

Mon, 19 Jan 2015 11:32:29 +0100[Costing] Change type of lineNo parameter in Costing automated tests
Alvaro Ferraz <alvaro.ferraz@openbravo.com> [Mon, 19 Jan 2015 11:32:29 +0100] rev 25722
[Costing] Change type of lineNo parameter in Costing automated tests

Tue, 13 Jan 2015 10:50:29 +0100fixed bug 28565: not possible to filter by LineNo field in Match LC Cost
Asier Lostalé <asier.lostale@openbravo.com> [Tue, 13 Jan 2015 10:50:29 +0100] rev 25721
fixed bug 28565: not possible to filter by LineNo field in Match LC Cost

The problem was caused by a reference mistmatch between lineNo property in HQL
table, which was correctly Integer, and the reference for the M_LC_Cost.lineNo
which was Number.

Fixed M_LC_Cost.lineNo to be Integer.

Fri, 16 Jan 2015 14:33:14 +0100Related to bug 28626: Fix copyright
Alvaro Ferraz <alvaro.ferraz@openbravo.com> [Fri, 16 Jan 2015 14:33:14 +0100] rev 25720
Related to bug 28626: Fix copyright

Fri, 16 Jan 2015 14:04:22 +0100Fixes bug 28626: MatchingAlgorithm window is not shown in test environments
Alvaro Ferraz <alvaro.ferraz@openbravo.com> [Fri, 16 Jan 2015 14:04:22 +0100] rev 25719
Fixes bug 28626: MatchingAlgorithm window is not shown in test environments

APRM_AlgorithmConfirm, APRM_ProcessReconciliation and APRM_SplitBankStatementLineConfirm popups are now shown, although OB.TestRegistry.registry object is not empty

Fri, 16 Jan 2015 12:56:53 +0100Fixes bug 28643: Currency now is setted correctly in Transaction tab.
Unai Martirena <unai.martirena@openbravo.com> [Fri, 16 Jan 2015 12:56:53 +0100] rev 25718
Fixes bug 28643: Currency now is setted correctly in Transaction tab.

Default value assigned to Currency column in transaction tab, that was not done during Transaction tab refactor project.