Fri, 07 Nov 2014 23:24:39 -0500Fixed bug 27313: D-U-N-S number should not be mandatory
Reinaldo Guerra <reinaldo.guerra@peoplewalking.com> [Fri, 07 Nov 2014 23:24:39 -0500] rev 26142
Fixed bug 27313: D-U-N-S number should not be mandatory

D-U-N-S number column in organization's information table was changed to non mandatory.
Now when introducing data in organization's information tab it is not necessary to fill D-U-N-S number as it is something that is not used in all the goberments/companies.

Fri, 06 Mar 2015 17:03:04 +0100Fixes issue 28939
Eduardo Argal Guibert <eduardo.argal@openbravo.com> [Fri, 06 Mar 2015 17:03:04 +0100] rev 26141
Fixes issue 28939
Perfromance problem running module script in environments with large amount of transactions (invoices and orders).
New index is added in postgres environments when this is not present. Problem comes from table recreation, so impacts those who update from a version that requires invoice table rebuilding.

Fri, 06 Mar 2015 16:52:17 +0100Related to issue 28909
Eduardo Argal Guibert <eduardo.argal@openbravo.com> [Fri, 06 Mar 2015 16:52:17 +0100] rev 26140
Related to issue 28909
Change variable definition to public to be able to retrieve the value

Fri, 06 Mar 2015 15:03:31 +0000CI: merge back from main
RM packaging bot <staff.rm@openbravo.com> [Fri, 06 Mar 2015 15:03:31 +0000] rev 26139
CI: merge back from main

Fri, 06 Mar 2015 14:42:49 +0000CI: update AD_MODULE to version 26133
RM packaging bot <staff.rm@openbravo.com> [Fri, 06 Mar 2015 14:42:49 +0000] rev 26138
CI: update AD_MODULE to version 26133

Fri, 06 Mar 2015 11:31:38 +0100Related to issue 28909
Eduardo Argal Guibert <eduardo.argal@openbravo.com> [Fri, 06 Mar 2015 11:31:38 +0100] rev 26137
Related to issue 28909
can't create orders in Oracle. Created StockUtils class to enable calls to M_GET_STOCK_PARAM procedure
getting out params

H : Enter commit message. Lines beginning with 'HG:' are removed.

Fri, 06 Mar 2015 11:21:26 +0100Fixes issue 29168
Eduardo Argal Guibert <eduardo.argal@openbravo.com> [Fri, 06 Mar 2015 11:21:26 +0100] rev 26136
Fixes issue 29168
getCallableResult broken when using null parameters. Removed TEST value for default

Fri, 06 Mar 2015 08:51:40 +0100fixed issue 29157: code review issues for Process Definition Reporting Tool
Asier Lostalé <asier.lostale@openbravo.com> [Fri, 06 Mar 2015 08:51:40 +0100] rev 26135
fixed issue 29157: code review issues for Process Definition Reporting Tool

Fixes include:
* Security: prevent traversal attack. BaseReportActionHandler could be invoked
to download any file in the system. Fixed by:
- Now it only accepts file name instead of full path, looking for this file
in the temporary directory.
- Filename is parsed to ensure it is a valid generated jasper file name,
preventing in this manner downloads of any arbitrary file in the temporary
directory.
* ReportSemaphoreHandling changes:
- Modified to make use of standard java.util.concurrent.Semaphore
implementation rather than implementing its own semaphore.
- Property to read maximum number of concurrent executions is read on
initialization instead of when acquiring. This way acquisition is faster.
* When a Jasper report is generated with a virtualizer, it's finally cleaned
up.
* When downloading a report, temporary file is deleted on a finally block to
ensure deletion even on failure.
* Changes in javadoc to fix some typos + prevent undocumented parameters.
* Defensive coding: when generating/downloading a report, don't assume if type
is not pdf then it is xls, but do check all the types and raise an exception
in case of unsupported type.
* UI: in process definition window, don't show Can Add Records flag for process
definitions of type report

Wed, 04 Mar 2015 17:07:47 +0100Fixed bug 29124 It is not possible to create PaymentOut from "match statement"
Sandra Huguet <sandra.huguet@openbravo.com> [Wed, 04 Mar 2015 17:07:47 +0100] rev 26134
Fixed bug 29124 It is not possible to create PaymentOut from "match statement"

It is not possible to create Payment Out from "match statement" using
a G/L item.

Fri, 06 Mar 2015 08:10:31 +0100fixed issue 29154: added log on table recreation when updating database
Asier Lostalé <asier.lostale@openbravo.com> [Fri, 06 Mar 2015 08:10:31 +0100] rev 26133
fixed issue 29154: added log on table recreation when updating database

Thu, 05 Mar 2015 17:36:57 +0100fixed bug 29140: selected credit selected is not used
Asier Lostalé <asier.lostale@openbravo.com> [Thu, 05 Mar 2015 17:36:57 +0100] rev 26132
fixed bug 29140: selected credit selected is not used

When adding a payment the selected records for used credit were not taken into
account.

The problem was credit_to_use._selection property was always sent as [] after
fix for issue #28712. The problem was in the overwritten selectionChanged js
method for this grid, which should invoke super's selectionChanged but it didn't
do it correctly.

Thu, 05 Mar 2015 16:00:48 +0000CI: merge back from main
RM packaging bot <staff.rm@openbravo.com> [Thu, 05 Mar 2015 16:00:48 +0000] rev 26131
CI: merge back from main

Thu, 05 Mar 2015 15:36:59 +0000CI: update AD_MODULE to version 26126
RM packaging bot <staff.rm@openbravo.com> [Thu, 05 Mar 2015 15:36:59 +0000] rev 26130
CI: update AD_MODULE to version 26126

Thu, 05 Mar 2015 14:18:04 +0100fixed bug 29127: PR14Q3 -> PR14Q4 update can fail activating FKs
Asier Lostalé <asier.lostale@openbravo.com> [Thu, 05 Mar 2015 14:18:04 +0100] rev 26129
fixed bug 29127: PR14Q3 -> PR14Q4 update can fail activating FKs

Added build validation to prevent this error.

This build validation prevents issue #29127 by deleting rows in ad_process_run for executions of
CostingRuleProcess which is removed but due to issue #29142 update database process is not able
to properly handle.

It is a temporary workaround and it should be removed one #29142 is resolved.

It should have been implemented as ModuleScript because it is repairing data, but because
ad_process_run and ad_process_request tables are recreated when updating from PR14Q3 to PR14Q4,
module script would be executed without indexes nor DB statistics which might result, depending
on the data volumes in these table, in slow executions due to poor query execution plans.
Exceptionally, implementing it as build validation to be executed before actual database update
allowing better plans.

Thu, 05 Mar 2015 16:04:13 +0100fixed bug 29117: empty linked items if computed column points current entity
Asier Lostalé <asier.lostale@openbravo.com> [Thu, 05 Mar 2015 16:04:13 +0100] rev 26128
fixed bug 29117: empty linked items if computed column points current entity

Linked items section didn't receive any row and remained in "loading data" state
when a computed column in any entity linked to the entity the section was used in.

The problem was caused by an error when trying to deal with computed column in
linked items. No error was shown nor in UI nor in openbravo.log.

This fix:
- Adds log in openbravo.log including stack trace in case of error computing
linked items
- NPE getMessage is null which caused not to be shown in the UI, it is casted
to String
- Computed Columns are properly ignored in linked items

IMPORTANT NOTE: Computed Columns cannot be evaluated in linked items so they
are ignored

Thu, 05 Mar 2015 10:49:36 +0100Related with issue 29113: Avoid using isc in OB.Utilities.Number.roundJSNumber
Augusto Mauch <augusto.mauch@openbravo.com> [Thu, 05 Mar 2015 10:49:36 +0100] rev 26127
Related with issue 29113: Avoid using isc in OB.Utilities.Number.roundJSNumber

The OB.Utilities.Number.roundJSNumber function is used in the mobile core module, but smartclient is not available there. OB.Utilities.Number.roundJSNumber should not be used there (see [1]), but in the meantime we are going to avoid using smartclient functions in roundJSNumber.

isc.isA.String has been replaced with (typeof num === 'string')

[1] https://issues.openbravo.com/view.php?id=29139

Thu, 05 Mar 2015 10:15:41 +0100Fixes issue 29113: Use setScale instead of round, and handle properly NaN
Augusto Mauch <augusto.mauch@openbravo.com> [Thu, 05 Mar 2015 10:15:41 +0100] rev 26126
Fixes issue 29113: Use setScale instead of round, and handle properly NaN

The BigDecimal.round function did not work as we expected [1]:

new BigDecimal('0.145').round(2, BigDecimal.prototype.ROUND_HALF_UP).toString() -> 0.15 (OK)
new BigDecimal('1.145').round(2, BigDecimal.prototype.ROUND_HALF_UP).toString() -> 1.1 (WRONG)
new BigDecimal('10.145').round(2, BigDecimal.prototype.ROUND_HALF_UP).toString() -> 10 (WRONG)

To round the number to a specific amout of decimal digits, the setScale function should be used.

new BigDecimal('0.145').setScale(2, BigDecimal.prototype.ROUND_HALF_UP).toString() -> 0.15 (OK)
new BigDecimal('1.145').setScale(2, BigDecimal.prototype.ROUND_HALF_UP).toString() -> 1.15 (OK)
new BigDecimal('10.145').setScale(2, BigDecimal.prototype.ROUND_HALF_UP).toString() -> 10.15 (OK)

Also, when the number provided in the first argument of the OB.Utilities.Number.roundJSNumber is not a number, the function returns NaN, as it used to do it before.

[1] http://stackoverflow.com/a/13461270

Wed, 04 Mar 2015 18:51:22 +0100Fixed issue 29133: Avoid JS error in 'Add Details' process
David Baz Fayos <david.baz@openbravo.com> [Wed, 04 Mar 2015 18:51:22 +0100] rev 26125
Fixed issue 29133: Avoid JS error in 'Add Details' process
while moving between fields in new record in 'G/L Items' grid

Wed, 04 Mar 2015 18:22:34 +0100Fixed bug 28729 select the proper credit when a reverse payment is made
Sandra Huguet <sandra.huguet@openbravo.com> [Wed, 04 Mar 2015 18:22:34 +0100] rev 26124
Fixed bug 28729 select the proper credit when a reverse payment is made

When reverse payment process is run for a credit payment the credit
generated in that specific payment should be consumed

Tue, 03 Mar 2015 13:57:53 +0100Fixes bug 29111: Valued Stock report filter properly by Product Category
Unai Martirena <unai.martirena@openbravo.com> [Tue, 03 Mar 2015 13:57:53 +0100] rev 26123
Fixes bug 29111: Valued Stock report filter properly by Product Category

A new language parameter was added in the issue that has caused the regression, but in wrong order, causing not to be able to filter by Product Category.
Also a left join was being done instead of inner join, so the query was displaying an wrong extra line with a sum up of all not necessary m_transaction records.

Wed, 04 Mar 2015 18:06:07 +0100Fixes issue 0029132: Internal cosumption line can not be saved,
Jon Alegría <jon.alegria@openbravo.com> [Wed, 04 Mar 2015 18:06:07 +0100] rev 26122
Fixes issue 0029132: Internal cosumption line can not be saved,
because unit is not filled when attribute set in product setup
is empty

Wed, 04 Mar 2015 14:50:57 +0000CI: merge back from main
RM packaging bot <staff.rm@openbravo.com> [Wed, 04 Mar 2015 14:50:57 +0000] rev 26121
CI: merge back from main

Wed, 04 Mar 2015 14:30:40 +0000CI: update AD_MODULE to version 26117
RM packaging bot <staff.rm@openbravo.com> [Wed, 04 Mar 2015 14:30:40 +0000] rev 26120
CI: update AD_MODULE to version 26117

Wed, 04 Mar 2015 15:01:42 +0100Related with issue 28842: Improves javadoc of checkReadableAccess method
Augusto Mauch <augusto.mauch@openbravo.com> [Wed, 04 Mar 2015 15:01:42 +0100] rev 26119
Related with issue 28842: Improves javadoc of checkReadableAccess method

Thu, 26 Feb 2015 13:45:06 +0100Fixed issue 28842: There are problems to handle attachments.
Naroa Iriarte <naroa.iriarte@openbravo.com> [Thu, 26 Feb 2015 13:45:06 +0100] rev 26118
Fixed issue 28842: There are problems to handle attachments.

There were two problems:
First: When storing an attachment in the database (c_file table), the current
organization of the user was used instead of the organization of the document where the
file is being attached to. The aim of this fix is to take the value of the organization
of the attached document instead of the current user organization.
Second: When an attachment was created with an organization and after that, the
organization of the document was changed, it was not possible to download it, update it nor delete
it with a user who does not have access to the organization used to create the attachment.

To fix the first part, a new field that stores the document organization has been added to the canvas
of the OBAttachmentsSectionItem class in the fillAttachments function. After that the
field is sent as a param in the request, and can be used in the TabAttachments.java class
to be included to create the new record in c_file.

To fix the second part, the way the attachments are retrieved in the TabAttachments and in the
AttachmentsAH classes has been modified. Now the automated organization filter is disabled,
so the organization of the attachment is not taken into accout. It is needed that the user has at
least readable access to the document's organization for downloading, deleting or editing its attachments
a new method has been added to the SecurityChecker class for checking this.

Tue, 03 Mar 2015 19:14:50 +0100Fixes issue 29113: BigDecimal is used to prevent rounding error
Augusto Mauch <augusto.mauch@openbravo.com> [Tue, 03 Mar 2015 19:14:50 +0100] rev 26117
Fixes issue 29113: BigDecimal is used to prevent rounding error

There was a problem with javascript decimal precision that was affecting the way we round numbers using the OB.Utilities.Number.roundJSNumber. For instance, if this is 0.145*100 is evaluated in the javascr
ipt console, the result was 14.499999999999998, not 14.5.

Now the OB.Utilities.Number.roundJSNumber uses BigDecimal to overcome this precision error. This is the command used not to round a number:

parseFloat(new BigDecimal(num).round(dec,BigDecimal.prototype.ROUND_HALF_UP));

Tue, 03 Mar 2015 21:33:25 +0000CI: merge back from main
RM packaging bot <staff.rm@openbravo.com> [Tue, 03 Mar 2015 21:33:25 +0000] rev 26116
CI: merge back from main

Tue, 03 Mar 2015 21:16:06 +0000CI: update AD_MODULE to version 26114
RM packaging bot <staff.rm@openbravo.com> [Tue, 03 Mar 2015 21:16:06 +0000] rev 26115
CI: update AD_MODULE to version 26114

Tue, 03 Mar 2015 16:03:04 +0100Related to issue 28819 place the description in the correct field
Sandra Huguet <sandra.huguet@openbravo.com> [Tue, 03 Mar 2015 16:03:04 +0100] rev 26114
Related to issue 28819 place the description in the correct field

Tue, 03 Mar 2015 15:08:08 +0000CI: merge back from main
RM packaging bot <staff.rm@openbravo.com> [Tue, 03 Mar 2015 15:08:08 +0000] rev 26113
CI: merge back from main