Mon, 27 Apr 2020 05:28:08 +0000Update AD_MODULE version to 3.0PR19Q4.4 3.0PR19Q4.4
RM packaging bot <staff.rm@openbravo.com> [Mon, 27 Apr 2020 05:28:08 +0000] rev 37319
Update AD_MODULE version to 3.0PR19Q4.4

Thu, 26 Mar 2020 07:43:14 +0100fixed BUG-43585: alerts not counted in main top bar widget
Asier Lostalé <asier.lostale@openbravo.com> [Thu, 26 Mar 2020 07:43:14 +0100] rev 37318
fixed BUG 43585: alerts not counted in main top bar widget

Alerts defined whose alert rule was defined in an organization
different than * were not counted in main top bar widget.

Parameter to set filter out not readeable organizations was
incorrectly setting clients instead of organizations.

Thu, 26 Mar 2020 12:25:43 +0100fixed BUG-43592: jrxml translate build step fails if using jasperreport.dtd
Asier Lostalé <asier.lostale@openbravo.com> [Thu, 26 Mar 2020 12:25:43 +0100] rev 37317
fixed BUG 43592: jrxml translate build step fails if using jasperreport.dtd

Translate makes use of a custom EntityResolver to handle jasperreport.dtd
resolving it locally instead of getting it from Internet. This local
resolution is implemented making use of Class.getResourceAsStream
method. The class the method was invoked from was java.lang.System.

Starting from JDK 9, getResourceAsStream invoked in classes within named
Modules looks for the resources only in those modules rather than in the
whole classpath [1]:

> If this class is in a named Module then this method will attempt to find
> the resource in the module. This is done by delegating to the module's class
> loader findResource(String,String) method, invoking it with the module name
> and the absolute name of the resource. Resources in named modules are subject
> to the rules for encapsulation specified in the Module getResourceAsStream
> method and so this method returns null when the resource is a non-".class"
> resource in a package that is not open to the caller's module.
>
> Otherwise, if this class is not in a named module then the rules for searching
> resources associated with a given class are implemented by the defining class
> loader of the class. This method delegates to this object's class loader. If
> this object was loaded by the bootstrap class loader, the method delegates to
> ClassLoader.getSystemResourceAsStream(java.lang.String).

As java.lang.System is in a named Module, dtd's resource was tried to be found within
it and not found.

Fixed by invoking getResourceAsStream on LocalEntityResolver.class which
is not in a named module.

[1] https://docs.oracle.com/en/java/javase/11/docs/api/java.base/java/lang/Class.html#getResourceAsStream(java.lang.String)

Thu, 23 Apr 2020 19:03:25 +0200Fixes ISSUE-43849: Executes change on ok when no item selected in multiselector
Cristian Berner <cristian.berner@openbravo.com> [Thu, 23 Apr 2020 19:03:25 +0200] rev 37316
Fixes ISSUE 43849: Executes change on ok when no item selected in multiselector

Thu, 23 Apr 2020 18:59:31 +0200Fixes ISSUE-43784: MultiSelector parameter values are saved in form onChange
Cristian Berner <cristian.berner@openbravo.com> [Thu, 23 Apr 2020 18:59:31 +0200] rev 37315
Fixes ISSUE 43784: MultiSelector parameter values are saved in form onChange

Tue, 21 Apr 2020 18:14:07 +0200Fixes ISSUE-43687: Cancel and make new transaction on error in TranslationHandl
Cristian Berner <cristian.berner@openbravo.com> [Tue, 21 Apr 2020 18:14:07 +0200] rev 37314
Fixes ISSUE 43687: Cancel and make new transaction on error in TranslationHandl

Thu, 23 Apr 2020 11:56:52 +0200Related to ISSUE-43696. Code Review changes:
David Miguelez <david.miguelez@openbravo.com> [Thu, 23 Apr 2020 11:56:52 +0200] rev 37313
Related to ISSUE 43696. Code Review changes:
* Use uppercase for class constants
* Use lowercase for reserved keyworkds in hql query

Wed, 15 Apr 2020 10:13:39 +0200related to ISSUE-43696:Applied new HQL Style
Iñigo Lerga <inigo.lerga@openbravo.com> [Wed, 15 Apr 2020 10:13:39 +0200] rev 37312
related to ISSUE 43696:Applied new HQL Style

Wed, 15 Apr 2020 09:59:56 +0200fixes BUG-43696:Transactions and Costing are now deleted
Iñigo Lerga <inigo.lerga@openbravo.com> [Wed, 15 Apr 2020 09:59:56 +0200] rev 37311
fixes BUG 43696:Transactions and Costing are now deleted

Tue, 21 Apr 2020 10:15:57 +0200Fixed ISSUE-43791. Make referencedinventory test auto-skip if AWO is installed.
Stefan Hühner <stefan.huehner@openbravo.com> [Tue, 21 Apr 2020 10:15:57 +0200] rev 37310
Fixed ISSUE 43791. Make referencedinventory test auto-skip if AWO is installed.

Those test are not compatible with AWO as data they create does not comply with
some new constraint added by AWO.
So far that was required to be handled manually by adding config/disabled-tests
i.e. in every CI job with AWO installed to list the all individual tests here
to skip them.

This issue makes that behavior automatic by checking inside a central base-class
if AWO module is present and skipping the tests themselves (using similar logic
as is used by code for skipping config/disabled-tests from OBBaseTest).
Note that the repeated (per test) calls to isModulePresent are very fast as
that function caches the data inside so no need for caching isAwoInstalled inside
the test-class.