CI: update AD_MODULE to version 26737

Fixed issue 29709: Physical inventory cannot be created.

The problem was that if it was a very small negative Book Quantity number, it was not
possible to create a Physical Inventory line.

It was because the "ScientificToDecimal" function was not working properly with negative
numbers. The '-' sign was taken as a number instead of as a sign, that was the reason of
obtaining a value like 0.000-3655 when -0.0003655 was expected.

To fix this, a condition has been added which takes into account the fact of having
the '-' sign and to deal with the sign as a sign and not as a number.

Fixes issue 29566: Upgrade Jasper Libraries

[jasper-library-upgrade] use constant

[jasper-library-upgrade] Added missing 'Iterator' change

Change 'Iterator' to 'for' loop in PrintController.java

[jasper-library-upgrade] String parameter retrieval for xls configuration also

[jasper-library-upgrade] Added missing AD_MESSAGE

[jasper-library-upgrade] Added cast to retrieve parameters correctly

[jasper-library-upgrade] Improvements in temporal file deletion

[jasper-library-upgrade] Code review improvements

[jasper-library-upgrade] Added jackson-annotations library

[jasper-library-upgrade] Merge with pi

[jasper-library-upgrade] Added required license texts

[jasper-library-upgrade] Updated the copyright year of some classes.

[jasper-library-upgrade] Fixes deprecation warnings

Concat reports using Jasper library

Update payment report in PDF with changes related to issue 29847

Delete temporal files after attaching or sending standard by email

Improved getTranslatedJasperReport method javadoc description

Update Licensing.txt with the new .jar libraries

Deprecate GridReportVO and ReportDesignBO classes

Add getTranslatedJasperReport method into the ReportingUtils class

Handle error when the browser is closed before getting the whole HTML report

Upgrade JRXML files according to the new JasperReports library

Upgrade JasperReports library to version 6.0.0

Fix to make virtualizer work properly

Centralize reporting API in ReportingUtils class

Fixes bug 29913: Correct trx status assigned while deleting from reconciliation

while checking or unchecking lines in Reconcile popup 'updateTransactionStatus' method is called to assign the proper status to the transaction. While unchecking 'Withdrawn not Cleared' or 'Deposited not Cleared' statuses has to be assigned to the transactions. This part is was wrong. When the transaction was of BP Deposit 'Withdrawn not Cleared' was being assigned and when the transaction was BP Withdrawal 'Deposited not Cleared' was being assigned.

Related to issue 29766: Retail Operations Buffer: store all transactions in operations table before processing
Backout of changeset 6ee939d35840 because of failing dbcons

Fixes issue 29903: Performance improvement in EntityAccessChecker.initialize

Related to issue 29766: Retail Operations Buffer: store all transactions in operations table before processing
Increased size of error info

Fixes issue 29956: Description not transferred from G/L Journal header to lines

Default value was removed in Description column of GL_JournalLine table. Now, it is setted correctly.
Also, an auxiliary input has been added to have the same default value in Description field of Simple G/L Journal window - Lines tab.

CI: merge back from main

CI: update AD_MODULE to version 26729

Fixed issue 29638: Google Calendar widget is not working properly.

In the workspace, adding a google calendar windget was not working properly. It
appeared blank.

It is necessary to set the field "email" of the user, in the user window, for being able
to show the asociated calendar in the widget. It is also necessary to be logged in the same
google account in the same browser for being able to display the calendar.

The problem was that it was not correctly displayed at first and it was necessary to refresh
the workspace for making the Google Calendar work properly.
This was because the email of the user was not correctly set.

The "evaluateContents" function has been overwritten in then "ob-url-widget.js" for granting
its correct behavior.

fixed bug 29940: field changes to Id in editable P&E when adding new rows

In P&E with editable grid, if adding new records with default value for a drop
down reference, existing records with different values for that field were changed
from identifier to uuid.

The problem was in how value map was set in this case. Instead of setting it for
the edit form it was done at grid level.

It has been fixed by setting the value map only to the field in the edit form.

CI: merge back from main

CI: update AD_MODULE to version 26726

Merge back from main

Merge temporary head for 3.0PR15Q2.1

Added signature for changeset fdb1e0cd936d

Added tag 3.0PR15Q2.1 for changeset e861122b0b1d

Update AD_MODULE version to 3.0PR15Q2.1

Fixed bug 29808: Impossible to create several calendars for the same organization

Two pieces of code were affected by this bug:
PeriodEventHandler.java: EntityPersistenceEventObserver in charge of checking overlap in manual inserts/updates (or any java process) in c_period table
C_YEARPERIODS: db function associated to the create periods process inside the Fiscal Calendar | Year tab. It also verifies the periods don't overlap other periods.

The fix consists in checking that there is no date overlap per calendar. Before this fix the calendar wasn't taken into account, so it was not possible to define several calendars for the same organization with the same periods.

Related to issue 29808: Backout wrong changeset
The changeset pushed was not the good one, and failed in Oracle

Related to bug 29884: Code Review

Add coalesce in case there is no batch associated to set GL Journal Org, in order to avoid issues in the if condition done right after the query if null values are compared

Fixes issue 29884: Error while completing a Simple G/L Journal in Oracle

A query in gl_journal_post has been changed to avoid errors in Oracle when retrieving a null id

Fixes issue 29889 & Fixes issue 29887: Error in Price Correction Background

IsCostCalculated will not be considered to set CheckPriceDifference flag, when completing an invoice.
Instead, when running Price Correction Background, transactions will be filtered by IsCostCalculated to avoid calculate price differences in transactions where cost has not been calculated.

Fixes issue 29899: False positives in GLJournalAccountingCheck validation
Missing ad_table_id constraint ends up in wrong validation when there are old records using numeric values for ids.

Related to bu 29891: Adjust costing tests to the new behavior

Fixes bug 29891: Total Movement qty fixed in costing tab with backdated trx

While working with cost adjustments, on certain cases the existing Costing records changes. This can happen because the cost has been recalculated due to backdated transactions, price adjustments, manual cost corrections, etc. In all this cases the 'Total Movement Quantity' field was not being correctly updated.
This field has to store the current stock of the product on that moment. So, each time the costing record is updated it is being checked if this value changes, and if it has changed the current stock is set.

Fixes bug 29838: Prevents unlimited datasource requests when filtering the grid

The problem was that the logic to check that if a datasource request was triggered by scrolling up in a grid that did not have its initial rows loaded (see [1]) did not work well when the user filtered the grid after having scrolled down the grid till loading its second page. This caused the totalRows property of the grid to be miscalculated, and this triggered the undefinite amount of datasource requests.

The logic to check if the request was triggered by scrolling up has been changed. Now, instead of checking low-level smartclient properties like lastScrollTop, we check if there are rows loaded in the positions just after the page that was just received. Only in that case we want to prevent resetting the totalRows property of the ResultSet with the value returned by the datasource.

[1] https://code.openbravo.com/erp/devel/pi/rev/c51dce7e9fd3c47915464ab4f565a9d1cee60e3b

Fixed bug 29827: Open/Close Period Control shows calendars associated to organizations

The Open/Close Period Control window was showing all the periods available at the C_Period table.
The target of this window is to open/close periods in fiscal calendars, so it should only show periods belonging to a fiscal calendar linked to an organization set as ready.

The fix has 2 parts:
1. Added a hql where clause to include only periods belonging to a fiscal calendar linked to an organization set as ready.
2. The hql filter clause was wrong because it was filtering by the c_period.ad_org_id. Instead it should be filtering by the organization linked to the calendar's periods

Fixed bug 29808: Impossible to create several calendars for the same organization

Two pieces of code were affected by this bug:
PeriodEventHandler.java: EntityPersistenceEventObserver in charge of checking overlap in manual inserts/updates (or any java process) in c_period table
C_YEARPERIODS: db function associated to the create periods process inside the Fiscal Calendar | Year tab. It also verifies the periods don't overlap other periods.

The fix consists in checking that there is no date overlap per calendar. Before this fix the calendar wasn't taken into account, so it was not possible to define several calendars for the same organization with the same periods.

Fixes bug 29836: Avoid creating unnecessary backdated adjustments.

The problem was happening when costing precision was different from standard precision. When calculating the expected cost of a transaction to know if an adjustment is necessary to be created, it has to be rounded to standard precision because the amounts always have to be created in standard precision. In this case, while comparing expected cost with actual cost from database, as in database values are rounded to standard precision, and expected cost was being rounded to cost precission, an adjustment was being created with the difference, that corresponds just to the precision lost, and finally an adjustment of Zero amount was being created.

Fixed bug 29780 The done button appears disabled when it should not

null parameter when it should be the view in recalcDisplayLogicOrReadOnlyLogic
call in updateDifference function

Merge temporary head for 3.0PR15Q1.4

Added signature for changeset ac3537eef819

Added tag 3.0PR15Q1.4 for changeset d5ec99ff8e8e