Mon, 25 May 2015 15:44:05 +0000CI: update AD_MODULE to version 26737
RM packaging bot <staff.rm@openbravo.com> [Mon, 25 May 2015 15:44:05 +0000] rev 26765
CI: update AD_MODULE to version 26737

Mon, 25 May 2015 16:18:51 +0200Fixed issue 29709: Physical inventory cannot be created.
Naroa Iriarte <naroa.iriarte@openbravo.com> [Mon, 25 May 2015 16:18:51 +0200] rev 26764
Fixed issue 29709: Physical inventory cannot be created.

The problem was that if it was a very small negative Book Quantity number, it was not
possible to create a Physical Inventory line.

It was because the "ScientificToDecimal" function was not working properly with negative
numbers. The '-' sign was taken as a number instead of as a sign, that was the reason of
obtaining a value like 0.000-3655 when -0.0003655 was expected.

To fix this, a condition has been added which takes into account the fact of having
the '-' sign and to deal with the sign as a sign and not as a number.

Mon, 25 May 2015 12:31:46 +0200Fixes issue 29566: Upgrade Jasper Libraries
Carlos Aristu <carlos.aristu@openbravo.com> [Mon, 25 May 2015 12:31:46 +0200] rev 26763
Fixes issue 29566: Upgrade Jasper Libraries

Fri, 22 May 2015 11:19:25 +0200[jasper-library-upgrade] use constant
Asier Lostalé <asier.lostale@openbravo.com> [Fri, 22 May 2015 11:19:25 +0200] rev 26762
[jasper-library-upgrade] use constant

Thu, 21 May 2015 19:06:52 +0200[jasper-library-upgrade] Added missing 'Iterator' change
Carlos Aristu <carlos.aristu@openbravo.com> [Thu, 21 May 2015 19:06:52 +0200] rev 26761
[jasper-library-upgrade] Added missing 'Iterator' change

Thu, 21 May 2015 12:38:47 +0200Change 'Iterator' to 'for' loop in PrintController.java
Carlos Aristu <carlos.aristu@openbravo.com> [Thu, 21 May 2015 12:38:47 +0200] rev 26760
Change 'Iterator' to 'for' loop in PrintController.java

Thu, 21 May 2015 11:15:48 +0200[jasper-library-upgrade] String parameter retrieval for xls configuration also
Carlos Aristu <carlos.aristu@openbravo.com> [Thu, 21 May 2015 11:15:48 +0200] rev 26759
[jasper-library-upgrade] String parameter retrieval for xls configuration also

Thu, 21 May 2015 11:12:40 +0200[jasper-library-upgrade] Added missing AD_MESSAGE
Carlos Aristu <carlos.aristu@openbravo.com> [Thu, 21 May 2015 11:12:40 +0200] rev 26758
[jasper-library-upgrade] Added missing AD_MESSAGE

Thu, 21 May 2015 11:11:36 +0200[jasper-library-upgrade] Added cast to retrieve parameters correctly
Carlos Aristu <carlos.aristu@openbravo.com> [Thu, 21 May 2015 11:11:36 +0200] rev 26757
[jasper-library-upgrade] Added cast to retrieve parameters correctly

Thu, 21 May 2015 10:04:24 +0200[jasper-library-upgrade] Improvements in temporal file deletion
Carlos Aristu <carlos.aristu@openbravo.com> [Thu, 21 May 2015 10:04:24 +0200] rev 26756
[jasper-library-upgrade] Improvements in temporal file deletion

Wed, 20 May 2015 19:06:43 +0200[jasper-library-upgrade] Code review improvements
Carlos Aristu <carlos.aristu@openbravo.com> [Wed, 20 May 2015 19:06:43 +0200] rev 26755
[jasper-library-upgrade] Code review improvements

Wed, 20 May 2015 10:26:36 +0200[jasper-library-upgrade] Added jackson-annotations library
Carlos Aristu <carlos.aristu@openbravo.com> [Wed, 20 May 2015 10:26:36 +0200] rev 26754
[jasper-library-upgrade] Added jackson-annotations library

Wed, 20 May 2015 09:24:44 +0200[jasper-library-upgrade] Merge with pi
Carlos Aristu <carlos.aristu@openbravo.com> [Wed, 20 May 2015 09:24:44 +0200] rev 26753
[jasper-library-upgrade] Merge with pi

Tue, 19 May 2015 12:36:46 +0200[jasper-library-upgrade] Added required license texts
Carlos Aristu <carlos.aristu@openbravo.com> [Tue, 19 May 2015 12:36:46 +0200] rev 26752
[jasper-library-upgrade] Added required license texts

Tue, 19 May 2015 10:50:45 +0200[jasper-library-upgrade] Updated the copyright year of some classes.
Naroa Iriarte <naroa.iriarte@openbravo.com> [Tue, 19 May 2015 10:50:45 +0200] rev 26751
[jasper-library-upgrade] Updated the copyright year of some classes.

Tue, 19 May 2015 10:44:13 +0200[jasper-library-upgrade] Fixes deprecation warnings
Carlos Aristu <carlos.aristu@openbravo.com> [Tue, 19 May 2015 10:44:13 +0200] rev 26750
[jasper-library-upgrade] Fixes deprecation warnings

Fri, 15 May 2015 15:17:50 +0200Concat reports using Jasper library
Carlos Aristu <carlos.aristu@openbravo.com> [Fri, 15 May 2015 15:17:50 +0200] rev 26749
Concat reports using Jasper library

Thu, 14 May 2015 12:43:04 +0200Update payment report in PDF with changes related to issue 29847
Carlos Aristu <carlos.aristu@openbravo.com> [Thu, 14 May 2015 12:43:04 +0200] rev 26748
Update payment report in PDF with changes related to issue 29847

Wed, 13 May 2015 13:57:50 +0200Delete temporal files after attaching or sending standard by email
Carlos Aristu <carlos.aristu@openbravo.com> [Wed, 13 May 2015 13:57:50 +0200] rev 26747
Delete temporal files after attaching or sending standard by email

Wed, 13 May 2015 09:05:35 +0200Improved getTranslatedJasperReport method javadoc description
Carlos Aristu <carlos.aristu@openbravo.com> [Wed, 13 May 2015 09:05:35 +0200] rev 26746
Improved getTranslatedJasperReport method javadoc description

Tue, 12 May 2015 09:23:41 +0200Update Licensing.txt with the new .jar libraries
Carlos Aristu <carlos.aristu@openbravo.com> [Tue, 12 May 2015 09:23:41 +0200] rev 26745
Update Licensing.txt with the new .jar libraries

Tue, 12 May 2015 09:07:08 +0200Deprecate GridReportVO and ReportDesignBO classes
Carlos Aristu <carlos.aristu@openbravo.com> [Tue, 12 May 2015 09:07:08 +0200] rev 26744
Deprecate GridReportVO and ReportDesignBO classes

Mon, 11 May 2015 19:39:15 +0200Add getTranslatedJasperReport method into the ReportingUtils class
Carlos Aristu <carlos.aristu@openbravo.com> [Mon, 11 May 2015 19:39:15 +0200] rev 26743
Add getTranslatedJasperReport method into the ReportingUtils class

Mon, 11 May 2015 13:33:21 +0200Handle error when the browser is closed before getting the whole HTML report
Carlos Aristu <carlos.aristu@openbravo.com> [Mon, 11 May 2015 13:33:21 +0200] rev 26742
Handle error when the browser is closed before getting the whole HTML report

Fri, 08 May 2015 11:17:47 +0200Upgrade JRXML files according to the new JasperReports library
Carlos Aristu <carlos.aristu@openbravo.com> [Fri, 08 May 2015 11:17:47 +0200] rev 26741
Upgrade JRXML files according to the new JasperReports library

Fri, 08 May 2015 11:10:02 +0200Upgrade JasperReports library to version 6.0.0
Carlos Aristu <carlos.aristu@openbravo.com> [Fri, 08 May 2015 11:10:02 +0200] rev 26740
Upgrade JasperReports library to version 6.0.0

Thu, 07 May 2015 11:52:50 +0200Fix to make virtualizer work properly
Carlos Aristu <carlos.aristu@openbravo.com> [Thu, 07 May 2015 11:52:50 +0200] rev 26739
Fix to make virtualizer work properly

Wed, 06 May 2015 18:24:45 +0200Centralize reporting API in ReportingUtils class
Carlos Aristu <carlos.aristu@openbravo.com> [Wed, 06 May 2015 18:24:45 +0200] rev 26738
Centralize reporting API in ReportingUtils class

Tue, 19 May 2015 13:26:52 +0200Fixes bug 29913: Correct trx status assigned while deleting from reconciliation
Unai Martirena <unai.martirena@openbravo.com> [Tue, 19 May 2015 13:26:52 +0200] rev 26737
Fixes bug 29913: Correct trx status assigned while deleting from reconciliation

while checking or unchecking lines in Reconcile popup 'updateTransactionStatus' method is called to assign the proper status to the transaction. While unchecking 'Withdrawn not Cleared' or 'Deposited not Cleared' statuses has to be assigned to the transactions. This part is was wrong. When the transaction was of BP Deposit 'Withdrawn not Cleared' was being assigned and when the transaction was BP Withdrawal 'Deposited not Cleared' was being assigned.

Sun, 24 May 2015 12:10:22 +0200Related to issue 29766: Retail Operations Buffer: store all transactions in operations table before processing
Martin Taal <martin.taal@openbravo.com> [Sun, 24 May 2015 12:10:22 +0200] rev 26736
Related to issue 29766: Retail Operations Buffer: store all transactions in operations table before processing
Backout of changeset 6ee939d35840 because of failing dbcons

Fri, 22 May 2015 16:12:45 +0200Fixes issue 29903: Performance improvement in EntityAccessChecker.initialize
Martin Taal <martin.taal@openbravo.com> [Fri, 22 May 2015 16:12:45 +0200] rev 26735
Fixes issue 29903: Performance improvement in EntityAccessChecker.initialize

Fri, 22 May 2015 16:12:19 +0200Related to issue 29766: Retail Operations Buffer: store all transactions in operations table before processing
Martin Taal <martin.taal@openbravo.com> [Fri, 22 May 2015 16:12:19 +0200] rev 26734
Related to issue 29766: Retail Operations Buffer: store all transactions in operations table before processing
Increased size of error info

Thu, 21 May 2015 19:24:22 +0200Fixes issue 29956: Description not transferred from G/L Journal header to lines
Alvaro Ferraz <alvaro.ferraz@openbravo.com> [Thu, 21 May 2015 19:24:22 +0200] rev 26733
Fixes issue 29956: Description not transferred from G/L Journal header to lines

Default value was removed in Description column of GL_JournalLine table. Now, it is setted correctly.
Also, an auxiliary input has been added to have the same default value in Description field of Simple G/L Journal window - Lines tab.

Fri, 22 May 2015 12:53:04 +0000CI: merge back from main
RM packaging bot <staff.rm@openbravo.com> [Fri, 22 May 2015 12:53:04 +0000] rev 26732
CI: merge back from main

Fri, 22 May 2015 12:37:28 +0000CI: update AD_MODULE to version 26729
RM packaging bot <staff.rm@openbravo.com> [Fri, 22 May 2015 12:37:28 +0000] rev 26731
CI: update AD_MODULE to version 26729

Fri, 22 May 2015 11:18:49 +0200Fixed issue 29638: Google Calendar widget is not working properly.
Naroa Iriarte <naroa.iriarte@openbravo.com> [Fri, 22 May 2015 11:18:49 +0200] rev 26730
Fixed issue 29638: Google Calendar widget is not working properly.

In the workspace, adding a google calendar windget was not working properly. It
appeared blank.

It is necessary to set the field "email" of the user, in the user window, for being able
to show the asociated calendar in the widget. It is also necessary to be logged in the same
google account in the same browser for being able to display the calendar.

The problem was that it was not correctly displayed at first and it was necessary to refresh
the workspace for making the Google Calendar work properly.
This was because the email of the user was not correctly set.

The "evaluateContents" function has been overwritten in then "ob-url-widget.js" for granting
its correct behavior.

Thu, 21 May 2015 17:44:34 +0200fixed bug 29940: field changes to Id in editable P&E when adding new rows
Asier Lostalé <asier.lostale@openbravo.com> [Thu, 21 May 2015 17:44:34 +0200] rev 26729
fixed bug 29940: field changes to Id in editable P&E when adding new rows

In P&E with editable grid, if adding new records with default value for a drop
down reference, existing records with different values for that field were changed
from identifier to uuid.

The problem was in how value map was set in this case. Instead of setting it for
the edit form it was done at grid level.

It has been fixed by setting the value map only to the field in the edit form.

Thu, 21 May 2015 20:52:41 +0000CI: merge back from main
RM packaging bot <staff.rm@openbravo.com> [Thu, 21 May 2015 20:52:41 +0000] rev 26728
CI: merge back from main

Thu, 21 May 2015 20:34:41 +0000CI: update AD_MODULE to version 26726
RM packaging bot <staff.rm@openbravo.com> [Thu, 21 May 2015 20:34:41 +0000] rev 26727
CI: update AD_MODULE to version 26726

Thu, 21 May 2015 14:46:06 +0200Merge back from main
RM packaging bot <staff.rm@openbravo.com> [Thu, 21 May 2015 14:46:06 +0200] rev 26726
Merge back from main

Thu, 21 May 2015 12:28:04 +0000Merge temporary head for 3.0PR15Q2.1
RM packaging bot <staff.rm@openbravo.com> [Thu, 21 May 2015 12:28:04 +0000] rev 26725
Merge temporary head for 3.0PR15Q2.1

Tue, 19 May 2015 12:59:48 +0000Added signature for changeset fdb1e0cd936d
RM packaging bot <staff.rm@openbravo.com> [Tue, 19 May 2015 12:59:48 +0000] rev 26724
Added signature for changeset fdb1e0cd936d

Tue, 19 May 2015 12:59:48 +0000Added tag 3.0PR15Q2.1 for changeset e861122b0b1d
RM packaging bot <staff.rm@openbravo.com> [Tue, 19 May 2015 12:59:48 +0000] rev 26723
Added tag 3.0PR15Q2.1 for changeset e861122b0b1d

Tue, 19 May 2015 12:59:48 +0000Update AD_MODULE version to 3.0PR15Q2.1 3.0PR15Q2.1
RM packaging bot <staff.rm@openbravo.com> [Tue, 19 May 2015 12:59:48 +0000] rev 26722
Update AD_MODULE version to 3.0PR15Q2.1

Thu, 07 May 2015 12:11:39 +0200Fixed bug 29808: Impossible to create several calendars for the same organization
Víctor Martínez Romanos <victor.martinez@openbravo.com> [Thu, 07 May 2015 12:11:39 +0200] rev 26721
Fixed bug 29808: Impossible to create several calendars for the same organization

Two pieces of code were affected by this bug:
PeriodEventHandler.java: EntityPersistenceEventObserver in charge of checking overlap in manual inserts/updates (or any java process) in c_period table
C_YEARPERIODS: db function associated to the create periods process inside the Fiscal Calendar | Year tab. It also verifies the periods don't overlap other periods.

The fix consists in checking that there is no date overlap per calendar. Before this fix the calendar wasn't taken into account, so it was not possible to define several calendars for the same organization with the same periods.

Tue, 19 May 2015 14:23:05 +0200Related to issue 29808: Backout wrong changeset
Víctor Martínez Romanos <victor.martinez@openbravo.com> [Tue, 19 May 2015 14:23:05 +0200] rev 26720
Related to issue 29808: Backout wrong changeset
The changeset pushed was not the good one, and failed in Oracle

Mon, 18 May 2015 17:30:26 +0200Related to bug 29884: Code Review
Unai Martirena <unai.martirena@openbravo.com> [Mon, 18 May 2015 17:30:26 +0200] rev 26719
Related to bug 29884: Code Review

Add coalesce in case there is no batch associated to set GL Journal Org, in order to avoid issues in the if condition done right after the query if null values are compared

Thu, 14 May 2015 14:20:33 +0200Fixes issue 29884: Error while completing a Simple G/L Journal in Oracle
Alvaro Ferraz <alvaro.ferraz@openbravo.com> [Thu, 14 May 2015 14:20:33 +0200] rev 26718
Fixes issue 29884: Error while completing a Simple G/L Journal in Oracle

A query in gl_journal_post has been changed to avoid errors in Oracle when retrieving a null id

Thu, 14 May 2015 17:24:16 +0200Fixes issue 29889 & Fixes issue 29887: Error in Price Correction Background
Alvaro Ferraz <alvaro.ferraz@openbravo.com> [Thu, 14 May 2015 17:24:16 +0200] rev 26717
Fixes issue 29889 & Fixes issue 29887: Error in Price Correction Background

IsCostCalculated will not be considered to set CheckPriceDifference flag, when completing an invoice.
Instead, when running Price Correction Background, transactions will be filtered by IsCostCalculated to avoid calculate price differences in transactions where cost has not been calculated.

Fri, 15 May 2015 12:01:31 +0200Fixes issue 29899: False positives in GLJournalAccountingCheck validation
Eduardo Argal Guibert <eduardo.argal@openbravo.com> [Fri, 15 May 2015 12:01:31 +0200] rev 26716
Fixes issue 29899: False positives in GLJournalAccountingCheck validation
Missing ad_table_id constraint ends up in wrong validation when there are old records using numeric values for ids.

Thu, 14 May 2015 17:12:18 +0200Related to bu 29891: Adjust costing tests to the new behavior
Unai Martirena <unai.martirena@openbravo.com> [Thu, 14 May 2015 17:12:18 +0200] rev 26715
Related to bu 29891: Adjust costing tests to the new behavior

Thu, 14 May 2015 17:11:31 +0200Fixes bug 29891: Total Movement qty fixed in costing tab with backdated trx
Unai Martirena <unai.martirena@openbravo.com> [Thu, 14 May 2015 17:11:31 +0200] rev 26714
Fixes bug 29891: Total Movement qty fixed in costing tab with backdated trx

While working with cost adjustments, on certain cases the existing Costing records changes. This can happen because the cost has been recalculated due to backdated transactions, price adjustments, manual cost corrections, etc. In all this cases the 'Total Movement Quantity' field was not being correctly updated.
This field has to store the current stock of the product on that moment. So, each time the costing record is updated it is being checked if this value changes, and if it has changed the current stock is set.

Mon, 11 May 2015 10:53:02 +0200Fixes bug 29838: Prevents unlimited datasource requests when filtering the grid
Augusto Mauch <augusto.mauch@openbravo.com> [Mon, 11 May 2015 10:53:02 +0200] rev 26713
Fixes bug 29838: Prevents unlimited datasource requests when filtering the grid

The problem was that the logic to check that if a datasource request was triggered by scrolling up in a grid that did not have its initial rows loaded (see [1]) did not work well when the user filtered the grid after having scrolled down the grid till loading its second page. This caused the totalRows property of the grid to be miscalculated, and this triggered the undefinite amount of datasource requests.

The logic to check if the request was triggered by scrolling up has been changed. Now, instead of checking low-level smartclient properties like lastScrollTop, we check if there are rows loaded in the positions just after the page that was just received. Only in that case we want to prevent resetting the totalRows property of the ResultSet with the value returned by the datasource.

[1] https://code.openbravo.com/erp/devel/pi/rev/c51dce7e9fd3c47915464ab4f565a9d1cee60e3b

Fri, 08 May 2015 14:02:09 +0200Fixed bug 29827: Open/Close Period Control shows calendars associated to organizations
Víctor Martínez Romanos <victor.martinez@openbravo.com> [Fri, 08 May 2015 14:02:09 +0200] rev 26712
Fixed bug 29827: Open/Close Period Control shows calendars associated to organizations

The Open/Close Period Control window was showing all the periods available at the C_Period table.
The target of this window is to open/close periods in fiscal calendars, so it should only show periods belonging to a fiscal calendar linked to an organization set as ready.

The fix has 2 parts:
1. Added a hql where clause to include only periods belonging to a fiscal calendar linked to an organization set as ready.
2. The hql filter clause was wrong because it was filtering by the c_period.ad_org_id. Instead it should be filtering by the organization linked to the calendar's periods

Thu, 07 May 2015 12:11:39 +0200Fixed bug 29808: Impossible to create several calendars for the same organization
Víctor Martínez Romanos <victor.martinez@openbravo.com> [Thu, 07 May 2015 12:11:39 +0200] rev 26711
Fixed bug 29808: Impossible to create several calendars for the same organization

Two pieces of code were affected by this bug:
PeriodEventHandler.java: EntityPersistenceEventObserver in charge of checking overlap in manual inserts/updates (or any java process) in c_period table
C_YEARPERIODS: db function associated to the create periods process inside the Fiscal Calendar | Year tab. It also verifies the periods don't overlap other periods.

The fix consists in checking that there is no date overlap per calendar. Before this fix the calendar wasn't taken into account, so it was not possible to define several calendars for the same organization with the same periods.

Mon, 11 May 2015 10:15:38 +0200Fixes bug 29836: Avoid creating unnecessary backdated adjustments.
Unai Martirena <unai.martirena@openbravo.com> [Mon, 11 May 2015 10:15:38 +0200] rev 26710
Fixes bug 29836: Avoid creating unnecessary backdated adjustments.

The problem was happening when costing precision was different from standard precision. When calculating the expected cost of a transaction to know if an adjustment is necessary to be created, it has to be rounded to standard precision because the amounts always have to be created in standard precision. In this case, while comparing expected cost with actual cost from database, as in database values are rounded to standard precision, and expected cost was being rounded to cost precission, an adjustment was being created with the difference, that corresponds just to the precision lost, and finally an adjustment of Zero amount was being created.

Wed, 06 May 2015 11:09:24 +0200Fixed bug 29780 The done button appears disabled when it should not
Sandra Huguet <sandra.huguet@openbravo.com> [Wed, 06 May 2015 11:09:24 +0200] rev 26709
Fixed bug 29780 The done button appears disabled when it should not

null parameter when it should be the view in recalcDisplayLogicOrReadOnlyLogic
call in updateDifference function

Thu, 21 May 2015 09:19:25 +0000Merge temporary head for 3.0PR15Q1.4
RM packaging bot <staff.rm@openbravo.com> [Thu, 21 May 2015 09:19:25 +0000] rev 26708
Merge temporary head for 3.0PR15Q1.4

Tue, 19 May 2015 12:57:06 +0000Added signature for changeset ac3537eef819
RM packaging bot <staff.rm@openbravo.com> [Tue, 19 May 2015 12:57:06 +0000] rev 26707
Added signature for changeset ac3537eef819

Tue, 19 May 2015 12:57:05 +0000Added tag 3.0PR15Q1.4 for changeset d5ec99ff8e8e
RM packaging bot <staff.rm@openbravo.com> [Tue, 19 May 2015 12:57:05 +0000] rev 26706
Added tag 3.0PR15Q1.4 for changeset d5ec99ff8e8e