Thu, 11 Dec 2014 14:13:06 +0100Fixes bug 28387 BillofMaterialsAccounting should always be created in the same order
Alvaro Ferraz <alvaro.ferraz@openbravo.com> [Thu, 11 Dec 2014 14:13:06 +0100] rev 25547
Fixes bug 28387 BillofMaterialsAccounting should always be created in the same order

In order to help JUnit tests assert Bill of Materials Production accounting, an orderBy clause has been added when creating Bill of Materials Production Accounting lines, to be created always in the same order

Tue, 11 Nov 2014 18:08:41 -0500Fixed bug 27786: Add extension point for m_pricelist_create
Fernando Soto <fernando.soto@peoplewalking.com> [Tue, 11 Nov 2014 18:08:41 -0500] rev 25546
Fixed bug 27786: Add extension point for m_pricelist_create

Fri, 12 Dec 2014 14:44:04 +0100fixed bug 27670: time refrerence has no correct style when it is readonly
Asier Lostalé <asier.lostale@openbravo.com> [Fri, 12 Dec 2014 14:44:04 +0100] rev 25545
fixed bug 27670: time refrerence has no correct style when it is readonly

The problem is caused by the incorrect management SC client does for styles in
this case. TimeItem contains an inner TextItem. In case the TimeItem defines a
textBoxStyle property, it is always applied to the inner TextItem without considering
if it is active.

Current fix overwrites SC default behavior so that is taken into account.

Wed, 10 Dec 2014 11:28:43 +0100related to 27670: revert previous changes to fix this issue
Asier Lostalé <asier.lostale@openbravo.com> [Wed, 10 Dec 2014 11:28:43 +0100] rev 25544
related to 27670: revert previous changes to fix this issue

Previous changesets only worked when the item was initially disabled, but in
case it was dinamically disabled (ie. readonly logic) this code was not
executed and the style was not properly applied.

Fri, 12 Dec 2014 12:56:00 +0100Fixed bug 27580 Wrong journal entries when you void a sales invoice with prepayment
Sandra Huguet <sandra.huguet@openbravo.com> [Fri, 12 Dec 2014 12:56:00 +0100] rev 25543
Fixed bug 27580 Wrong journal entries when you void a sales invoice with prepayment

New column "prepaymentamt" has been added in order not to lose information
about prepayments when the invoice is voided.

Thu, 11 Dec 2014 12:43:38 -0500Related to issue 27280: Changes required in module script in order to improve it
Reinaldo Guerra <reinaldo.guerra@peoplewalking.com> [Thu, 11 Dec 2014 12:43:38 -0500] rev 25542
Related to issue 27280: Changes required in module script in order to improve it

Some changes were made in Delete Duplicate Commission Detail module script in order to improve it. A short comment indicating the issue to solve, was added in the java class and the dummy sql method was replaced for the really used selecting logic.

Thu, 11 Dec 2014 13:05:07 +0100Fixed issue 28334: The default value on UOM is not taken.
Naroa Iriarte <naroa.iriarte@openbravo.com> [Thu, 11 Dec 2014 13:05:07 +0100] rev 25541
Fixed issue 28334: The default value on UOM is not taken.

When the user level is chosen as "organization". The default value set in the Unit of Measure is not
taken when the user creates a new product. Instead of the default value of UOM the first one appears.

For fixing this the "LoginUtils" java class has been changed. The readable organizations were not taken into
account and that was the reason why the default value of the Unit of Measure was not taken into account when
a new product was created by the user with user level as "organization".

Now the readable organizatios are taken thanks to the "Utility.getContext(conn, vars, "#AccesibleOrgTree", "LoginHandler")"
code.
"#AccesibleOrgTree" has been put instead of "#User_Org", which is an string with the readable organizations inside.

Now when a user with user level as "organization" creates a new product, the default value of the UOM is
taken.

Thu, 11 Dec 2014 16:08:13 +0530Fixed bug 27664: Accounting tab is missing in return material receipt window
Reinaldo Guerra <reinaldo.guerra@peoplewalking.com> [Thu, 11 Dec 2014 16:08:13 +0530] rev 25540
Fixed bug 27664: Accounting tab is missing in return material receipt window

A new accounting tab was added in return material receipt window with its corresponding fields.
Now it is possible to view the accounting information when a return material receipt record is posted.

Wed, 10 Dec 2014 17:48:00 -0500Fixed bug 27280: Commission payment details are duplicated in some cases.
Reinaldo Guerra <reinaldo.guerra@peoplewalking.com> [Wed, 10 Dec 2014 17:48:00 -0500] rev 25539
Fixed bug 27280: Commission payment details are duplicated in some cases.

Generate commision process was changed to exclude the same records when retrieving data to be inserted in the payment detail table. This information comes duplicated due to the payment is divided in two records as the invoice has fractionated payment terms.
Thus the stored procedure was changed only in those cases when the commission basis document is an invoice, and the information related with the payments and its products are joined in the same query, avoiding duplicated tuples.
Now there are not duplicated fields when processing commissions for invoices with fractionated payment terms. Also a module script was developed to correct inconsistent data. When executing an ant update database duplicated data in commission detail table will be deleted, also amounts and quantities will be updated in commission amount and commission payment tables with the correct information.

Wed, 10 Dec 2014 17:08:15 +0100Fixed bug 28372: Payment Date field description needs to be changed.
Sandra Huguet <sandra.huguet@openbravo.com> [Wed, 10 Dec 2014 17:08:15 +0100] rev 25538
Fixed bug 28372: Payment Date field description needs to be changed.

Wed, 10 Dec 2014 14:30:29 +0100Fixed issue 28047:An exception is shown in console.
Naroa Iriarte <naroa.iriarte@openbravo.com> [Wed, 10 Dec 2014 14:30:29 +0100] rev 25537
Fixed issue 28047:An exception is shown in console.

There was an exception that was ignored (this is a correct behaviour), but it was shown in the log.
This exception appeared when, in cube definition window a cube Report Dimension was created. Then the log showed
the exception, but the Cube Report Dimension was correctly created. So, the exception needed not to be shown.

For fixing this the "AdvancedQueryBuilder" java class has been modified.
The exception was thrown before because the method <getPropertyByColumnName(String ColumName)> was called
and this method always checks the "isNotNull". When the variable was null, the message and the exception was catched
and shown.
For avoiding this, the method <getPropertyByColumnName(param, checkIsNoNull)> has been called instead the other one.
This method, has an input parameter called "checkIsNotNull", putting this to false, avoids the evaluation of the function
"isNotNull", so, if the variable is null it doesn't matter and the message and the exception shown before does not appear now.
The problem is that we get a "nullPointerException" if we do nothing else more.
For avoiding this, a condition has been added to the code in the "AdvancedQueryBuilder" java class. If the prop variable is
null, the paramValue variable gets the empty string value. And as the value for paramValue variable cannot be reached from
the request, it is get from the context.

Wed, 10 Dec 2014 14:09:54 +0100Fixes Issue 28157: Landed Cost takes into account exchange rate at invoice level
Unai Martirena <unai.martirena@openbravo.com> [Wed, 10 Dec 2014 14:09:54 +0100] rev 25536
Fixes Issue 28157: Landed Cost takes into account exchange rate at invoice level

If an exchange rate different from the System is added in Purchase Invoice and this Invoice is matched in a Landed Cost, a new record will be created in 'Matched Amount' tab under 'Landed Cost Cost' tab of 'Landed Cost' window. This new record will have the new flag of 'Is Conversion Matching' as true, and the amount will be the difference obtained from using the Invoice exchange rate compared to the one of the System.
This will create a new Cost Adjustment of source 'Landed Cost' with the same amount.

Wed, 10 Dec 2014 13:20:48 +0100Fixed issue 26386: Process buttons are not shown in the tree grid view.
Inigo Sanchez <inigo.sanchez@openbravo.com> [Wed, 10 Dec 2014 13:20:48 +0100] rev 25535
Fixed issue 26386: Process buttons are not shown in the tree grid view.

Process buttons are not shown in the tree grid view if no records are selected in
the standard grid view.

It has been solved by controlling the current view: tree grid view or grid view.
Now, Process buttons are shown in the tree grid view if no records are selected in
the standard grid view.

Tue, 09 Dec 2014 18:59:11 +0100Fixed bug 28362 c_invoice_post creates unnecesary contentions
Sandra Huguet <sandra.huguet@openbravo.com> [Tue, 09 Dec 2014 18:59:11 +0100] rev 25534
Fixed bug 28362 c_invoice_post creates unnecesary contentions

Avoiding the join with m_pricelist and c_doctype contentions are solved

Tue, 09 Dec 2014 18:55:38 +0100Fixed bug 28360 c_order_post creates unnecesary contentions
Sandra Huguet <sandra.huguet@openbravo.com> [Tue, 09 Dec 2014 18:55:38 +0100] rev 25533
Fixed bug 28360 c_order_post creates unnecesary contentions

Avoiding the join with m_pricelist the m_pricelist contention is solved

For update sentence is deleted in c_orderline selects because the
c_orderline is bloqued with the main select and is redundant and
causes unnecessary contentions.

Tue, 09 Dec 2014 11:16:40 +0100Related with issue 27542: Prevents potential NPE
Augusto Mauch <augusto.mauch@openbravo.com> [Tue, 09 Dec 2014 11:16:40 +0100] rev 25532
Related with issue 27542: Prevents potential NPE

Tue, 09 Dec 2014 11:13:29 +0100Related issue 27542: Fixes some typos
Augusto Mauch <augusto.mauch@openbravo.com> [Tue, 09 Dec 2014 11:13:29 +0100] rev 25531
Related issue 27542: Fixes some typos

Fri, 05 Dec 2014 14:38:40 +0100Related issue 27542: Added a variable to persist the chosen database.
Inigo Sanchez <inigo.sanchez@openbravo.com> [Fri, 05 Dec 2014 14:38:40 +0100] rev 25530
Related issue 27542: Added a variable to persist the chosen database.

It has been added a variable "chosenDatabase" that contains the name
of chosen database. This avoid to use some parts of the code. It have
been removed.

Fri, 05 Dec 2014 14:25:29 +0100Related issue 27542: Added small refactor and close scanners.
Inigo Sanchez <inigo.sanchez@openbravo.com> [Fri, 05 Dec 2014 14:25:29 +0100] rev 25529
Related issue 27542: Added small refactor and close scanners.

It has been added a method to improve readibility. This method
prints a message with the same style. Besides,it have added
some close() function for close "scanners".

Fri, 05 Dec 2014 14:20:30 +0100Related issue 27542: Renamed some methods in ConfigureOption
Inigo Sanchez <inigo.sanchez@openbravo.com> [Fri, 05 Dec 2014 14:20:30 +0100] rev 25528
Related issue 27542: Renamed some methods in ConfigureOption

It have been renamed some methods to improve readibility.

Fri, 05 Dec 2014 11:55:54 +0100Related issue 27542: Added some comments to class variables.
Inigo Sanchez <inigo.sanchez@openbravo.com> [Fri, 05 Dec 2014 11:55:54 +0100] rev 25527
Related issue 27542: Added some comments to class variables.

Fri, 05 Dec 2014 11:36:38 +0100Related issue 27542: Added some constants to improve readibility.
Inigo Sanchez <inigo.sanchez@openbravo.com> [Fri, 05 Dec 2014 11:36:38 +0100] rev 25526
Related issue 27542: Added some constants to improve readibility.

It have been added some constants to improve readibility. Besides,
it have been removed some unnecesary comments.

Thu, 04 Dec 2014 10:11:17 +0100Related bug 27542: Added some options to ant task javac and dependence "init"
Inigo Sanchez <inigo.sanchez@openbravo.com> [Thu, 04 Dec 2014 10:11:17 +0100] rev 25525
Related bug 27542: Added some options to ant task javac and dependence "init"

It have been added options to ant task javac like fork, deprecation,encoding,
debug and debuglevel. Besides, it has been added dependence "init" to setup ant task.

Thu, 04 Dec 2014 10:20:33 +0100Related bug 27542: Improved behaviour when the configuration is not completed.
Inigo Sanchez <inigo.sanchez@openbravo.com> [Thu, 04 Dec 2014 10:20:33 +0100] rev 25524
Related bug 27542: Improved behaviour when the configuration is not completed.

Now, it is consider the posibility that there not exists Openbravo.properties
file at the begining. In this case, it has been used template file. FInally,
Openbravo.properties file is created at the end of the successfully
configuration but not at first.

Besides, It have been removed some unnecesary comments.

Tue, 02 Dec 2014 10:58:10 +0100Related bug 27542: Removed some options and rename a variable
Inigo Sanchez <inigo.sanchez@openbravo.com> [Tue, 02 Dec 2014 10:58:10 +0100] rev 25523
Related bug 27542: Removed some options and rename a variable

It has been removed some options because it has been considered non useful properties. Now, it is NOT possible configure the next properties in this application:
* Output script location
* Tomcat Manager URL
* Tomcat manager username
* Tomcat manager password
However, It is possible configure this properties in Openbravo.properties file.

Besides, it has been renamed a variable to improve readibility.

Sun, 30 Nov 2014 21:21:59 +0100Related bug 27542: Refactored collection type used to store options.
Inigo Sanchez <inigo.sanchez@openbravo.com> [Sun, 30 Nov 2014 21:21:59 +0100] rev 25522
Related bug 27542: Refactored collection type used to store options.

It has been changed the type of object that stores the options. Now, instead of
using a HashMap <Int, ConfigureOption>, an ArrayList <ConfigureOption> is used.

It has been modified everything related to this refactor:
*Access to ArrayList
*Editing an element of ArrayList
*Search for an item in an ArrayList
*...

Fri, 28 Nov 2014 19:24:21 +0100Related bug 27542: Added a small functional improvement and other style issue.
Inigo Sanchez <inigo.sanchez@openbravo.com> [Fri, 28 Nov 2014 19:24:21 +0100] rev 25521
Related bug 27542: Added a small functional improvement and other style issue.

Now, some files are copied at the end of program execution. Thus
if the user does not complete the setup process, these files are not copied.

Also, it has been created a method called printOptionWithStyle() that is used
to display the options with the same style.

Fri, 28 Nov 2014 18:34:37 +0100Related issue 27542: Added refactor code.
Inigo Sanchez <inigo.sanchez@openbravo.com> [Fri, 28 Nov 2014 18:34:37 +0100] rev 25520
Related issue 27542: Added refactor code.

There have been several changes to improve usability. This changes are:
* Refactor several variable names and methods names.
* Removed several unnecessary constants.

Besides, it has been updated README file.

Fri, 28 Nov 2014 17:38:27 +0100Related issue 27542: Added refactor to improve readability of the code.
Inigo Sanchez <inigo.sanchez@openbravo.com> [Fri, 28 Nov 2014 17:38:27 +0100] rev 25519
Related issue 27542: Added refactor to improve readability of the code.

For each "case" in the main "switch" has been created a method that implements
the functionality associated with the case.

It has also been created a general method that could replace the functionality
of two of the previous methods. This method is called changeAllOptionsDatabase().

Fri, 05 Dec 2014 08:51:10 +0100Fixes bug 28230 Null Pointer Exception is raised when trying to post a goods receipt
Alvaro Ferraz <alvaro.ferraz@openbravo.com> [Fri, 05 Dec 2014 08:51:10 +0100] rev 25518
Fixes bug 28230 Null Pointer Exception is raised when trying to post a goods receipt

When a goods receipt with a product of type Service, which has a cost of type Standard, is posted, the DocInOut class calls the getStandardCost method from CostingUtils class with the currency of the current organization. If the organization has no currency, the client's currency will be used. Otherwise, a null pointer exception will be raised.