Wed, 17 Feb 2016 09:52:43 +0100[ChangePassword] Applied code review.Fixed security problem.
Jonathan Bueno <jonathan.bueno@openbravo.com> [Wed, 17 Feb 2016 09:52:43 +0100] rev 28677
[ChangePassword] Applied code review.Fixed security problem.

Mon, 15 Feb 2016 13:16:35 +0100[ChangePassword] Added text interfaces from login.html
Jonathan Bueno <jonathan.bueno@openbravo.com> [Mon, 15 Feb 2016 13:16:35 +0100] rev 28676
[ChangePassword] Added text interfaces from login.html

Mon, 15 Feb 2016 12:28:37 +0100[ChangePassword] Merge with pi
Jonathan Bueno <jonathan.bueno@openbravo.com> [Mon, 15 Feb 2016 12:28:37 +0100] rev 28675
[ChangePassword] Merge with pi

Mon, 15 Feb 2016 12:11:46 +0100[ChangePassword] Code review applied.
Jonathan Bueno <jonathan.bueno@openbravo.com> [Mon, 15 Feb 2016 12:11:46 +0100] rev 28674
[ChangePassword] Code review applied.

Updated javadocs of methods.
Added check to avoid security problem when updating password.

Fri, 12 Feb 2016 13:44:48 +0100[ChangePassword] Updated year of license in some files. Updated referenced data with new name of the column
Jonathan Bueno <jonathan.bueno@openbravo.com> [Fri, 12 Feb 2016 13:44:48 +0100] rev 28673
[ChangePassword] Updated year of license in some files. Updated referenced data with new name of the column

Fri, 12 Feb 2016 11:41:37 +0100[ChangePassword] Code review applied.
Jonathan Bueno <jonathan.bueno@openbravo.com> [Fri, 12 Feb 2016 11:41:37 +0100] rev 28672
[ChangePassword] Code review applied.

Solved camel case in Days To Password Expiration column.
Labels in Login.html are now translatable.
Last Password Update column is now updated in case user didn't have a password and is set for the first time.
Messages are now set correctly from the beginning and are not overwritten.
Refactor code, now check for expiration date is made in the method, exception is thrown in the method also.
AuthenticationExpirationPasswordException now log a single line.

Tue, 09 Feb 2016 09:45:56 +0100[Change Password] Merge with pi
Alberto Santos <alberto.santos@openbravo.com> [Tue, 09 Feb 2016 09:45:56 +0100] rev 28671
[Change Password] Merge with pi

Mon, 08 Feb 2016 16:14:49 +0100Correct the column updated in AD_USER_EXPIRYPASS_TRG and the message name.
Alberto Santos <alberto.santos@openbravo.com> [Mon, 08 Feb 2016 16:14:49 +0100] rev 28670
Correct the column updated in AD_USER_EXPIRYPASS_TRG and the message name.

Tue, 02 Feb 2016 14:11:27 +0100[Change Password] Code review applied:
Alberto Santos <alberto.santos@openbravo.com> [Tue, 02 Feb 2016 14:11:27 +0100] rev 28669
[Change Password] Code review applied:
Rename property Lastupdatepassworddate to lastPasswordUpdate.
Be consistent in naming: change expiry to expiration.
Use 'userID' instead of username in getUpdatePasswordDate function.
Check sameOldPassword in the rigth place.

Thu, 28 Jan 2016 12:40:57 +0100[ChangePassword] Solved security problem, added check to change user password
Jonathan Bueno <jonathan.bueno@openbravo.com> [Thu, 28 Jan 2016 12:40:57 +0100] rev 28668
[ChangePassword] Solved security problem, added check to change user password

Thu, 28 Jan 2016 10:58:07 +0100[ChangePassword] Fixed code after code review.
Jonathan Bueno <jonathan.bueno@openbravo.com> [Thu, 28 Jan 2016 10:58:07 +0100] rev 28667
[ChangePassword] Fixed code after code review.

Username is not cleaned in case of invalid user/password.
Added check in LoginHandler to avoid security problem when changing password.
Deleted unused params in getUpdatePasswordDate method.
Login param changed to username in getUpdatePasswordDate method.
Deleted UserLock delay because has been already done (getUpdatePasswordDate and updatePassword methods).
Updated javadoc in getUpdatePasswordDate method.
Corrections in OBCriteria, using eq instead of like, using property of User PROPERTY_USERNAME.
Refactor in Dates in getUpdatePasswordDate method.
Deleted comments.
Now gets the pasword value from password field instead of user field (Both have the same content when updating the password).
Removed strange vars names like strUser and strPass.
setAdminMode and restorePreviousMode moved to updatePassword method.
Replaced vars.getLanguage() with language var where possible.
Updated javadoc in updatePassword method.
getUpdatePasswordDate method moved to DefaultAuthenticationManager and changed visibility to private.
updatePassword method moved to LoginHandler and changed visibility to private.
AuthenticationExpiryPasswordException is now a subclass of authentication exception.
Strings compared with === in js(Login.html).
Using single quotes '' for js strings.

Fri, 22 Jan 2016 12:22:19 +0100[ChangePassword] Merge with pi
Jonathan Bueno <jonathan.bueno@openbravo.com> [Fri, 22 Jan 2016 12:22:19 +0100] rev 28666
[ChangePassword] Merge with pi

Fri, 22 Jan 2016 12:16:40 +0100[ChangePassword] Fixed trigger to work with oracle
Jonathan Bueno <jonathan.bueno@openbravo.com> [Fri, 22 Jan 2016 12:16:40 +0100] rev 28665
[ChangePassword] Fixed trigger to work with oracle

Changed logic of trigger

Fri, 22 Jan 2016 10:19:07 +0100[ChangePassword] Merge with pi
Jonathan Bueno <jonathan.bueno@openbravo.com> [Fri, 22 Jan 2016 10:19:07 +0100] rev 28664
[ChangePassword] Merge with pi

Fri, 22 Jan 2016 09:15:57 +0100[ChangePassword] Fixed trigger to work with oracle
Jonathan Bueno <jonathan.bueno@openbravo.com> [Fri, 22 Jan 2016 09:15:57 +0100] rev 28663
[ChangePassword] Fixed trigger to work with oracle

Deleted return new;

Thu, 21 Jan 2016 10:56:25 +0100[ChangePassword] Merge with pi
Jonathan Bueno <jonathan.bueno@openbravo.com> [Thu, 21 Jan 2016 10:56:25 +0100] rev 28662
[ChangePassword] Merge with pi

Thu, 21 Jan 2016 10:17:24 +0100[ChangePassword] Fixed trigger to work with oracle
Jonathan Bueno <jonathan.bueno@openbravo.com> [Thu, 21 Jan 2016 10:17:24 +0100] rev 28661
[ChangePassword] Fixed trigger to work with oracle

Wed, 20 Jan 2016 13:38:41 +0100[ChangePassword] Solved null value in users fields, added columns from last merge
Jonathan Bueno <jonathan.bueno@openbravo.com> [Wed, 20 Jan 2016 13:38:41 +0100] rev 28660
[ChangePassword] Solved null value in users fields, added columns from last merge

Wed, 20 Jan 2016 12:36:52 +0100[ChangePassword] Merge with pi
Jonathan Bueno <jonathan.bueno@openbravo.com> [Wed, 20 Jan 2016 12:36:52 +0100] rev 28659
[ChangePassword] Merge with pi

Tue, 19 Jan 2016 10:38:46 +0100[ChangePassword] Fixed issue on WebServices
Guillermo Gil <guillermo.gil@openbravo.com> [Tue, 19 Jan 2016 10:38:46 +0100] rev 28658
[ChangePassword] Fixed issue on WebServices

There is no session if you are not logged in Openbravo.
Use SeguridadData instead of OBCriteria.

Thu, 31 Dec 2015 13:18:09 +0100[ChangePassword] Merge with Pi
Jonathan Bueno <jonathan.bueno@openbravo.com> [Thu, 31 Dec 2015 13:18:09 +0100] rev 28657
[ChangePassword] Merge with Pi

Thu, 31 Dec 2015 13:11:16 +0100[ChangePassword] Fixed problem with triggers. Last update password date column mandatory to avoid NPE
Jonathan Bueno <jonathan.bueno@openbravo.com> [Thu, 31 Dec 2015 13:11:16 +0100] rev 28656
[ChangePassword] Fixed problem with triggers. Last update password date column mandatory to avoid NPE

Wed, 30 Dec 2015 10:48:35 +0100[ChangePassword] Modified message
Jonathan Bueno <jonathan.bueno@openbravo.com> [Wed, 30 Dec 2015 10:48:35 +0100] rev 28655
[ChangePassword] Modified message

Mon, 28 Dec 2015 16:19:59 +0100[ChangePassword] Fixed bug when valid days of password equal to zero.
Jonathan Bueno <jonathan.bueno@openbravo.com> [Mon, 28 Dec 2015 16:19:59 +0100] rev 28654
[ChangePassword] Fixed bug when valid days of password equal to zero.

Thu, 24 Dec 2015 11:56:20 +0100[ChangePassword] Renamed AD elements,added messages,renamed some variables, trigger updated
Jonathan Bueno <jonathan.bueno@openbravo.com> [Thu, 24 Dec 2015 11:56:20 +0100] rev 28653
[ChangePassword] Renamed AD elements,added messages,renamed some variables, trigger updated

Wed, 23 Dec 2015 10:55:13 +0100[ChangePassword] Merge with pi.
Jonathan Bueno <jonathan.bueno@openbravo.com> [Wed, 23 Dec 2015 10:55:13 +0100] rev 28652
[ChangePassword] Merge with pi.

Wed, 23 Dec 2015 10:52:18 +0100[ChangePassword] Fixed some minor issues. Messages added. Refactor of some files
Jonathan Bueno <jonathan.bueno@openbravo.com> [Wed, 23 Dec 2015 10:52:18 +0100] rev 28651
[ChangePassword] Fixed some minor issues. Messages added. Refactor of some files

Mon, 21 Dec 2015 16:26:08 +0100[ChangePassword] Merge with actual pi
Jonathan Bueno <jonathan.bueno@openbravo.com> [Mon, 21 Dec 2015 16:26:08 +0100] rev 28650
[ChangePassword] Merge with actual pi

Mon, 21 Dec 2015 16:15:13 +0100[ChangePassword] Updated fields, synchronize terminology to get elements
Jonathan Bueno <jonathan.bueno@openbravo.com> [Mon, 21 Dec 2015 16:15:13 +0100] rev 28649
[ChangePassword] Updated fields, synchronize terminology to get elements

Fri, 18 Dec 2015 10:15:24 +0100[ChangePassword] Updated date of licenses.
Jonathan Bueno <jonathan.bueno@openbravo.com> [Fri, 18 Dec 2015 10:15:24 +0100] rev 28648
[ChangePassword] Updated date of licenses.