Tue, 16 Jun 2015 12:59:25 +0200[cdi-junit] edding to eclipse project and classpath weld resources
Asier Lostalé <asier.lostale@openbravo.com> [Tue, 16 Jun 2015 12:59:25 +0200] rev 27092
[cdi-junit] edding to eclipse project and classpath weld resources

Tue, 16 Jun 2015 12:55:28 +0200[cdi-junit] updated arquillian 1.0.0 Alpha4 -> 1.1.8 Final
Asier Lostalé <asier.lostale@openbravo.com> [Tue, 16 Jun 2015 12:55:28 +0200] rev 27091
[cdi-junit] updated arquillian 1.0.0 Alpha4 -> 1.1.8 Final

Fri, 12 Jun 2015 12:13:50 +0200Fixes issue 29730: Avoid manual cost correction in Standard Cost transactions
Alvaro Ferraz <alvaro.ferraz@openbravo.com> [Fri, 12 Jun 2015 12:13:50 +0200] rev 27090
Fixes issue 29730: Avoid manual cost correction in Standard Cost transactions

Manual Cost Adjustment button will not appear in transactions with standard costing algorithm to avoid manual cost correction in this type of transactions.

Tue, 07 Jul 2015 10:45:53 +0200fixed issue 30308: use get to reload grid object on save/update
Asier Lostalé <asier.lostale@openbravo.com> [Tue, 07 Jul 2015 10:45:53 +0200] rev 27089
fixed issue 30308: use get to reload grid object on save/update

Backed out changesets: 2268a549839c2268a549839c & ec134f647522ec134f647522
because New OBDal.refresh(BaseOBObject, boolean) had some problems:

* Unlike OBDal.refresh(Object) method, it does not refresh current Object
instance but creates a new one which is returned
* Parameter object instance can be evicted from DAL's cache, so reusing it
after calling this method can result in a LazyInitializationException
* If parameter object is already in DAL's cache, refreshing with useCache=false
has no effect
* If parameter object is not yet initialized bob.getId() might result in a
LazyInitializationException

After those backouts code remains as it was originally doing the evict and get
within DefaultJsonDataService.update method.

Tue, 07 Jul 2015 09:30:33 +0200fixed bug 30324, related to bug 30249 (backed out)
Asier Lostalé <asier.lostale@openbravo.com> [Tue, 07 Jul 2015 09:30:33 +0200] rev 27088
fixed bug 30324, related to bug 30249 (backed out)

Backed out changest e45f0f903a952 because introduced regression #30324.

It only took into account case of process definitions executed as a popup but
not when they are executed as a full tab.

Thu, 02 Jul 2015 15:12:55 +0200Fixes issue 29729 & Fixes issue 29702 & Fixes issue 29728
Alvaro Ferraz <alvaro.ferraz@openbravo.com> [Thu, 02 Jul 2015 15:12:55 +0200] rev 27087
Fixes issue 29729 & Fixes issue 29702 & Fixes issue 29728

Cost Adjustments will not be created in transactions calculated with Standard Algorithm.

Fri, 03 Jul 2015 11:08:17 +0200Fixes issue 30232: Costing record not referencing transaction
Alvaro Ferraz <alvaro.ferraz@openbravo.com> [Fri, 03 Jul 2015 11:08:17 +0200] rev 27086
Fixes issue 30232: Costing record not referencing transaction

getRelatedTransactions method in AverageCostAdjustment.java was creating an HQL query with a wrong parenthesis. Because of that Order By clause did not appear in the query, what was causing wrong Costing entries.
Also, when this error happens, current costing will be updated with the new cost, instead of creating a new costing with a null transaction.

Mon, 06 Jul 2015 12:32:17 +0200Log4J warning message moved to debug in AcctSchemaElement.java
Víctor Martínez Romanos <victor.martinez@openbravo.com> [Mon, 06 Jul 2015 12:32:17 +0200] rev 27085
Log4J warning message moved to debug in AcctSchemaElement.java

Thu, 02 Jul 2015 22:07:27 +0530Fixes Issue 30273:"Not Balance" error received when posting a transaction
Atul Gaware <atul.gaware@openbravo.com> [Thu, 02 Jul 2015 22:07:27 +0530] rev 27084
Fixes Issue 30273:"Not Balance" error received when posting a transaction
(although suspense balancing is not needed)

Fix takes into account the payment's sign (payment in/out).

Mon, 06 Jul 2015 11:20:55 +0200fixed bug 30297: selectors with display field property fail
Asier Lostalé <asier.lostale@openbravo.com> [Mon, 06 Jul 2015 11:20:55 +0200] rev 27083
fixed bug 30297: selectors with display field property fail

They failed in case the display field property was not in the main property but
in a referenced one. In this case, the property was tried to be obtained from the
record object in an incorrect manner (path to the referred entity was removed).

The fix preserves path to referred entity and checks for not null value before
doing replacements in the string.

Fri, 03 Jul 2015 15:04:14 +0200Related to issue 30077: code review improvements
Víctor Martínez Romanos <victor.martinez@openbravo.com> [Fri, 03 Jul 2015 15:04:14 +0200] rev 27082
Related to issue 30077: code review improvements

Use credit popup when completing an invoice only shown when invoice's currency = business partner's currency.
Call getCustomerPaymentsWithCredit() without checking currency != null, because the method already checks it.
Improved warning message with a link to the wiki page.
Amounts are properly rounded.
Improvements in the created payment messages.
Change Business Partner currency: Forced to select a gl item if credit is detected in order to change the currency.

Fri, 03 Jul 2015 13:33:24 +0200Related to issue 30077: applied js beautifier
Víctor Martínez Romanos <victor.martinez@openbravo.com> [Fri, 03 Jul 2015 13:33:24 +0200] rev 27081
Related to issue 30077: applied js beautifier

Thu, 11 Jun 2015 12:43:23 +0200Fixes issue 30077: Wrong customer balance with multicurrency credits
Alvaro Ferraz <alvaro.ferraz@openbravo.com> [Thu, 11 Jun 2015 12:43:23 +0200] rev 27080
Fixes issue 30077: Wrong customer balance with multicurrency credits

Customer balance was not correctly updated when consuming credit generated in one currency in a payment with another currency.
Credit To Use grid in AddPayment will only show available credit in the currency of current payment.
Also, when changing the currency of a business partner with Set New Currency process, if exists available credit, the process will be able to convert automatically this credit into credit in the new curreny if a GLItem is selected, following this process: http://wiki.openbravo.com/wiki/How_to_convert_credit_to_a_different_currency

Mon, 06 Jul 2015 09:12:10 +0200Related with issue 29612: Merge with pi
Augusto Mauch <augusto.mauch@openbravo.com> [Mon, 06 Jul 2015 09:12:10 +0200] rev 27079
Related with issue 29612: Merge with pi

Tue, 23 Jun 2015 11:50:57 +0200Fixes issue 29612: FK filters with drop down disable behave like text filters
Augusto Mauch <augusto.mauch@openbravo.com> [Tue, 23 Jun 2015 11:50:57 +0200] rev 27078
Fixes issue 29612: FK filters with drop down disable behave like text filters

If the "Disable Foreign Key Combo" grid configuration is enabled, then the filters of foreign key fields will not include a dropdown. In this case the filter will look like a standard text filter, so it ha
s been decided that is should act like one. This mean the following grid properties should work:
- Text Field Filter Behaviour. Allows to specify the default operator, no change was needed
- Threashold to Trigger Filter on Text Field. Prevents executing several requests to the datasource in short time span. No change was needed
- Filter On Change: Allows to specify if a filter datasource request should be done when the user types, before the filter editor loses the focus.

The changes done in this changeset fix the third case. The actOnKeypress property is set to true if the FilterOnChange grid config is enabled, otherwise the filter was only done when the filter editor lost
the focus. For this to work properly, another change was needed: the symbol of the default operator should not be shown in the filter editor.

Mon, 18 May 2015 18:13:47 +0200Related with issue 29612: Adds display logic to Grid Configuration
Augusto Mauch <augusto.mauch@openbravo.com> [Mon, 18 May 2015 18:13:47 +0200] rev 27077
Related with issue 29612: Adds display logic to Grid Configuration

Adds display logic to the Field tab of the Grid Configuration:
- If the Allow Filter field is set to No, the following fields are hidden: Text Field Filter Behavior, Field On Change, Threshold to Trigger Filter on Text Field, Disable Foreign Key Combo, Allow Filtering FOreign Keys by its identifier and Unfiltered Foreign Key Combo
- If the Disable Foreign Key Combo field is set to Yes, the following fields are hidden: Allow Filtering FOreign Keys by its identifier and Unfiltered Foreign Key Combo

Mon, 18 May 2015 12:28:44 +0200Related with issue 29612: handle properly fk filter properties
Augusto Mauch <augusto.mauch@openbravo.com> [Mon, 18 May 2015 12:28:44 +0200] rev 27076
Related with issue 29612: handle properly fk filter properties
>
> If the disableFkDropdown grid configuration is enabled, then the allowFkFilterByIdentifier and showFkDropdownUnfiltered should not be taken into account. Otherwise the user could configure the grid in a way that the fintering of a column is enabled, but non functional

Mon, 18 May 2015 10:49:53 +0200Related with issue 29612: to_char needed in non-textual identifier properties
Augusto Mauch <augusto.mauch@openbravo.com> [Mon, 18 May 2015 10:49:53 +0200] rev 27075
Related with issue 29612: to_char needed in non-textual identifier properties

When filtering a foreign key whose identifier is a column that does not use a text/string reference, using the to_char function is still needed.

Mon, 18 May 2015 09:51:00 +0200Related with issue 29612: Update Copyright year
Augusto Mauch <augusto.mauch@openbravo.com> [Mon, 18 May 2015 09:51:00 +0200] rev 27074
Related with issue 29612: Update Copyright year

Tue, 12 May 2015 16:08:36 +0200Related with issue 29612: Updates name to use Combo instead of Dropdown
Augusto Mauch <augusto.mauch@openbravo.com> [Tue, 12 May 2015 16:08:36 +0200] rev 27073
Related with issue 29612: Updates name to use Combo instead of Dropdown

Tue, 12 May 2015 13:13:23 +0200Related with bug 29612: Applies properly the client/organizations filter
Augusto Mauch <augusto.mauch@openbravo.com> [Tue, 12 May 2015 13:13:23 +0200] rev 27072
Related with bug 29612: Applies properly the client/organizations filter

If the column being filtered referenced the Client or Organization entity, then the resulting query was not including the where clause to filter the readable clients and organizations, respectively. This is a known issue, reported here [1].

This issue cannot be easily fixed, so this project address it by adding manually the readable client or organization filter if the entity being filtered is client or organization and if the query is being built as a result of opening the dropdown of one of the new unfiltered foreign key filters.

[1] https://issues.openbravo.com/view.php?id=29846

Mon, 11 May 2015 13:45:43 +0200Fixes issue 29612: Adds grid configuration to disable fk filter dropdown
Augusto Mauch <augusto.mauch@openbravo.com> [Mon, 11 May 2015 13:45:43 +0200] rev 27071
Fixes issue 29612: Adds grid configuration to disable fk filter dropdown

Sometime the cost of populating a foreign key filter dropdown is much higher than filtering its column using its identifier, like a standard text column. This changeset adds a grid configuration to allow disabling the dropdown of foreign key filters.

If the configuration is activated the use will not be able to open the dropdown, not even using keyboard shortcuts. Saved views created before enabling this configuration will keep working after activating it.

Mon, 11 May 2015 13:18:57 +0200Fixes bug 29732: Get rid of coalesce(to_char()) when possible to improve query
Augusto Mauch <augusto.mauch@openbravo.com> [Mon, 11 May 2015 13:18:57 +0200] rev 27070
Fixes bug 29732: Get rid of coalesce(to_char()) when possible to improve query

We sometimes use the coalesce(to_char(value),'') functions to prevent passing null values in a where clause, replacing the null value with an empty string. The problem is that if those functions are used, then it will not be possible benefit from the indexes defined in the database.

In this issue we have made a distintion between mandatory and non-mandatory columns. Mandatory columns will no longer use the coalesce and to_char functions in the AdvancedQueryBuilder.createIdentifierLeftClause method. We can do that safely as it is not possible that those columns have null values.

Fri, 08 May 2015 12:39:56 +0200Related with bug 29612:New grid configuration to improve population of fk combo
Augusto Mauch <augusto.mauch@openbravo.com> [Fri, 08 May 2015 12:39:56 +0200] rev 27069
Related with bug 29612:New grid configuration to improve population of fk combo

The new grid configuration allows to change the way the foreign key filter drop downs are populated. Usually the rows shown in a fk filter drop down are only those that are being used in the referencing table. But that can be very slow if the referenced table has only a few records and the referenced tablas has a huge volume.

To address this problem, this new grid configuration allows to show all the records of the referenced table, even if they are not being used in the referencing table. When the queryService is being created to populate the filter drop down, the main entity is changed to the referenced table, and the criteria is updated. Also the where clause of the referencing table is now ignored.

Fri, 03 Jul 2015 19:41:40 +0200Related to issue 30308: fix in javadoc
Carlos Aristu <carlos.aristu@openbravo.com> [Fri, 03 Jul 2015 19:41:40 +0200] rev 27068
Related to issue 30308: fix in javadoc

Fri, 03 Jul 2015 19:31:11 +0200Related to issue 30308: created new refresh method in OBDal
Carlos Aristu <carlos.aristu@openbravo.com> [Fri, 03 Jul 2015 19:31:11 +0200] rev 27067
Related to issue 30308: created new refresh method in OBDal

Place the solution in a new method in OBDal, to allow the usage of this approach in similar cases

Wed, 24 Jun 2015 16:56:47 +0200Fixed issue 29978: Enable tree reference selectors in Pick & Exectute windows.
Naroa Iriarte <naroa.iriarte@openbravo.com> [Wed, 24 Jun 2015 16:56:47 +0200] rev 27066
Fixed issue 29978: Enable tree reference selectors in Pick & Exectute windows.

It was not possible to use tree reference selectors in the pick & execute windows.

To enable this the "ob-formitem-tree-filter.js" has been changed.
Before, there was a function which copied the functions from the view grid, the problem was that this
doesn't exist for the Pick and Execute windows.

Now, it takes into account the pick and execute windows, this has been done by a
condition which checks if "paramWindow" is true, which means that is a pick and execute window.

A new function has been developed too, for granting the correct behavior of this new functionality.
This function, copies some functions from the grid of the pick and execute windows.

Thu, 25 Jun 2015 17:04:28 +0200Fixed issue 30249: Error get when the Set New Currency process def. is executed
Naroa Iriarte <naroa.iriarte@openbravo.com> [Thu, 25 Jun 2015 17:04:28 +0200] rev 27065
Fixed issue 30249: Error get when the Set New Currency process def. is executed

The problem was that a error was got when clicking the "Done" button of the "Set New Currency"
process definition.

"Uncaught TypeError: Cannot read property '_handleSelect' of null"

The problem was in the "ob-parameter-window-view.js" in the handleResponse function.
It was executing "this.showProcessing(false)" even when the "retryExecution" parameter
was false.
Now the "this.showProcessing(false)" is executed only if the "retryExecution" parameter is true.

This affected to the process definition execution because as we were executing the "this.showProcessing(false)"
even when the retryExecution parameter was false, an ob-selector was deleted and after that, it was trying to
get the "._handleSelect" of that selector.

Fri, 03 Jul 2015 16:04:19 +0200Fixes issue 30308: Use get instead of refresh when saving or updating a record
Carlos Aristu <carlos.aristu@openbravo.com> [Fri, 03 Jul 2015 16:04:19 +0200] rev 27064
Fixes issue 30308: Use get instead of refresh when saving or updating a record

We use now OBDal.getInstance().get() instead of OBDal.getInstance().getSession().refresh(). To ensure that the get() methods retrieves the last changes in the object from database, we call evict() to remove the bob from the cache

Thu, 02 Jul 2015 10:54:26 +0200Related to issue 29731: Updated AD_TEXTINTERFACES
Víctor Martínez Romanos <victor.martinez@openbravo.com> [Thu, 02 Jul 2015 10:54:26 +0200] rev 27063
Related to issue 29731: Updated AD_TEXTINTERFACES