Wed, 08 Jan 2020 18:36:44 +0100Related to Issue 42515: Code Review changes
David Miguelez <david.miguelez@openbravo.com> [Wed, 08 Jan 2020 18:36:44 +0100] rev 36915
Related to Issue 42515: Code Review changes

* Added final modifiers to variables and parameters
* Combined logic of if clauses into one and extracted the condition
into a different method
* Use a query to retrieve the TransactionCosts instead of looping
throught the generated .getList method and then filter the results.

Tue, 07 Jan 2020 18:37:21 +0530Fixes BUG-42515:Wrong cost calculated for backdated goods movements
Atul Gaware <atul.gaware@openbravo.com> [Tue, 07 Jan 2020 18:37:21 +0530] rev 36914
Fixes BUG 42515:Wrong cost calculated for backdated goods movements

**Implement a method to get cost adjustment amount from related
Movement From Transaction to consider it into the outgoing
Movement To Transaction

Thu, 10 Oct 2019 10:22:45 -0300Fixes issue 41946: Filter only by characteristics that belong to the product
Mark Molina <mark.molina@doceleguas.com> [Thu, 10 Oct 2019 10:22:45 -0300] rev 36913
Fixes issue 41946: Filter only by characteristics that belong to the product

The filter in product with characteristics was showing characteristics that didn't
belong to the product. Was fixed the query to take into account just the characteristic
subset (if exists) of the product characteristic and not all the existing ones.

Thu, 05 Dec 2019 13:38:45 +0100fixed BUG-42475: JS compression supports template literals
Asier Lostalé <asier.lostale@openbravo.com> [Thu, 05 Dec 2019 13:38:45 +0100] rev 36912
fixed BUG 42475: JS compression supports template literals

Previously they were not supported as ` was not considered as string
delimiter.

Fixed by taking into account ` can be a string delimiter. Also in this
case new lines must be preserved.

Thu, 05 Dec 2019 13:08:08 +0100related to BUG-42475: removed warnings in JSMin
Asier Lostalé <asier.lostale@openbravo.com> [Thu, 05 Dec 2019 13:08:08 +0100] rev 36911
related to BUG 42475: removed warnings in JSMin

Thu, 05 Dec 2019 13:06:49 +0100related to BUG-42475: replaced jsmin.jar with its sources
Asier Lostalé <asier.lostale@openbravo.com> [Thu, 05 Dec 2019 13:06:49 +0100] rev 36910
related to BUG 42475: replaced jsmin.jar with its sources

Thu, 05 Dec 2019 13:05:29 +0100related to BUG-42475: added test cases
Asier Lostalé <asier.lostale@openbravo.com> [Thu, 05 Dec 2019 13:05:29 +0100] rev 36909
related to BUG 42475: added test cases

Thu, 05 Dec 2019 11:48:54 +0100related to BUG-42475: add existent JS compressor test case to CI
Asier Lostalé <asier.lostale@openbravo.com> [Thu, 05 Dec 2019 11:48:54 +0100] rev 36908
related to BUG 42475: add existent JS compressor test case to CI

Mon, 06 Jan 2020 09:53:15 +0000Merge back from main
RM packaging bot <staff.rm@openbravo.com> [Mon, 06 Jan 2020 09:53:15 +0000] rev 36907
Merge back from main

Mon, 06 Jan 2020 09:44:14 +0000Merge temporary head for 3.0PR19Q4.1
RM packaging bot <staff.rm@openbravo.com> [Mon, 06 Jan 2020 09:44:14 +0000] rev 36906
Merge temporary head for 3.0PR19Q4.1

Fri, 03 Jan 2020 10:46:16 +0000Added signature for changeset 30609cd42768
RM packaging bot <staff.rm@openbravo.com> [Fri, 03 Jan 2020 10:46:16 +0000] rev 36905
Added signature for changeset 30609cd42768

Fri, 03 Jan 2020 10:46:16 +0000Added tag 3.0PR19Q4.1 for changeset 78a343464034
RM packaging bot <staff.rm@openbravo.com> [Fri, 03 Jan 2020 10:46:16 +0000] rev 36904
Added tag 3.0PR19Q4.1 for changeset 78a343464034

Fri, 03 Jan 2020 10:46:15 +0000Update AD_MODULE version to 3.0PR19Q4.1 3.0PR19Q4.1
RM packaging bot <staff.rm@openbravo.com> [Fri, 03 Jan 2020 10:46:15 +0000] rev 36903
Update AD_MODULE version to 3.0PR19Q4.1

Thu, 02 Jan 2020 14:25:25 +0100Open fiscal period 2020 for 3.0PR19Q4.1
Guillermo Alvarez de Eulate <guillermo.alvarez@openbravo.com> [Thu, 02 Jan 2020 14:25:25 +0100] rev 36902
Open fiscal period 2020 for 3.0PR19Q4.1

Wed, 04 Dec 2019 16:04:05 +0100fixed BUG-42614: Discount Organization can add rows to incorrect header
Asier Lostalé <asier.lostale@openbravo.com> [Wed, 04 Dec 2019 16:04:05 +0100] rev 36901
fixed BUG 42614: Discount Organization can add rows to incorrect header

If parent Discount header is inactive, when adding rows to Organization tab,
they were added to the first active Discount instead of to the proper parent.

This was caused because M_Offer_Organization.AD_Org_ID column is used to store
the organization the discount is applicable for instead of just row's organization.

AD_Org columns have an special treatment, when they are changed, a
virtual callout is executed to refresh all combos. Mandatory combos
take the first available value in case their default is not available,
which is the case if it is inactive. As M_Offer_ID column had a
TableDir reference, it was treated as a combo, if its parent was
inactive, first active record was taken in place.

A proper solution would be not to use AD_Org_ID column to store the
actual value but to use instead a new column. This change would be
much more aggressive being an API change that would require of
updating existing data. That's why, the problem has been fixed by
replaciing TableDir reference with Search without selector, in this
way FK reltionship is preserved, but only the value is used in UI
instead of creating a combo.

Wed, 18 Dec 2019 13:15:18 +0100Fixed BUG-42577: Adding remove log archive policy to prevent indefinite growth.
Javier Armendáriz <javier.armendariz@openbravo.com> [Wed, 18 Dec 2019 13:15:18 +0100] rev 36900
Fixed BUG 42577: Adding remove log archive policy to prevent indefinite growth.

Using current log4j config, only files under the same period of time are limited
(i.e. when logfile is bigger than 100MB, there can be max 30 log archives for the
same day).

The new rule added applies to log archives with the format openbravo-*.log.gz and
will remove the oldest archive until there are max 30 files. This process will be
performed every time a log rollover occurs.

This commit also adds a build validation step that overrides the current config
with the updated one _only_ if its a exact copy of the previous default config.

Wed, 18 Dec 2019 10:30:37 +0530Fixes BUG-42573: Solves problem with lock in pricelist table
Atul Gaware <atul.gaware@openbravo.com> [Wed, 18 Dec 2019 10:30:37 +0530] rev 36899
Fixes BUG 42573: Solves problem with lock in pricelist table

* Remove join to pricelist table, that is not used, from the query
* Remove extra 'For Update' sentence, as the document and document tables
are alredy blocked by the first 'For Update' statement

Fri, 03 Jan 2020 12:04:27 +0100Related to BUG-42520: Update license year
Álvaro Ferraz <alvaro.ferraz@openbravo.com> [Fri, 03 Jan 2020 12:04:27 +0100] rev 36898
Related to BUG 42520: Update license year

Mon, 30 Dec 2019 08:43:55 +0530Fixes BUG-42520:Pareto Product Report shows wrong stock
Atul Gaware <atul.gaware@openbravo.com> [Mon, 30 Dec 2019 08:43:55 +0530] rev 36897
Fixes BUG 42520:Pareto Product Report shows wrong stock

** Stock quantity was added as many times the no of records
in m_transaction_cost related to m_transaction, to fix
issue m_transaction_cost is removed as main table in select
query, m_transaction is used as main table in the select
query, a subquery is used to calculate sum of the cost from
m_transaction_cost taking into consideration currency conv
if required, then this subquery is join with m_transaction
main table in the query. While re-arranging the queries,
maxaggDate parameter order is changed as required.

Thu, 02 Jan 2020 12:52:32 +0000Merge back from main
RM packaging bot <staff.rm@openbravo.com> [Thu, 02 Jan 2020 12:52:32 +0000] rev 36896
Merge back from main

Thu, 02 Jan 2020 12:51:18 +0000Merge temporary head for 3.0PR19Q3.3
RM packaging bot <staff.rm@openbravo.com> [Thu, 02 Jan 2020 12:51:18 +0000] rev 36895
Merge temporary head for 3.0PR19Q3.3

Thu, 02 Jan 2020 07:44:18 +0000Added signature for changeset 5353be431bba
RM packaging bot <staff.rm@openbravo.com> [Thu, 02 Jan 2020 07:44:18 +0000] rev 36894
Added signature for changeset 5353be431bba

Thu, 02 Jan 2020 07:44:18 +0000Added tag 3.0PR19Q3.3 for changeset 6add7201072c
RM packaging bot <staff.rm@openbravo.com> [Thu, 02 Jan 2020 07:44:18 +0000] rev 36893
Added tag 3.0PR19Q3.3 for changeset 6add7201072c

Thu, 02 Jan 2020 07:44:18 +0000Update AD_MODULE version to 3.0PR19Q3.3 3.0PR19Q3.3
RM packaging bot <staff.rm@openbravo.com> [Thu, 02 Jan 2020 07:44:18 +0000] rev 36892
Update AD_MODULE version to 3.0PR19Q3.3

Fri, 27 Dec 2019 13:52:48 +0100Open fiscal period 2020 for 3.0PR19Q3.3
Guillermo Alvarez de Eulate <guillermo.alvarez@openbravo.com> [Fri, 27 Dec 2019 13:52:48 +0100] rev 36891
Open fiscal period 2020 for 3.0PR19Q3.3

Wed, 04 Dec 2019 16:04:05 +0100fixed BUG-42615: Discount Organization can add rows to incorrect header
Asier Lostalé <asier.lostale@openbravo.com> [Wed, 04 Dec 2019 16:04:05 +0100] rev 36890
fixed BUG 42615: Discount Organization can add rows to incorrect header

If parent Discount header is inactive, when adding rows to Organization tab,
they were added to the first active Discount instead of to the proper parent.

This was caused because M_Offer_Organization.AD_Org_ID column is used to store
the organization the discount is applicable for instead of just row's organization.

AD_Org columns have an special treatment, when they are changed, a
virtual callout is executed to refresh all combos. Mandatory combos
take the first available value in case their default is not available,
which is the case if it is inactive. As M_Offer_ID column had a
TableDir reference, it was treated as a combo, if its parent was
inactive, first active record was taken in place.

A proper solution would be not to use AD_Org_ID column to store the
actual value but to use instead a new column. This change would be
much more aggressive being an API change that would require of
updating existing data. That's why, the problem has been fixed by
replaciing TableDir reference with Search without selector, in this
way FK reltionship is preserved, but only the value is used in UI
instead of creating a combo.

Wed, 18 Dec 2019 13:12:36 +0100Fixed BUG-42578: Adding remove log archive policy to prevent indefinite growth.
Javier Armendáriz <javier.armendariz@openbravo.com> [Wed, 18 Dec 2019 13:12:36 +0100] rev 36889
Fixed BUG 42578: Adding remove log archive policy to prevent indefinite growth.

Using current log4j config, only files under the same period of time are limited
(i.e. when logfile is bigger than 100MB, there can be max 30 log archives for the
same day).

The new rule added applies to log archives with the format openbravo-*.log.gz and
will remove the oldest archive until there are max 30 files. This process will be
performed every time a log rollover occurs.

This commit also adds a build validation step that overrides the current config
with the updated one _only_ if its a exact copy of the previous default config.

Wed, 18 Dec 2019 11:26:19 +0100Fixes BUG-42574:Solves problem with lock in pricelist table
Atul Gaware <atul.gaware@openbravo.com> [Wed, 18 Dec 2019 11:26:19 +0100] rev 36888
Fixes BUG 42574:Solves problem with lock in pricelist table

* Remove join to pricelist table, that is not used, from the query
* Remove extra 'For Update' sentence, as the document and document tables
are alredy blocked by the first 'For Update' statement

Wed, 18 Dec 2019 11:23:08 +0100Related to Issue 42574. Partial fix of Issue 40823 must be included in order
David Miguelez <david.miguelez@openbravo.com> [Wed, 18 Dec 2019 11:23:08 +0100] rev 36887
Related to Issue 42574. Partial fix of Issue 40823 must be included in order
to be compatible with the changes done to solve the proper issue.

The changes included are to avoid using functions that are deprecated.

Wed, 18 Sep 2019 14:48:34 +0530[Improve Translators Experience] Change visibility of exportTrl method
Atul Gaware <atul.gaware@openbravo.com> [Wed, 18 Sep 2019 14:48:34 +0530] rev 36886
[Improve Translators Experience] Change visibility of exportTrl method
and CONTRIBUTORS_FILENAME variable to public in TranslationManager
** Use variable for file name to be used for exporting translation for
Buile Structure File i.e buildStructureTrl. This way we can use the
filename for skipping few files when transforming xml files to po files