Mon, 14 Jan 2019 09:40:46 +0100Fixes Issue 39888. When canceling a cost adjustment:
David Miguelez <david.miguelez@openbravo.com> [Mon, 14 Jan 2019 09:40:46 +0100] rev 35316
Fixes Issue 39888. When canceling a cost adjustment:

* Keep the Negative Stock Correction and Backdated Transactions
flags with the same values as the original record
* When retrieving the lines of the Adjustment, retrieve also the lines
from Adjusments in Voided Status

Wed, 26 Dec 2018 17:28:40 +0100Related to Issue 39822. Code Review Changes:
David Miguelez <david.miguelez@openbravo.com> [Wed, 26 Dec 2018 17:28:40 +0100] rev 35315
Related to Issue 39822. Code Review Changes:

* Fixed typo in Message value
* Changed name of class variable from costAdjusted to adjustmentAmt (changed getter too)
* Added currency variable for parameters class
* If not specified, it uses the currency of the transaction
* If specified, it is used to create the line and to search
for existing adjustment lines

Mon, 17 Dec 2018 17:50:52 +0100Fixes Issue 39822. Fixes issues when merging new cost adjustment lines
David Miguelez <david.miguelez@openbravo.com> [Mon, 17 Dec 2018 17:50:52 +0100] rev 35314
Fixes Issue 39822. Fixes issues when merging new cost adjustment lines
with existing ones.

To avoid creating more Adjusment Lines than needed, the process
tries to find existing cost adjustment lines and it adds the cost
adjusted to an existing line if any.
But when looking for existing lines it was not taking into account
the unit cost, negative correction or backdated flags.

To do so, it is necessary to send the parameters to the methods
that creates the lines. But adding more parameters to this
functions was too complex, as they already had many parameters.

What has been done is to create a new class to store the line information.
This class is initialized with just three parameters and the
rest are set to the default values.

Then, the developer can change any parameter with the setter methods.
This makes the code more clear and clean, instead of having a
function with more than 10 parameters, being 4 of them booleans,
now it creates a new object with three parameters and then it
sets the boolean values with methods that have a name with more
meaning.

After this change, all the information of the line is set through this
new object, so there is no need to change the line object afterwards,
since all the different parameters are set to the LineParameter object.

Changes:

Database:
* Change default value of needsposting column to use the same
one as in AD and avoid confusion

CostAdjustmentLineParameters:
* New class to store lines information
* Does not allow to create adjustment lines with empty cost adjusment
or empty Transaction
* Does not create an adjustment that is both negative and unit cost.
This was not controlled before

CostAdjustmentUtils:
* Deprecated old methods that does not send the new flags
* Created new API to use the new LineParams object
* Modify query to take into account new flags
* Modify insert method to set all the parameters for the new
Cost Adjusment Line

CostingAlgorithmAdjustmentImp:
* Modify inser line method to use new API

Adapted all the calls to old methods to use new API

Mon, 14 Jan 2019 16:03:40 +0100fixes issue 39938: URL query string is no longer kept in session
Carlos Aristu <carlos.aristu@openbravo.com> [Mon, 14 Jan 2019 16:03:40 +0100] rev 35313
fixes issue 39938: URL query string is no longer kept in session

Fri, 11 Jan 2019 18:18:40 +0530Fixes Issue 39895: Simple G/L Journal line can be removed although
atul.gaware@openbravo.com <atul.gaware@openbravo.com> [Fri, 11 Jan 2019 18:18:40 +0530] rev 35312
Fixes Issue 39895: Simple G/L Journal line can be removed although
it has related payment. Payment can be deleted although the journal
is processed

** Before deleting gj journal line check is done for linked payment
if payment is linked error message is shown else line can be deleted.
** Before reactivating payment check is whether it is linked with gl
journal line having processed flag = yes in its header gl journal.

Mon, 14 Jan 2019 13:23:02 +0100related to issue 39885: make it work also when redirecting to Menu.html
Carlos Aristu <carlos.aristu@openbravo.com> [Mon, 14 Jan 2019 13:23:02 +0100] rev 35311
related to issue 39885: make it work also when redirecting to Menu.html

This flow happens when some kind of license restriction is detected during the login process

Mon, 14 Jan 2019 10:37:29 +0100fixes bug 39885: link to a document isn't followed properly after login
Carlos Aristu <carlos.aristu@openbravo.com> [Mon, 14 Jan 2019 10:37:29 +0100] rev 35310
fixes bug 39885: link to a document isn't followed properly after login

Before[1] the URL query string used to specify the link to a concrete document was being stored in session. After that changeset the code to save that value in session was no longer being executed, so it was not possible to recover the document link information.

To solve this problem now we keep the query string with the link information in the URL, and we retrieve it from there when needed.


[1] https://code.openbravo.com/erp/devel/pi/rev/6d6a3a710fd21bbc60de46c5778b212c64ec300c

Fri, 11 Jan 2019 09:54:50 +0100fixed bug 39919: session leaked after password reset from login window
Asier Lostalé <asier.lostale@openbravo.com> [Fri, 11 Jan 2019 09:54:50 +0100] rev 35309
fixed bug 39919: session leaked after password reset from login window

When password was detected to be expired in login process a new active session
was created, after resetting the password, this session was leaked and a new
one was created.

Now login process creates an inactive failed session when password is expired.

Thu, 10 Jan 2019 12:24:54 +0100Fixes invoice creation from shipment for POS orders
Eduardo Argal Guibert <eduardo.argal@openbravo.com> [Thu, 10 Jan 2019 12:24:54 +0100] rev 35308
Fixes invoice creation from shipment for POS orders

Thu, 10 Jan 2019 12:26:05 +0530Fixes Issue 39889:Cannot process a Simple G/L Journal with
Atul Gaware <atul.gaware@openbravo.com> [Thu, 10 Jan 2019 12:26:05 +0530] rev 35307
Fixes Issue 39889:Cannot process a Simple G/L Journal with
Open Items option selected on a line

Type of typed query was wrongly mentioned during hibernate
upgrade, org.openbravo.model.financialmgmt.accounting.coa.AcctSchema
required instead of org.openbravo.erpCommon.ad_forms.AcctSchema