Mon, 01 Jun 2015 13:08:42 +0200Fixes Issue 29992. Fixes HQL Where Clause in OBUISEL_Selector definition.
David Miguelez <david.miguelez@openbravo.com> [Mon, 01 Jun 2015 13:08:42 +0200] rev 26815
Fixes Issue 29992. Fixes HQL Where Clause in OBUISEL_Selector definition.
It now filters by Products that are Stocked based on the Product definition
rather than the Stocked flag in the Storage Detail.

Sun, 31 May 2015 15:43:59 +0200Fixed 30056: Cleanup all warnings in src-wad
Stefan Hühner <stefan.huehner@openbravo.com> [Sun, 31 May 2015 15:43:59 +0200] rev 26814
Fixed 30056: Cleanup all warnings in src-wad

XX
- Remove String or int parameter assignment by copying into local variable.
- in Wad#processSelCol use Vector.toArray function to avoid needing to
replace reference in parameter. Note: .toArray will auto-resize itself
to correct size as param is 0-length array
- Fix 2 possible NPE. As code to treat null as empty value was only
called after .debug triggering NPE as param of log4j.debug will be evaluated
even without log level set to debug.
- Wad#getVectorElementsNotRepeated function had parameter which was new empty
Vector in all its 3 callers. As we do not expect more callers (was is
deprecated) just remove the param completely and create new Vector inside
the function removing param assignment.
- in WadUtility instead of assigning to text-param and immediately returning
that value just return it directly as the rest of that function already did.
- in WadNumber. Confusion between non-static function param name + field
inherited from superclass. As those seem to be very clearly utility
functions which should use the param (and not some inherited field) ->
just make them static to remove that confusion.
- WadValidator gets 'friendlyWarnings' flag on construction but does not
currently use it. However we may want to add it (and keep api stable now)
so just supress that unused warning.

Sun, 31 May 2015 14:06:56 +0200Fixed 30055. Fix all warnings in src-trl
Stefan Hühner <stefan.huehner@openbravo.com> [Sun, 31 May 2015 14:06:56 +0200] rev 26813
Fixed 30055. Fix all warnings in src-trl

Two types of changes:
- Remove variables which are never read
- Do not assign to parameters, copy to local var instead
References of parameters cannot be modified in java
Content of objects passed in can be, however in all this
cases object are String which are immutable
Same fix always: Copy of local variable keeping name
of old param as new variable name to reduce diff to review.
- That avoid any developer confusing maybe thinking change
of param would be visible in caller.

Sun, 31 May 2015 13:33:21 +0200Fixed 30054: Cleanup warnings in wad-generated code
Stefan Hühner <stefan.huehner@openbravo.com> [Sun, 31 May 2015 13:33:21 +0200] rev 26812
Fixed 30054: Cleanup warnings in wad-generated code

Goal is not to make wad-generated code nicer (as it should go away).
But instead to reduce the big number of eclipse warnings in it.
So they get out of the way when looking at warning in other code

Changes:
- remove java.util.Arrays & java.util.List imports and covered by existing
java.util.* import
- The other 'unused' code warnings are not so easy to fix so in context of wad
supress all 'unused' warnings in the srcAD files on class level.
As secondary change remove to existing more specific unused annotation
as they triggered warnings themselves (and are covered by the new one anyway)
- Remove private log4j Logger declaration. It shadows a similar one coming
inherited from HttpBaseServer. That one is defined as non-static via
this.getClass so is already of the instance we want (the concrete window-
servlet). That means logger functionally works as before (you can still
set i.e. debug level logging for individual servlet as before).
- in printPageEdit function a parameter was being assigned to in the function
quite often. Apparently those cannot be surpressed. After checking easy to fix
- All caller use just simple constant on every call.
- So add local variable on top of function and copy param value.
- Keep existing param name as variable name to reduce diff of generated code.

Together those reduce number of warnings in srcAD from hundreds down to just 14.

Sat, 30 May 2015 20:59:23 +0200Issue 30053. Part 3: Delete local unused variables (easy cases)
Stefan Hühner <stefan.huehner@openbravo.com> [Sat, 30 May 2015 20:59:23 +0200] rev 26811
Issue 30053. Part 3: Delete local unused variables (easy cases)

This removes unused local variables / fields for all the easy cases.
Where there is no user besides the variables declaration/init and
where it is clear that just deleting it is the right thing to do (so
no doubt it should be used instead of deleting it)

Sat, 30 May 2015 20:29:02 +0200Issue 30053. Part 2: Cleanup unnecessary slf4j / log4j loggers
Stefan Hühner <stefan.huehner@openbravo.com> [Sat, 30 May 2015 20:29:02 +0200] rev 26810
Issue 30053. Part 2: Cleanup unnecessary slf4j / log4j loggers

Remove those where they are private and never used in the file.

Sat, 30 May 2015 20:07:50 +0200Issue 30053. Part 1: Cleanup unnecessary serialVersionUID variables.
Stefan Hühner <stefan.huehner@openbravo.com> [Sat, 30 May 2015 20:07:50 +0200] rev 26809
Issue 30053. Part 1: Cleanup unnecessary serialVersionUID variables.

Those definitions are not useful in this cases and the classes they are in
are not serializable.

So instead of special feature related to Serialization in this cases just a
local unused variable.

Sat, 30 May 2015 19:57:13 +0200Fixed 30052. Cleanup all 'Unnecessary cast' warnings from Eclipse.
Stefan Hühner <stefan.huehner@openbravo.com> [Sat, 30 May 2015 19:57:13 +0200] rev 26808
Fixed 30052. Cleanup all 'Unnecessary cast' warnings from Eclipse.

As those extra casts are not useful and make the code harder to read/understand
-> Remove all those

Fri, 29 May 2015 09:52:37 +0200Fixes issue 30017: Landed Cost must not be applied to negative receipt lines
Alvaro Ferraz <alvaro.ferraz@openbravo.com> [Fri, 29 May 2015 09:52:37 +0200] rev 26807
Fixes issue 30017: Landed Cost must not be applied to negative receipt lines

Goods Receipt selector in Landed Cost window - Receipt tab, will not show receipts which does not have any positive line.
Goods Receipt Line selector in Landed Cost window - Receipt tab, will not show negative receipts lines.
Landed Cost process will not consider negative receipt lines to distribute the amount of the landed cost.

Wed, 27 May 2015 16:27:00 +0200Fixed issue 29602: window with table defined as view should be RO
Inigo Sanchez <inigo.sanchez@openbravo.com> [Wed, 27 May 2015 16:27:00 +0200] rev 26806
Fixed issue 29602: window with table defined as view should be RO

The problem was that if you had a window that was assigned with a
table defined as view you could edited.

Now, it is taking into account this condition by checking windows
(Type window "M" and "T").