Mon, 01 Jun 2015 13:08:42 +0200Fixes Issue 29992. Fixes HQL Where Clause in OBUISEL_Selector definition.
David Miguelez <david.miguelez@openbravo.com> [Mon, 01 Jun 2015 13:08:42 +0200] rev 26815
Fixes Issue 29992. Fixes HQL Where Clause in OBUISEL_Selector definition.
It now filters by Products that are Stocked based on the Product definition
rather than the Stocked flag in the Storage Detail.

Sun, 31 May 2015 15:43:59 +0200Fixed 30056: Cleanup all warnings in src-wad
Stefan Hühner <stefan.huehner@openbravo.com> [Sun, 31 May 2015 15:43:59 +0200] rev 26814
Fixed 30056: Cleanup all warnings in src-wad

XX
- Remove String or int parameter assignment by copying into local variable.
- in Wad#processSelCol use Vector.toArray function to avoid needing to
replace reference in parameter. Note: .toArray will auto-resize itself
to correct size as param is 0-length array
- Fix 2 possible NPE. As code to treat null as empty value was only
called after .debug triggering NPE as param of log4j.debug will be evaluated
even without log level set to debug.
- Wad#getVectorElementsNotRepeated function had parameter which was new empty
Vector in all its 3 callers. As we do not expect more callers (was is
deprecated) just remove the param completely and create new Vector inside
the function removing param assignment.
- in WadUtility instead of assigning to text-param and immediately returning
that value just return it directly as the rest of that function already did.
- in WadNumber. Confusion between non-static function param name + field
inherited from superclass. As those seem to be very clearly utility
functions which should use the param (and not some inherited field) ->
just make them static to remove that confusion.
- WadValidator gets 'friendlyWarnings' flag on construction but does not
currently use it. However we may want to add it (and keep api stable now)
so just supress that unused warning.

Sun, 31 May 2015 14:06:56 +0200Fixed 30055. Fix all warnings in src-trl
Stefan Hühner <stefan.huehner@openbravo.com> [Sun, 31 May 2015 14:06:56 +0200] rev 26813
Fixed 30055. Fix all warnings in src-trl

Two types of changes:
- Remove variables which are never read
- Do not assign to parameters, copy to local var instead
References of parameters cannot be modified in java
Content of objects passed in can be, however in all this
cases object are String which are immutable
Same fix always: Copy of local variable keeping name
of old param as new variable name to reduce diff to review.
- That avoid any developer confusing maybe thinking change
of param would be visible in caller.

Sun, 31 May 2015 13:33:21 +0200Fixed 30054: Cleanup warnings in wad-generated code
Stefan Hühner <stefan.huehner@openbravo.com> [Sun, 31 May 2015 13:33:21 +0200] rev 26812
Fixed 30054: Cleanup warnings in wad-generated code

Goal is not to make wad-generated code nicer (as it should go away).
But instead to reduce the big number of eclipse warnings in it.
So they get out of the way when looking at warning in other code

Changes:
- remove java.util.Arrays & java.util.List imports and covered by existing
java.util.* import
- The other 'unused' code warnings are not so easy to fix so in context of wad
supress all 'unused' warnings in the srcAD files on class level.
As secondary change remove to existing more specific unused annotation
as they triggered warnings themselves (and are covered by the new one anyway)
- Remove private log4j Logger declaration. It shadows a similar one coming
inherited from HttpBaseServer. That one is defined as non-static via
this.getClass so is already of the instance we want (the concrete window-
servlet). That means logger functionally works as before (you can still
set i.e. debug level logging for individual servlet as before).
- in printPageEdit function a parameter was being assigned to in the function
quite often. Apparently those cannot be surpressed. After checking easy to fix
- All caller use just simple constant on every call.
- So add local variable on top of function and copy param value.
- Keep existing param name as variable name to reduce diff of generated code.

Together those reduce number of warnings in srcAD from hundreds down to just 14.

Sat, 30 May 2015 20:59:23 +0200Issue 30053. Part 3: Delete local unused variables (easy cases)
Stefan Hühner <stefan.huehner@openbravo.com> [Sat, 30 May 2015 20:59:23 +0200] rev 26811
Issue 30053. Part 3: Delete local unused variables (easy cases)

This removes unused local variables / fields for all the easy cases.
Where there is no user besides the variables declaration/init and
where it is clear that just deleting it is the right thing to do (so
no doubt it should be used instead of deleting it)

Sat, 30 May 2015 20:29:02 +0200Issue 30053. Part 2: Cleanup unnecessary slf4j / log4j loggers
Stefan Hühner <stefan.huehner@openbravo.com> [Sat, 30 May 2015 20:29:02 +0200] rev 26810
Issue 30053. Part 2: Cleanup unnecessary slf4j / log4j loggers

Remove those where they are private and never used in the file.

Sat, 30 May 2015 20:07:50 +0200Issue 30053. Part 1: Cleanup unnecessary serialVersionUID variables.
Stefan Hühner <stefan.huehner@openbravo.com> [Sat, 30 May 2015 20:07:50 +0200] rev 26809
Issue 30053. Part 1: Cleanup unnecessary serialVersionUID variables.

Those definitions are not useful in this cases and the classes they are in
are not serializable.

So instead of special feature related to Serialization in this cases just a
local unused variable.

Sat, 30 May 2015 19:57:13 +0200Fixed 30052. Cleanup all 'Unnecessary cast' warnings from Eclipse.
Stefan Hühner <stefan.huehner@openbravo.com> [Sat, 30 May 2015 19:57:13 +0200] rev 26808
Fixed 30052. Cleanup all 'Unnecessary cast' warnings from Eclipse.

As those extra casts are not useful and make the code harder to read/understand
-> Remove all those

Fri, 29 May 2015 09:52:37 +0200Fixes issue 30017: Landed Cost must not be applied to negative receipt lines
Alvaro Ferraz <alvaro.ferraz@openbravo.com> [Fri, 29 May 2015 09:52:37 +0200] rev 26807
Fixes issue 30017: Landed Cost must not be applied to negative receipt lines

Goods Receipt selector in Landed Cost window - Receipt tab, will not show receipts which does not have any positive line.
Goods Receipt Line selector in Landed Cost window - Receipt tab, will not show negative receipts lines.
Landed Cost process will not consider negative receipt lines to distribute the amount of the landed cost.

Wed, 27 May 2015 16:27:00 +0200Fixed issue 29602: window with table defined as view should be RO
Inigo Sanchez <inigo.sanchez@openbravo.com> [Wed, 27 May 2015 16:27:00 +0200] rev 26806
Fixed issue 29602: window with table defined as view should be RO

The problem was that if you had a window that was assigned with a
table defined as view you could edited.

Now, it is taking into account this condition by checking windows
(Type window "M" and "T").

Fri, 29 May 2015 13:58:50 +0200Related issue 29602: Changed UI pattern to read only mode in some tabs
Inigo Sanchez <inigo.sanchez@openbravo.com> [Fri, 29 May 2015 13:58:50 +0200] rev 26805
Related issue 29602: Changed UI pattern to read only mode in some tabs

The problem was that some tabs have their UI patterns wrong.They are
not set properly.

Now it have been solved by updating the UI Pattern to read only mode.

Sat, 30 May 2015 19:19:54 +0200Fixed 30050: cleanup javadoc warnings
Stefan Hühner <stefan.huehner@openbravo.com> [Sat, 30 May 2015 19:19:54 +0200] rev 26804
Fixed 30050: cleanup javadoc warnings
This commit clean up all javadoc warnings as shown by eclipse or
ant generate.java.doc
Exception are 3 warnings inside CSSMinimizer.java which is external code
and will should be fixed differently (upstream)

Most fixes are:
- Deleting useless java doc tags (useless as not documenting anything)
- Fixing up paramater references and link target

Fri, 29 May 2015 15:21:50 +0000CI: merge back from main
RM packaging bot <staff.rm@openbravo.com> [Fri, 29 May 2015 15:21:50 +0000] rev 26803
CI: merge back from main

Fri, 29 May 2015 15:06:33 +0000CI: update AD_MODULE to version 26798
RM packaging bot <staff.rm@openbravo.com> [Fri, 29 May 2015 15:06:33 +0000] rev 26802
CI: update AD_MODULE to version 26798

Tue, 12 May 2015 09:36:15 +0200Related to issue 25355: Executed Synchronize Terminology
Alvaro Ferraz <alvaro.ferraz@openbravo.com> [Tue, 12 May 2015 09:36:15 +0200] rev 26801
Related to issue 25355: Executed Synchronize Terminology

Thu, 26 Feb 2015 18:09:18 +0100Related to issue 25355: Fix Dimension fields display
Alvaro Ferraz <alvaro.ferraz@openbravo.com> [Thu, 26 Feb 2015 18:09:18 +0100] rev 26800
Related to issue 25355: Fix Dimension fields display

Dimension fields display in Payment In Lines and Payment Out Lines tabs will now work with Accounting Dimensions Central Maintenance.
Also, Order Payment Schedule and Invoice Payment Schedule fields navigation has been fixed.

Fri, 13 Feb 2015 10:20:41 -0500Fixed bug 25355: Long time to show the lines on the payment in/out windows
Fernando Soto <fernando.soto@peoplewalking.com> [Fri, 13 Feb 2015 10:20:41 -0500] rev 26799
Fixed bug 25355: Long time to show the lines on the payment in/out windows

Fri, 29 May 2015 11:17:43 +0200Related to issue 29867: grid checkboxes are now selected on refresh
David Baz Fayos <david.baz@openbravo.com> [Fri, 29 May 2015 11:17:43 +0200] rev 26798
Related to issue 29867: grid checkboxes are now selected on refresh
when multiple records were selected

Thu, 28 May 2015 21:17:31 +0000CI: merge back from main
RM packaging bot <staff.rm@openbravo.com> [Thu, 28 May 2015 21:17:31 +0000] rev 26797
CI: merge back from main

Thu, 28 May 2015 21:02:06 +0000CI: update AD_MODULE to version 26793
RM packaging bot <staff.rm@openbravo.com> [Thu, 28 May 2015 21:02:06 +0000] rev 26796
CI: update AD_MODULE to version 26793

Thu, 28 May 2015 19:51:06 +0200Fixed issue 29867: Now grid multiple selection is not lost on refresh
David Baz Fayos <david.baz@openbravo.com> [Thu, 28 May 2015 19:51:06 +0200] rev 26795
Fixed issue 29867: Now grid multiple selection is not lost on refresh

If the selected items are in different pages, only the items belonging to the land
page once the grid get refreshed will be shown. A message notifying this loss will
be shown (in the message bar if this is empty or as a popup if there is a message
already been displayed, to avoid loss its information if we come from a process
execution)

Thu, 28 May 2015 12:58:25 +0200Fixes issue 30007: Payment schedule amount incorrectly calculated.
Alvaro Ferraz <alvaro.ferraz@openbravo.com> [Thu, 28 May 2015 12:58:25 +0200] rev 26794
Fixes issue 30007: Payment schedule amount incorrectly calculated.

Payment schedule amount incorrectly calculated when adding a payment from reconcile window to a sales order.
FIN_TransactionProcess and PaidStatusEventHandler have been changed in order to set invoicepaid=true only when FIN_PaymentScheduleDetail has a related InvoicePaymentSchedule.
FIN_PaymentProcess.java has also been changed, in order to check invoicePaidAmounts only if FIN_PaymentScheduleDetail has a related InvoicePaymentSchedule.
In case of a payment to a order without an invoice, updatePaymentAmounts will be called only once.
Name of preference in UpdatePaymentPlan modulescript has been update to run it again and fix wrong data created by the issue.

Thu, 28 May 2015 16:19:09 +0200Fixed issue 29857: When there are not linked items it appears "Loading"
Naroa Iriarte <naroa.iriarte@openbravo.com> [Thu, 28 May 2015 16:19:09 +0200] rev 26793
Fixed issue 29857: When there are not linked items it appears "Loading"

When there are no linked items, the linked items category section shows the message "Loading data..."
instead of the message "No items to show".

The problem was that the fact of not having any item category was not correctly handled.
In the initWidget function, when the linkedItemCategoryListGrid is created, in the function "dataArrived"
there was a condition which called the function that showed the correct message "No items to show" when the
startRow was '0' and when de endRow was '-1', the problem was that in this case of not having any linked Item
category, the endRow and the startRow where both '0', so, the correct message was never shown and it always shows
the message "Loading data...".
To fix this, the condition has been changed, now it is taking into account the length of the data, and if it
is '0' that means that there are not linked items so, the message "No items to show" is shown.

Wed, 27 May 2015 23:08:18 +0000CI: merge back from main
RM packaging bot <staff.rm@openbravo.com> [Wed, 27 May 2015 23:08:18 +0000] rev 26792
CI: merge back from main

Wed, 27 May 2015 22:53:11 +0000CI: update AD_MODULE to version 26790
RM packaging bot <staff.rm@openbravo.com> [Wed, 27 May 2015 22:53:11 +0000] rev 26791
CI: update AD_MODULE to version 26790

Wed, 27 May 2015 17:14:52 +0200Related to issue 25278: updated copyright and fixed indentation
Víctor Martínez Romanos <victor.martinez@openbravo.com> [Wed, 27 May 2015 17:14:52 +0200] rev 26790
Related to issue 25278: updated copyright and fixed indentation

Wed, 20 May 2015 18:17:08 +0200Fixed issue 25278: Long time to update a warehouse with thousends of locators
Jorge Garcia <jorge.garcia@openbravo.com> [Wed, 20 May 2015 18:17:08 +0200] rev 26789
Fixed issue 25278: Long time to update a warehouse with thousends of locators

On an environment with 60.000 locators for one of the warehouse, when updating
a field of the warehouse it takes a long time to save the record.

Part of the problem is the update of the m_warehouse table. When updated, the
trigger launch an update of the organization id for M_LOCATOR and
M_WAREHOUSE_ACCT tables.

The solution is to check if the organization has changed and, if not, avoid the
unnecessary update of those tables.

Wed, 27 May 2015 16:31:12 +0200Related to issue 29566: fixes deprecated method calls in ReportDesignBO
Carlos Aristu <carlos.aristu@openbravo.com> [Wed, 27 May 2015 16:31:12 +0200] rev 26788
Related to issue 29566: fixes deprecated method calls in ReportDesignBO

Wed, 27 May 2015 09:41:59 +0200Fixed bug 29904 Performance improvements for orderloading in finance core
Sandra Huguet <sandra.huguet@openbravo.com> [Wed, 27 May 2015 09:41:59 +0200] rev 26787
Fixed bug 29904 Performance improvements for orderloading in finance core

review flush () and .list () in FIN_PaymentProcess and FIN_TransactionProcess

Wed, 27 May 2015 16:05:43 +0200Related with issue 29709: Some test cases have been created.
Naroa Iriarte <naroa.iriarte@openbravo.com> [Wed, 27 May 2015 16:05:43 +0200] rev 26786
Related with issue 29709: Some test cases have been created.

Some test have been created for testing the correct behaviour of the OB.Utilities.Number.roundJSNumber,
OB.Utilities.Number.ScientificToDecimal and OB.Utilities.Number.OBMaskedToOBPlain functions.