Fri, 22 Jan 2016 08:42:24 +0000Merge temporary head for 3.0PR15Q3.5
RM packaging bot <staff.rm@openbravo.com> [Fri, 22 Jan 2016 08:42:24 +0000] rev 28727
Merge temporary head for 3.0PR15Q3.5

Thu, 21 Jan 2016 09:06:30 +0000Added signature for changeset 6c3455925759
RM packaging bot <staff.rm@openbravo.com> [Thu, 21 Jan 2016 09:06:30 +0000] rev 28726
Added signature for changeset 6c3455925759

Thu, 21 Jan 2016 09:06:30 +0000Added tag 3.0PR15Q3.5 for changeset 0c91d0ae09c3
RM packaging bot <staff.rm@openbravo.com> [Thu, 21 Jan 2016 09:06:30 +0000] rev 28725
Added tag 3.0PR15Q3.5 for changeset 0c91d0ae09c3

Thu, 21 Jan 2016 09:06:30 +0000Update AD_MODULE version to 3.0PR15Q3.5 3.0PR15Q3.5
RM packaging bot <staff.rm@openbravo.com> [Thu, 21 Jan 2016 09:06:30 +0000] rev 28724
Update AD_MODULE version to 3.0PR15Q3.5

Tue, 19 Jan 2016 17:53:22 +0100fixes issue 31948: Labels linked to a concrete file are not translated
Carlos Aristu <carlos.aristu@openbravo.com> [Tue, 19 Jan 2016 17:53:22 +0100] rev 28723
fixes issue 31948: Labels linked to a concrete file are not translated

The translation engine requires the base design path to retrieve the ad_textinterfaces linked to a particular report. This path was not being sent properly in ReportinUtils class. Now the path is generated correctly making use of a new method called getBaseDesignPath.

Fri, 15 Jan 2016 10:01:40 +0100related to issue 31886: code review improvement
Carlos Aristu <carlos.aristu@openbravo.com> [Fri, 15 Jan 2016 10:01:40 +0100] rev 28722
related to issue 31886: code review improvement

Wed, 13 Jan 2016 21:13:18 +0530Fixes Issue 31898:Cannot save a G/L Journal header with the date of the
Atul Gaware <atul.gaware@openbravo.com> [Wed, 13 Jan 2016 21:13:18 +0530] rev 28721
Fixes Issue 31898:Cannot save a G/L Journal header with the date of the
adjustment period if both periods are opened

c_chk_open_period returns value more than 1 in case standard period and
adjustment period is open in which the date of GL journal is included.
<> 1 check is failed in this case so check is changed to < 1 to show
error message in case period id not available

Thu, 14 Jan 2016 11:01:49 +0100fixes issue 31886: can not move tree nodes in classic mode
Carlos Aristu <carlos.aristu@openbravo.com> [Thu, 14 Jan 2016 11:01:49 +0100] rev 28720
fixes issue 31886: can not move tree nodes in classic mode

When moving tree nodes using the classic mode there is a point where the process tries to recover the tree type. This information is stored in the ADTable entity which can not be accessed by non system roles. To prevent this error now the part where the tree type is recovered is executed using the DAL admin mode.

Thu, 24 Dec 2015 11:03:13 +0100Related to issue 31775: Avoid append a null description
Alvaro Ferraz <alvaro.ferraz@openbravo.com> [Thu, 24 Dec 2015 11:03:13 +0100] rev 28719
Related to issue 31775: Avoid append a null description

Wed, 23 Dec 2015 18:48:11 +0100Fixed bug 31775: code review improvements
Víctor Martínez Romanos <victor.martinez@openbravo.com> [Wed, 23 Dec 2015 18:48:11 +0100] rev 28718
Fixed bug 31775: code review improvements

In case of removing a gl item from a transaction, the part of the transaction's description related to the GL Item (and everything else afterwards) will be deleted. The part of the transaction's description before the GL Item description
will be always kept.
The same behavior is applied when adding a new transaction from the Financial Account window and from the Match Statement --> Add transaction process

In case of removing a payment, the behavior is similar to the GL Item described above. However, since the payment description doesn't follow a constant structure (like in the case of GL Item's description), it's very hard to detect the description on the fly. That means that the flow will only work just after saving the transaction or in the first change after loading the transaction, which are the common flows. If the user selects different payments without saving the record, the system will append the different payment's description to the transaction.

The getFinAccTransactionDescription() method:
1. won't append multiple times the same description.
2. will add an extra empty line only when it's something to be appended
3. will work fine when the transaction already has a description with multiple lines
4. control any possible exception and returns the text to be append (if not blank), or the original description

Applied jsbeautifier to ob-aprm-addTransaction.js

Wed, 23 Dec 2015 01:08:07 +0530Fixes Issue 31775:Bank Statement Line description overwritten with GL Item's
Atul Gaware <atul.gaware@openbravo.com> [Wed, 23 Dec 2015 01:08:07 +0530] rev 28717
Fixes Issue 31775:Bank Statement Line description overwritten with GL Item's
or payment's description when adding gl item or payment in add transaction
of Match Statement Process.

This issue is fixed in two area's
1. Add Transaction Process Definition window in Match Statement.
2. Transaction Tab of Financial Account window.

Whenever there exists a description prior adding gl item or payment in above
both cases description is appended with either gl item description or
payment description.

Tue, 01 Dec 2015 18:20:18 +0100Fixes issue 31739: UniqueValidCombination modulescript is deactivating accounts
Alvaro Ferraz <alvaro.ferraz@openbravo.com> [Tue, 01 Dec 2015 18:20:18 +0100] rev 28716
Fixes issue 31739: UniqueValidCombination modulescript is deactivating accounts

Add group by c_acctschema_id in selectDuplicates and updateValidCombinationDeactivateDuplicated queries in UniqueValidCombination modulescript.

Tue, 15 Dec 2015 14:54:22 +0100Fixed bug 31724: Return to vendor shipments can be selected in return to vendor
Víctor Martínez Romanos <victor.martinez@openbravo.com> [Tue, 15 Dec 2015 14:54:22 +0100] rev 28715
Fixed bug 31724: Return to vendor shipments can be selected in return to vendor

The HQL query in charge of getting the shipment lines was wrongly including all the shipment documents. Instead it should be taking only the lines belonging to a non-return shipment document.

This feature was lost during the refactor to a manual datasource P&E

Wed, 16 Dec 2015 10:12:11 +0100fixes issue 31722: a date used to filter on a grid dissapears after enter it
Carlos Aristu <carlos.aristu@openbravo.com> [Wed, 16 Dec 2015 10:12:11 +0100] rev 28714
fixes issue 31722: a date used to filter on a grid dissapears after enter it

After solving issue 29554 the values of the date filters are completely removed when invoking the clearValue() method. For this reason, in order to prevent the clearing of the date filter it is necessary to call setValue().

This was already controlled when choosing the dates from the date pickers, but not after entering the date with the tab or enter keys or when using the 'Use as Filter' menu option.

Now this cases are controlled also, by calling setValue() on the setSingleDateValue() method.

Mon, 14 Dec 2015 17:14:18 +0100fixes issue 31684: Some values are not shown in XLS format using MS Office
Carlos Aristu <carlos.aristu@openbravo.com> [Mon, 14 Dec 2015 17:14:18 +0100] rev 28713
fixes issue 31684: Some values are not shown in XLS format using MS Office

The detect cell type feature was not working properly for BigInteger values in Office after the Jasper Library Upgrade. A personalized format was applied causing the data not be shown when opening the report.

To solve this problem the detect cell type feature has been disabled. This way, by default, all the values in the XLS will be exported as strings.

This default configuration can be overriden at report level. As an example, the General Ledger Report and Trial Balance report have been updated properly. With this configuration, those reports are now using number formatting for the cells showing the BigDecimal values.

Tue, 15 Mar 2016 19:12:36 +0100fixes issue 32474: [object Object] appears after clearing value in selector
Carlos Aristu <carlos.aristu@openbravo.com> [Tue, 15 Mar 2016 19:12:36 +0100] rev 28712
fixes issue 32474: [object Object] appears after clearing value in selector

Having singleDateMode as false after clearing the filter content of the date causes the return of an empty object in the getValuesAsCriteria method of the grid. The this.singleDateMode was being set to true in clearFilterValues function, but this statement was deleted to solve issue 31705, because it was preventing to show the range dialog after clearing the filters, when pressing the Enter key.

To solve both problems the change regarding setting singleDateMode in clearFilterValues has been reverted, and in order to ensure that the range dialog is displayed when it should be, a new check has been included in the keyPress method.

Mon, 14 Mar 2016 10:42:09 +0100Fixes issue 32460:install.source can be invoked without executing modulescripts
Augusto Mauch <augusto.mauch@openbravo.com> [Mon, 14 Mar 2016 10:42:09 +0100] rev 28711
Fixes issue 32460:install.source can be invoked without executing modulescripts

A flag called execute.modulescripts has been added to allow invoking the install.source task without executing the modulescripts. Specifically the flag has been added to the impo
rt.sample.data task, which is invoked from the install.source task. The new parameter is set like this:

ant install.source -Dexecute.modulescripts=false

If the new parameter is not specified, the modulescripts will be executed by default.

Thu, 03 Mar 2016 18:33:33 +0530Fixes Issue 30639:Sample data (F&B International Group Client) for 3.0PR16Q2
Atul Gaware <atul.gaware@openbravo.com> [Thu, 03 Mar 2016 18:33:33 +0530] rev 28710
Fixes Issue 30639:Sample data (F&B International Group Client) for 3.0PR16Q2

Transactions created for Jan, Feb and Mar 2016 as per document "How to evolve
F&B"

Wed, 02 Mar 2016 18:35:15 +0530Related to Issue 30639:Sample data (F&B International Group Client) for
Atul Gaware <atul.gaware@openbravo.com> [Wed, 02 Mar 2016 18:35:15 +0530] rev 28709
Related to Issue 30639:Sample data (F&B International Group Client) for
3.0PR16Q2

Commited changed prior to inserting transactions

Thu, 10 Mar 2016 17:56:11 +0100Related to issue 32428: Code review improvements
Alvaro Ferraz <alvaro.ferraz@openbravo.com> [Thu, 10 Mar 2016 17:56:11 +0100] rev 28708
Related to issue 32428: Code review improvements

Use BigDecimal.ZERO instead of new BigDecimal(0).

Wed, 09 Mar 2016 18:53:24 -0500Fixes issue 32428: Wrong orders created by the Copy Record process
Mark <m.molina@nectus.com> [Wed, 09 Mar 2016 18:53:24 -0500] rev 28707
Fixes issue 32428: Wrong orders created by the Copy Record process

Fixed the wrong Tax Amount and Total Gross Amount calculation in orders created by the Copy Record process
if price list includes taxes. These amounts are calculated when related triggers are fired, due that when
the order is cloned from the original order was necessary to reset calculated amounts and then triggers updates
them again when lines are added to the cloned order.

Tue, 08 Mar 2016 10:56:37 +0100fixed issue 32152: Some colums were modified even with no modules in devel.
Naroa Iriarte <naroa.iriarte@openbravo.com> [Tue, 08 Mar 2016 10:56:37 +0100] rev 28706
fixed issue 32152: Some colums were modified even with no modules in devel.

The AllowSorting and AllowFiltering columns were modified even with no module in development.
That behavior is not correct and the AD_COLUMN_MOD_TRG.xml trigger has been modified to handle
this situation. Now if there is no module in development and the old value of these columns is
not the same as the new one (if it has been modified) an error is shown.

Tue, 08 Mar 2016 11:21:24 +0100Fixed issue 32331. Added method to check if importentry has status 'Error'
Antonio Moreno Perez <antonio.moreno@openbravo.com> [Tue, 08 Mar 2016 11:21:24 +0100] rev 28705
Fixed issue 32331. Added method to check if importentry has status 'Error'

Tue, 08 Mar 2016 09:36:55 +0100related to issue 32429: code review improvements
Carlos Aristu <carlos.aristu@openbravo.com> [Tue, 08 Mar 2016 09:36:55 +0100] rev 28704
related to issue 32429: code review improvements

Tue, 08 Mar 2016 08:54:17 +0100fixed issue 32432: incorrect dates issue detection on install.source
Asier Lostalé <asier.lostale@openbravo.com> [Tue, 08 Mar 2016 08:54:17 +0100] rev 28703
fixed issue 32432: incorrect dates issue detection on install.source

Do not execute PgJdbcDatesIssue module script on install.source.

Tue, 08 Mar 2016 07:54:00 +0100fixed issue 32431: missing link to wiki in Log Clean Up Configuration window
Asier Lostalé <asier.lostale@openbravo.com> [Tue, 08 Mar 2016 07:54:00 +0100] rev 28702
fixed issue 32431: missing link to wiki in Log Clean Up Configuration window

Added missing distribution modules so that windows defined in them will also
show link to wiki.

Mon, 07 Mar 2016 19:15:00 +0100fixes issue 32429: Added error log in remove method of DefaultJsonDataService
Carlos Aristu <carlos.aristu@openbravo.com> [Mon, 07 Mar 2016 19:15:00 +0100] rev 28701
fixes issue 32429: Added error log in remove method of DefaultJsonDataService

Mon, 07 Mar 2016 11:31:44 +0100Fixes issue 32396: cannot filter grid when it is grouped by a column.
Inigo Sanchez <inigo.sanchez@openbravo.com> [Mon, 07 Mar 2016 11:31:44 +0100] rev 28700
Fixes issue 32396: cannot filter grid when it is grouped by a column.

Having a column grouped, if a filter was applied in a grid, it was not
possible to apply it.A js error was thrown:
Uncaught TypeError: this.data.willFetchData is not a function.

The problem was in:"this.data.willFetchData(....))" statement which
incorrectly assumed this.data to be an object and willFetchData a function
within it. This is not true when in this situation where this.data is a
Tree class.

It has been fixed by taking into account this case by checking that "this.data" defines the
function.

Fri, 31 Jul 2015 12:59:08 +0530Fixes Issue 30147: US Region code are wrong
Atul Gaware <atul.gaware@openbravo.com> [Fri, 31 Jul 2015 12:59:08 +0530] rev 28699
Fixes Issue 30147: US Region code are wrong

Codes for region updated as follows:
MI - Michigan
MN - Minnesota

Fri, 04 Mar 2016 14:37:26 +0100Fixed issue 32151: It wasnt possible configure text referenced cols. properly.
Naroa Iriarte <naroa.iriarte@openbravo.com> [Fri, 04 Mar 2016 14:37:26 +0100] rev 28698
Fixed issue 32151: It wasnt possible configure text referenced cols. properly.

It was not possible to configure the Allow Filtering property in colums that used Text reference.
The problem was in the UIDefinition.removeAttributeFromString.

Here the canSort and canFilter properties were being deleted and that was not correct, because in the case of
the "help" column of the Module window, for example, when the method was invoked, it was only desired to remove
the "canSort" property and not the canFilter.
The method has been changed, now, the passed String argument is the one which will be deleted instead of deleting
canSort or canFilter directly.