Tue, 14 Mar 2017 09:22:54 +0100related to issue 35493, related to issue 35503
Asier Lostalé <asier.lostale@openbravo.com> [Tue, 14 Mar 2017 09:22:54 +0100] rev 31647
related to issue 35493, related to issue 35503

Don't display warn message when tomcat pool cannot be used unless log level is
set to debug.

It is expected not to be possible to use it from CLI, because now export.database
uses standard ConsoleAppender, this message was now visible in logs.

Tue, 14 Mar 2017 09:21:07 +0100fixed bug 35492, fixed bug 35493: new dbsm
Asier Lostalé <asier.lostale@openbravo.com> [Tue, 14 Mar 2017 09:21:07 +0100] rev 31646
fixed bug 35492, fixed bug 35493: new dbsm

Includes:
* 35492 - Fixes PG trigger translation consistency:
- incorrect casting from Trigger to Function
- use correct translator for triggers
* 35493 - Missing log info in export.database:
- replaced OBLogAppender which is not required by standard
ConsoleAppender
- changed layout so that time and log level (INFO, WARN...) is
displayed

Mon, 13 Mar 2017 07:48:48 +0100fixed bug 35490: SystemService logs a ERROR line always
Stefan Hühner <stefan.huehner@openbravo.com> [Mon, 13 Mar 2017 07:48:48 +0100] rev 31645
fixed bug 35490: SystemService logs a ERROR line always

Fri, 10 Mar 2017 11:11:58 -0500Fixes issue 35447:Error creating an Order from a Requisition To Order.
Miguel <martencobasmiguel@gmail.com> [Fri, 10 Mar 2017 11:11:58 -0500] rev 31644
Fixes issue 35447:Error creating an Order from a Requisition To Order.

In AUM project the Constraint c_orderline_check1 was modified, to only allow creation
of order lines whith QUANTITYORDER and M_PRODUCT_UOM_ID values null or not null at same time.
When they were created from the Requisition to Order process, the Order line's QUANTITYORDER
was created with 0 in the case it had a NULL value, instead of maintain the value as NULL.
Because of it the constraint was failing because a QUANTITYORDER=0 and a M_PRODUCT_UOM_ID=NULL.

To solve this problem was modified the linesToOrder query in RequisitionToOrder_data.xsql, to
retrieve the correct value of QUANTITYORDER, including NULL if there are no qty in the second
UOM.

Thu, 09 Mar 2017 14:22:29 -0500Fixes issue 35341: Wrong orders shown in "Create Invoices From Orders" window
Miguel <martencobasmiguel@gmail.com> [Thu, 09 Mar 2017 14:22:29 -0500] rev 31643
Fixes issue 35341: Wrong orders shown in "Create Invoices From Orders" window

Fixed the C_INVOICE_CANDIDATE_V view, changing the condition to not take into account
the sales orders different than 'ON' AND 'OB' AND 'WR' instead of using an incorrect
OR condition as suggested in the proposed solution.

Also were included some performances in the view replacing OR and AND conditions with they
respectively translations to IN and NOT IN clauses.

Fri, 10 Mar 2017 15:57:33 +0100Related to bug 35471: Add last TaxAmt when calculating cascade/dependant taxes
Alvaro Ferraz <alvaro.ferraz@openbravo.com> [Fri, 10 Mar 2017 15:57:33 +0100] rev 31642
Related to bug 35471: Add last TaxAmt when calculating cascade/dependant taxes

Fri, 10 Mar 2017 14:37:32 +0100related to issue 35426: improved comments
Carlos Aristu <carlos.aristu@openbravo.com> [Fri, 10 Mar 2017 14:37:32 +0100] rev 31641
related to issue 35426: improved comments

Fri, 10 Mar 2017 12:13:30 +0100Fixes Issue 35415. Fixes problem while setting the alias of a subquery in Oracle.
David Miguelez <david.miguelez@openbravo.com> [Fri, 10 Mar 2017 12:13:30 +0100] rev 31640
Fixes Issue 35415. Fixes problem while setting the alias of a subquery in Oracle.

Fri, 10 Mar 2017 10:47:38 +0100Related to issue 35471: Fix variables definition
Alvaro Ferraz <alvaro.ferraz@openbravo.com> [Fri, 10 Mar 2017 10:47:38 +0100] rev 31639
Related to issue 35471: Fix variables definition

Thu, 09 Mar 2017 17:47:15 +0100Related to issue 35471: Do not round line net amount in TaxesTest
Alvaro Ferraz <alvaro.ferraz@openbravo.com> [Thu, 09 Mar 2017 17:47:15 +0100] rev 31638
Related to issue 35471: Do not round line net amount in TaxesTest

Fri, 10 Mar 2017 10:23:51 +0100Fixes issue 35471: Order Line amounts and taxes not rounded after booking
Alvaro Ferraz <alvaro.ferraz@openbravo.com> [Fri, 10 Mar 2017 10:23:51 +0100] rev 31637
Fixes issue 35471: Order Line amounts and taxes not rounded after booking

M_PROMOTION_CALCULATE was run after rounding and adjusting the order, and it was updating the order lines, so triggers were run again calculating line net amount and taxes without rounding.
Now, round, adjust and recalculate will be done at the end of c_order_post and c_invoice_post, just before finish process extension point.
Also, line net amount will always be rounded to standard precision to avoid problems. In case we need to calculate taxes without rounding (price including taxes and taxes at document level), we will calculate again the line net amount in line after trigger to use it for calculating taxes at line level and document level without rounding.

Fri, 10 Mar 2017 10:15:36 +0100Fixed issue 35426: Adaptive filtering does not work for Table references.
Inigo Sanchez <inigo.sanchez@openbravo.com> [Fri, 10 Mar 2017 10:15:36 +0100] rev 31636
Fixed issue 35426: Adaptive filtering does not work for Table references.

The problem was that adaptive filtering (filter in client when all data is locally available) did
not work for Table references when filtering by text instead of by selecting a value in the drop
down list. The issue that causes this regression was not taking into account adaptive filtering.

This problem has been fixed by taking into account this case in getDisplayProperty method. Now
getDisplayProperty method manages properly when all the data are in the client (Adaptive filtering).

Fri, 10 Mar 2017 09:33:16 +0100Related to issue 35435. Improved comment on user null check
Gorka Ion Damián <gorkaion.damian@openbravo.com> [Fri, 10 Mar 2017 09:33:16 +0100] rev 31635
Related to issue 35435. Improved comment on user null check

Mon, 06 Mar 2017 23:38:22 +0100Fixed issue 35435. Centralize in protected method user and password check
Gorka Ion Damián <gorkaion.damian@openbravo.com> [Mon, 06 Mar 2017 23:38:22 +0100] rev 31634
Fixed issue 35435. Centralize in protected method user and password check

New protected method checkUserPassword() has been added in AuthenticationManager
to centralize all the calls to check the user and password.

The DefaultAuthenticationManager now catches AuthenticationExceptions in case
the implementations of the new method throw it instead of returning null user
id.

checkIfPasswordExpired() method changed to protected() to allow
AuthenticationManager implementations to customize the password expiration
check.

Thu, 09 Mar 2017 11:04:36 +0100Merge back from main
RM packaging bot <staff.rm@openbravo.com> [Thu, 09 Mar 2017 11:04:36 +0100] rev 31633
Merge back from main

Thu, 09 Mar 2017 09:44:31 +0000Merge temporary head for 3.0PR16Q4.3
RM packaging bot <staff.rm@openbravo.com> [Thu, 09 Mar 2017 09:44:31 +0000] rev 31632
Merge temporary head for 3.0PR16Q4.3

Tue, 07 Mar 2017 12:43:27 +0000Added signature for changeset a131c85d1d3d
RM packaging bot <staff.rm@openbravo.com> [Tue, 07 Mar 2017 12:43:27 +0000] rev 31631
Added signature for changeset a131c85d1d3d

Tue, 07 Mar 2017 12:43:27 +0000Added tag 3.0PR16Q4.3 for changeset eaeb76d8cd4e
RM packaging bot <staff.rm@openbravo.com> [Tue, 07 Mar 2017 12:43:27 +0000] rev 31630
Added tag 3.0PR16Q4.3 for changeset eaeb76d8cd4e

Tue, 07 Mar 2017 12:43:27 +0000Update AD_MODULE version to 3.0PR16Q4.3 3.0PR16Q4.3
RM packaging bot <staff.rm@openbravo.com> [Tue, 07 Mar 2017 12:43:27 +0000] rev 31629
Update AD_MODULE version to 3.0PR16Q4.3

Thu, 02 Mar 2017 14:16:00 -0500Fixes issue 35420:Cannot remove an orphan line in Return to/from vendor/customer
Miguel <martencobasmiguel@gmail.com> [Thu, 02 Mar 2017 14:16:00 -0500] rev 31628
Fixes issue 35420:Cannot remove an orphan line in Return to/from vendor/customer

Was not able to remove an orphan line from a return to vendor or a return from
customer document because an incorrect casting to boolean.

When is validating tha Last record is selected inside the Orphan grid lines, the
lastRecord.get("obSelected") object gets as String instead of a Boolean object,
in other case it gets as Boolean.

Now, conditions are rightly validated depending of the class of the object.

Thu, 02 Mar 2017 09:22:31 +0100fixes issue 35399: Check readable clients for child properties using DAL WS
Carlos Aristu <carlos.aristu@openbravo.com> [Thu, 02 Mar 2017 09:22:31 +0100] rev 31627
fixes issue 35399: Check readable clients for child properties using DAL WS

Fix for issue #29683 was introducing a security check to avoid showing child properties which belong to a client different from the current client. But this fix was preventing to display some readable objects like master data defined at system level (client 0).

Therefore this security check has been improved and now it is verified if the child property is defined for a client which is readable for the current role.

Tue, 28 Feb 2017 08:02:50 +0100Fixed issue 35374. Reenable automatic discounts in purchase flows.
Antonio Moreno <antonio.moreno@openbravo.com> [Tue, 28 Feb 2017 08:02:50 +0100] rev 31626
Fixed issue 35374. Reenable automatic discounts in purchase flows.

Tue, 28 Feb 2017 08:02:43 +0100Fixed issue 35374. Reenable automatic discounts in purchase flows.
Antonio Moreno <antonio.moreno@openbravo.com> [Tue, 28 Feb 2017 08:02:43 +0100] rev 31625
Fixed issue 35374. Reenable automatic discounts in purchase flows.

Mon, 27 Feb 2017 10:49:29 +0100Fixed issue 35350:Callout problem when working with comma as decimal separator
Inigo Sanchez <inigo.sanchez@openbravo.com> [Mon, 27 Feb 2017 10:49:29 +0100] rev 31624
Fixed issue 35350:Callout problem when working with comma as decimal separator

The problem was raised when a default format were switched, it means, when
decimal and group separator were switched. In this situation, when
SimpleCalloutInformationProvider class was used to obtain the current element
value and this current element was a BigDecimal, the format was not managed
properly. This occurred because getCurrentElementValue method always retrieved
a String element instead of Object element, in tyhis case BigDecimal.

In this situation, managesUpdatedValuesForCallout method of FIC class compare
if element is a String or not. If a BigDecimal is retrieved as String element,
in this part of the code the format is not managed properly when decimal separator
is comma. The code manage the comma separator as group separator and removed it.

When the decimal separator is dot (.) the format is managed as expected although
this method retrieves a String object (e.g. "1.23"). When decimal separator is
comma (,) this BigDecimal (e.g. 1,24) is retrieved by getCurrentElementValue method
as String value and the format is missed.

This problem has been fixed by take into account type of current element inside
getCurrentElementValue method. Now this method retrieves an object value. In this
case, a BigDecimal is retrieved. Now the format is managed properly.

Tue, 21 Feb 2017 14:12:18 +0100fixes issue 35319: documents were not being attached after send them by e-mail
Carlos Aristu <carlos.aristu@openbravo.com> [Tue, 21 Feb 2017 14:12:18 +0100] rev 31623
fixes issue 35319: documents were not being attached after send them by e-mail

The CoreAttachImplementation class is deleting the original report file after completing the upload process. When attaching a document using the e-mail pop-up this is done before attaching the document into the e-mail. This explains why the document was not being received on the e-mail.

To avoid this problem, now a copy of the original document is sent to the AttachImplementationManager, this way the original file will never be deleted by an upload process handler.

Together with this, now when attaching a document after printing (not by e-mail) we have to delete the original file because in other case it will be kept on disk.

Thu, 16 Feb 2017 11:18:42 -0500Fixes issue 35277: General Ledger filter changes with pagination in JE Report
Armaignac <collazoandy4@gmail.com> [Thu, 16 Feb 2017 11:18:42 -0500] rev 31622
Fixes issue 35277: General Ledger filter changes with pagination in JE Report

Selected General Ledger filter value changes when pagination is executed in the
Journal Entries report

The General Ledger filter is not kept in the session to make use in the pagination.
For the solution, was saved the General Ledger Filter in the session every time
the search is executed (FIND action). By default, if there is any GL in the
session, the GL field will use the defaulted for the selected org. When paginating
always is used the account schema id stored in the session.

Wed, 15 Feb 2017 19:40:59 -0500Fix for issue 35274: General Ledger filter removed when paginating in GL Report
Armaignac <collazoandy4@gmail.com> [Wed, 15 Feb 2017 19:40:59 -0500] rev 31621
Fix for issue 35274: General Ledger filter removed when paginating in GL Report

The General Ledger filter was removed when paginating in General Ledger Report
in HTML view

Now the General Ledger filter it's save in the session by the FIND action and get in the DEFAULT action
for showing in the report page

Wed, 08 Feb 2017 14:07:20 +0100fixes bug 35198: Can't attach using manual role having modules in indevelopment
Carlos Aristu <carlos.aristu@openbravo.com> [Wed, 08 Feb 2017 14:07:20 +0100] rev 31620
fixes bug 35198: Can't attach using manual role having modules in indevelopment

It was not possible to attach a document with a role that hasn't got access to ADTab entity having modules in indevelopment. This was happening because when there are modules in indevelopemnt status, the getTab method of the ADCS class does not store the tab information in cache and uses DAL to retrieve the tab every time it is being called.

Under this circumstances, the getTab method in AttachImplementationManager must be invoked in admin mode to ensure that the role can generate the attachment even when not having access to the ADTab entity.

Tue, 07 Feb 2017 09:57:04 +0100fixes issue 35178: Initialize callout's connection pool on init
Carlos Aristu <carlos.aristu@openbravo.com> [Tue, 07 Feb 2017 09:57:04 +0100] rev 31619
fixes issue 35178: Initialize callout's connection pool on init

Tue, 31 Jan 2017 11:19:49 -0500Fixes issue 35093: Set value in a warehouse document line with empty attribute
Armaignac <collazoandy4@gmail.com> [Tue, 31 Jan 2017 11:19:49 -0500] rev 31618
Fixes issue 35093: Set value in a warehouse document line with empty attribute

In a warehouse document line now can set value in a warehouse document line in case
it does not contain an instance attribute