Wed, 09 Mar 2016 18:53:24 -0500Fixes issue 32428: Wrong orders created by the Copy Record process
Mark <m.molina@nectus.com> [Wed, 09 Mar 2016 18:53:24 -0500] rev 28707
Fixes issue 32428: Wrong orders created by the Copy Record process

Fixed the wrong Tax Amount and Total Gross Amount calculation in orders created by the Copy Record process
if price list includes taxes. These amounts are calculated when related triggers are fired, due that when
the order is cloned from the original order was necessary to reset calculated amounts and then triggers updates
them again when lines are added to the cloned order.

Tue, 08 Mar 2016 10:56:37 +0100fixed issue 32152: Some colums were modified even with no modules in devel.
Naroa Iriarte <naroa.iriarte@openbravo.com> [Tue, 08 Mar 2016 10:56:37 +0100] rev 28706
fixed issue 32152: Some colums were modified even with no modules in devel.

The AllowSorting and AllowFiltering columns were modified even with no module in development.
That behavior is not correct and the AD_COLUMN_MOD_TRG.xml trigger has been modified to handle
this situation. Now if there is no module in development and the old value of these columns is
not the same as the new one (if it has been modified) an error is shown.

Tue, 08 Mar 2016 11:21:24 +0100Fixed issue 32331. Added method to check if importentry has status 'Error'
Antonio Moreno Perez <antonio.moreno@openbravo.com> [Tue, 08 Mar 2016 11:21:24 +0100] rev 28705
Fixed issue 32331. Added method to check if importentry has status 'Error'

Tue, 08 Mar 2016 09:36:55 +0100related to issue 32429: code review improvements
Carlos Aristu <carlos.aristu@openbravo.com> [Tue, 08 Mar 2016 09:36:55 +0100] rev 28704
related to issue 32429: code review improvements

Tue, 08 Mar 2016 08:54:17 +0100fixed issue 32432: incorrect dates issue detection on install.source
Asier Lostalé <asier.lostale@openbravo.com> [Tue, 08 Mar 2016 08:54:17 +0100] rev 28703
fixed issue 32432: incorrect dates issue detection on install.source

Do not execute PgJdbcDatesIssue module script on install.source.

Tue, 08 Mar 2016 07:54:00 +0100fixed issue 32431: missing link to wiki in Log Clean Up Configuration window
Asier Lostalé <asier.lostale@openbravo.com> [Tue, 08 Mar 2016 07:54:00 +0100] rev 28702
fixed issue 32431: missing link to wiki in Log Clean Up Configuration window

Added missing distribution modules so that windows defined in them will also
show link to wiki.

Mon, 07 Mar 2016 19:15:00 +0100fixes issue 32429: Added error log in remove method of DefaultJsonDataService
Carlos Aristu <carlos.aristu@openbravo.com> [Mon, 07 Mar 2016 19:15:00 +0100] rev 28701
fixes issue 32429: Added error log in remove method of DefaultJsonDataService

Mon, 07 Mar 2016 11:31:44 +0100Fixes issue 32396: cannot filter grid when it is grouped by a column.
Inigo Sanchez <inigo.sanchez@openbravo.com> [Mon, 07 Mar 2016 11:31:44 +0100] rev 28700
Fixes issue 32396: cannot filter grid when it is grouped by a column.

Having a column grouped, if a filter was applied in a grid, it was not
possible to apply it.A js error was thrown:
Uncaught TypeError: this.data.willFetchData is not a function.

The problem was in:"this.data.willFetchData(....))" statement which
incorrectly assumed this.data to be an object and willFetchData a function
within it. This is not true when in this situation where this.data is a
Tree class.

It has been fixed by taking into account this case by checking that "this.data" defines the
function.

Fri, 31 Jul 2015 12:59:08 +0530Fixes Issue 30147: US Region code are wrong
Atul Gaware <atul.gaware@openbravo.com> [Fri, 31 Jul 2015 12:59:08 +0530] rev 28699
Fixes Issue 30147: US Region code are wrong

Codes for region updated as follows:
MI - Michigan
MN - Minnesota

Fri, 04 Mar 2016 14:37:26 +0100Fixed issue 32151: It wasnt possible configure text referenced cols. properly.
Naroa Iriarte <naroa.iriarte@openbravo.com> [Fri, 04 Mar 2016 14:37:26 +0100] rev 28698
Fixed issue 32151: It wasnt possible configure text referenced cols. properly.

It was not possible to configure the Allow Filtering property in colums that used Text reference.
The problem was in the UIDefinition.removeAttributeFromString.

Here the canSort and canFilter properties were being deleted and that was not correct, because in the case of
the "help" column of the Module window, for example, when the method was invoked, it was only desired to remove
the "canSort" property and not the canFilter.
The method has been changed, now, the passed String argument is the one which will be deleted instead of deleting
canSort or canFilter directly.

Fri, 04 Mar 2016 08:51:01 +0100related to bug 32375: added test case covering preference's client visibility
Asier Lostalé <asier.lostale@openbravo.com> [Fri, 04 Mar 2016 08:51:01 +0100] rev 28697
related to bug 32375: added test case covering preference's client visibility

Fri, 04 Mar 2016 08:50:01 +0100fixed bug 32375: preferences incorrectly resolve client visibility
Asier Lostalé <asier.lostale@openbravo.com> [Fri, 04 Mar 2016 08:50:01 +0100] rev 28696
fixed bug 32375: preferences incorrectly resolve client visibility

Reimplemented client visibility resolution to correctly handle the case of
2 preference candidates with different client visibility.

Fri, 04 Mar 2016 08:48:31 +0100related to bug 32375: make preference resolution more consistent
Asier Lostalé <asier.lostale@openbravo.com> [Fri, 04 Mar 2016 08:48:31 +0100] rev 28695
related to bug 32375: make preference resolution more consistent

In case of several preferences defined for a given property/attribute, the
result of getting value could be undetermistic.

Solved by sorting by preference's id in these cases.

Fri, 04 Mar 2016 08:45:40 +0100related to bug 32375: preferences incorrectly resolve client visibility
Asier Lostalé <asier.lostale@openbravo.com> [Fri, 04 Mar 2016 08:45:40 +0100] rev 28694
related to bug 32375: preferences incorrectly resolve client visibility

Small code clean up:
-isHigherPriority renamed to getHighestPriority: by convention is* are boolean
getters which was not the case of this one
-removed unneded brackets in condition which didn't help to make the code more
readable

Thu, 11 Feb 2016 13:03:59 +0100Fixes issue 32386: Set Final good C product as isquantityvariable in QA client
Alvaro Ferraz <alvaro.ferraz@openbravo.com> [Thu, 11 Feb 2016 13:03:59 +0100] rev 28693
Fixes issue 32386: Set Final good C product as isquantityvariable in QA client

Tue, 01 Mar 2016 13:24:31 +0100Fixes bug 32083: Move Service Price Rule menu entry under Pricing Setup menu entry
Unai Martirena <unai.martirena@openbravo.com> [Tue, 01 Mar 2016 13:24:31 +0100] rev 28692
Fixes bug 32083: Move Service Price Rule menu entry under Pricing Setup menu entry

Mon, 29 Feb 2016 18:07:19 +0530Fixes Issue 32337:Division by zero error when completing an invoice
Atul Gaware <atul.gaware@openbravo.com> [Mon, 29 Feb 2016 18:07:19 +0530] rev 28691
Fixes Issue 32337:Division by zero error when completing an invoice
associated to a closed order (quantity 0) with a promotion

While calculating promotion if qty ordered is non zero then only
use divide by statement else set values to zero

Tue, 01 Mar 2016 18:02:57 +0100Related to issue 32364: Code review improvements
Alvaro Ferraz <alvaro.ferraz@openbravo.com> [Tue, 01 Mar 2016 18:02:57 +0100] rev 28690
Related to issue 32364: Code review improvements

Call line.getProductCosts only when line.transaction != null in DocInventory.java.

Mon, 29 Feb 2016 17:00:12 +0530Fixes Issue 32364:NullPointerException when posting a Physical Inventory
Atul Gaware <atul.gaware@openbravo.com> [Mon, 29 Feb 2016 17:00:12 +0530] rev 28689
Fixes Issue 32364:NullPointerException when posting a Physical Inventory
with a line without an associated transaction (not stocked product)

- Avoid insertion of zero quantity products in inventory line having
stocked flag as No.
- Code improvement to handle line with null transaction.

Tue, 01 Mar 2016 13:19:21 +0100Fixes issue 0032381: missing upload image icon
Adrián Romero <adrianromero@openbravo.com> [Tue, 01 Mar 2016 13:19:21 +0100] rev 28688
Fixes issue 0032381: missing upload image icon
* Restoring upload icon and erase icon

Mon, 29 Feb 2016 23:49:20 +0100Fixes issue 32233: Payment In and Payment Out lines are not exported to CSV.
Inigo Sanchez <inigo.sanchez@openbravo.com> [Mon, 29 Feb 2016 23:49:20 +0100] rev 28687
Fixes issue 32233: Payment In and Payment Out lines are not exported to CSV.

The problem was that export to CSV does not work properly in some subtabs without
link to parent column (e.g.Lines subtab of Payment In/Out). Before, It was used
"tabId" to obtaing data for export to CSV and the value of the "tabId" was sent
in a variable called "tab". The Criteria that is run when it is displayed the tab
uses a property named "tabId" instead of "tab".

The solution for this case (and other related cases) is to adapt the code that
exports to CSV to use the same Criteria run when displaying the tab. Now export
to CSV uses tabId property. Besides it has been refactored some piece of code
related with export data in DataSourceServlet to use "tabId" instead of "tab".

Thu, 18 Feb 2016 13:23:15 +0100Fixed issue 0032044: Ensure stable ids in docs send from WebPOS to the server (Payment API)
Miguel de Juana <miguel.dejuana@openbravo.com> [Thu, 18 Feb 2016 13:23:15 +0100] rev 28686
Fixed issue 0032044: Ensure stable ids in docs send from WebPOS to the server (Payment API)

- Set some entities ids related to order loading in Web POS to ensure stable ids

Tue, 26 Jan 2016 17:24:27 +0100Fixed bug 31419: Add parameter to control flushes in some APRM methods
Víctor Martínez Romanos <victor.martinez@openbravo.com> [Tue, 26 Jan 2016 17:24:27 +0100] rev 28685
Fixed bug 31419: Add parameter to control flushes in some APRM methods

Added a parameter doFlush to some APRM methods to control whether to flush inside the method. By default it continues to have the same behavior as before (to flush inside the method) so we should avoid any possible regression.
These flushes inside the method makes the process of several payments in a batch really slow, which is a common scenario for the remittance module. With this change (and with the necessary modifications in the remittance module), the time to process a remittance line has been decreased from 900ms to 15ms.

The idea is to create this "self-protected" methods and adapt the flows with performance problems. When the time goes by, we should clean the duplicated methods.

Fri, 26 Feb 2016 08:57:54 +0100fixed bug 32354: field edit access doesn't allow to save if tab contains audit
Asier Lostalé <asier.lostale@openbravo.com> [Fri, 26 Feb 2016 08:57:54 +0100] rev 28684
fixed bug 32354: field edit access doesn't allow to save if tab contains audit

For tabs that explicitly define their audit (updated/updated by) fields, roles
with access to edit only some fields couldn't save unless in those fields audit
were also included.

Now audit fields are not checked for this validation as they are always updated
on any allowed modification.

Fri, 26 Feb 2016 08:20:01 +0100[ChangePassword] Merge ChangePassword development
Guillermo Gil <guillermo.gil@openbravo.com> [Fri, 26 Feb 2016 08:20:01 +0100] rev 28683
[ChangePassword] Merge ChangePassword development

Mon, 22 Feb 2016 15:30:30 +0100[ChangePassword] Merge with pi
Jonathan Bueno <jonathan.bueno@openbravo.com> [Mon, 22 Feb 2016 15:30:30 +0100] rev 28682
[ChangePassword] Merge with pi

Mon, 22 Feb 2016 11:31:04 +0100[ChangePassword] Applied code review.
Jonathan Bueno <jonathan.bueno@openbravo.com> [Mon, 22 Feb 2016 11:31:04 +0100] rev 28681
[ChangePassword] Applied code review.

Now client messages are translated.
Used === for javascript comparison

Fri, 19 Feb 2016 13:42:53 +0100[ChangePassword] Renamed trigger to AD_USER_EXPIRATIONPASS_TRG
Jonathan Bueno <jonathan.bueno@openbravo.com> [Fri, 19 Feb 2016 13:42:53 +0100] rev 28680
[ChangePassword] Renamed trigger to AD_USER_EXPIRATIONPASS_TRG

Fri, 19 Feb 2016 12:56:49 +0100[ChangePassword] Applied code review.
Jonathan Bueno <jonathan.bueno@openbravo.com> [Fri, 19 Feb 2016 12:56:49 +0100] rev 28679
[ChangePassword] Applied code review.

Renamed trigger to be consistent, used expiration instead of expiry.
Used === to compare strings in Login.html.
Renamed getUpdatePasswordDate method to checkIfPasswordExpired in DefaultAuthenticationManager class.
Added throws in signature and javadoc for checkIfPasswordExpired and updatePassword methods.
Removed static parameter from checkIfPasswordExpired and updatePassword methods.
Removed extra brackets in expression in checkIfPasswordExpired method.
Exception AuthenticationExpirationPasswordException fixed. Removed extra variables, error is now loaded in the subclass AuthenticationException.
Removed empty line in checkIfPasswordExpired.
Removed check to support 2.50.
LoginUtils file keep unmodified.

Wed, 17 Feb 2016 09:56:42 +0100[ChangePassword] Merge with pi
Jonathan Bueno <jonathan.bueno@openbravo.com> [Wed, 17 Feb 2016 09:56:42 +0100] rev 28678
[ChangePassword] Merge with pi