Mon, 02 Feb 2015 16:24:12 -0500Fixed bug 28691: It is possible to add discounts to documents already processed.
Reinaldo Guerra <reinaldo.guerra@peoplewalking.com> [Mon, 02 Feb 2015 16:24:12 -0500] rev 26042
Fixed bug 28691: It is possible to add discounts to documents already processed.

One possible solution for this issue would be to configure the C_ORDERDISCOUNT_TRG to be executed ON INSERT action, but this trigger is launched also when inserting orders for business partners with discounts defined, so the trigger logic causes a "mutating table" oracle's error.
In this case a new event handler is developed, to launch an error message, when trying to insert discounts for a sales order already processed. This change also affects the following windows: Purchase Order, Return from Customer, Return to Vendor and Sales Quotation.

Mon, 23 Feb 2015 11:17:39 +0100fixed bug 28712: record selection lost in p&e grid if data has multiple pages
Asier Lostalé <asier.lostale@openbravo.com> [Mon, 23 Feb 2015 11:17:39 +0100] rev 26041
fixed bug 28712: record selection lost in p&e grid if data has multiple pages

In P&E grid with data displayed in several pages, if part of the selection was
not in the 1st page two errors occured:

-If after selecting a record in 2nd page another one in the 1st page was selected,
selection of record in 2nd page was lost
-If record in 2nd page was selected by using a filter, the filter was removed, and
the p&e was submitted, the selection was not sent to backend

The problem is in SC grid.getSelectedRecords which returns records only in current
page.

To solve this a cache of selected/unselected records is completelly maintained for p&e
grids without using getSelectedRecords, this is used also to send the selected recors
on p&e submission.

Mon, 23 Feb 2015 04:09:31 +0000CI: merge back from main
RM packaging bot <staff.rm@openbravo.com> [Mon, 23 Feb 2015 04:09:31 +0000] rev 26040
CI: merge back from main

Mon, 23 Feb 2015 03:50:05 +0000CI: update AD_MODULE to version 26038
RM packaging bot <staff.rm@openbravo.com> [Mon, 23 Feb 2015 03:50:05 +0000] rev 26039
CI: update AD_MODULE to version 26038

Fri, 20 Feb 2015 18:06:24 +0100Issue 28130: Backout cset: ed3b5179390b
Stefan Hühner <stefan.huehner@openbravo.com> [Fri, 20 Feb 2015 18:06:24 +0100] rev 26038
Issue 28130: Backout cset: ed3b5179390b
As the new index references a retail column it must be in a retail module
and not directly in pi

Fri, 20 Feb 2015 14:49:11 +0100Merge back from main
RM packaging bot <staff.rm@openbravo.com> [Fri, 20 Feb 2015 14:49:11 +0100] rev 26037
Merge back from main

Fri, 20 Feb 2015 13:34:43 +0000Merge temporary head for 3.0PR15Q1.1
RM packaging bot <staff.rm@openbravo.com> [Fri, 20 Feb 2015 13:34:43 +0000] rev 26036
Merge temporary head for 3.0PR15Q1.1

Fri, 20 Feb 2015 08:50:02 +0000Added signature for changeset 831f7c3e5429
RM packaging bot <staff.rm@openbravo.com> [Fri, 20 Feb 2015 08:50:02 +0000] rev 26035
Added signature for changeset 831f7c3e5429

Fri, 20 Feb 2015 08:50:01 +0000Added tag 3.0PR15Q1.1 for changeset 39f3bed2ed0e
RM packaging bot <staff.rm@openbravo.com> [Fri, 20 Feb 2015 08:50:01 +0000] rev 26034
Added tag 3.0PR15Q1.1 for changeset 39f3bed2ed0e

Fri, 20 Feb 2015 08:50:01 +0000Update AD_MODULE version to 3.0PR15Q1.1 3.0PR15Q1.1
RM packaging bot <staff.rm@openbravo.com> [Fri, 20 Feb 2015 08:50:01 +0000] rev 26033
Update AD_MODULE version to 3.0PR15Q1.1

Wed, 18 Feb 2015 16:44:45 +0100Fixes bug 28980:Goods receipt without PO now appears in CreateLines in Purc. Inv
Unai Martirena <unai.martirena@openbravo.com> [Wed, 18 Feb 2015 16:44:45 +0100] rev 26032
Fixes bug 28980:Goods receipt without PO now appears in CreateLines in Purc. Inv

selectFromShipmentCombo method in Purchase Invoice window has been modified to exclude shipments coming from orders with Invoice Terms as Do not invoice. This is only done if a Purchase Order exits. AND o.InvoiceRule <> 'N' condition has been moved from where clause to left join clause

Thu, 19 Feb 2015 10:43:52 +0100Fixes issue 28985: Grid columns can be frozen
Augusto Mauch <augusto.mauch@openbravo.com> [Thu, 19 Feb 2015 10:43:52 +0100] rev 26031
Fixes issue 28985: Grid columns can be frozen

In this changeset [1], a function named fieldIsVisible was added to the OBViewGrid class, to control if a field was actually visible in the grid. The problem was that there was actually a function defined with that same name in the Smartclient's DataBoundComponent class, which is an OBViewGrid ancestor. This means that the fieldIsVisible function implemented in [1] is overwriting the original implementation, and this was not intended.

The fieldIsVisible function is invoked when a grid column is frozen, that is why the change made in [1] has created the current issue. To fix it, the name of OBViewGrid.fieldIsVisible function has been renamed to fieldIsVisibleInGrid. It has been checked that there is no function defined with that name in any OBViewGrid ancestor class.

[1] https://code.openbravo.com/erp/devel/pi/rev/25794

Wed, 18 Feb 2015 14:02:30 +0100Related to bug 28111,related to bug 28951: Fix on where clause
Unai Martirena <unai.martirena@openbravo.com> [Wed, 18 Feb 2015 14:02:30 +0100] rev 26030
Related to bug 28111,related to bug 28951: Fix on where clause

Filter m_transaction_cost records in Costing Background process using same dateformat that has been used in oncreatedefault to insert values

Tue, 17 Feb 2015 23:43:14 +0530Fixes Issue 28967:Business Partner dimension is not taken into account in
Atul Gaware <atul.gaware@openbravo.com> [Tue, 17 Feb 2015 23:43:14 +0530] rev 26029
Fixes Issue 28967:Business Partner dimension is not taken into account in
G/L Journal lines

Wrongly written C_BPARTNERr_ID instead of C_BPARTNER_ID

Wed, 18 Feb 2015 11:46:11 +0100Related to bug 28111,related to bug 28951: Fix on oncreatedefault
Unai Martirena <unai.martirena@openbravo.com> [Wed, 18 Feb 2015 11:46:11 +0100] rev 26028
Related to bug 28111,related to bug 28951: Fix on oncreatedefault

oncreatedefault statement of dateacct has been changed in order to work both in oracle and postgres with different date formats.
Also to_date has been removed from background process in order to allways the filter work.

Tue, 17 Feb 2015 10:28:34 +0100Related to bug 28111,related to bug 28951: Remove xsql Data class file
Unai Martirena <unai.martirena@openbravo.com> [Tue, 17 Feb 2015 10:28:34 +0100] rev 26027
Related to bug 28111,related to bug 28951: Remove xsql Data class file

Mon, 16 Feb 2015 16:00:25 +0100Fixes bug 28111, Fixes bug 28951: InitCostDateacct modulescript has been removed
Unai Martirena <unai.martirena@openbravo.com> [Mon, 16 Feb 2015 16:00:25 +0100] rev 26026
Fixes bug 28111, Fixes bug 28951: InitCostDateacct modulescript has been removed

The functionality that was being implemented in the modulescript now will be done in Costing Background process. An oncreatedefault has been added in dateacct column because it has a constraint of not null. The date set to the column will be 01-01-1970, and this date will be used as a reference while updating it in Costing Background process

Thu, 12 Feb 2015 09:06:42 +0100Related to Bug 28890: Valued Stock Report shows correct qty with Cost Adjusments
Unai Martirena <unai.martirena@openbravo.com> [Thu, 12 Feb 2015 09:06:42 +0100] rev 26025
Related to Bug 28890: Valued Stock Report shows correct qty with Cost Adjusments

The query is working in Postgres and in Oracle

Tue, 17 Feb 2015 13:40:24 +0100Fixed bug 28956: Negative Cash VAT info when partially paying Credit Memo
Víctor Martínez Romanos <victor.martinez@openbravo.com> [Tue, 17 Feb 2015 13:40:24 +0100] rev 26024
Fixed bug 28956: Negative Cash VAT info when partially paying Credit Memo

When there was a partial payment in cash vat, the calculated percentage had the wrong sign (negative, when it should be possitive).
Thus the tax and taxable amounts had also the opposite sign.

The fix negates the invoice's grand total amount in case of a "reversal" document (i.e. Credit Memo), so the percentage, tax and taxable amounts are OK.

Note that the tax and taxable amount sign must honor the correspondent c_invoicetax record.
(See testlink test case: "[cashVATe180] Sales Invoice AR Credit Memo (Cash VAT). Partial Payment. Transaction account" for more info)


For fixing previous wrong data, a module script will be available in Cash VAT module 1.0.8 or higher

Mon, 16 Feb 2015 18:04:56 +0100Related to issue 28956: Applied Openbravo's code format
Víctor Martínez Romanos <victor.martinez@openbravo.com> [Mon, 16 Feb 2015 18:04:56 +0100] rev 26023
Related to issue 28956: Applied Openbravo's code format

Mon, 16 Feb 2015 14:35:52 +0530Fixes Issue 28914:Should be an option to use the UOM Standard precision for
Atul Gaware <atul.gaware@openbravo.com> [Mon, 16 Feb 2015 14:35:52 +0530] rev 26022
Fixes Issue 28914:Should be an option to use the UOM Standard precision for
production or not.

Flag is provided in Unit of Measurement window to decided whether ROUNDING is
to be done using StdPrecision or not, Default value is N. Based on the flag
Rounding is done in MA_PRODUCTIONRUN_STANDARD process.

Mon, 16 Feb 2015 18:45:16 +0100related to issue 28912 .class files are missing in last commit
Sandra Huguet <sandra.huguet@openbravo.com> [Mon, 16 Feb 2015 18:45:16 +0100] rev 26021
related to issue 28912 .class files are missing in last commit

Fri, 13 Feb 2015 09:24:33 +0100Fixed bug 28912 update modulescript Issue28591UpdatePSD
Sandra Huguet <sandra.huguet@openbravo.com> [Fri, 13 Feb 2015 09:24:33 +0100] rev 26020
Fixed bug 28912 update modulescript Issue28591UpdatePSD

Modulescript Issue28591UpdatePSD should be updated in order
to fix the payment proposal lines wrongly created because of 28591

Thu, 12 Feb 2015 13:35:34 +0100Related to bug 28896: Missing entry on group by clause
Unai Martirena <unai.martirena@openbravo.com> [Thu, 12 Feb 2015 13:35:34 +0100] rev 26019
Related to bug 28896: Missing entry on group by clause

Wed, 11 Feb 2015 19:01:27 +0100Fixes bug 28896: Purchase Invoices Supplier reference is shown in add payment.
Unai Martirena <unai.martirena@openbravo.com> [Wed, 11 Feb 2015 19:01:27 +0100] rev 26018
Fixes bug 28896: Purchase Invoices Supplier reference is shown in add payment.

A case has been added in AddPaymentOrderInvoicesTransformer to display the Supplier Reference instead of Invoice Number when is configured like that in Organization Info tab, only for Purchase Invoices

Mon, 16 Feb 2015 11:11:14 +0100Fixes issue 28943: DocDate & AccDate in GLJournal could be different
Alvaro Ferraz <alvaro.ferraz@openbravo.com> [Mon, 16 Feb 2015 11:11:14 +0100] rev 26017
Fixes issue 28943: DocDate & AccDate in GLJournal could be different

Document Date and Accounting Date in G/L Journal window and Header tab can now be different

Mon, 16 Feb 2015 17:39:33 +0100fixed bug 28949: bg process can't insert DAL object having doc no column
Asier Lostalé <asier.lostale@openbravo.com> [Mon, 16 Feb 2015 17:39:33 +0100] rev 26016
fixed bug 28949: bg process can't insert DAL object having doc no column

The problem was caused by SetDocumentNoHandler which assumed there was always
a valid request.

After changes to support tomcat 7, this was not the case of bg processes.

The fix return null in this case rather than throwing a NPE.

Wed, 18 Feb 2015 12:40:10 +0000fix for issue 28684 for 3.0PR15Q1
RM packaging bot <staff.rm@openbravo.com> [Wed, 18 Feb 2015 12:40:10 +0000] rev 26015
fix for issue 28684 for 3.0PR15Q1

Fri, 06 Feb 2015 08:29:42 +0100Related to issue 28862
Sandra Huguet <sandra.huguet@openbravo.com> [Fri, 06 Feb 2015 08:29:42 +0100] rev 26014
Related to issue 28862

add warning message when invoiced quantity is higher than delivered
quantity when invoice terms are After Delivery

Fri, 06 Feb 2015 08:17:31 +0100fixed issue 28862 backout changeset d45ee3d2e877
Sandra Huguet <sandra.huguet@openbravo.com> [Fri, 06 Feb 2015 08:17:31 +0100] rev 26013
fixed issue 28862 backout changeset d45ee3d2e877