Fri, 24 Oct 2014 09:07:03 +0200Fixed bug 27972 Landed cost field should be readonly in landed cost tab
Sandra Huguet <sandra.huguet@openbravo.com> [Fri, 24 Oct 2014 09:07:03 +0200] rev 25092
Fixed bug 27972 Landed cost field should be readonly in landed cost tab

Fri, 24 Oct 2014 09:05:56 +0200Related to issue 27913
Sandra Huguet <sandra.huguet@openbravo.com> [Fri, 24 Oct 2014 09:05:56 +0200] rev 25091
Related to issue 27913

fix convertDateToUTC method and match statement force name process

Fri, 24 Oct 2014 09:56:21 +0200Fixes Issue 27963: Set Unit Cost false in LC Adjustments created in Match LC P&E
Unai Martirena <unai.martirena@openbravo.com> [Fri, 24 Oct 2014 09:56:21 +0200] rev 25090
Fixes Issue 27963: Set Unit Cost false in LC Adjustments created in Match LC P&E

Also set as currency of this Landed Cost Adjustment lines the currency of the Landed Cost header.

Fri, 24 Oct 2014 09:38:26 +0200Fixes issue 27957: Grid button don't get stuck after autosaving new record
Augusto Mauch <augusto.mauch@openbravo.com> [Fri, 24 Oct 2014 09:38:26 +0200] rev 25089
Fixes issue 27957: Grid button don't get stuck after autosaving new record

In the fix [1] of this issue [2], a change was made to force reselecting a new record even if it was already selected, because otherwise when a record was created in grid mode while a filter was applied, when the record was saved the selection was lost.

The problem is that that change should only be applied when the editCompletionEvent is 'programmatic'. In the other cases (i.e. 'tab', 'enter', etc), the focus goes to another record, so it did not apply to [2]. In fact when the editCompletion event is not 'programmatic' not only reselecting the record was not needed, but also it caused the grid buttons to get stuck.

[1] https://code.openbravo.com/erp/devel/pi/rev/dfda65fa925f89a21eee64f35d7aadb252c90dab
[2] https://issues.openbravo.com/view.php?id=26702

Thu, 23 Oct 2014 18:36:05 +0200Fixed issue 27946.Add negative correction for basetrx when needed.
Gorka Ion Damián <gorkaion.damian@openbravo.com> [Thu, 23 Oct 2014 18:36:05 +0200] rev 25088
Fixed issue 27946.Add negative correction for basetrx when needed.

In some cases like Price Difference Correction it is possible to have a base
trx that also requires a negative stock correction adjustment. A check is
added to insert an aditional negative correction line for the base transaction
when needed.

Thu, 23 Oct 2014 18:05:43 +0200Related to issue 27713. Removal of unnecessary log
Eduardo Argal Guibert <eduardo.argal@openbravo.com> [Thu, 23 Oct 2014 18:05:43 +0200] rev 25087
Related to issue 27713. Removal of unnecessary log

Thu, 23 Oct 2014 17:04:33 +0200Fixed issue 27947.Use org id instead of object in OBQuery
Gorka Ion Damián <gorkaion.damian@openbravo.com> [Thu, 23 Oct 2014 17:04:33 +0200] rev 25086
Fixed issue 27947.Use org id instead of object in OBQuery

When filtering a OBCriteria or OBQuery by a BaseOBObject after a clear session
can fail if the object is not correctly reattached to the session. Filtering
by its id avoid this issue.

Thu, 23 Oct 2014 16:57:58 +0200Related to Issue 27853: Not any more wrong records created in Costing tab
Unai Martirena <unai.martirena@openbravo.com> [Thu, 23 Oct 2014 16:57:58 +0200] rev 25085
Related to Issue 27853: Not any more wrong records created in Costing tab

Changed the filter by Id in CostAdjustmentUtils.getStockOnTransactionDate(), CostAdjustmentUtils.getValuedStockOnTransactionDate() and AverageCostAdjustment.getRelatedTransactions().

Thu, 23 Oct 2014 13:43:11 +0200Related to issue 27913. Miossing related files
Eduardo Argal Guibert <eduardo.argal@openbravo.com> [Thu, 23 Oct 2014 13:43:11 +0200] rev 25084
Related to issue 27913. Miossing related files

Thu, 23 Oct 2014 13:37:20 +0200Related to issue 27913: Adds comments to method and chnages method name
Eduardo Argal Guibert <eduardo.argal@openbravo.com> [Thu, 23 Oct 2014 13:37:20 +0200] rev 25083
Related to issue 27913: Adds comments to method and chnages method name

Thu, 23 Oct 2014 13:15:37 +0200Fixes bug 27913: System throws error message when user try to match bank statement lines with OB transactions manually
Eduardo Argal Guibert <eduardo.argal@openbravo.com> [Thu, 23 Oct 2014 13:15:37 +0200] rev 25082
Fixes bug 27913: System throws error message when user try to match bank statement lines with OB transactions manually

There was a new method created in OBDateUtils which was asuming parameter date was always in the current date. This was wrong so that chnage is reverted and method is no longer doing that assumption.

Thu, 23 Oct 2014 12:49:47 +0200Fixes issue 27929: Landed Cost correctly manages multicurrency
Unai Martirena <unai.martirena@openbravo.com> [Thu, 23 Oct 2014 12:49:47 +0200] rev 25081
Fixes issue 27929: Landed Cost correctly manages multicurrency

Landed Cost adjustment was being created with currency of transaction instead of Landed Cost Cost currency.
The transaction cost currency was being created on Landed Cost adjustment currency instead of transaction currency.

Thu, 23 Oct 2014 10:49:56 +0200Related to issue 27924
Sandra Huguet <sandra.huguet@openbravo.com> [Thu, 23 Oct 2014 10:49:56 +0200] rev 25080
Related to issue 27924

Filter by organization in query should be by FinancialMgmtPeriodControl

Wed, 22 Oct 2014 13:18:48 +0200Fixes build Build #871 int-dbcons-oracle. Wrong placing of INTO in a query
Eduardo Argal Guibert <eduardo.argal@openbravo.com> [Wed, 22 Oct 2014 13:18:48 +0200] rev 25079
Fixes build Build #871 int-dbcons-oracle. Wrong placing of INTO in a query

Wed, 22 Oct 2014 12:21:54 +0200Related to issue 27887.Boolean filters are advanced criterias
Gorka Ion Damián <gorkaion.damian@openbravo.com> [Wed, 22 Oct 2014 12:21:54 +0200] rev 25078
Related to issue 27887.Boolean filters are advanced criterias

When filtering by a boolean in a grid the criteria received by the datasource
is an AdvancedCriteria. New isInScope method created for boolean fields based
on the version for BigDecimals to cope with this type of criterias.

Wed, 22 Oct 2014 10:57:55 +0200Fixes Bug 27926: Fixed process a Landed Cost with amt different than Matched amt
Unai Martirena <unai.martirena@openbravo.com> [Wed, 22 Oct 2014 10:57:55 +0200] rev 25077
Fixes Bug 27926: Fixed process a Landed Cost with amt different than Matched amt

A condition has been removed from m_lc_cost_chk_trg that was preventing to update m_lc_cost table.

Wed, 22 Oct 2014 10:35:37 +0200Related to issue 27887.Implement filtering by Allocated field.
Gorka Ion Damián <gorkaion.damian@openbravo.com> [Wed, 22 Oct 2014 10:35:37 +0200] rev 25076
Related to issue 27887.Implement filtering by Allocated field.

Wed, 22 Oct 2014 10:24:27 +0200Fixes issue 27713: slow post of goods shipment if there are many storage detail for that product
Eduardo Argal Guibert <eduardo.argal@openbravo.com> [Wed, 22 Oct 2014 10:24:27 +0200] rev 25075
Fixes issue 27713: slow post of goods shipment if there are many storage detail for that product

Second commit required for the function to work in postgres 8.4. Parameter can not be assigned

Wed, 22 Oct 2014 09:04:25 +0200Fixed bug 27924 be able to enter backdatedfrom while creating a costing rule
Sandra Huguet <sandra.huguet@openbravo.com> [Wed, 22 Oct 2014 09:04:25 +0200] rev 25074
Fixed bug 27924 be able to enter backdatedfrom while creating a costing rule

Tue, 21 Oct 2014 18:58:30 +0200Fixes Issue 27925: Match LC Cost Process P&E now processes correctly Matchings
Unai Martirena <unai.martirena@openbravo.com> [Tue, 21 Oct 2014 18:58:30 +0200] rev 25073
Fixes Issue 27925: Match LC Cost Process P&E now processes correctly Matchings

The problem was due to a missing OBDal.getInstance().flush().

Also LCCostMatchFromInvoiceHandler.java action handler has been improved to return correctly error messages.

Tue, 21 Oct 2014 18:48:07 +0200Fixed issue 27887.Set required fields as show in grid true.
Gorka Ion Damián <gorkaion.damian@openbravo.com> [Tue, 21 Oct 2014 18:48:07 +0200] rev 25072
Fixed issue 27887.Set required fields as show in grid true.

Tue, 21 Oct 2014 18:40:15 +0200Fixes bug 27713, 27712
Eduardo Argal Guibert <eduardo.argal@openbravo.com> [Tue, 21 Oct 2014 18:40:15 +0200] rev 25071
Fixes bug 27713, 27712

Adds new index for qtyonhand qtyorderonhand to storage detail table.
Changes m_attributesetinstance_id to not null for M_STORAGE_DETAIL, and M_RESERVATION_STOCK tables as almost all records where already using '0' instead of null.
Removes unnecessary coalesce

Tue, 21 Oct 2014 18:07:45 +0200Fixed bug 27252: Invoice lines products don't belong to the org. header tree.
Víctor Martínez Romanos <victor.martinez@openbravo.com> [Tue, 21 Oct 2014 18:07:45 +0200] rev 25070
Fixed bug 27252: Invoice lines products don't belong to the org. header tree.

Sales invoice line product selector's HQL query base table was changed to Product table so the implicit filter by accessible Organizations is now applied for Product instead of ProductPrice.
Now the selector filters by products with organization in the same tree of the organization in the header. This change also affects other windows where this selector is used, like Purchase Invoice and APRM GL Item P&E windows.

Tue, 21 Oct 2014 16:18:05 +0200Fixes issue 27918: Removes tree structure from table that is not a tree
Augusto Mauch <augusto.mauch@openbravo.com> [Tue, 21 Oct 2014 16:18:05 +0200] rev 25069
Fixes issue 27918: Removes tree structure from table that is not a tree

In the initial changeset for fixing 27918, the tree type of the FinancialMgmtAccountingReport table was set to null because that table is not really a tree. The problem was that the cleaning up of the table was not complete, the Is Tree flag should be set to false, and its Tree Table Category subtab should be empty. This has been done now.

The Initial Client Setup was failing because of the incomplete cleanup. The Tree Table Category of FinancialMgmtAccountingReport had a record called Accounting Report, which is the same name as the tree of the FinancialMgmtAccountingRptElement table.

Tue, 21 Oct 2014 13:55:05 +0200Fixes issue 27853: Manual Cost Correction Cost adjustments are not properly created
Unai Martirena <unai.martirena@openbravo.com> [Tue, 21 Oct 2014 13:55:05 +0200] rev 25068
Fixes issue 27853: Manual Cost Correction Cost adjustments are not properly created

Tue, 21 Oct 2014 13:40:33 +0200Fixed bug 27461: Sales invoice Dimensional Report improvements for Credit Memo
Víctor Martínez Romanos <victor.martinez@openbravo.com> [Tue, 21 Oct 2014 13:40:33 +0200] rev 25067
Fixed bug 27461: Sales invoice Dimensional Report improvements for Credit Memo

In case of credit memo documents, the following columns in the report should reflect a negative number:
Quantity
Amount
Cost
Profit
Margin

Before this fix, only the Amount column reflected a negative number. Besides the Profit and Margin were wrongly calculated in credit memo scenario, because they are based on the Cost which had a wrong possitive sign for credit memos.
After this fix all these columns show a negative number in case of credit memo. Thus the Profit and Margin are properly calculated based on the right sign of the Cost column.

Note that the Margin formula has been also updated to reflect a negative sign in case the Profit is also negative:
Profit = Amount - Cost
Margin = 100 * ((Profit) / Amount) * sign(Profit)

That means the Margin will now be shown as a negative percentage for credit memo and negative invoices.

Tue, 21 Oct 2014 13:09:51 +0200Fixes issue 27918, fixes issue 27930. Prevents breaking the int-inc tests
Augusto Mauch <augusto.mauch@openbravo.com> [Tue, 21 Oct 2014 13:09:51 +0200] rev 25066
Fixes issue 27918, fixes issue 27930. Prevents breaking the int-inc tests

The problem was that due to this design defect [1], the oracle and postgres int-inc tests were failing. This is because a value 'AR' was being set to the treetype of a table and then being set to null in other table whose treetype was also 'AR'. Treetype has a unique constraint that was enabled when the application data was updated, so the constraint failed.

To prevent this error, the treetype of the second table is going to be set to null in a modulescript, that is executed before updating the application data.

[1] https://issues.openbravo.com/view.php?id=12577

Tue, 21 Oct 2014 11:28:25 +0200Fixes issue 27918: User Defined Accounting Report Setup shows tree view
Augusto Mauch <augusto.mauch@openbravo.com> [Tue, 21 Oct 2014 11:28:25 +0200] rev 25065
Fixes issue 27918: User Defined Accounting Report Setup shows tree view

The problem was that the tree configuration previous to the new tree implementation was wrong. The Table table had a field called Type Area which was originally used to specify the Tree type of the table. The FinancialMgmtAccountingRptElement table had this field empty, and instead the FinancialMgmtAccountingReport had this field set to Accounting Report, which is the value that should have been assigned to FinancialMgmtAccountingRptElement.

The configuration of the new implementation was done based on the Tree Type field, so it was wrong for the FinancialMgmtAccountingRptElement table. Now it has been properly done (it has been flagged as Is Tree, a record has been added to the Table Tree Category subtab and a value has been selected in the Table Tree Category field of the Tab tab.

Also, a module script has been modified to fix the data of ad_tree. The ad_tree table has a column called ad_table_id, which points to the table that the tree belongs to. The accounting report tree was mistakenly pointing to FinancialMgmtAccountingReport, and the updated modulescript fixes it so that now it points to FinancialMgmtAccountingRptElement.

Mon, 20 Oct 2014 18:54:45 +0200Fixes issue 27919: Match Landed Cost P&E raises an error in Postgres 8.4
Unai Martirena <unai.martirena@openbravo.com> [Mon, 20 Oct 2014 18:54:45 +0200] rev 25064
Fixes issue 27919: Match Landed Cost P&E raises an error in Postgres 8.4

Mon, 20 Oct 2014 18:39:02 +0200Related to issue 27913 Add convertToUTC to obdateutils
Sandra Huguet <sandra.huguet@openbravo.com> [Mon, 20 Oct 2014 18:39:02 +0200] rev 25063
Related to issue 27913 Add convertToUTC to obdateutils