Tue, 23 Dec 2014 17:12:06 +0100Fixed issue 28376: Copyright year of ERP code for 2015 is not updated.
Naroa Iriarte <naroa.iriarte@openbravo.com> [Tue, 23 Dec 2014 17:12:06 +0100] rev 25597
Fixed issue 28376: Copyright year of ERP code for 2015 is not updated.

Some files have been updated with the proper year.

Wed, 24 Dec 2014 11:11:43 +0100Fixes issue 28379: Value from field is not lost after setting it with a process
Augusto Mauch <augusto.mauch@openbravo.com> [Wed, 24 Dec 2014 11:11:43 +0100] rev 25596
Fixes issue 28379: Value from field is not lost after setting it with a process

This issue was caused from a bug in the OBViewGrid.processFICReturn function. There was some code that meant to save in the grid the value of fields that were not being shown in the grid, and that therefore were not returned by the datasource when the grid was loaded. The faulty condition to check if the value of the field was present in the grid was the following:

if (field && !this.getRecord(rowNum)[field.property]) {

This condition is not proper because it does not check if the field is visible in the grid or not. This condition will evaluate to true if the value of that field is null, even if the field is being shown in the grid. Due to this when the value of the Storage Bin field was erased, its new null value was stored in the list of edited values of the grid, and this value took precedence over the Storage Bin value picked in the process.

To fix this, the condition has been improved to check if the field is actually being shown in the grid.

Wed, 24 Dec 2014 14:36:24 +0530Related to issue 28440: Code review changes
Pandeeswari Ramakrishnan <pandeeswari.ramakrishnan@openbravo.com> [Wed, 24 Dec 2014 14:36:24 +0530] rev 25595
Related to issue 28440: Code review changes

If the 'Cancel' button is clicked, the pop up should be closed irrespective
of mandatory fields are filled or not.

Tue, 23 Dec 2014 13:24:32 +0100Fixed bug 28440 Require at least one value flag for instance atributtes is not working
Sandra Huguet <sandra.huguet@openbravo.com> [Tue, 23 Dec 2014 13:24:32 +0100] rev 25594
Fixed bug 28440 Require at least one value flag for instance atributtes is not working

If Require at least one value flag is true Lot/Serial Number/Expiration Date
should be mandatory in Attribute Set selector

Tue, 28 Oct 2014 21:23:23 -0500Fixed bug 27570: The Business Partner should be filled in the Payment Out Lines
Fernando Soto <fernando.soto@peoplewalking.com> [Tue, 28 Oct 2014 21:23:23 -0500] rev 25593
Fixed bug 27570: The Business Partner should be filled in the Payment Out Lines

Modified APRM_GEN_PAYMENTSCHEDULE_INV and APRM_GEN_PAYMENTSCHEDULE_ORD to set the business partner to the payment_schedule_detail.
Also added a Modulescript to correct previously entered data.

Tue, 23 Dec 2014 11:18:30 +0100Related to issue 19728: Do more JS code formatting
David Baz Fayos <david.baz@openbravo.com> [Tue, 23 Dec 2014 11:18:30 +0100] rev 25592
Related to issue 19728: Do more JS code formatting

Tue, 23 Dec 2014 10:00:03 +0100fixed bug 28472: multi requests to datasource in big FK filter drop down
Asier Lostalé <asier.lostale@openbravo.com> [Tue, 23 Dec 2014 10:00:03 +0100] rev 25591
fixed bug 28472: multi requests to datasource in big FK filter drop down

Setting drawAllMaxCells to 0 makes SC to only fetch one page

Mon, 22 Dec 2014 19:14:54 +0100Fixes issue 28432: HQLDataSourceService manages translations properly
Augusto Mauch <augusto.mauch@openbravo.com> [Mon, 22 Dec 2014 19:14:54 +0100] rev 25590
Fixes issue 28432: HQLDataSourceService manages translations properly

There were several problems related with the handling of translatable columns in the HQLDataSourceService class:
- If there was a translation installed, the query done to retrieve some data that contained a translatable column threw an exception. This was because the WHERE constant of the inner query done to retrieve the translated string was being removed. The regex that handled this has been improved so that now only the leading WHERE constant is removed.
- After fixing that the query no longer threw an exception but it did not return the proper results. This happened because the query was not properly built, due to not using the entity alias in the query builder.
- After that, the translated string was not being shown when the filter drop down was populated. This has been fixed by changing the way this information is obtained. Previously only the id and the (not translated) identifier was obtained using the query. Now the whole BaseOBObject is retrieved, and it is used later to obtain its id and its potentially tranlated identifier.

Mon, 22 Dec 2014 19:12:07 +0100Fixes Issue 26511: Display correct error message while deleting the orderline.
Unai Martirena <unai.martirena@openbravo.com> [Mon, 22 Dec 2014 19:12:07 +0100] rev 25589
Fixes Issue 26511: Display correct error message while deleting the orderline.

The problem on this issue is that the trigger is not able to delete the related reservation of the orderline and the given error is displayed. So in this case the error message displayed has been improved to warn the user that needs to remove the reservation manually before deleting the Sales Order Line.

Mon, 22 Dec 2014 18:30:10 +0100Fixes Issue 28417: Warehouse in Return Material Receipt properly filtered.
Unai Martirena <unai.martirena@openbravo.com> [Mon, 22 Dec 2014 18:30:10 +0100] rev 25588
Fixes Issue 28417: Warehouse in Return Material Receipt properly filtered.

The warehouse selector in the Return Material Receipt window is not filtering any more by warehouses on hand. The filter expression on On Hand Warehouse selector has been modified to fix this problem.

Mon, 22 Dec 2014 17:21:27 +0100Related to Issue 27831: Add copyright header to new file
Unai Martirena <unai.martirena@openbravo.com> [Mon, 22 Dec 2014 17:21:27 +0100] rev 25587
Related to Issue 27831: Add copyright header to new file

Mon, 22 Dec 2014 10:17:32 +0100Fixes bug 28461: Fix Backdated From field should be equal to Starting Date field
Unai Martirena <unai.martirena@openbravo.com> [Mon, 22 Dec 2014 10:17:32 +0100] rev 25586
Fixes bug 28461: Fix Backdated From field should be equal to Starting Date field

Fix Backdated From date column reference in Costing Rule has been changed from Date to DateTime.

Mon, 22 Dec 2014 12:06:48 +0100Related with issue 28454: Add comments to function
Augusto Mauch <augusto.mauch@openbravo.com> [Mon, 22 Dec 2014 12:06:48 +0100] rev 25585
Related with issue 28454: Add comments to function

Tue, 02 Dec 2014 09:27:28 -0500Fixed bug 27323: Frecuency field in Quality Control Point has wrong reference
Fernando Soto <fernando.soto@peoplewalking.com> [Tue, 02 Dec 2014 09:27:28 -0500] rev 25584
Fixed bug 27323: Frecuency field in Quality Control Point has wrong reference

Change the reference to Absolute Time

Mon, 22 Dec 2014 09:53:28 +0100Fixed bug 27831: Credit to Use grid in Add Payment button can't be modularized.
Unai Martirena <unai.martirena@openbravo.com> [Mon, 22 Dec 2014 09:53:28 +0100] rev 25583
Fixed bug 27831: Credit to Use grid in Add Payment button can't be modularized.

Created CreditToUseTransformer class and modified the Aprm_Credit_To_Use HQL.

Mon, 10 Nov 2014 00:18:53 -0500Fixed bug 27720: Remove Generate Invoice from receipt field from Goods Shipment
Fernando Soto <fernando.soto@peoplewalking.com> [Mon, 10 Nov 2014 00:18:53 -0500] rev 25582
Fixed bug 27720: Remove Generate Invoice from receipt field from Goods Shipment

De-activated field "Generate Invoice from receipt" from Goods Shipment window

Fri, 19 Dec 2014 15:07:05 +0100Related to issue 28289: Improve @FixBackdateFromBeforeStartingDate@ message
Unai Martirena <unai.martirena@openbravo.com> [Fri, 19 Dec 2014 15:07:05 +0100] rev 25581
Related to issue 28289: Improve @FixBackdateFromBeforeStartingDate@ message

Fri, 19 Dec 2014 13:15:14 +0100Related to bug 28289:Do @FixBackdateFromBeforeStartingDate@ later in the process.
Unai Martirena <unai.martirena@openbravo.com> [Fri, 19 Dec 2014 13:15:14 +0100] rev 25580
Related to bug 28289:Do @FixBackdateFromBeforeStartingDate@ later in the process.

Check the validation at the end of the Costing Rule Validation process when fixbackdated from and starting date are being initialized.
Also update the error message displayed.

Fri, 19 Dec 2014 12:01:16 +0100Related to bug 28389: If is no diff in match LCC leave LCC amount as matchedAmt
Unai Martirena <unai.martirena@openbravo.com> [Fri, 19 Dec 2014 12:01:16 +0100] rev 25579
Related to bug 28389: If is no diff in match LCC leave LCC amount as matchedAmt

Fri, 19 Dec 2014 09:45:01 +0100fixed bug 28454: can't nullify fields when 1st edition is in grid
Asier Lostalé <asier.lostale@openbravo.com> [Fri, 19 Dec 2014 09:45:01 +0100] rev 25578
fixed bug 28454: can't nullify fields when 1st edition is in grid

When the first edition in a tab was done in grid view, it was not possible to
nullify any field.

The problem was null values are only sent to backend for fields present in the
standard view. To get those fields form.getFields() method was invoked, in order
to improve performance, form fields are only loaded when the form is opened 1st
time, so if the form view was not opened before this check, all nulls were
removed from the request. As this was cached, all further editions were using this
incorrect cache.

The fix consists in not using form.getFields() methods but to get the fields from
view.formFields which is guaranteed to be loaded one the window is opened.

Thu, 18 Dec 2014 18:36:08 +0100Related to Issue 28389: Fixed Posting of LC Cost with Invoice Line
Unai Martirena <unai.martirena@openbravo.com> [Thu, 18 Dec 2014 18:36:08 +0100] rev 25577
Related to Issue 28389: Fixed Posting of LC Cost with Invoice Line

While processing a Landed Cost with an Invoice in a Landed Cost Cost it, if the invoice has an exchange rate different from the system, a new Cost Adjustment is created with that difference between the rates. But this difference it was not taking into account while setting the matched amount in Landed Cost Cost, so the Post process it was not working well.

Thu, 18 Dec 2014 14:33:34 +0100[Costing]Related to issue 28333 Data needed in demodata for CostAdjustment test
Alvaro Ferraz <alvaro.ferraz@openbravo.com> [Thu, 18 Dec 2014 14:33:34 +0100] rev 25576
[Costing]Related to issue 28333 Data needed in demodata for CostAdjustment test

Thu, 18 Dec 2014 14:18:27 +0100[Costing]Related to issue 28333 Data needed in demodata for CostAdjustment test
Alvaro Ferraz <alvaro.ferraz@openbravo.com> [Thu, 18 Dec 2014 14:18:27 +0100] rev 25575
[Costing]Related to issue 28333 Data needed in demodata for CostAdjustment test

Enable M_LandedCost, M_LC_Cost and M_LC_Type tables in sampledata dataset

Thu, 20 Nov 2014 17:27:26 +0530Fixes Issue 28092:"create invoices from orders" form should consider order
Atul Gaware <atul.gaware@openbravo.com> [Thu, 20 Nov 2014 17:27:26 +0530] rev 25574
Fixes Issue 28092:"create invoices from orders" form should consider order
lines partially delivered, when "customer schedule after delivery"

In case of invoice rule as Customer Schedule After Delivery in Order,
Create Invoice From Orders considers Orders Partially Delivered
and not yet invoiced.

Thu, 18 Dec 2014 13:29:41 +0100Fixes Issue 28450: Costing Migration Process does not fail any more.
Unai Martirena <unai.martirena@openbravo.com> [Thu, 18 Dec 2014 13:29:41 +0100] rev 25573
Fixes Issue 28450: Costing Migration Process does not fail any more.

In the function insertTrxCosts() in CostingMigrationProcess.java while inserting m_transaction_cost records the column dateacct is filled in the following way:
* If the transaction is a goods shipment line, with the accounting date of the Shipment.
* If the transaction is not a goods shipment line, with the movement date of the transaction.

Thu, 18 Dec 2014 10:45:23 +0100fixed bug 28443: Exception not handled after upload a non supported image
Asier Lostalé <asier.lostale@openbravo.com> [Thu, 18 Dec 2014 10:45:23 +0100] rev 25572
fixed bug 28443: Exception not handled after upload a non supported image

There were unhandled exceptions when uploading images, when in this case openbravo.log
included info but this was not displayed to user.

Now any exception occurred during image upload is caught and displayed in UI.

Wed, 17 Dec 2014 21:45:17 +0100Related to issue 28289: Little code review
Unai Martirena <unai.martirena@openbravo.com> [Wed, 17 Dec 2014 21:45:17 +0100] rev 25571
Related to issue 28289: Little code review

Wed, 17 Dec 2014 13:56:07 +0100Fixes Bug 28289: Manage null start and fix backdated from dates in Costing Rule.
Unai Martirena <unai.martirena@openbravo.com> [Wed, 17 Dec 2014 13:56:07 +0100] rev 25570
Fixes Bug 28289: Manage null start and fix backdated from dates in Costing Rule.

Several things have been implemented in this changeset:
* A new Process Definition called 'Validate Costing Rule' has been created that replaces the old Process with the same name. This has been done to be able to use the new capabilities that these new kind of processes offer, like validations before executing the process and the posibility to show a confirmation popup. The new process action handler calls the old process java class, so all existing modules that may call or extend the old class they will continue working.
* The CostingRuleEventHandler has been removed, because it was doing a wrong validation and the fix backdated from date is managed in the CostingRuleProcess.
* 2 new functions have been created in CostingUtils ('getCostingRuleStartingDate' and 'getCostingRuleFixBackdatedFrom') that they return '01/01/1900' as costing rule Starting Date or Fix Backdated From when these are null. This has been done because in some places when these dates are null the application was giving an error. So, every time these dates are retrieved, these functions will be called.
* A validation has been added before executing the new Action Handler 'Validate Costing Rule' that shows a popup when transactions without cost calculated are found in closed periods. It asks for confirmation to proceed or the option to cancel.

Wed, 17 Dec 2014 18:33:43 +0100Fixes Bug 28441:Validate Costing Rule doesn't fail if there prev transactions.
Unai Martirena <unai.martirena@openbravo.com> [Wed, 17 Dec 2014 18:33:43 +0100] rev 25569
Fixes Bug 28441:Validate Costing Rule doesn't fail if there prev transactions.

The process was failing while trying to create Transaction Cost records in initializeOldTrx and updateInventoriesCostAndProcessInitInventories processes. It was not setting any value to accounting date column, which is mandatory. This column has been populated in the following way: If the related transaction is a shipment the accounting date of the shipment is assigned, if not, the movement date of the transaction will be assigned.

Wed, 17 Dec 2014 17:30:22 +0100Related to issue 27580
Sandra Huguet <sandra.huguet@openbravo.com> [Wed, 17 Dec 2014 17:30:22 +0100] rev 25568
Related to issue 27580