Thu, 28 Jan 2016 17:22:21 +0100fixes issue 32007: combo/selector with a callout can cause a double FIC request
Carlos Aristu <carlos.aristu@openbravo.com> [Thu, 28 Jan 2016 17:22:21 +0100] rev 28547
fixes issue 32007: combo/selector with a callout can cause a double FIC request

If a form redrawal was fired after selecting a value of a combo/selector with a callout, a double request to the datasource was being performed due to asynchrony problems. An example of this scenario is when after selecting a value of a combo/selector with a callout, the form needs to be scrolled (overflow) because new fields are displayed in the form (for example because this fields have a display logic).

This kind of scenarios are now detected in the change event of the OBSelectorItem class, when the value to be updated is null but at the same time the pick list already contains a selected value.

Mon, 25 Jan 2016 13:07:24 +0100Fixes issue 31979: Costing Migration Process does not set isprocessed flag
Alvaro Ferraz <alvaro.ferraz@openbravo.com> [Mon, 25 Jan 2016 13:07:24 +0100] rev 28546
Fixes issue 31979: Costing Migration Process does not set isprocessed flag

Set transaction isprocessed flag as true in updateTrxLegacyCosts, updateWithZeroCostRemainingTrx and calculateCosts methods in CostingMigrationProcess class.
Set also transaction isprocessed flag as true in updateInventoriesCostAndProcessInitInventories method in CostingRuleProcess class.

Tue, 26 Jan 2016 12:57:37 +0100related to issue 31856: remove comment and add missing javadoc descriptions
Carlos Aristu <carlos.aristu@openbravo.com> [Tue, 26 Jan 2016 12:57:37 +0100] rev 28545
related to issue 31856: remove comment and add missing javadoc descriptions

Tue, 26 Jan 2016 10:30:45 +0100fixes issue 31856: allow multiple 'Tree and node image' for same client
Carlos Aristu <carlos.aristu@openbravo.com> [Tue, 26 Jan 2016 10:30:45 +0100] rev 28544
fixes issue 31856: allow multiple 'Tree and node image' for same client

The Account Tree window was using the ADTreeDatasourceService which asumes that a table is always represented by the same AD_Tree. In this case, two account trees (c_elementvalue table) can have different base trees to display their information. In order to support this scenario, a new datasource has been created: AccountTreeDatasourceService which allows to select the correct base tree on each case.

Mon, 25 Jan 2016 18:46:51 +0100fixes issue 31901: can't edit decimal value with observer after manual edition
Carlos Aristu <carlos.aristu@openbravo.com> [Mon, 25 Jan 2016 18:46:51 +0100] rev 28543
fixes issue 31901: can't edit decimal value with observer after manual edition

The decimal fields were using a property called textualValue to prevent rounding errors. This is because when instantiating a BigDecimal using a double value, it converts the entire precision of the double. Then, on the server, the textual value was translated back to a number using BigDecimal avoiding the rounding problem.

In this case the problem was caused because the textualValue was not being synchronized properly with the current value. To solve the problem, the textualValue property is not longer used and the textual conversion is done in the server: using the BigDecimal.valueOf method the double value is converted to a string internally, and finally that value is converted into a BigDecimal.

Thus, we do not need to worry about keeping textualValue synchronized and the double value is rounded properly using BigDecimal.valueOf()

Thu, 21 Jan 2016 14:27:39 +0100Fixes issue 31972: Wrong cost calculation in Costing Migration Process
Alvaro Ferraz <alvaro.ferraz@openbravo.com> [Thu, 21 Jan 2016 14:27:39 +0100] rev 28542
Fixes issue 31972: Wrong cost calculation in Costing Migration Process

HQL in insertTrxCosts method in CostingMigrationProcess class was doing an inner join between m_transaction and m_inoutline instead of a left join.

Mon, 25 Jan 2016 10:17:14 +0100Related with issue 31965: It is possible to skip the PLSQL standardization
Augusto Mauch <augusto.mauch@openbravo.com> [Mon, 25 Jan 2016 10:17:14 +0100] rev 28541
Related with issue 31965: It is possible to skip the PLSQL standardization

A parameter has been added to SystemService.getModelFromDatabase to specify whether the PLSQL code standardization should be done.

Thu, 21 Jan 2016 16:52:52 +0100Related to issue 31580: Reduced Java Heap Usage even more
Víctor Martínez Romanos <victor.martinez@openbravo.com> [Thu, 21 Jan 2016 16:52:52 +0100] rev 28540
Related to issue 31580: Reduced Java Heap Usage even more

DocFINFinAccTransaction and DocFINPayment:
+ Avoid storing useless objects like ps and pd, and replaced by String Ids, so we can safely clear the Hibernate session
+ Save cInvoiceId when loading lines in field provider so it's available latter on when loading the document lines, thus we avoid an extra query to the database to get the invoice from the payment detail
+ Forces a session clear every 100 records when working with the payment details. This is only possible because DAL objects are not stored anywhere.

DocLine_FINFinAccTransaction and DocLine_FINPayment:
+ Declare a String invoiceId parameter instead of using an Invoice object. This improves the memory consumption and allows to manage external session clears when required.
+ Declare as deprecated all the methods that used the invoice object and adapt the getInvoice() to be backward compatible (returns the invoice object is previously declared in the object, or a new object based on the invoiceId)
+ For DocLine_FINPayment only, adapted the Order object usage following the same logic.

FIN_Utility.getOrderedPaymentDetailList() query uses an inner join to the FPSD because having a linked FPSD is a requirement in the accounting classes.


Note that DocFINReconciliation class should be also adapted following the same logics described above. However, this class would require deeper refactor mainly because of the attribute Set<FIN_FinaccTransaction> transactionsToBePosted, that avoids safely session clears.

Fri, 22 Jan 2016 08:11:32 +0100[Product Services] Merged from Pi
Aaron Calero <aaron.calero@openbravo.com> [Fri, 22 Jan 2016 08:11:32 +0100] rev 28539
[Product Services] Merged from Pi

Wed, 20 Jan 2016 11:58:16 +0100[Product Services] Merged from Pi
Aaron Calero <aaron.calero@openbravo.com> [Wed, 20 Jan 2016 11:58:16 +0100] rev 28538
[Product Services] Merged from Pi