Wed, 04 Mar 2015 18:06:07 +0100Fixes issue 0029132: Internal cosumption line can not be saved,
Jon Alegría <jon.alegria@openbravo.com> [Wed, 04 Mar 2015 18:06:07 +0100] rev 26122
Fixes issue 0029132: Internal cosumption line can not be saved,
because unit is not filled when attribute set in product setup
is empty

Wed, 04 Mar 2015 14:50:57 +0000CI: merge back from main
RM packaging bot <staff.rm@openbravo.com> [Wed, 04 Mar 2015 14:50:57 +0000] rev 26121
CI: merge back from main

Wed, 04 Mar 2015 14:30:40 +0000CI: update AD_MODULE to version 26117
RM packaging bot <staff.rm@openbravo.com> [Wed, 04 Mar 2015 14:30:40 +0000] rev 26120
CI: update AD_MODULE to version 26117

Wed, 04 Mar 2015 15:01:42 +0100Related with issue 28842: Improves javadoc of checkReadableAccess method
Augusto Mauch <augusto.mauch@openbravo.com> [Wed, 04 Mar 2015 15:01:42 +0100] rev 26119
Related with issue 28842: Improves javadoc of checkReadableAccess method

Thu, 26 Feb 2015 13:45:06 +0100Fixed issue 28842: There are problems to handle attachments.
Naroa Iriarte <naroa.iriarte@openbravo.com> [Thu, 26 Feb 2015 13:45:06 +0100] rev 26118
Fixed issue 28842: There are problems to handle attachments.

There were two problems:
First: When storing an attachment in the database (c_file table), the current
organization of the user was used instead of the organization of the document where the
file is being attached to. The aim of this fix is to take the value of the organization
of the attached document instead of the current user organization.
Second: When an attachment was created with an organization and after that, the
organization of the document was changed, it was not possible to download it, update it nor delete
it with a user who does not have access to the organization used to create the attachment.

To fix the first part, a new field that stores the document organization has been added to the canvas
of the OBAttachmentsSectionItem class in the fillAttachments function. After that the
field is sent as a param in the request, and can be used in the TabAttachments.java class
to be included to create the new record in c_file.

To fix the second part, the way the attachments are retrieved in the TabAttachments and in the
AttachmentsAH classes has been modified. Now the automated organization filter is disabled,
so the organization of the attachment is not taken into accout. It is needed that the user has at
least readable access to the document's organization for downloading, deleting or editing its attachments
a new method has been added to the SecurityChecker class for checking this.

Tue, 03 Mar 2015 19:14:50 +0100Fixes issue 29113: BigDecimal is used to prevent rounding error
Augusto Mauch <augusto.mauch@openbravo.com> [Tue, 03 Mar 2015 19:14:50 +0100] rev 26117
Fixes issue 29113: BigDecimal is used to prevent rounding error

There was a problem with javascript decimal precision that was affecting the way we round numbers using the OB.Utilities.Number.roundJSNumber. For instance, if this is 0.145*100 is evaluated in the javascr
ipt console, the result was 14.499999999999998, not 14.5.

Now the OB.Utilities.Number.roundJSNumber uses BigDecimal to overcome this precision error. This is the command used not to round a number:

parseFloat(new BigDecimal(num).round(dec,BigDecimal.prototype.ROUND_HALF_UP));

Tue, 03 Mar 2015 21:33:25 +0000CI: merge back from main
RM packaging bot <staff.rm@openbravo.com> [Tue, 03 Mar 2015 21:33:25 +0000] rev 26116
CI: merge back from main

Tue, 03 Mar 2015 21:16:06 +0000CI: update AD_MODULE to version 26114
RM packaging bot <staff.rm@openbravo.com> [Tue, 03 Mar 2015 21:16:06 +0000] rev 26115
CI: update AD_MODULE to version 26114

Tue, 03 Mar 2015 16:03:04 +0100Related to issue 28819 place the description in the correct field
Sandra Huguet <sandra.huguet@openbravo.com> [Tue, 03 Mar 2015 16:03:04 +0100] rev 26114
Related to issue 28819 place the description in the correct field

Tue, 03 Mar 2015 15:08:08 +0000CI: merge back from main
RM packaging bot <staff.rm@openbravo.com> [Tue, 03 Mar 2015 15:08:08 +0000] rev 26113
CI: merge back from main

Tue, 03 Mar 2015 14:48:18 +0000CI: update AD_MODULE to version 26111
RM packaging bot <staff.rm@openbravo.com> [Tue, 03 Mar 2015 14:48:18 +0000] rev 26112
CI: update AD_MODULE to version 26111

Mon, 16 Feb 2015 12:05:59 +0100Fixes issue 28290: Performance problem in SL_TaxCategory_Org callout
Alvaro Ferraz <alvaro.ferraz@openbravo.com> [Mon, 16 Feb 2015 12:05:59 +0100] rev 26111
Fixes issue 28290: Performance problem in SL_TaxCategory_Org callout

Changed SL_TaxCategory_Org, now executes a query against ProductCategory only one time instead of two times, retrieving only the one needed result

Mon, 02 Mar 2015 19:31:04 +0000CI: merge back from main
RM packaging bot <staff.rm@openbravo.com> [Mon, 02 Mar 2015 19:31:04 +0000] rev 26110
CI: merge back from main

Mon, 02 Mar 2015 19:14:01 +0000CI: update AD_MODULE to version 26102
RM packaging bot <staff.rm@openbravo.com> [Mon, 02 Mar 2015 19:14:01 +0000] rev 26109
CI: update AD_MODULE to version 26102

Mon, 02 Mar 2015 16:15:36 +0100Related to issue 19728: Do more JS code formatting
David Baz Fayos <david.baz@openbravo.com> [Mon, 02 Mar 2015 16:15:36 +0100] rev 26108
Related to issue 19728: Do more JS code formatting

Mon, 02 Mar 2015 13:59:01 +0100fixed issue 26794: some bg processes are restarted on Tomcat start
Asier Lostalé <asier.lostale@openbravo.com> [Mon, 02 Mar 2015 13:59:01 +0100] rev 26107
fixed issue 26794: some bg processes are restarted on Tomcat start

Processes sheduled to be run immediatelly or executed from a button in the toolbar,
that were in execution when Tomcat was stopped, were re-started next time Tomcat
was started again.

In these 2 cases now the process requests are marked as 'System Restart' not
rescheduling them again.

Mon, 02 Mar 2015 15:03:54 +0100Related to issue 29103: Exclude the vendor directory from the jsLint check list
Rafa Alonso <rafael.alonso@openbravo.com> [Mon, 02 Mar 2015 15:03:54 +0100] rev 26106
Related to issue 29103: Exclude the vendor directory from the jsLint check list

The problem is that external libs do not follow javascript linter rules

In this case, the non-minified javascript file has been edited to be linter compliant

Fri, 20 Feb 2015 09:46:32 +0100Fixes issue 28817: OutOfMemory importing bank statement using the csv importer
Alvaro Ferraz <alvaro.ferraz@openbravo.com> [Fri, 20 Feb 2015 09:46:32 +0100] rev 26105
Fixes issue 28817: OutOfMemory importing bank statement using the csv importer

ScrollableResults object, used to scrolls OBQuery of business partners when importing bank statements, was directly closed to release resources, between each line's iteration of the csv file. This change avoids the memory overusing, so now it is possible to import a csv file with 4000 lines or more. Also, OBCriteria has been changed into Query in order to use arryas instead of DAL objects what reduces the memory usage.

Mon, 02 Mar 2015 13:45:56 +0100Fixes bug 29097: A menu tree node can be moved with a template in development
Augusto Mauch <augusto.mauch@openbravo.com> [Mon, 02 Mar 2015 13:45:56 +0100] rev 26104
Fixes bug 29097: A menu tree node can be moved with a template in development

When the Openbravo Trees were reimplemented [1], there was a problem reimplementing the logic done when a Menu tree item is moved. Before the reimplementation, it was possible to move a menu tree item if the module it belonged to was in development or if there was any template module in development. The reimplementation did not take into account the templates, so from then on it has not been possible to moved menu tree nodes having a template in development.

To fix this, templates are taken into accout in the MenuTreeOperationManager class.

[1] https://issues.openbravo.com/view.php?id=25906

Tue, 24 Feb 2015 12:33:15 -0500Fixed bug 28948: Orders Awaiting Delivery report do not show well the Stock Qtty
Reinaldo Guerra <reinaldo.guerra@peoplewalking.com> [Tue, 24 Feb 2015 12:33:15 -0500] rev 26103
Fixed bug 28948: Orders Awaiting Delivery report do not show well the Stock Qtty

Orders Awaiting Delivery report's query, was not obtaining correctly the Quantity in Stock, due to a wrong comparison with the value of the attribute set of products in order's line, when it is seted as null.
To avoid this, the report's sql query was changed to compare the attribute set values of the storage detail between them, if the order's lines product has not an attribute set value defined. In other case, are compared the attribute set values of the order's line and the storage detail.
Now the product's stock quantity is correctly shown.

Mon, 02 Mar 2015 12:22:20 +0100fixed issue 27315: Slow query for interrupted bg processes on tomcat start
Asier Lostalé <asier.lostale@openbravo.com> [Mon, 02 Mar 2015 12:22:20 +0100] rev 26102
fixed issue 27315: Slow query for interrupted bg processes on tomcat start

On Tomcat start, background processes that were in execution are updated to change
their status from 'Processing' to 'System Restart'.

This query does a sequential scan on ad_process_run which can be slow if there are
many records.

This fix:
* Adds a filter on STATUS column which is indexed. The amount of processes in PRC
status is expected to be small (specially comapring with the total rows in this
table), so indexed scan should be used instead of sequential scan.
* Adds log to inform about the number of executions marked as 'System Restart'

Wed, 18 Feb 2015 21:38:42 +053028772: Commission payment details are duplicated if the invoice is paid in two
Atul Gaware <atul.gaware@openbravo.com> [Wed, 18 Feb 2015 21:38:42 +0530] rev 26101
28772: Commission payment details are duplicated if the invoice is paid in two
different months

In case of BasisType = Fully Paid Documents and BasisAmt = NetAmount,
Commission detail amount is calculated as per percentage of invoice schedule
amount with respect to total invoice amount based on payment terms lines if
exists any.

Mon, 02 Mar 2015 10:56:15 +0100Fixes issue 28754: Context info is properly sent for selectors in P&E grids
Augusto Mauch <augusto.mauch@openbravo.com> [Mon, 02 Mar 2015 10:56:15 +0100] rev 26100
Fixes issue 28754: Context info is properly sent for selectors in P&E grids

The problem was that when a selector drop down was open in a P&E window, the context info sent to the datasource did not include any info of the record being edited. This made impossible to include in the selector a validation based on other fields of the P&E window.

To fix this, the OBSelectorItem.prepareDSRequest function has been updated. Now that function detects if the selector belongs to a P&E grid, and if so it adds to the datasource request params the context info of the record being edited.

Fri, 27 Feb 2015 14:51:17 +0100Fixes bug 29093: LazyInitializationException avoided calculating BOM prod. cost
Unai Martirena <unai.martirena@openbravo.com> [Fri, 27 Feb 2015 14:51:17 +0100] rev 26099
Fixes bug 29093: LazyInitializationException avoided calculating BOM prod. cost

prodLine has been reloaded in case cost calculation of previous BOM Product has cleared the session.

Mon, 16 Feb 2015 18:10:06 +0100Fixes issue 28507: Error shown when posting a reconciliation
Alvaro Ferraz <alvaro.ferraz@openbravo.com> [Mon, 16 Feb 2015 18:10:06 +0100] rev 26098
Fixes issue 28507: Error shown when posting a reconciliation

When posting a reconciliation with a payment with a payment method not included in the financial account, a warning message will be shown instead of an error message, saying "Documemt disabled for accounting"

Thu, 26 Feb 2015 11:26:38 +0100fixed bug 28712: record selection lost in p&e grid if data has multiple pages
Asier Lostalé <asier.lostale@openbravo.com> [Thu, 26 Feb 2015 11:26:38 +0100] rev 26097
fixed bug 28712: record selection lost in p&e grid if data has multiple pages

In P&E grid with data displayed in several pages, if part of the selection was
not in the 1st page two errors occured:

-If after selecting a record in 2nd page another one in the 1st page was selected,
selection of record in 2nd page was lost
-If record in 2nd page was selected by using a filter, the filter was removed, and
the p&e was submitted, the selection was not sent to backend

The problem is in SC grid.getSelectedRecords which returns records only in current
page.

To solve this a cache of selected/unselected records is completelly maintained for p&e
grids without using getSelectedRecords, this is used also to send the selected recors
on p&e submission.

Fri, 27 Feb 2015 15:10:33 +0000CI: merge back from main
RM packaging bot <staff.rm@openbravo.com> [Fri, 27 Feb 2015 15:10:33 +0000] rev 26096
CI: merge back from main

Fri, 27 Feb 2015 14:51:03 +0000CI: update AD_MODULE to version 26090
RM packaging bot <staff.rm@openbravo.com> [Fri, 27 Feb 2015 14:51:03 +0000] rev 26095
CI: update AD_MODULE to version 26090

Fri, 27 Feb 2015 14:30:15 +0100Fixes bug 28870: Callouts are run when moving from grid to form with a shortcut
Augusto Mauch <augusto.mauch@openbravo.com> [Fri, 27 Feb 2015 14:30:15 +0100] rev 26094
Fixes bug 28870: Callouts are run when moving from grid to form with a shortcut

When a dynamic column is modified, a call is done to the FIC to run the callouts. The list of dynamic columns is stored in the form (in the view form and also in the grid edit form), and is loaded from the
FIC response. For instance, when a record is created (either or grid or form view), a call is done to the FIC in NEW mode, and the dynamicCols list is initialized.

The cause of this issue is that it was possible to open a record in form view in an inconsistent state, having the form's dynamicCols list not set. In this state the callouts are not run. To get to this in
consistent state, the following steps should take place:
- The user creates a record in the grid (a call to the FIC in NEW mode is done, and the dynamicCols list of the grid edit form is initialized)
- Without saving, the user presses Ctrl+F2 to edit the record in form view. No FIC call is done (there is no need for it), so even though the record is shown in the form view, its dynamicCols list is not s
et. The callouts will not run until a call to the FIC is done (for instance by refreshing the record).

To fix this, the list of dynamicCols of the grid edit form is copied to the form view. This is done in the ksAction_EditInForm function, which is the function executed when the user presses Ctrl+F2 to move
from the grid view to the form view.

The list of dynamic columns returned from the FIC to the grid view is the same as the one returned from the FIC to the form view, so it is not a problem is a dynamic columns is shown in the form view but n
ot in the grid view.

Thu, 26 Feb 2015 13:37:44 -0500Fixed bug 27010: Invoice Dimensional Report should not consider voided status.
Reinaldo Guerra <reinaldo.guerra@peoplewalking.com> [Thu, 26 Feb 2015 13:37:44 -0500] rev 26093
Fixed bug 27010: Invoice Dimensional Report should not consider voided status.

A new primary filter, was added to the Sales Invoice Dimensional Report, to allow exclude or not, documents voided in report's output.
This filter can be managed through a new preference that was created too, in order to let user decide if filter will be shown. By default the filter will be hidden and documents voided will be considered.