Thu, 09 Apr 2015 12:30:22 +0200Related to issue 29448: Empty filter when there is no attribute set value.
Unai Martirena <unai.martirena@openbravo.com> [Thu, 09 Apr 2015 12:30:22 +0200] rev 26498
Related to issue 29448: Empty filter when there is no attribute set value.

When records are created in Stock Reservation pick and edit, the 0 value retrieved from default attribute set instance, defined in reservation's tables, is now set to null, when creating filter criteria.
Now if there is no attribute set defined for reservation's products, the attribute set value filter is empty.

Thu, 09 Apr 2015 12:26:23 +0200Fixes bug 29448, Fixes bug 29447, Fixes bug 29449
Unai Martirena <unai.martirena@openbravo.com> [Thu, 09 Apr 2015 12:26:23 +0200] rev 26497
Fixes bug 29448, Fixes bug 29447, Fixes bug 29449

The following changes was made in Stock Reservation pick and edit:
When filters are executed, a Reservation entity is created from the json parameter @MaterialMgmtReservation.id@. This works fine when the pop-up is called from Stock Reservation window, but from Sales Order, this parameter does not exists, and the filter process fails. Now is included a code line that puts a @MaterialMgmtReservation.id@ into the json parameters before the filters are applied.
Array critera filtering was bad created when getting grid's data, so was changed, to allow filter's multiple selection.
An hibernate exception is launched when typing wrong filters and the expression 'in ()' is included in the query to be executed. So this expression was replaced by one which returns a false value: '1 = 2'
Were included also, changes to allow filtering quantity's column. Other changes were included to avoid exceptions comparing to null values.

Wed, 08 Apr 2015 10:51:35 +0200Fixed issue 29461: It is possible to create a payment in/out
Jorge Garcia <jorge.garcia@openbravo.com> [Wed, 08 Apr 2015 10:51:35 +0200] rev 26496
Fixed issue 29461: It is possible to create a payment in/out

It is possible to create a payment header when a payment method or a financial
account is disabled in a given financial account.

Now only active payment methods of financial accounts and active financial
accounts are showing in the payment in / payment out window.

In addition, if the user selects a business partner in these windows and the
default payment method and/or the default financial account is/are inactive,
a warning message is shown to the user, indicating which one is inactive.

These warning messages are also included in the fix.

Tue, 07 Apr 2015 10:00:20 +0200Related to bug 29498: Code review
Unai Martirena <unai.martirena@openbravo.com> [Tue, 07 Apr 2015 10:00:20 +0200] rev 26495
Related to bug 29498: Code review

Use ParameterType instead of InputType for CONSTANT String.

Wed, 01 Apr 2015 15:55:26 +0200Fixed bug 29498: Several issues in Match Statement
Víctor Martínez Romanos <victor.martinez@openbravo.com> [Wed, 01 Apr 2015 15:55:26 +0200] rev 26494
Fixed bug 29498: Several issues in Match Statement

1) Wrong management of default parameters in automatic execution process:
ParameterType was used where InputType was expected (and the opposite)

2) NPE when working with default parameters in execution process
constantParameters attribute wasn't initialized before being used. Fixed also parameters attribute with the same potential issue

3) Impossible to create a new payment from transaction when the payment method has an automatic execution process and automatic deposit/withdrawn
We now pass an internal parameter "comingFrom" to know if we come from a transaction. In this case we don't create automatically the transaction (regardless the payment method is automatic deposit/withdrawn) to avoid breaking the unique constraint FIN_FINACC_TRANSACTION_UN inside FIN_FINACC_TRANSACTION table

Tue, 31 Mar 2015 12:45:26 +0200fixed bug 29467: list reference are validated while typing
Asier Lostalé <asier.lostale@openbravo.com> [Tue, 31 Mar 2015 12:45:26 +0200] rev 26493
fixed bug 29467: list reference are validated while typing

This caused to see the field in red as non valid while typing to filter a value.

It has been fixed in the same way selector reference does: preventing validation
on filterComplete. A new OBComboBoxItem class has been implemented in order to
make both list and selectors (including table and tableDir) extend it preventing
in this manner code duplicities.

Thu, 26 Mar 2015 15:21:18 +0100fixed bug 29428: Distinct parameter is not working in JSON REST web services
Asier Lostalé <asier.lostale@openbravo.com> [Thu, 26 Mar 2015 15:21:18 +0100] rev 26492
fixed bug 29428: Distinct parameter is not working in JSON REST web services

Using _distinct property in JSON REST webservices resulted in an incorrectly
generated query. There were 2 problems:

- Entity name for was set in the fetch method, after the refactor done to fix
issue #25182, entity is different in case of using _distinct, and it is managed
by QueryService.
- This refactor also requires of using aliases to work

Mon, 30 Mar 2015 10:07:10 +0200fixed bug 29453: Process Definition without params popup is not closed
Asier Lostalé <asier.lostale@openbravo.com> [Mon, 30 Mar 2015 10:07:10 +0200] rev 26491
fixed bug 29453: Process Definition without params popup is not closed

When a process defintion has no parameters, it is not closed after execution/failure.

The problem was due the invokation of allRequiredParametersSet which now is performed
after validation, this method incorretly assumed there was a form with paramters.

Thu, 26 Mar 2015 10:26:30 +0100fixed bug 29416, related to issue 29424: Done can be clicked more than once
Asier Lostalé <asier.lostale@openbravo.com> [Thu, 26 Mar 2015 10:26:30 +0100] rev 26490
fixed bug 29416, related to issue 29424: Done can be clicked more than once

In process definition Done button was enabled and clickable while client side
validations were being evaluated. This was specially noticeable if those validations
perform backend requests to be completed (which is the case of Add Payment).

Fixed by disabling Done button as first step before executing any validation.

Wed, 01 Apr 2015 17:28:03 +0200Fixes bug 29473: Bank Statement Line amount maintained in Add Payment from FA
Unai Martirena <unai.martirena@openbravo.com> [Wed, 01 Apr 2015 17:28:03 +0200] rev 26489
Fixes bug 29473: Bank Statement Line amount maintained in Add Payment from FA

If exists bslamount this means that Add Payment window has been opened from Match Statement window, so, when selecting a line in Order/Invoices grid, this amount will be set in the line when is smaller than outstanding amount.

If Outstanding amount is smaller, then outstanding amount will be assigned.