Mon, 18 May 2015 16:50:47 +0200Related to bug 29256: Code Review
Unai Martirena <unai.martirena@openbravo.com> [Mon, 18 May 2015 16:50:47 +0200] rev 26647
Related to bug 29256: Code Review

Add coalesce in case there is no batch associated to set GL Journal Org, in order to avoid issues in the if condition done right after the query if null values are compared

Thu, 14 May 2015 14:20:33 +0200Fixes issue 29256: Error while completing a Simple G/L Journal in Oracle
Alvaro Ferraz <alvaro.ferraz@openbravo.com> [Thu, 14 May 2015 14:20:33 +0200] rev 26646
Fixes issue 29256: Error while completing a Simple G/L Journal in Oracle

A query in gl_journal_post has been changed to avoid errors in Oracle when retrieving a null id

Mon, 18 May 2015 11:06:08 +0200Fixes issue 27170: Performance problems in CharacteristicValueEventHandler
Alvaro Ferraz <alvaro.ferraz@openbravo.com> [Mon, 18 May 2015 11:06:08 +0200] rev 26645
Fixes issue 27170: Performance problems in CharacteristicValueEventHandler

onUpdate method has been changed to execute an update query instead of two OBCriteria queries, which improves the performance of the event handler.

Sat, 16 May 2015 03:19:14 +0000CI: merge back from main
RM packaging bot <staff.rm@openbravo.com> [Sat, 16 May 2015 03:19:14 +0000] rev 26644
CI: merge back from main

Sat, 16 May 2015 03:04:03 +0000CI: update AD_MODULE to version 26642
RM packaging bot <staff.rm@openbravo.com> [Sat, 16 May 2015 03:04:03 +0000] rev 26643
CI: update AD_MODULE to version 26642

Fri, 15 May 2015 18:27:18 +0200Related with issue 29896: Fix backed out because it is breaks int-initial tests
Augusto Mauch <augusto.mauch@openbravo.com> [Fri, 15 May 2015 18:27:18 +0200] rev 26642
Related with issue 29896: Fix backed out because it is breaks int-initial tests

A side effect of the changeset is making Selenium unable to know when a grid has been loaded under certain circumstances.

Fri, 15 May 2015 12:01:31 +0200Fixes issue 29897: False positives in GLJournalAccountingCheck validation
Eduardo Argal Guibert <eduardo.argal@openbravo.com> [Fri, 15 May 2015 12:01:31 +0200] rev 26641
Fixes issue 29897: False positives in GLJournalAccountingCheck validation
Missing ad_table_id constraint ends up in wrong validation when there are old records using numeric values for ids.

Fri, 15 May 2015 12:23:20 +0200Related to issue 29766: Retail Operations Buffer: store all transactions in operations table before processing
Martin Taal <martin.taal@openbravo.com> [Fri, 15 May 2015 12:23:20 +0200] rev 26640
Related to issue 29766: Retail Operations Buffer: store all transactions in operations table before processing
Solve javadoc errors

Fri, 15 May 2015 09:58:34 +0200Fixes issue 29896: Prevents unneded datasource request when filtering
Augusto Mauch <augusto.mauch@openbravo.com> [Fri, 15 May 2015 09:58:34 +0200] rev 26639
Fixes issue 29896: Prevents unneded datasource request when filtering

When the grid was filtered in a scrolled down grid, two datasource requests to load the grid were bein
g done instead of one. This happened due to two reasons:
- The function scrollTo of the grid's body was being invoked while the grid was being filtered. This f
unction can be skipped in this case because when a datasource request is triggered due to a filter eve
nt, the grid is always automatically scrolled up to the top
- If the OBViewGrid.getRecord function was invoked in the middle of a datasource request, an additiona
l request was done. To prevent this, in this case the function returns Array.LOADING

To detect if the grid is in the process of doing a datasource request, the isFilteringExternally flag
is used. This flag is set in the handleFilterEditorSubmit function, and only if the change in the filt
er editor is going to trigger a datasource request. The flag is reset in the callback of that function
.

Thu, 14 May 2015 15:46:56 +0000CI: merge back from main
RM packaging bot <staff.rm@openbravo.com> [Thu, 14 May 2015 15:46:56 +0000] rev 26638
CI: merge back from main

Thu, 14 May 2015 15:29:39 +0000CI: update AD_MODULE to version 26633
RM packaging bot <staff.rm@openbravo.com> [Thu, 14 May 2015 15:29:39 +0000] rev 26637
CI: update AD_MODULE to version 26633

Thu, 14 May 2015 14:59:55 +0200ted to issue 29751: Killable processes
Asier Lostalé <asier.lostale@openbravo.com> [Thu, 14 May 2015 14:59:55 +0200] rev 26636
ted to issue 29751: Killable processes

Few minor enhacements:
- When a process is killed, its status in process monitor is shown as "Killed
by User"
- When user clicks on "Kill Process" button change the message from "Process
killed successfully" to "Kill signal sent to process" as sending the kill
signal doesn't imply necessaryly the process to be successfully killed
- Changed UI message levels when "Kill Process" button is clicked:
- If signal is sent: from success to info
- If process does not implement KillableProcess: from info to warn
- Added ProcessBundle to KillableProcess.kill method so process instance's
information can be accessed (ie. allows to add extra log when killing the
process)

Wed, 13 May 2015 12:11:18 +0200Fixes issue 29701 & Fixes issue 29861: Error in Price Correction Background
Alvaro Ferraz <alvaro.ferraz@openbravo.com> [Wed, 13 May 2015 12:11:18 +0200] rev 26635
Fixes issue 29701 & Fixes issue 29861: Error in Price Correction Background

IsCostCalculated will not be considered to set CheckPriceDifference flag, when completing an invoice.
Instead, when running Price Correction Background, transactions will be filtered by IsCostCalculated to avoid calculate price differences in transactions where cost has not been calculated.

Thu, 14 May 2015 12:15:15 +0200Fixed issue 29561: 'Time' fields now can be set as no updateable via AD_COLUMN
David Baz Fayos <david.baz@openbravo.com> [Thu, 14 May 2015 12:15:15 +0200] rev 26634
Fixed issue 29561: 'Time' fields now can be set as no updateable via AD_COLUMN

Thu, 14 May 2015 10:55:38 +0200Related to Issue 29201. Fixes dbcons problem.
David Miguelez <david.miguelez@openbravo.com> [Thu, 14 May 2015 10:55:38 +0200] rev 26633
Related to Issue 29201. Fixes dbcons problem.

Thu, 14 May 2015 09:56:05 +0200Fixes issue 29618: G/L Journal Accounting amounts are setted correctly
Alvaro Ferraz <alvaro.ferraz@openbravo.com> [Thu, 14 May 2015 09:56:05 +0200] rev 26632
Fixes issue 29618: G/L Journal Accounting amounts are setted correctly

Now, converted amounts are correctly setted when posting a G/L Journal although amounts are negative and rate is different than 1

Wed, 13 May 2015 17:25:26 +0200Related to issue 29513: Remove unused line
Alvaro Ferraz <alvaro.ferraz@openbravo.com> [Wed, 13 May 2015 17:25:26 +0200] rev 26631
Related to issue 29513: Remove unused line

Tue, 12 May 2015 18:20:20 +0200Related to bug 29513: Adjust costing tests to the new behavior
Unai Martirena <unai.martirena@openbravo.com> [Tue, 12 May 2015 18:20:20 +0200] rev 26630
Related to bug 29513: Adjust costing tests to the new behavior

Tue, 12 May 2015 18:18:07 +0200Fixes bug 29513: Total Movement qty fixed in costing tab with backdated trx
Unai Martirena <unai.martirena@openbravo.com> [Tue, 12 May 2015 18:18:07 +0200] rev 26629
Fixes bug 29513: Total Movement qty fixed in costing tab with backdated trx

While working with cost adjustments, on certain cases the existing Costing records changes. This can happen because the cost has been recalculated due to backdated transactions, price adjustments, manual cost corrections, etc. In all this cases the 'Total Movement Quantity' field was not being correctly updated.
This field has to store the current stock of the product on that moment. So, each time the costing record is updated it is being checked if this value changes, and if it has changed the current stock is set.

Wed, 13 May 2015 18:15:58 +0200Related to Issue 29201. Changes description of Process Generate Invoices
David Miguelez <david.miguelez@openbravo.com> [Wed, 13 May 2015 18:15:58 +0200] rev 26628
Related to Issue 29201. Changes description of Process Generate Invoices
and Label of Organization Parameter

Wed, 13 May 2015 15:13:39 +0000CI: merge back from main
RM packaging bot <staff.rm@openbravo.com> [Wed, 13 May 2015 15:13:39 +0000] rev 26627
CI: merge back from main

Wed, 13 May 2015 14:57:13 +0000CI: update AD_MODULE to version 26618
RM packaging bot <staff.rm@openbravo.com> [Wed, 13 May 2015 14:57:13 +0000] rev 26626
CI: update AD_MODULE to version 26618

Wed, 13 May 2015 16:53:36 +0200Modified Smartclient 10.0d 2014-02-13 SNAPSHOT to fix issue 28405
David Baz Fayos <david.baz@openbravo.com> [Wed, 13 May 2015 16:53:36 +0200] rev 26625
Modified Smartclient 10.0d 2014-02-13 SNAPSHOT to fix issue 28405

Wed, 13 May 2015 16:20:30 +0200Related to bug 29748: Fix copyright
Unai Martirena <unai.martirena@openbravo.com> [Wed, 13 May 2015 16:20:30 +0200] rev 26624
Related to bug 29748: Fix copyright

Mon, 11 May 2015 18:56:21 +0200Fixed issue 29748: "Create VAT register" process should consider exchange rate
Jorge Garcia <jorge.garcia@openbravo.com> [Mon, 11 May 2015 18:56:21 +0200] rev 26623
Fixed issue 29748: "Create VAT register" process should consider exchange rate

"Create VAT register" process in Tax Payment window should consider exchange
rate defined at document level.

The solution is to check if there is an exchange rate defined in the invoice
and if it's null, use the exchange rate defined in Conversion Rate window.

Wed, 13 May 2015 15:58:31 +0200Related to issue 19728: Do more JS code formatting
David Baz Fayos <david.baz@openbravo.com> [Wed, 13 May 2015 15:58:31 +0200] rev 26622
Related to issue 19728: Do more JS code formatting

Wed, 13 May 2015 15:56:05 +0200Fixed issue 29561: 'Time' fields now can be set as readonly via AD_FIELD
David Baz Fayos <david.baz@openbravo.com> [Wed, 13 May 2015 15:56:05 +0200] rev 26621
Fixed issue 29561: 'Time' fields now can be set as readonly via AD_FIELD

Wed, 13 May 2015 13:50:58 +0200fixed bug 29849: RequestDispatcher.include deletes context from current thread
Asier Lostalé <asier.lostale@openbravo.com> [Wed, 13 May 2015 13:50:58 +0200] rev 26620
fixed bug 29849: RequestDispatcher.include deletes context from current thread

This code:

RequestDispatcher dispatcher = request.getRequestDispatcher(url);
dispatcher.include(wrappedRequest, response)

deletes context OBContext and RequestContext.

The problem is caused because the way Tomcat internally manages it. By definition
RequestDispatcher.include should not execute the Request filters (only the include
ones) but they were executed causing this issue. They were executed because
of the manner the special attribute to get the dispatch type is obtained, as
the wrappedRequest now extends javax.servlet.http.HttpServletRequestWrapper it
is managed differently than before when this was not the case, now type was always
"Request" even when it should be "Include".

The fix consists on managing getAttribute from request differently when they are
special Tomcat internal attributes getting them from the request instead of from
the delegate.

Tue, 12 May 2015 17:14:50 +0200Fixed issue 29847: Applied bad format number when running Payment Report in PDF
Jorge Garcia <jorge.garcia@openbravo.com> [Tue, 12 May 2015 17:14:50 +0200] rev 26619
Fixed issue 29847: Applied bad format number when running Payment Report in PDF

Decimal and Grouping separators defined in Format.xml are not applied when
running Payment Report in PDF.

The solution is to fix the Payment Report number format in the jrxml file.
Also, a new parameter must be added to the Report.

Now, all the number fields of the report are formatted as the Format.xml
definition.

Tue, 12 May 2015 14:03:06 +0530Fixes Issue 29042:Should not be possible to delete a summary node in User
Atul Gaware <atul.gaware@openbravo.com> [Tue, 12 May 2015 14:03:06 +0530] rev 26618
Fixes Issue 29042:Should not be possible to delete a summary node in User
Defined Accounting Report Setup

After Delete part is added in AD_Accountingrpt_Element_Trg which checks
that whether there exists childs for the element being deleted.