Tue, 27 Oct 2015 11:20:34 +0100Fixed issue 30783: Reduce the number of clicks to print Documents.
Naroa Iriarte <naroa.iriarte@openbravo.com> [Tue, 27 Oct 2015 11:20:34 +0100] rev 27815
Fixed issue 30783: Reduce the number of clicks to print Documents.

Before, when a document was going to be printed, several clicks were needed.
That was because when you click on the print button, a popup which asks if
you wanted to attach the document or just print it appear, and after it was possible to print.

The number of clicks needed for that task could be bothering if it was often repeated:.

To fix this two new preferences have been added.
The first one "Attach by default": If this preference is set to "N" then, the popup is not
shown when clicking the print button, and the document is not attached.
If this preference is set to "Y" then, the popup is not shown when clicking the print button
and the document is attached.
If this preference is undefined, then, the popup which asks for attaching the document or just printing
it appears when clicking the print button.

The other preference "Direct Print": If this is set as "Y" then the printing popup will be
opened.
If this is set as "N" or undefined, then the document is downloaded, but the printing popup is not shown.
The "ReportingUtils.java" has been modified, now if the direct print preference is set, the "this.print()" js function
is executed.
The "PrinterReports.java" has been modified for handling the new functionality with the preference which
attaches the documents directly.
The "PrintController.java" has been modified for handling the new functionality with the Direct print
preference.

The index.jsp has been changed because there was a problem with some browsers and the "Direct print" preference
it was not possible to display the printer popup in Internet Explorer nor Firefox.
This was because we were using a hidden frame for putting the pdf there. Chrome was able to take what there was in
that frame, but Firefox and Internet Explorer were not able.
To fix this the style="display:none" of the frame "background_target" has been removed.
Now, it is possible to use the Direct Print preference in the Firefox, Safari, Internet Explorer and Chrome browsers.

Tue, 27 Oct 2015 13:37:18 +0100fixes issue 31254: The style of the toolbar button looks different in MS Edge
Carlos Aristu <carlos.aristu@openbravo.com> [Tue, 27 Oct 2015 13:37:18 +0100] rev 27814
fixes issue 31254: The style of the toolbar button looks different in MS Edge

The transparency of the border defined in the CSS properties of the button was not being interpreted properly by MS Edge. To solve this problem, a solution has been added for this particular browser, by setting the transparency of the border using CSS3

Tue, 27 Oct 2015 08:28:58 +0100fixed bug 31187: Lazy filtering does not work when filtering the first time
Asier Lostalé <asier.lostale@openbravo.com> [Tue, 27 Oct 2015 08:28:58 +0100] rev 27813
fixed bug 31187: Lazy filtering does not work when filtering the first time

Having lazy filtering configured, if a filter was applied in a grid as first
action, it was not possible to apply it. A js error was thrown:
Uncaught TypeError: this.data.willFetchData is not a function

The problem was in "if (this.data.willFetchData(this.convertCriteria(criteria)))"
statement which incorrectly assumed this.data to be an object and willFetchData
a function within it. This is not true when in this situation where this.data is
an array.

It has been fixed by taking into account this case by checking wether this.data
is an array.

Mon, 26 Oct 2015 11:56:37 +0100related to issue 30919: fixed logic to check if JNDIConnectionProvider is used
Asier Lostalé <asier.lostale@openbravo.com> [Mon, 26 Oct 2015 11:56:37 +0100] rev 27812
related to issue 30919: fixed logic to check if JNDIConnectionProvider is used

Old JNDIConnectionProvider should be used if JNDI is configured and there is
no external pool in use.

Mon, 26 Oct 2015 11:07:45 +0100fixes issue 30534: Some pop-ups are not displayed properly on MS Edge
Carlos Aristu <carlos.aristu@openbravo.com> [Mon, 26 Oct 2015 11:07:45 +0100] rev 27811
fixes issue 30534: Some pop-ups are not displayed properly on MS Edge

Mon, 19 Oct 2015 17:11:49 +0200Fixes issue 31041: Insuffient stock error message when processing an inventory
Alvaro Ferraz <alvaro.ferraz@openbravo.com> [Mon, 19 Oct 2015 17:11:49 +0200] rev 27810
Fixes issue 31041: Insuffient stock error message when processing an inventory

Avoid "insufficient stock" error message when processing an Inventory Amount Update created in the past.
Now, when processing related closing and opening inventories, negative stock will not be checked.

Fri, 23 Oct 2015 14:14:37 +0200related to issue 30931: recalculate child permissions with different parents
Carlos Aristu <carlos.aristu@openbravo.com> [Fri, 23 Oct 2015 14:14:37 +0200] rev 27809
related to issue 30931: recalculate child permissions with different parents
When recalculating all the permissions of a role, it was not being deleted the child permissions inherited from a role different than the one used to inherit the parent. This is not fixed. Note that this case only applies in Tab Access and Field Access.

Fri, 23 Oct 2015 10:45:30 +0200Related to issue 30986:Code review improvements.
Inigo Sanchez <inigo.sanchez@openbravo.com> [Fri, 23 Oct 2015 10:45:30 +0200] rev 27808
Related to issue 30986:Code review improvements.

The problem was when creating new language code has been included in AD_LANGUAGE_CREATE
which is in core, being insertions for a table in client.application module, the code
managing them should be within that module (OBUIAPP_LANGUAGE_CREATE) where parameters
are also handled.

Now it has been resolved the problem by moving the code to the correct function
(OBUIAPP_LANGUAGE_CREATE).

Fri, 23 Oct 2015 09:39:33 +0200related to issue 30986: Process Def > Parameter tab marked as trl
Asier Lostalé <asier.lostale@openbravo.com> [Fri, 23 Oct 2015 09:39:33 +0200] rev 27807
related to issue 30986: Process Def > Parameter tab marked as trl

In this way it will not be shown unless "Show Trl Tabs" prefrence is enabled

Thu, 22 Oct 2015 20:06:52 +0200Related to issue 30986:updated column type in obuiapp_process_trl table.
Inigo Sanchez <inigo.sanchez@openbravo.com> [Thu, 22 Oct 2015 20:06:52 +0200] rev 27806
Related to issue 30986:updated column type in obuiapp_process_trl table.

The problem was that testTrlColumnsOraTyp was failling. It has been updated column
types in obuiapp_process_trl table and now it has been resolved the problem.

Thu, 22 Oct 2015 18:04:29 +0200related to issue 30931: Add missing ancestor check
Carlos Aristu <carlos.aristu@openbravo.com> [Thu, 22 Oct 2015 18:04:29 +0200] rev 27805
related to issue 30931: Add missing ancestor check

Thu, 22 Oct 2015 17:51:34 +0200fixes issue 31217: Toolbar disappears under some circumnstances
Carlos Aristu <carlos.aristu@openbravo.com> [Thu, 22 Oct 2015 17:51:34 +0200] rev 27804
fixes issue 31217: Toolbar disappears under some circumnstances
The problem was that action can be null when invoking dirtyEditForm.autoSave. Now we have prevented the error by avoiding to use action.parameters if action is null

Thu, 22 Oct 2015 17:17:07 +0200Related to issue 30986:revert change columns type to avoid 'INT-API' failed
Inigo Sanchez <inigo.sanchez@openbravo.com> [Thu, 22 Oct 2015 17:17:07 +0200] rev 27803
Related to issue 30986:revert change columns type to avoid 'INT-API' failed

The problem was that it has been changed the column type of the name, description and help of
the OBUIAPP_PROCESS table and these changes have broken the api.

It has been found that this change are unnecessary and for that reason it have been reverted.

Thu, 22 Oct 2015 15:26:37 +0200fixed bug 31214: adding extra filter after product characteristics fails
Asier Lostalé <asier.lostale@openbravo.com> [Thu, 22 Oct 2015 15:26:37 +0200] rev 27802
fixed bug 31214: adding extra filter after product characteristics fails

When product characteristics was filtered returning less than 100 records, and
on top of that criteria a new one in another field was added, it was not possible
to refresh the grid anymore.

When this additional criteria was set, a javascript exception was thrown because
adaptive filtering was tried to be evaluated for 'exists' search operator. This
operator didn't implement condition funtion which was invoked causing the exception.
This exception left the grid in an inconsistent estate which made not posible to
refresh it.

To fix it, 'condition' function has been implemented for 'exists' search operator,
as this operator can't be evaluted in client side, we can ensure all fields in
grid fulfill any criteria defined by it, so the implementation can return always
true.

Thu, 22 Oct 2015 14:45:26 +0200Related to issue 30986:Updated Parameter Translation name element.
Inigo Sanchez <inigo.sanchez@openbravo.com> [Thu, 22 Oct 2015 14:45:26 +0200] rev 27801
Related to issue 30986:Updated Parameter Translation name element.

Thu, 22 Oct 2015 13:03:44 +0200Related to issue 30986:Updated Obuiapp_Process_Trl_ID name element.
Inigo Sanchez <inigo.sanchez@openbravo.com> [Thu, 22 Oct 2015 13:03:44 +0200] rev 27800
Related to issue 30986:Updated Obuiapp_Process_Trl_ID name element.

Wed, 21 Oct 2015 12:18:28 +0200Fixed issue 30986:fixed grid position of fields in Translation tab.
Inigo Sanchez <inigo.sanchez@openbravo.com> [Wed, 21 Oct 2015 12:18:28 +0200] rev 27799
Fixed issue 30986:fixed grid position of fields in Translation tab.

It have been changed grid position of some fields.

Wed, 21 Oct 2015 10:36:47 +0200Related to issue 30986: Add parameter translation tab for Process Definition.
Inigo Sanchez <inigo.sanchez@openbravo.com> [Wed, 21 Oct 2015 10:36:47 +0200] rev 27798
Related to issue 30986: Add parameter translation tab for Process Definition.

It has been done two things:
*Added parameter translation tab for 'Process Definition'.
*Small fix in 'AD_Language' column. The reference has been changed to 'Table' reference.

Thu, 15 Oct 2015 09:53:14 +0200Related issue 30986: Add translation infrastructure for Process Definition.
Inigo Sanchez <inigo.sanchez@openbravo.com> [Thu, 15 Oct 2015 09:53:14 +0200] rev 27797
Related issue 30986: Add translation infrastructure for Process Definition.

Add translation DB infrastructure for Process Definition.

Thu, 22 Oct 2015 09:14:03 +0200related to issue 30931: RoleInheritanceWarningFICExtension, correct method name
Carlos Aristu <carlos.aristu@openbravo.com> [Thu, 22 Oct 2015 09:14:03 +0200] rev 27796
related to issue 30931: RoleInheritanceWarningFICExtension, correct method name

Thu, 22 Oct 2015 09:00:46 +0200related to issue 30931: added new method for RoleInheritanceWarningFICExtension
Carlos Aristu <carlos.aristu@openbravo.com> [Thu, 22 Oct 2015 09:00:46 +0200] rev 27795
related to issue 30931: added new method for RoleInheritanceWarningFICExtension

Wed, 21 Oct 2015 12:21:21 +0200fixed bug 30919: can't use DB connection defined as JNDI service
Asier Lostalé <asier.lostale@openbravo.com> [Wed, 21 Oct 2015 12:21:21 +0200] rev 27794
fixed bug 30919: can't use DB connection defined as JNDI service

Several problems fixed:
* Even configured, JNDI was not used in ModelProvider.initializeReferenceClasses
method
* Casting exception was thrown in ModelProvider.initializeReferenceClasses
* When Tomcat Pool was configured as external pool and also JDNI datasource
was configured, it was not properly managed. Now the pool is used and JNDI
datasource is set
* Improved some error logging which was hiding root cause stack traces

Wed, 21 Oct 2015 19:28:48 +0200related to issue 30931: Improvement in warning message of FICExtension
Carlos Aristu <carlos.aristu@openbravo.com> [Wed, 21 Oct 2015 19:28:48 +0200] rev 27793
related to issue 30931: Improvement in warning message of FICExtension
The warning message was not being shown the first time a permission was created for a template role in use. The problem was that row does not contain the role information yet. For this reason, now we try to retrieve the information from the information provided by the FIC

Wed, 21 Oct 2015 10:21:13 +0200related to issue 30931: Add missing comment
Carlos Aristu <carlos.aristu@openbravo.com> [Wed, 21 Oct 2015 10:21:13 +0200] rev 27792
related to issue 30931: Add missing comment

Wed, 14 Oct 2015 16:47:18 +0200Fixed bug 31039: Cannot create sales order from project phase if the customer default invoice terms is Contract Billing
Víctor Martínez Romanos <victor.martinez@openbravo.com> [Wed, 14 Oct 2015 16:47:18 +0200] rev 27791
Fixed bug 31039: Cannot create sales order from project phase if the customer default invoice terms is Contract Billing

The v_InvoiceRule variable was defined as CHAR. In case the C_BPartner.InvoiceRule length is higher than 1 (as when defining Contract Billing), the process throws an exception.
The solution is to declare the variable as C_BPartner.InvoiceRule%TYPE, which automatically takes the definition from the C_BPartner table.

Tue, 20 Oct 2015 12:57:26 +0200fixed issue 31152: context info in process definition can be extended
Asier Lostalé <asier.lostale@openbravo.com> [Tue, 20 Oct 2015 12:57:26 +0200] rev 27790
fixed issue 31152: context info in process definition can be extended

Process definition has a new property (additionalContextInfo) that can be used
to add additional properties, or overwrite existing ones, in context info that
is used later to compute ie. display logic.

In this way it will be possible to set this info with an ActionHandler to be used
later as part of context info.

Mon, 19 Oct 2015 12:38:32 +0200Fixed bug 31121: Copy Version process in Process Plan window is not working in Oracle
Víctor Martínez Romanos <victor.martinez@openbravo.com> [Mon, 19 Oct 2015 12:38:32 +0200] rev 27789
Fixed bug 31121: Copy Version process in Process Plan window is not working in Oracle

Ad_Sequence_Doc is a stored procedure that returns the next sequence number using an "out" parameter. The CallStoredProcedure.call() used to call that procedure doesn't currently support parameters of type "out", creating an exception in Oracle only (and not in PostgreSQL because the procedure is declared as a function returning the value).

Instead of calling the procedure using CallStoredProcedure.call(), we use Utility.getDocumentNo() method instead, which is a more standard way to get the next sequence no. from Java, and supports Oracle procedures with "out" parameters.

Besides the class has been modified to properly show an error message in the UI in case an exception is raised, which is something not working before neither.

Tue, 20 Oct 2015 09:14:00 +0200fixes issue 30931: Add ability to inherit role permissions
Carlos Aristu <carlos.aristu@openbravo.com> [Tue, 20 Oct 2015 09:14:00 +0200] rev 27788
fixes issue 30931: Add ability to inherit role permissions

Mon, 19 Oct 2015 19:09:05 +0200[roleInheritance] Updated Recalculate Permissions process description
Carlos Aristu <carlos.aristu@openbravo.com> [Mon, 19 Oct 2015 19:09:05 +0200] rev 27787
[roleInheritance] Updated Recalculate Permissions process description

Mon, 19 Oct 2015 11:55:50 +0200[roleInheritance] Fixes in javadoc
Carlos Aristu <carlos.aristu@openbravo.com> [Mon, 19 Oct 2015 11:55:50 +0200] rev 27786
[roleInheritance] Fixes in javadoc