Wed, 18 Nov 2015 12:57:36 +0100fixes issue 30813: Show batch exception cause in SessionHandler commitAndClose
Carlos Aristu <carlos.aristu@openbravo.com> [Wed, 18 Nov 2015 12:57:36 +0100] rev 27915
fixes issue 30813: Show batch exception cause in SessionHandler commitAndClose

A new method, getCausingException(Throwable t), has been created in OBException to recover the underlying exception of a BatchUpdateException. This method is used in the commitAndClose() method of SessionHandler class to solve this issue.

Together with this, this new method is now used when instantating OBException with this constructor: OBException(Throwable cause) in order to retrieve the underlying exception information in this case also.

Wed, 18 Nov 2015 10:40:21 +0100related to issue 29027: updated copyright year
Carlos Aristu <carlos.aristu@openbravo.com> [Wed, 18 Nov 2015 10:40:21 +0100] rev 27914
related to issue 29027: updated copyright year

Wed, 18 Nov 2015 10:34:43 +0100fixes issue 29027: boolean default values for widget parameters properly set
Carlos Aristu <carlos.aristu@openbravo.com> [Wed, 18 Nov 2015 10:34:43 +0100] rev 27913
fixes issue 29027: boolean default values for widget parameters properly set

The problem was that initially the default boolean values for widget parameters were not being set properly. This type of parameters were initially retrieved as strings, and this caused that checkboxes values were not being set correctly.

To fix the problem now the default values for boolean widget parameters are returned as boolean values from the server side.

Tue, 17 Nov 2015 19:37:00 +0100fixes issue 25012: Process definition params not work if lenght is 1000 or more
Carlos Aristu <carlos.aristu@openbravo.com> [Tue, 17 Nov 2015 19:37:00 +0100] rev 27912
fixes issue 25012: Process definition params not work if lenght is 1000 or more

The length value was using directly as a float value to generate the js component. This caused the error parsing the component view as for example a length of 2000 result in a value of '2,000'. That comma was causing the error in the parser.

To solve the problem the float value is now converted using the 'c' built-in in the freemarker template. This built-in converts a number to string for a 'computer language', using dot as decimal separator. Also it never uses grouping separators which is the key to solve this problem.

Tue, 17 Nov 2015 17:57:32 +0100fixes issue 29683: web services not filter system/client entity by client
Carlos Aristu <carlos.aristu@openbravo.com> [Tue, 17 Nov 2015 17:57:32 +0100] rev 27911
fixes issue 29683: web services not filter system/client entity by client

The problem here was that system/client entities can have children properties which belongs to different clients. So it was necessary to filter the children properties by the current client also, when returning the web service results.

Tue, 17 Nov 2015 13:39:07 +0100Related to issue 31479: code review improvements
Víctor Martínez Romanos <victor.martinez@openbravo.com> [Tue, 17 Nov 2015 13:39:07 +0100] rev 27910
Related to issue 31479: code review improvements

List Price is only set when bdPriceList is not Zero (or null)

Mon, 09 Nov 2015 11:11:18 +0100Fixes issue 31061: Can not reactivate a invoice if it's related to a LandedCost
Alvaro Ferraz <alvaro.ferraz@openbravo.com> [Mon, 09 Nov 2015 11:11:18 +0100] rev 27909
Fixes issue 31061: Can not reactivate a invoice if it's related to a LandedCost

It is not possible to reactivate a purchase invoice if any line has a related landed cost matched.
Now, it will be possible to manually remove this landed cost matched, if matching is not processed, by unselecting it in Match LC Costs pick and edit, and then reactivate purchase invoice.

Tue, 17 Nov 2015 09:04:02 +0100fixes issue 28561: OB.Utilities.Number.ScientificToDecimal and leading zeros
Carlos Aristu <carlos.aristu@openbravo.com> [Tue, 17 Nov 2015 09:04:02 +0100] rev 27908
fixes issue 28561: OB.Utilities.Number.ScientificToDecimal and leading zeros

OB.Utilities.Number.ScientificToDecimal was not working properly if the number passed as parameter had leading zeros. To fix the problem we use a regular expression to remove them: we look for at least one zero at the beginning of the string representation of the number. If found, it is deleted by replacing it with ''.

Tue, 17 Nov 2015 08:49:16 +0100fixes issue 29746: unneded FIC request on record selection in some windows
Carlos Aristu <carlos.aristu@openbravo.com> [Tue, 17 Nov 2015 08:49:16 +0100] rev 27907
fixes issue 29746: unneded FIC request on record selection in some windows

This problem happens on those windows which do not have buttons on the right side of the toolbar. The EDIT request was introduced to solve issue #18711 in order to set the session variables in grid mode. This called was done through this.view.setContextInfo();. Then after fixing issue #20522 the second call in SETSESSION mode was introduced.

To avoid the call in EDIT mode we have just removed the call to this.view.setContextInfo();. This way just the call in SETSESSION mode is performed.

Sat, 14 Nov 2015 14:34:45 +0100Fixed 31482: Fix Type Safety and Raw Types warnings
Stefan Hühner <stefan.huehner@openbravo.com> [Sat, 14 Nov 2015 14:34:45 +0100] rev 27906
Fixed 31482: Fix Type Safety and Raw Types warnings

- AdvPaymentMngtDao, parametrize obc parameters as function
is private and only used with that specific paramtetric type
- ConvertQuotationIntoOrder
- Iterator+Entry usage of a already parametric Map
So no reason to abandon type info + later need manual casts
again.
- ProductionMultiple problem is older servlet api not having
a generic version of those methods so just silence this one
with a SupressWarnings

Sat, 14 Nov 2015 14:19:01 +0100Fixed 31481: Fix & improve javadoc generation
Stefan Hühner <stefan.huehner@openbravo.com> [Sat, 14 Nov 2015 14:19:01 +0100] rev 27905
Fixed 31481: Fix & improve javadoc generation

- add modules src + src-test to generated javadoc to not miss all the
code in modules in the docs (convert to subelement sourcepath for this)
- fix referencing java sources in src-test by adding /src to the reference
- add modules/*/lib/test/*.jar to find referenced class in test code
- update link to standard java6 javadoc to use newer url

- 2-3 simple javadoc syntax fixes in java files

Sat, 14 Nov 2015 13:26:10 +0100Fixed 31480: Remove unnecessary casts in code
Stefan Hühner <stefan.huehner@openbravo.com> [Sat, 14 Nov 2015 13:26:10 +0100] rev 27904
Fixed 31480: Remove unnecessary casts in code

A few distinct patterns:
- Cast from XX directly to XX just not needed at all
- sometimes from .uniqueResult()
- somtimes from i.e. reading from typed Map
- Cast from Object to XX then passing to API using object anyway
i.e. result of .uniqueResult() then passing to Restrictions.eq
- some misc ones like DalUtil.getId to String when not required

Sat, 14 Nov 2015 13:22:20 +0100Fixed 31479: Fix NPE with bdPriceList being null.
Stefan Hühner <stefan.huehner@openbravo.com> [Sat, 14 Nov 2015 13:22:20 +0100] rev 27903
Fixed 31479: Fix NPE with bdPriceList being null.

Fix logic error in if-condition to ensure the bdPriceList != null
check works as intended.

Sat, 14 Nov 2015 13:12:53 +0100Fixed 31478: Fix all warnings to access static fields in a static way.
Stefan Hühner <stefan.huehner@openbravo.com> [Sat, 14 Nov 2015 13:12:53 +0100] rev 27902
Fixed 31478: Fix all warnings to access static fields in a static way.

i.e. json.NULL -> JSONObject.NULL
with NULL being a static constant in that class

Fri, 13 Nov 2015 17:08:52 +0100Fixed 30681. Cleanup rest of warnings in src-core
Stefan Hühner <stefan.huehner@openbravo.com> [Fri, 13 Nov 2015 17:08:52 +0100] rev 27901
Fixed 30681. Cleanup rest of warnings in src-core

Cleanup all (but 2) warnings in src-core:

- HttpBaseServlet:
Fix NPE. Apparently wrong operator used as testing for ""
for a nullpointer does not make sense. But testing for not
null and not empty does.
- JNDIConnectionProvider.PoolInfo
Add default serialVersionUID constant
- TranslationHandler remove never read field. Add comment to (public)
setter about its value not being used.
- TranslationUtils
Remove local variable never being read

Fri, 13 Nov 2015 16:12:27 +0100Issue 30681: Fix all 'Parameter should not be assigned warnings' in src-core
Stefan Hühner <stefan.huehner@openbravo.com> [Fri, 13 Nov 2015 16:12:27 +0100] rev 27900
Issue 30681: Fix all 'Parameter should not be assigned warnings' in src-core

Same fix always in case parameter p is written to:
Rename parameter to _p
Create temporary variable p in first line of the method, assigning it
from the _p renamed parameter.

Additionally in file BuildValidationHandler:
Chaneg access to members basedir and module to be static and not via
this. as those are static fields.

Fri, 13 Nov 2015 16:02:57 +0100Issue 30681: Fix all 'Name Shadowing an Conflicts' warnings in src-core
Stefan Hühner <stefan.huehner@openbravo.com> [Fri, 13 Nov 2015 16:02:57 +0100] rev 27899
Issue 30681: Fix all 'Name Shadowing an Conflicts' warnings in src-core
Mostly 2 classes:
- parameter name same as field name
Solve by renaming parameter to be unique in all function
as it takes precendence over field name unless using this.
- Local variable having same name as field name
Solve by renaming local variable as it takes precedence over
field name unless using this.
Exceptions:
- Slqc.java remove parameter out completely as it was never used
in the function
- XmlTemplate: remove field uri as it was never used (so now only
local var in some methods without shading the field)
- XmlVectorValue
- Remove unused field xmlDocument and references writing to it
as it was never read
- remove function printStringBuffer(HaspMap...) completely as
it was never used

Mon, 09 Nov 2015 13:41:23 +0100Fixes issue 31144: Error in Costing Background
Alvaro Ferraz <alvaro.ferraz@openbravo.com> [Mon, 09 Nov 2015 13:41:23 +0100] rev 27898
Fixes issue 31144: Error in Costing Background

Costing Background process was failing when first costing rule of an organization was validated with a starting date in the future.
Transactions before this starting date were calculated at zero cost but they were not set as processed, and then Costing Background was wrongly taking those transactions into account to calculate their cost.

Mon, 16 Nov 2015 18:09:03 +0100Related with issue 31432: Updates classpath
Augusto Mauch <augusto.mauch@openbravo.com> [Mon, 16 Nov 2015 18:09:03 +0100] rev 27897
Related with issue 31432: Updates classpath

Fri, 06 Nov 2015 13:14:15 +0100Fixes issue 31207: Error when the FixBackdatedFrom is before StartingDate
Alvaro Ferraz <alvaro.ferraz@openbravo.com> [Fri, 06 Nov 2015 13:14:15 +0100] rev 27896
Fixes issue 31207: Error when the FixBackdatedFrom is before StartingDate

The costing background process was failing when the 'fixbackdated from' is defined before the costing rule's starting date.
Check transaction movement date is equals or after than costing rule fix backdated from date, when creating BDT cost adjustments.
getCostingRuleFixBackdatedFrom method in CostingUtils was wrongly retrieving costing rule starting date instead of fix backdated from date.

Mon, 16 Nov 2015 11:19:34 +0100Related to issue 31069: Fix testCostingE3 test in TestCosting
Alvaro Ferraz <alvaro.ferraz@openbravo.com> [Mon, 16 Nov 2015 11:19:34 +0100] rev 27895
Related to issue 31069: Fix testCostingE3 test in TestCosting

Mon, 16 Nov 2015 11:16:11 +0100Related to issue 31202: Fix testCostingE2 test in TestCosting
Alvaro Ferraz <alvaro.ferraz@openbravo.com> [Mon, 16 Nov 2015 11:16:11 +0100] rev 27894
Related to issue 31202: Fix testCostingE2 test in TestCosting

Mon, 16 Nov 2015 14:27:46 +0100Updates common-io library version in Licensing.txt
Augusto Mauch <augusto.mauch@openbravo.com> [Mon, 16 Nov 2015 14:27:46 +0100] rev 27893
Updates common-io library version in Licensing.txt

Mon, 16 Nov 2015 12:31:48 +0100Related to Issue 31080. Code Review changes.
David Miguelez <david.miguelez@openbravo.com> [Mon, 16 Nov 2015 12:31:48 +0100] rev 27892
Related to Issue 31080. Code Review changes.

Takes into account if a Product is defined as Production when
filtering the queries by Organization and Warehouse.

Wed, 11 Nov 2015 11:30:33 +0100Fixes issue 31080: Standard Algorithm is not working with Inventory Amount Update
Alvaro Ferraz <alvaro.ferraz@openbravo.com> [Wed, 11 Nov 2015 11:30:33 +0100] rev 27891
Fixes issue 31080: Standard Algorithm is not working with Inventory Amount Update

Display "Backdated Transactions Fixed" flag and "Fix Backdated Transactions" button in Costing Rule window, also with "Standard Algorithm".
With Standard cost, when creating a backdated transaction (which modifies the stock in the past) and in case we have "Backdated Transactions Fixed" flag activated, a BDT adjustment will be created related to any of the opening inventory transactions of each Inventory Amount Update created after backdated transaction.
With Standard cost, when creating a backdated Inventory Amount Update (which modifies the cost in the past), a BDT adjustment will be created related to each transaction created after backdated Inventory Amount Update and before next Inventory Amount Update created, including closing inventory transactions related to next Inventory Amount Update created.

Mon, 16 Nov 2015 13:45:51 +0100Backed out changeset f96d16904892
David Miguelez <david.miguelez@openbravo.com> [Mon, 16 Nov 2015 13:45:51 +0100] rev 27890
Backed out changeset f96d16904892

Mon, 16 Nov 2015 13:43:53 +0100Backed out changeset 54816dff1cfb
David Miguelez <david.miguelez@openbravo.com> [Mon, 16 Nov 2015 13:43:53 +0100] rev 27889
Backed out changeset 54816dff1cfb

Mon, 16 Nov 2015 12:31:48 +0100Related to Issue 31080. Code Review changes.
David Miguelez <david.miguelez@openbravo.com> [Mon, 16 Nov 2015 12:31:48 +0100] rev 27888
Related to Issue 31080. Code Review changes.

Takes into account if a Product is defined as Production when
filtering the queries by Organization and Warehouse.

Fri, 13 Nov 2015 13:33:58 +0100Issue 31080
David Miguelez <david.miguelez@openbravo.com> [Fri, 13 Nov 2015 13:33:58 +0100] rev 27887
Issue 31080

Wed, 11 Nov 2015 17:48:28 +0100Fixes issue 31432: Upgrade version of commons-io from 2.0.1 to 2.4
Augusto Mauch <augusto.mauch@openbravo.com> [Wed, 11 Nov 2015 17:48:28 +0100] rev 27886
Fixes issue 31432: Upgrade version of commons-io from 2.0.1 to 2.4

In the near future a module related with database synchronization is going to be published. This module requires the 2.4 version of the commons-io library, that's why the commons-io library has been updated to this version.