Mon, 16 Nov 2015 11:19:34 +0100Related to issue 31069: Fix testCostingE3 test in TestCosting
Alvaro Ferraz <alvaro.ferraz@openbravo.com> [Mon, 16 Nov 2015 11:19:34 +0100] rev 27895
Related to issue 31069: Fix testCostingE3 test in TestCosting

Mon, 16 Nov 2015 11:16:11 +0100Related to issue 31202: Fix testCostingE2 test in TestCosting
Alvaro Ferraz <alvaro.ferraz@openbravo.com> [Mon, 16 Nov 2015 11:16:11 +0100] rev 27894
Related to issue 31202: Fix testCostingE2 test in TestCosting

Mon, 16 Nov 2015 14:27:46 +0100Updates common-io library version in Licensing.txt
Augusto Mauch <augusto.mauch@openbravo.com> [Mon, 16 Nov 2015 14:27:46 +0100] rev 27893
Updates common-io library version in Licensing.txt

Mon, 16 Nov 2015 12:31:48 +0100Related to Issue 31080. Code Review changes.
David Miguelez <david.miguelez@openbravo.com> [Mon, 16 Nov 2015 12:31:48 +0100] rev 27892
Related to Issue 31080. Code Review changes.

Takes into account if a Product is defined as Production when
filtering the queries by Organization and Warehouse.

Wed, 11 Nov 2015 11:30:33 +0100Fixes issue 31080: Standard Algorithm is not working with Inventory Amount Update
Alvaro Ferraz <alvaro.ferraz@openbravo.com> [Wed, 11 Nov 2015 11:30:33 +0100] rev 27891
Fixes issue 31080: Standard Algorithm is not working with Inventory Amount Update

Display "Backdated Transactions Fixed" flag and "Fix Backdated Transactions" button in Costing Rule window, also with "Standard Algorithm".
With Standard cost, when creating a backdated transaction (which modifies the stock in the past) and in case we have "Backdated Transactions Fixed" flag activated, a BDT adjustment will be created related to any of the opening inventory transactions of each Inventory Amount Update created after backdated transaction.
With Standard cost, when creating a backdated Inventory Amount Update (which modifies the cost in the past), a BDT adjustment will be created related to each transaction created after backdated Inventory Amount Update and before next Inventory Amount Update created, including closing inventory transactions related to next Inventory Amount Update created.

Mon, 16 Nov 2015 13:45:51 +0100Backed out changeset f96d16904892
David Miguelez <david.miguelez@openbravo.com> [Mon, 16 Nov 2015 13:45:51 +0100] rev 27890
Backed out changeset f96d16904892

Mon, 16 Nov 2015 13:43:53 +0100Backed out changeset 54816dff1cfb
David Miguelez <david.miguelez@openbravo.com> [Mon, 16 Nov 2015 13:43:53 +0100] rev 27889
Backed out changeset 54816dff1cfb

Mon, 16 Nov 2015 12:31:48 +0100Related to Issue 31080. Code Review changes.
David Miguelez <david.miguelez@openbravo.com> [Mon, 16 Nov 2015 12:31:48 +0100] rev 27888
Related to Issue 31080. Code Review changes.

Takes into account if a Product is defined as Production when
filtering the queries by Organization and Warehouse.

Fri, 13 Nov 2015 13:33:58 +0100Issue 31080
David Miguelez <david.miguelez@openbravo.com> [Fri, 13 Nov 2015 13:33:58 +0100] rev 27887
Issue 31080

Wed, 11 Nov 2015 17:48:28 +0100Fixes issue 31432: Upgrade version of commons-io from 2.0.1 to 2.4
Augusto Mauch <augusto.mauch@openbravo.com> [Wed, 11 Nov 2015 17:48:28 +0100] rev 27886
Fixes issue 31432: Upgrade version of commons-io from 2.0.1 to 2.4

In the near future a module related with database synchronization is going to be published. This module requires the 2.4 version of the commons-io library, that's why the commons-io library has been updated to this version.

Mon, 16 Nov 2015 13:18:49 +0100related to issue 30436: added missing js beautify
Carlos Aristu <carlos.aristu@openbravo.com> [Mon, 16 Nov 2015 13:18:49 +0100] rev 27885
related to issue 30436: added missing js beautify

Mon, 16 Nov 2015 13:15:27 +0100related to issue 31434: code review improvements
Carlos Aristu <carlos.aristu@openbravo.com> [Mon, 16 Nov 2015 13:15:27 +0100] rev 27884
related to issue 31434: code review improvements

Mon, 16 Nov 2015 10:00:45 +0100fixes issue 29090: Archiving on email adds description 'generated by e-mailing'
Carlos Aristu <carlos.aristu@openbravo.com> [Mon, 16 Nov 2015 10:00:45 +0100] rev 27883
fixes issue 29090: Archiving on email adds description 'generated by e-mailing'

Now the ReportManager overloads the createAttachmentForReport method in order to allow the ability of passing a description for the attachment

Mon, 16 Nov 2015 08:52:40 +0100fixes issue 28200: Amount field located in 'Cost' tab set as read-only
Carlos Aristu <carlos.aristu@openbravo.com> [Mon, 16 Nov 2015 08:52:40 +0100] rev 27882
fixes issue 28200: Amount field located in 'Cost' tab set as read-only

The Amount field has a read only logic based on the value of the Invoice Line field and this problem was reproducible if we tab over the Invoice Line field. After that action, the setValue() function of OBComboBoxItem was setting the value to null.

This caused that the currentValue was set to null in setItemValue function of ob-view-form, avoiding to include the invoiceline property into the currentValues of the form. As this property was not present, an undefined value was retrieved when computing the read only logic for the amount field, so the logic was not being calculated properly, causing this field to be displayed as read only.

This was an Smartclient issue in the OBComboBoxItem widget. The corresponding fix for the setValue() function has been applied to solve the issue.

Fri, 13 Nov 2015 12:14:29 +0100Related to issue 31461: Add property to prevent import process threads to run in instance
Martin Taal <martin.taal@openbravo.com> [Fri, 13 Nov 2015 12:14:29 +0100] rev 27881
Related to issue 31461: Add property to prevent import process threads to run in instance
Prevent NPE when entries are created

Fri, 13 Nov 2015 11:33:39 +0100Fixes issue 31461: Add property to prevent import process threads to run in instance
Martin Taal <martin.taal@openbravo.com> [Fri, 13 Nov 2015 11:33:39 +0100] rev 27880
Fixes issue 31461: Add property to prevent import process threads to run in instance
Prevent threads from starting if import.disable.process property is set to true

Fri, 13 Nov 2015 11:07:02 +0100Related to issue 31410: Import entry process can have a stopped but not deregistered thread: tickets remain in the queue
Martin Taal <martin.taal@openbravo.com> [Fri, 13 Nov 2015 11:07:02 +0100] rev 27879
Related to issue 31410: Import entry process can have a stopped but not deregistered thread: tickets remain in the queue
Handle the case that the import entry has no role set, use the default in that case

Fri, 13 Nov 2015 10:07:21 +0100fixes issue 28687: IllegalArgumentException in QueryListDataSource
Carlos Aristu <carlos.aristu@openbravo.com> [Fri, 13 Nov 2015 10:07:21 +0100] rev 27878
fixes issue 28687: IllegalArgumentException in QueryListDataSource

The exception will not be thrown anymore as we now check if value is null before executing xmlDateFormat.format(value).

Fri, 13 Nov 2015 10:05:37 +0100related to bug 28477: removed debugging code
Asier Lostalé <asier.lostale@openbravo.com> [Fri, 13 Nov 2015 10:05:37 +0100] rev 27877
related to bug 28477: removed debugging code

Fri, 13 Nov 2015 09:02:58 +0100fixed bug 28477: view generation: unneeded queries to trl tables
Asier Lostalé <asier.lostale@openbravo.com> [Fri, 13 Nov 2015 09:02:58 +0100] rev 27876
fixed bug 28477: view generation: unneeded queries to trl tables

When generating view definition for standard windows queries to translation
tables where performed regardless the instance had no translation installed.
This results in several queries that were useless as they should never return
any value.

These queries have been prevented by checking if translations are installed
before executing them.

Fri, 13 Nov 2015 08:43:20 +0100fixes issue 28977: NPE if property field can not reach the complete path
Carlos Aristu <carlos.aristu@openbravo.com> [Fri, 13 Nov 2015 08:43:20 +0100] rev 27875
fixes issue 28977: NPE if property field can not reach the complete path

The NPE was thrown when defining a property field in the header tab. The FIC is using the getValueFromPath() method to calculate the value of the property field on NEW mode. It is sending as parameter the reference to the parent record for the cases where the value of the property field can be retrieved using the parent information. As in the header tabs we do not have a reference to a parent record, the parameter is null in these cases.

To solve the problem now we first check in getValueFromPath() method if the bob passed as parameter is null. In that case we return null in order to avoid the NPE.

Thu, 12 Nov 2015 17:03:51 +0100fixes issue 30436: Some columns appear empty when adding them in a saved view
Carlos Aristu <carlos.aristu@openbravo.com> [Thu, 12 Nov 2015 17:03:51 +0100] rev 27874
fixes issue 30436: Some columns appear empty when adding them in a saved view

The problem happened when adding a field with a saved view which by defaul is not displayed in the grid. In that case the values for that field are not present in the client side and is necessary to perform a request to the datasource.

To solve the problem a new method has been included for OBViewGrid, viewHasFieldsNotInGrid, which checks if every field added by the saved view is already displayed in the grid. If not then we invalidate the cache to force a request to the datasource through the refreshContents() function.

Thu, 12 Nov 2015 18:42:04 +0100Fixes issue 31387 & Fixes issue 31389: code review improvements
Víctor Martínez Romanos <victor.martinez@openbravo.com> [Thu, 12 Nov 2015 18:42:04 +0100] rev 27873
Fixes issue 31387 & Fixes issue 31389: code review improvements

Reverted back the behavior of the Sender field. It shows the Business Partner Name (from the OB object) or the Business Partner Name string as it was doing before.

Wed, 11 Nov 2015 20:01:21 +0100Fixes issue 31387 & Fixes issue 31389: Add two new columns in Match Statement
Alvaro Ferraz <alvaro.ferraz@openbravo.com> [Wed, 11 Nov 2015 20:01:21 +0100] rev 27872
Fixes issue 31387 & Fixes issue 31389: Add two new columns in Match Statement

Added Business Partner Name and Transaction Description as new fields in Match Statement P&E window. They will not be shown in grid by default.
HQL Query in aprm_matchstatement table has been modified to retrieve this two new columns from FIN_BankStatementLine and FIN_Finacc_Transaction tables, and to retrieve bp.name as businessPartner also in case it is null.

Tue, 10 Nov 2015 19:05:45 +0100Fixes issue 31385: BusinessPartnerName not loaded in AddTransaction description
Alvaro Ferraz <alvaro.ferraz@openbravo.com> [Tue, 10 Nov 2015 19:05:45 +0100] rev 27871
Fixes issue 31385: BusinessPartnerName not loaded in AddTransaction description

Add Transaction description will be loaded with Business Partner name + Bank Statement Line description, in case Business Partner name is not empty.

Thu, 12 Nov 2015 18:24:03 +0100fixes issue 31104: Lazy filtering feature also affects column sorting
Carlos Aristu <carlos.aristu@openbravo.com> [Thu, 12 Nov 2015 18:24:03 +0100] rev 27870
fixes issue 31104: Lazy filtering feature also affects column sorting

- Updated help and description fields for the lazy filtering fields on Grid Configuration windows, explaining that the change affects to the sorting also.
- Updated the lazy filtering button tooltip.

Wed, 04 Nov 2015 10:05:47 +0100Related to issue 31069: Added an automated test in TestCosting
Alvaro Ferraz <alvaro.ferraz@openbravo.com> [Wed, 04 Nov 2015 10:05:47 +0100] rev 27869
Related to issue 31069: Added an automated test in TestCosting

Thu, 29 Oct 2015 22:53:04 +0100Related to issue 31069: Added sleep to avoid assert errors in testCostingE1
Alvaro Ferraz <alvaro.ferraz@openbravo.com> [Thu, 29 Oct 2015 22:53:04 +0100] rev 27868
Related to issue 31069: Added sleep to avoid assert errors in testCostingE1

Wed, 28 Oct 2015 13:40:44 +0100Fixes issue 31069: Wrong cost calculation in Inventory Amount Update
Alvaro Ferraz <alvaro.ferraz@openbravo.com> [Wed, 28 Oct 2015 13:40:44 +0100] rev 27867
Fixes issue 31069: Wrong cost calculation in Inventory Amount Update

Change the reference of Unit Cost and Current Unit Cost columns from Amount to Number in Inventory Amount Update window, to take into account currency precision.
Remove getInventoryClosingCost method from AverageAlgorithm to calculate inventory closing transactions with Average Algorithm with current average cost, as it is done in getInventoryClosingCost method from CostingAlgorithm.
Set line number correctly to Physical Inventory Lines in InventoryAmountUpdateProcess.
Create a Negative Stock Correction adjustment related to last closing inventory line transaction created by an Inventory Amount Update (the ones that leaves the curent stock to zero) with current valued stock (remaining value) if any.
Retrieve trx and icl from session in CostingRuleProcess to avoid errors when validating a new Costing Rule.

Thu, 12 Nov 2015 17:32:58 +0100Fixes issue 30961: Warehouse rules will now make partial reservations
Alvaro Ferraz <alvaro.ferraz@openbravo.com> [Thu, 12 Nov 2015 17:32:58 +0100] rev 27866
Fixes issue 30961: Warehouse rules will now make partial reservations

Warehouse rules will now make partial reservations in case it exists stock for the reservation but not enough to cover it completely.