Thu, 18 Feb 2016 16:29:10 +0100[cross-org] renamed field to be consistent with the rest
Asier Lostalé <asier.lostale@openbravo.com> [Thu, 18 Feb 2016 16:29:10 +0100] rev 28907
[cross-org] renamed field to be consistent with the rest

Thu, 18 Feb 2016 16:28:38 +0100[cross-org] added boolean DB constraint
Asier Lostalé <asier.lostale@openbravo.com> [Thu, 18 Feb 2016 16:28:38 +0100] rev 28906
[cross-org] added boolean DB constraint

Thu, 18 Feb 2016 16:23:21 +0100[cross-org] removed unneeded code
Asier Lostalé <asier.lostale@openbravo.com> [Thu, 18 Feb 2016 16:23:21 +0100] rev 28905
[cross-org] removed unneeded code

Thu, 18 Feb 2016 16:10:01 +0100[cross-org] ADMIN_TRACE_SIZE is not final anymore
Asier Lostalé <asier.lostale@openbravo.com> [Thu, 18 Feb 2016 16:10:01 +0100] rev 28904
[cross-org] ADMIN_TRACE_SIZE is not final anymore

* This prevents warn messages for dead code
* A setter has also been created to allow changing it

Thu, 18 Feb 2016 16:05:27 +0100[cross-org] test case for cross org admin mode working as stack
Asier Lostalé <asier.lostale@openbravo.com> [Thu, 18 Feb 2016 16:05:27 +0100] rev 28903
[cross-org] test case for cross org admin mode working as stack

Thu, 18 Feb 2016 16:05:05 +0100[cross-org] javadoc
Asier Lostalé <asier.lostale@openbravo.com> [Thu, 18 Feb 2016 16:05:05 +0100] rev 28902
[cross-org] javadoc

Thu, 18 Feb 2016 15:57:52 +0100[cross-org] rename for consistency
Asier Lostalé <asier.lostale@openbravo.com> [Thu, 18 Feb 2016 15:57:52 +0100] rev 28901
[cross-org] rename for consistency

Thu, 18 Feb 2016 15:56:18 +0100[cross-org] removed duplicated test case
Asier Lostalé <asier.lostale@openbravo.com> [Thu, 18 Feb 2016 15:56:18 +0100] rev 28900
[cross-org] removed duplicated test case

Thu, 18 Feb 2016 15:47:27 +0100[cross-org] proper implementation for cross org admin stack
Asier Lostalé <asier.lostale@openbravo.com> [Thu, 18 Feb 2016 15:47:27 +0100] rev 28899
[cross-org] proper implementation for cross org admin stack

Thu, 18 Feb 2016 15:46:47 +0100[cross-org] test cases for cross org admin mode
Asier Lostalé <asier.lostale@openbravo.com> [Thu, 18 Feb 2016 15:46:47 +0100] rev 28898
[cross-org] test cases for cross org admin mode

Thu, 18 Feb 2016 15:45:13 +0100[cross-org] ALLOWED_CROSS_ORG_LINK onCreateDefault
Asier Lostalé <asier.lostale@openbravo.com> [Thu, 18 Feb 2016 15:45:13 +0100] rev 28897
[cross-org] ALLOWED_CROSS_ORG_LINK onCreateDefault

Thu, 18 Feb 2016 15:23:29 +0100[cross-org] pi merge
Asier Lostalé <asier.lostale@openbravo.com> [Thu, 18 Feb 2016 15:23:29 +0100] rev 28896
[cross-org] pi merge

Thu, 18 Feb 2016 15:22:50 +0100[cross-org] partial backout of changeset ae290995c081
Asier Lostalé <asier.lostale@openbravo.com> [Thu, 18 Feb 2016 15:22:50 +0100] rev 28895
[cross-org] partial backout of changeset ae290995c081

Some column postions were unintentionally changed. This causes conflicts
merging with pi.

Thu, 18 Feb 2016 11:23:05 +0100[cross-org] testing with a more limited role (access only to Spain, no *)
Asier Lostalé <asier.lostale@openbravo.com> [Thu, 18 Feb 2016 11:23:05 +0100] rev 28894
[cross-org] testing with a more limited role (access only to Spain, no *)

Thu, 18 Feb 2016 10:38:51 +0100[cross-org] test cases covering DAL one-to-many bags fetch
Asier Lostalé <asier.lostale@openbravo.com> [Thu, 18 Feb 2016 10:38:51 +0100] rev 28893
[cross-org] test cases covering DAL one-to-many bags fetch

Thu, 18 Feb 2016 09:44:34 +0100[cross-org] added test cases for one to many relationships
Asier Lostalé <asier.lostale@openbravo.com> [Thu, 18 Feb 2016 09:44:34 +0100] rev 28892
[cross-org] added test cases for one to many relationships

Thu, 18 Feb 2016 08:55:23 +0100[cross-org] clean up after test execution
Asier Lostalé <asier.lostale@openbravo.com> [Thu, 18 Feb 2016 08:55:23 +0100] rev 28891
[cross-org] clean up after test execution

Thu, 18 Feb 2016 08:31:31 +0100[cross-org] basic implementation for cross org references:
Asier Lostalé <asier.lostale@openbravo.com> [Thu, 18 Feb 2016 08:31:31 +0100] rev 28890
[cross-org] basic implementation for cross org references:

- Allowed cross org is read in base Column model
- This value is kept in run-time in memory model
- New crossOrgReferenceAdminMode can be set in OBContext
- This admin mode is taken into account to check org of FKs

Thu, 18 Feb 2016 08:26:20 +0100[cross-org] test cases for column allowing cross org, but not in org admin mode
Asier Lostalé <asier.lostale@openbravo.com> [Thu, 18 Feb 2016 08:26:20 +0100] rev 28889
[cross-org] test cases for column allowing cross org, but not in org admin mode

Wed, 17 Feb 2016 16:55:49 +0100[cross-org] DB infra to define allowed cross org link
Asier Lostalé <asier.lostale@openbravo.com> [Wed, 17 Feb 2016 16:55:49 +0100] rev 28888
[cross-org] DB infra to define allowed cross org link

Wed, 17 Feb 2016 16:52:45 +0100[cross-org] added test to suite
Asier Lostalé <asier.lostale@openbravo.com> [Wed, 17 Feb 2016 16:52:45 +0100] rev 28887
[cross-org] added test to suite

Wed, 17 Feb 2016 16:50:50 +0100[cross-org] added basic test for cross org reference
Asier Lostalé <asier.lostale@openbravo.com> [Wed, 17 Feb 2016 16:50:50 +0100] rev 28886
[cross-org] added basic test for cross org reference

Wed, 17 Feb 2016 16:50:12 +0100[cross-org] add parent test class
Asier Lostalé <asier.lostale@openbravo.com> [Wed, 17 Feb 2016 16:50:12 +0100] rev 28885
[cross-org] add parent test class

Wed, 17 Feb 2016 16:10:28 +0100[cross-org] renamed test class
Asier Lostalé <asier.lostale@openbravo.com> [Wed, 17 Feb 2016 16:10:28 +0100] rev 28884
[cross-org] renamed test class

Wed, 17 Feb 2016 15:48:18 +0100[cross-org] added test cases covering current behavior
Asier Lostalé <asier.lostale@openbravo.com> [Wed, 17 Feb 2016 15:48:18 +0100] rev 28883
[cross-org] added test cases covering current behavior

Wed, 13 Apr 2016 10:50:18 +0200Related to issue 32573: Code review improvements
Alvaro Ferraz <alvaro.ferraz@openbravo.com> [Wed, 13 Apr 2016 10:50:18 +0200] rev 28882
Related to issue 32573: Code review improvements

Wed, 13 Apr 2016 08:38:40 +0200fixed issue 32511: support JBoss AS 7.1.1
Asier Lostalé <asier.lostale@openbravo.com> [Wed, 13 Apr 2016 08:38:40 +0200] rev 28881
fixed issue 32511: support JBoss AS 7.1.1

Wed, 13 Apr 2016 08:35:27 +0200[wildfly] fixed typos in log messages
Asier Lostalé <asier.lostale@openbravo.com> [Wed, 13 Apr 2016 08:35:27 +0200] rev 28880
[wildfly] fixed typos in log messages

Thu, 07 Apr 2016 15:05:49 +0200[wildfly] fixed typo
Asier Lostalé <asier.lostale@openbravo.com> [Thu, 07 Apr 2016 15:05:49 +0200] rev 28879
[wildfly] fixed typo

Thu, 07 Apr 2016 14:42:59 +0200[wildfly] it's possible to prevent MMC rebuild with a pref
Asier Lostalé <asier.lostale@openbravo.com> [Thu, 07 Apr 2016 14:42:59 +0200] rev 28878
[wildfly] it's possible to prevent MMC rebuild with a pref

Thu, 07 Apr 2016 13:21:09 +0200[wildfly] if not running in Tomcat, do not allow to rebuild/restart system
Asier Lostalé <asier.lostale@openbravo.com> [Thu, 07 Apr 2016 13:21:09 +0200] rev 28877
[wildfly] if not running in Tomcat, do not allow to rebuild/restart system
from MMC's UI

Tue, 05 Apr 2016 12:26:12 +0200[wildfly] pi merge
Asier Lostalé <asier.lostale@openbravo.com> [Tue, 05 Apr 2016 12:26:12 +0200] rev 28876
[wildfly] pi merge

Mon, 21 Mar 2016 09:26:05 +0100[wildlfly] read BeanManager from jndi if not present in ServletContext
Asier Lostalé <asier.lostale@openbravo.com> [Mon, 21 Mar 2016 09:26:05 +0100] rev 28875
[wildlfly] read BeanManager from jndi if not present in ServletContext

Tomcat stores BeanManager in ServletContext whereas wildfly does not, it saves
it in as a jdni resource.

Mon, 21 Mar 2016 08:50:35 +0100[wildfly] read templates as stream instead of as URL
Asier Lostalé <asier.lostale@openbravo.com> [Mon, 21 Mar 2016 08:50:35 +0100] rev 28874
[wildfly] read templates as stream instead of as URL

Reading templates as a URL resource from classpath is problematic when
deploying in wildfly (returs vfs:/// protocol instead of file:///).

This is fixed by reading the resource as a stream.

Fri, 18 Mar 2016 13:01:38 +0100fixed 32506: GenerateComponentTest.testApplication test case is ignored
Asier Lostalé <asier.lostale@openbravo.com> [Fri, 18 Mar 2016 13:01:38 +0100] rev 28873
fixed 32506: GenerateComponentTest.testApplication test case is ignored

It failed because of same reasons of #32507.

Having this issue fixed we can now enable it again.

Fri, 18 Mar 2016 13:00:05 +0100fixed bug 32507: NPE when executing GenerateComponentTest.testStaticResources
Asier Lostalé <asier.lostale@openbravo.com> [Fri, 18 Mar 2016 13:00:05 +0100] rev 28872
fixed bug 32507: NPE when executing GenerateComponentTest.testStaticResources

StaticResourcesComponent assumes there is a ServletContext to read templates
based on it. As test is executed out of Tomcat there is no ServletContext,
causing NPE.

Fixed by mocking a ServletContext.

Additionally ApplicationComponent assumes there is a session to get format values
from causing also NPE when executing as test.

Fixed by dealing with this case and returning an empty map.

Mon, 11 Apr 2016 11:02:52 +0200Related to issue 32573: Update copyright
Alvaro Ferraz <alvaro.ferraz@openbravo.com> [Mon, 11 Apr 2016 11:02:52 +0200] rev 28871
Related to issue 32573: Update copyright

Wed, 06 Apr 2016 15:23:01 +0530Fixes bug 32573:Not possible to execute Automatic Deposit payment created in FA
Atul Gaware <atul.gaware@openbravo.com> [Wed, 06 Apr 2016 15:23:01 +0530] rev 28870
Fixes bug 32573:Not possible to execute Automatic Deposit payment created in FA

Before creating a record in financial account transaction, check is done: if transaction exists, get it so that no transactiom is created and the same is sent for processing

Mon, 11 Apr 2016 10:46:58 +0200Related to issue 32383: Code review improvements
Alvaro Ferraz <alvaro.ferraz@openbravo.com> [Mon, 11 Apr 2016 10:46:58 +0200] rev 28869
Related to issue 32383: Code review improvements

Tue, 05 Apr 2016 15:26:26 +0530Fixes Issue 32383:Payments can be deposited without being executed
Atul Gaware <atul.gaware@openbravo.com> [Tue, 05 Apr 2016 15:26:26 +0530] rev 28868
Fixes Issue 32383:Payments can be deposited without being executed

In case of payment created using financial account transaction add payment selector (+), a check for payment method with automatic execution process is added before processing transaction and payment has awaiting execution status.

Fri, 08 Apr 2016 14:58:03 +0200fixes issue 32627: template role cannot be used as session role
Carlos Aristu <carlos.aristu@openbravo.com> [Fri, 08 Apr 2016 14:58:03 +0200] rev 28867
fixes issue 32627: template role cannot be used as session role
Now the injector used for preferences returns the complete Role object and not a proxy, in order to prevent possible LazyInitializationException when using a template role as session role.
This was happening because some preferences are created at system level when a session role is making use of the UI. It is also verified that after fixing this issue, those preferences are not being propagated, thanks to the preference black list.

Fri, 08 Apr 2016 14:07:14 +0200fixes issue 32626: cannot propagate privileges if a template role has been used
Carlos Aristu <carlos.aristu@openbravo.com> [Fri, 08 Apr 2016 14:07:14 +0200] rev 28866
fixes issue 32626: cannot propagate privileges if a template role has been used
Now the client/org check is skipped when propagating changes (create, remove, update) privileges. This is done by using the OBContext.setAdminMode(false).
Besides, the UINAVBA_MenuRecentList preference has been included into the preference black list, which is a list that prevents the propagation of all the preferences included within it.

Fri, 08 Apr 2016 10:40:36 +0200related to bug 32605: removed some duplication
Asier Lostalé <asier.lostale@openbravo.com> [Fri, 08 Apr 2016 10:40:36 +0200] rev 28865
related to bug 32605: removed some duplication

hql where clause was converted to lower case several times

Thu, 07 Apr 2016 11:26:17 +0200Related to Issue 32341: Prevents infinite loop if organization is null
David Miguelez <david.miguelez@openbravo.com> [Thu, 07 Apr 2016 11:26:17 +0200] rev 28864
Related to Issue 32341: Prevents infinite loop if organization is null

Wed, 02 Mar 2016 10:18:21 +0100Fixes issue 32341: Performance problem in ResetAccounting
Alvaro Ferraz <alvaro.ferraz@openbravo.com> [Wed, 02 Mar 2016 10:18:21 +0100] rev 28863
Fixes issue 32341: Performance problem in ResetAccounting

Modify ad_org_getperiodcontrolallow function to make it recursive and improve its query.
Execute query only once in ResetAccounting.java and for every orgIds instead of for each orgId in orgIds. Query will be done in SQL instead of HQL to avoid errors when executing PostDocumentTest.

Wed, 06 Apr 2016 11:12:42 +0200Related issue 32584: Code review and improvements
Inigo Sanchez <inigo.sanchez@openbravo.com> [Wed, 06 Apr 2016 11:12:42 +0200] rev 28862
Related issue 32584: Code review and improvements

Now WSWithNoActiveDalObjects works with Currency entity instead of
Organization entity in order to avoid some problems that appears
in this test in Oracle. (int-checks-oracle).

Besides it have been added small changes to improve legibility.

Tue, 05 Apr 2016 17:33:10 +0200Related to issue 32536: Code review improvements
Alvaro Ferraz <alvaro.ferraz@openbravo.com> [Tue, 05 Apr 2016 17:33:10 +0200] rev 28861
Related to issue 32536: Code review improvements

Avoid using orglist column also in SL_ProductPrice_PriceListVersion class.

Mon, 04 Apr 2016 10:41:45 +0530Fixes Issue 32536: Organizations not available in BalanceSheet and PL Structure
Atul Gaware <atul.gaware@openbravo.com> [Mon, 04 Apr 2016 10:41:45 +0530] rev 28860
Fixes Issue 32536: Organizations not available in BalanceSheet and PL Structure

Organization list is fetched using query instead of column orglist

Tue, 05 Apr 2016 18:08:46 +0200Related to issue 32539: Update copyright
Alvaro Ferraz <alvaro.ferraz@openbravo.com> [Tue, 05 Apr 2016 18:08:46 +0200] rev 28859
Related to issue 32539: Update copyright

Tue, 05 Apr 2016 18:49:43 +0530Fixes issue 32539: Fixed wrong calculation in acct with operands
Sanjota <sanjota.nelagi@promantia.com> [Tue, 05 Apr 2016 18:49:43 +0530] rev 28858
Fixes issue 32539: Fixed wrong calculation in acct with operands

Use #AccessibleOrgTree instead of #User_Org.

Tue, 05 Apr 2016 17:50:00 +0200Related to bug 32584: fix a problem related to context in a test.
Inigo Sanchez <inigo.sanchez@openbravo.com> [Tue, 05 Apr 2016 17:50:00 +0200] rev 28857
Related to bug 32584: fix a problem related to context in a test.

Tue, 05 Apr 2016 17:13:38 +0200fixed bug 32605: widgets summary field not displayed if HQL has group by clause
Asier Lostalé <asier.lostale@openbravo.com> [Tue, 05 Apr 2016 17:13:38 +0200] rev 28856
fixed bug 32605: widgets summary field not displayed if HQL has group by clause

When calculating in backend summary function, group by clause must be removed
from the query as all values should be aggregated without grouping.

Tue, 05 Apr 2016 17:12:02 +0200related to bug 32605: widget summary not displayed if HQL has group by clause
Asier Lostalé <asier.lostale@openbravo.com> [Tue, 05 Apr 2016 17:12:02 +0200] rev 28855
related to bug 32605: widget summary not displayed if HQL has group by clause

Added log in case exception is thrown when executing summary query.

Tue, 05 Apr 2016 16:50:22 +0200Related to bug 32584: Added test cases covering this regression
Inigo Sanchez <inigo.sanchez@openbravo.com> [Tue, 05 Apr 2016 16:50:22 +0200] rev 28854
Related to bug 32584: Added test cases covering this regression

Tue, 05 Apr 2016 16:26:21 +0200fixed bug 32604: Stock by Warehouse widget logs error message
Asier Lostalé <asier.lostale@openbravo.com> [Tue, 05 Apr 2016 16:26:21 +0200] rev 28853
fixed bug 32604: Stock by Warehouse widget logs error message

Quantiy on hand summary was incorrectly defined.

This summary has been removed because functionally it does not make sense to
sum quantities of different products and it would add performance degradation.

Tue, 05 Apr 2016 14:53:57 +0200Fixed bug 32584: fetch method does not retrieves data with a non active entity
Inigo Sanchez <inigo.sanchez@openbravo.com> [Tue, 05 Apr 2016 14:53:57 +0200] rev 28852
Fixed bug 32584: fetch method does not retrieves data with a non active entity

The problem here was that fetch method does not retrieves data with a non active
entity. (e.g., if it is tried to obtain a non active organization). It is not take
into account non active entities.

Now, the issues has been fixed by adding setFilterOnActive(false); to take into
account non active entities too.

Tue, 05 Apr 2016 12:21:35 +0200related to issue 32519: updated javadoc
Asier Lostalé <asier.lostale@openbravo.com> [Tue, 05 Apr 2016 12:21:35 +0200] rev 28851
related to issue 32519: updated javadoc

Tue, 22 Mar 2016 08:23:42 +0100fixed 32519: Openbravo.properties can be overriden from an absolute path
Asier Lostalé <asier.lostale@openbravo.com> [Tue, 22 Mar 2016 08:23:42 +0100] rev 28850
fixed 32519: Openbravo.properties can be overriden from an absolute path

It is now possible to override some properties by defining an abosolute path
to a properties file through properties.path system property.

Mon, 04 Apr 2016 18:22:09 +0200Related to issue 32281: Add coalesce to avoid null value in v_reservationqty
Alvaro Ferraz <alvaro.ferraz@openbravo.com> [Mon, 04 Apr 2016 18:22:09 +0200] rev 28849
Related to issue 32281: Add coalesce to avoid null value in v_reservationqty

Thu, 25 Feb 2016 09:46:02 -0500Fixed issue 32281: Wrong movement quantity of the picking list without enough stock available
Rafael Queralta Pozo <rqueralta@nauta.cu> [Thu, 25 Feb 2016 09:46:02 -0500] rev 28848
Fixed issue 32281: Wrong movement quantity of the picking list without enough stock available

Now, movement quantity of the picking list if stock available is not enough is equal to stock avilable - manual reservation qty

Wed, 30 Mar 2016 15:32:26 +0530Fixes Issue 32463: "Total payment" not correct in ReportRegisterByVatJR report
Atul Gaware <atul.gaware@openbravo.com> [Wed, 30 Mar 2016 15:32:26 +0530] rev 28847
Fixes Issue 32463: "Total payment" not correct in ReportRegisterByVatJR report

IsSale value in the data file was compared with different name as in jrxml query to negate tax line values in case of sales or purchase transaction in variable calculation. Now they are kept uniform in both jrxml as well as data xsql file.

Mon, 28 Mar 2016 16:16:15 +0530Fixes issue 32440: Same currency in Simple G/L Journal header and lines
Sanjota <sanjota.nelagi@promantia.com> [Mon, 28 Mar 2016 16:16:15 +0530] rev 28846
Fixes issue 32440: Same currency in Simple G/L Journal header and lines

Mon, 04 Apr 2016 11:59:06 +0200Related to issue 32392: Remove unused variables and methods
Alvaro Ferraz <alvaro.ferraz@openbravo.com> [Mon, 04 Apr 2016 11:59:06 +0200] rev 28845
Related to issue 32392: Remove unused variables and methods

Mon, 28 Mar 2016 12:44:57 -0400Fixes issue 32392: Wrong value in qtyreserved column of m_storage_pending in sales quotation.
Mark <m.molina@nectus.com> [Mon, 28 Mar 2016 12:44:57 -0400] rev 28844
Fixes issue 32392: Wrong value in qtyreserved column of m_storage_pending in sales quotation.

When the "Create Order process" was launched from a Sales Quotation that generates pending storage, the ordered quantity in the M_STORAGE_PENDING was the double than the original for a recently created product. It was caused because a double call of the M_UPDATE_STORAGE_PENDING PL. Inside the C_ORDER_POST PL (it creates the entry inside the M_STORAGE_PENDING with the quantity reserved), and then the lines were processed again, the M_UPDATE_STORAGE_PENDING was called again and it updates the previously created entry increasing the quantity reserved once more time.
The process is working as expected now.

Mon, 04 Apr 2016 11:52:47 +0200fixed bug 32576: connection leak when printing Requisition report
Asier Lostalé <asier.lostale@openbravo.com> [Mon, 04 Apr 2016 11:52:47 +0200] rev 28843
fixed bug 32576: connection leak when printing Requisition report

Ensure methods used by Requisition subreports close DAL transaction after using
it so that the connection is returned back to the pool.

Fri, 01 Apr 2016 14:45:21 +0200fixed bug 28586: error logged showing translatable identifier
Asier Lostalé <asier.lostale@openbravo.com> [Fri, 01 Apr 2016 14:45:21 +0200] rev 28842
fixed bug 28586: error logged showing translatable identifier

Having at least one translation installed in the system, whenever a DAL
identifier composed by translatable properties when retrieved, an error was
logged in case the translation entity for that property was not granted to
current role.

This is fixed by executing the query to retrieve translation in admin mode.

If the base property is granted at least in referred mode, its translations
should be accessible, so it is not problematic to set admin.

Fri, 01 Apr 2016 10:08:39 +0200Fixes issue 32553: Constraints and fks can be reenabled for a given table
Augusto Mauch <augusto.mauch@openbravo.com> [Fri, 01 Apr 2016 10:08:39 +0200] rev 28841
Fixes issue 32553: Constraints and fks can be reenabled for a given table

The method PlatformImplBase.enableCheckConstraintsForTable was not implemented properly, as it was trying to disable the constraints of a table instead of to enable it.

Also the enableAllFkForTable method was only defined in PostgreSqlPlatform, it should also be defined in enableAllFkForTable.

Wed, 23 Mar 2016 20:52:00 +0000CI: merge back from main
RM packaging bot <staff.rm@openbravo.com> [Wed, 23 Mar 2016 20:52:00 +0000] rev 28840
CI: merge back from main

Wed, 23 Mar 2016 20:37:56 +0000CI: update AD_MODULE to version 28838
RM packaging bot <staff.rm@openbravo.com> [Wed, 23 Mar 2016 20:37:56 +0000] rev 28839
CI: update AD_MODULE to version 28838

Wed, 23 Mar 2016 16:10:06 +0100fixes issue 32541: invoice report can not be printed by manual roles
Carlos Aristu <carlos.aristu@openbravo.com> [Wed, 23 Mar 2016 16:10:06 +0100] rev 28838
fixes issue 32541: invoice report can not be printed by manual roles

Now the Window object is retrieved using admin mode.

Wed, 23 Mar 2016 01:00:40 +0000CI: merge back from main
RM packaging bot <staff.rm@openbravo.com> [Wed, 23 Mar 2016 01:00:40 +0000] rev 28837
CI: merge back from main

Wed, 23 Mar 2016 00:46:37 +0000CI: update AD_MODULE to version 28834
RM packaging bot <staff.rm@openbravo.com> [Wed, 23 Mar 2016 00:46:37 +0000] rev 28836
CI: update AD_MODULE to version 28834

Wed, 16 Mar 2016 13:15:55 -0400Fixes issue 32434: Fixed Wrong Exchange Rate set in Payment created from "Set New currency" process.
Mark <m.molina@nectus.com> [Wed, 16 Mar 2016 13:15:55 -0400] rev 28835
Fixes issue 32434: Fixed Wrong Exchange Rate set in Payment created from "Set New currency" process.

Payment that generates credit in new currency was calculated with wrong Exchange Rate so payment's accounting
entry was not properly converted, it was fixed updating the transaction tax rate with the correct conversion between currencies.

Fri, 18 Mar 2016 12:40:41 -0400Fixes issue 32390: Cannot close an order with an allocated reservation if is not released the total reserved quantity.
Mark <m.molina@nectus.com> [Fri, 18 Mar 2016 12:40:41 -0400] rev 28834
Fixes issue 32390: Cannot close an order with an allocated reservation if is not released the total reserved quantity.

Cannot close an order with an allocated reservation if the released quantity is different than the total reserved quantity.

Mon, 21 Mar 2016 13:03:15 +0000CI: merge back from main
RM packaging bot <staff.rm@openbravo.com> [Mon, 21 Mar 2016 13:03:15 +0000] rev 28833
CI: merge back from main

Mon, 21 Mar 2016 12:49:28 +0000CI: update AD_MODULE to version 28827
RM packaging bot <staff.rm@openbravo.com> [Mon, 21 Mar 2016 12:49:28 +0000] rev 28832
CI: update AD_MODULE to version 28827

Mon, 21 Mar 2016 11:17:03 +0100Related to issue 29414: Updated browser supported/recommended list for PR16Q2
David Baz Fayos <david.baz@openbravo.com> [Mon, 21 Mar 2016 11:17:03 +0100] rev 28831
Related to issue 29414: Updated browser supported/recommended list for PR16Q2

* Firefox. Supported 38, Recommended 45 or higher.
* Chrome. Supported 48, Recommended 49 or higher.
* Internet Explorer. Supported 9, Recommended 11 or higher.
* Edge (EdgeHTML). Supported 12, Recommended 13 or higher.
* Safari. Supported 8, Recommended 9 or higher.

Mon, 21 Mar 2016 10:09:07 +0100Related to issue 32458: Code review improvements
Alvaro Ferraz <alvaro.ferraz@openbravo.com> [Mon, 21 Mar 2016 10:09:07 +0100] rev 28830
Related to issue 32458: Code review improvements

Add log only in Costing Rule process three main steps.

Tue, 15 Mar 2016 11:29:37 -0400Fixes issue 32458: Added log information in process executed when Validating Costing Rule.
Mark <m.molina@nectus.com> [Tue, 15 Mar 2016 11:29:37 -0400] rev 28829
Fixes issue 32458: Added log information in process executed when Validating Costing Rule.

Several log information was added to be able to follow information when the "Validate Costing Rule" process is executed.

Mon, 21 Mar 2016 09:22:39 +0100Fixes issue 32460: Improves log. Supports true, yes and on literals
Augusto Mauch <augusto.mauch@openbravo.com> [Mon, 21 Mar 2016 09:22:39 +0100] rev 28828
Fixes issue 32460: Improves log. Supports true, yes and on literals

If modulescripts are skipped, it is shown in hte log. Also now it is possible to use 'yes', 'true' and 'on' as the property value to specify that the modulescripts should be exec
uted, as it is defined in the standard (see [1]).

Also the execute.modulescripts property is now defined only once in the build.xml.

[1] https://ant.apache.org/manual/develop.html

Fri, 18 Mar 2016 13:01:38 +0100fixed 32506: GenerateComponentTest.testApplication test case is ignored
Asier Lostalé <asier.lostale@openbravo.com> [Fri, 18 Mar 2016 13:01:38 +0100] rev 28827
fixed 32506: GenerateComponentTest.testApplication test case is ignored

It failed because of same reasons of #32507.

Having this issue fixed we can now enable it again.

Fri, 18 Mar 2016 13:00:05 +0100fixed bug 32507: NPE when executing GenerateComponentTest.testStaticResources
Asier Lostalé <asier.lostale@openbravo.com> [Fri, 18 Mar 2016 13:00:05 +0100] rev 28826
fixed bug 32507: NPE when executing GenerateComponentTest.testStaticResources

StaticResourcesComponent assumes there is a ServletContext to read templates
based on it. As test is executed out of Tomcat there is no ServletContext,
causing NPE.

Fixed by mocking a ServletContext.

Additionally ApplicationComponent assumes there is a session to get format values
from causing also NPE when executing as test.

Fixed by dealing with this case and returning an empty map.

Fri, 18 Mar 2016 14:12:54 +0000CI: merge back from main
RM packaging bot <staff.rm@openbravo.com> [Fri, 18 Mar 2016 14:12:54 +0000] rev 28825
CI: merge back from main

Fri, 18 Mar 2016 13:59:11 +0000CI: update AD_MODULE to version 28822
RM packaging bot <staff.rm@openbravo.com> [Fri, 18 Mar 2016 13:59:11 +0000] rev 28824
CI: update AD_MODULE to version 28822

Fri, 18 Mar 2016 11:09:24 +0100fixed bug 32491: lines removed after printing header with a non-matching filter
Asier Lostalé <asier.lostale@openbravo.com> [Fri, 18 Mar 2016 11:09:24 +0100] rev 28823
fixed bug 32491: lines removed after printing header with a non-matching filter

After printing a document that does not match grid's current filter, its lines
were removed from grid.

After printing a refresh is done, the problem is the refresh was done not for
the current printed record but for the whole grid, being discarded current if
not matching filter crieria.

Now in case a single record is selected, it is refreshed only this one regardless
applied filtering criteria.

Fri, 18 Mar 2016 09:24:44 +0100Merge back from main
RM packaging bot <staff.rm@openbravo.com> [Fri, 18 Mar 2016 09:24:44 +0100] rev 28822
Merge back from main

Fri, 18 Mar 2016 08:14:59 +0000Merge temporary head for 3.0PR15Q4.5
RM packaging bot <staff.rm@openbravo.com> [Fri, 18 Mar 2016 08:14:59 +0000] rev 28821
Merge temporary head for 3.0PR15Q4.5

Thu, 17 Mar 2016 05:54:25 +0000Added signature for changeset a53670f00eb6
RM packaging bot <staff.rm@openbravo.com> [Thu, 17 Mar 2016 05:54:25 +0000] rev 28820
Added signature for changeset a53670f00eb6

Thu, 17 Mar 2016 05:54:25 +0000Added tag 3.0PR15Q4.5 for changeset 21c8ed48293c
RM packaging bot <staff.rm@openbravo.com> [Thu, 17 Mar 2016 05:54:25 +0000] rev 28819
Added tag 3.0PR15Q4.5 for changeset 21c8ed48293c

Thu, 17 Mar 2016 05:54:24 +0000Update AD_MODULE version to 3.0PR15Q4.5 3.0PR15Q4.5
RM packaging bot <staff.rm@openbravo.com> [Thu, 17 Mar 2016 05:54:24 +0000] rev 28818
Update AD_MODULE version to 3.0PR15Q4.5

Tue, 15 Mar 2016 19:22:47 +0100fixes issue 32478: [object Object] appears after clearing value in selector
Carlos Aristu <carlos.aristu@openbravo.com> [Tue, 15 Mar 2016 19:22:47 +0100] rev 28817
fixes issue 32478: [object Object] appears after clearing value in selector

Having singleDateMode as false after clearing the filter content of the date causes the return of an empty object in the getValuesAsCriteria method of the grid. The this.singleDateMode was being set to true in clearFilterValues function, but this statement was deleted to solve issue 31705, because it was preventing to show the range dialog after clearing the filters, when pressing the Enter key.

To solve both problems the change regarding setting singleDateMode in clearFilterValues has been reverted, and in order to ensure that the range dialog is displayed when it should be, a new check has been included in the keyPress method.

Thu, 10 Mar 2016 17:56:11 +0100Related to issue 32438: Code review improvements
Alvaro Ferraz <alvaro.ferraz@openbravo.com> [Thu, 10 Mar 2016 17:56:11 +0100] rev 28816
Related to issue 32438: Code review improvements

Use BigDecimal.ZERO instead of new BigDecimal(0).

Wed, 09 Mar 2016 18:53:24 -0500Fixes issue 32438: Wrong orders created by the Copy Record process
Mark <m.molina@nectus.com> [Wed, 09 Mar 2016 18:53:24 -0500] rev 28815
Fixes issue 32438: Wrong orders created by the Copy Record process

Fixed the wrong Tax Amount and Total Gross Amount calculation in orders created by the Copy Record process
if price list includes taxes. These amounts are calculated when related triggers are fired, due that when
the order is cloned from the original order was necessary to reset calculated amounts and then triggers updates
them again when lines are added to the cloned order.

Mon, 07 Mar 2016 15:51:16 +0100Fixes issue 32400: cannot filter grid when it is grouped by a column.
Inigo Sanchez <inigo.sanchez@openbravo.com> [Mon, 07 Mar 2016 15:51:16 +0100] rev 28814
Fixes issue 32400: cannot filter grid when it is grouped by a column.

Having a column grouped, if a filter was applied in a grid, it was not
possible to apply it.A js error was thrown:
Uncaught TypeError: this.data.willFetchData is not a function.

The problem was in:"this.data.willFetchData(....))" statement which
incorrectly assumed this.data to be an object and willFetchData a function
within it. This is not true when in this situation where this.data is a
Tree class.

It has been fixed by taking into account this case by checking that "this.data" defines the
function.

Fri, 04 Mar 2016 08:51:49 +0100Fixes issue 32238: Payment In and Payment Out lines are not exported to CSV.
Inigo Sanchez <inigo.sanchez@openbravo.com> [Fri, 04 Mar 2016 08:51:49 +0100] rev 28813
Fixes issue 32238: Payment In and Payment Out lines are not exported to CSV.

The problem was that export to CSV does not work properly in some subtabs without
link to parent column (e.g.Lines subtab of Payment In/Out). Before, It was used
"tabId" to obtaing data for export to CSV and the value of the "tabId" was sent
in a variable called "tab". The Criteria that is run when it is displayed the tab
uses a property named "tabId" instead of "tab".

The solution for this case (and other related cases) is to adapt the code that exports
to CSV to use the same Criteria run when displaying the tab. Now export to CSV uses
tabId property. Besides it has been refactored some piece of code related with export
data in DataSourceServlet to use "tabId" instead of "tab".

Tue, 01 Mar 2016 18:02:57 +0100Related to issue 32373: Code review improvements
Alvaro Ferraz <alvaro.ferraz@openbravo.com> [Tue, 01 Mar 2016 18:02:57 +0100] rev 28812
Related to issue 32373: Code review improvements

Call line.getProductCosts only when line.transaction != null in DocInventory.java.

Mon, 29 Feb 2016 17:00:12 +0530Fixes Issue 32373:NullPointerException when posting a Physical Inventory
Atul Gaware <atul.gaware@openbravo.com> [Mon, 29 Feb 2016 17:00:12 +0530] rev 28811
Fixes Issue 32373:NullPointerException when posting a Physical Inventory
with a line without an associated transaction (not stocked product)

- Avoid insertion of zero quantity products in inventory line having
stocked flag as No.
- Code improvement to handle line with null transaction.

Thu, 17 Mar 2016 19:33:46 +0000CI: merge back from main
RM packaging bot <staff.rm@openbravo.com> [Thu, 17 Mar 2016 19:33:46 +0000] rev 28810
CI: merge back from main

Thu, 17 Mar 2016 19:19:56 +0000CI: update AD_MODULE to version 28808
RM packaging bot <staff.rm@openbravo.com> [Thu, 17 Mar 2016 19:19:56 +0000] rev 28809
CI: update AD_MODULE to version 28808

Thu, 17 Mar 2016 10:45:05 +0100Fixed issue 32498 added index in M_PRODUCT_CH_VALUE
Sandra Huguet <sandra.huguet@openbravo.com> [Thu, 17 Mar 2016 10:45:05 +0100] rev 28808
Fixed issue 32498 added index in M_PRODUCT_CH_VALUE

added index in M_PRODUCT_CH_VALUE to improve characteristic performance

Thu, 17 Mar 2016 09:53:43 +0000CI: merge back from main
RM packaging bot <staff.rm@openbravo.com> [Thu, 17 Mar 2016 09:53:43 +0000] rev 28807
CI: merge back from main

Thu, 17 Mar 2016 09:36:48 +0000CI: update AD_MODULE to version 28804
RM packaging bot <staff.rm@openbravo.com> [Thu, 17 Mar 2016 09:36:48 +0000] rev 28806
CI: update AD_MODULE to version 28804

Thu, 17 Mar 2016 09:50:30 +0100Related with issue 32460: modulescripts can be disabled in update.database
Augusto Mauch <augusto.mauch@openbravo.com> [Thu, 17 Mar 2016 09:50:30 +0100] rev 28805
Related with issue 32460: modulescripts can be disabled in update.database

The fix of 32460 has been extended to be able to disable the execution of modulescripts also when updating the database. It has been tested both with the update.database and with
the smartbuild -Dlocal=no tasks.

Wed, 16 Mar 2016 05:33:34 +0100Merge back from main
RM packaging bot <staff.rm@openbravo.com> [Wed, 16 Mar 2016 05:33:34 +0100] rev 28804
Merge back from main

Tue, 15 Mar 2016 10:34:03 +0000Merge temporary head for 3.0PR16Q1
RM packaging bot <staff.rm@openbravo.com> [Tue, 15 Mar 2016 10:34:03 +0000] rev 28803
Merge temporary head for 3.0PR16Q1

Fri, 11 Mar 2016 04:42:53 +0000Added signature for changeset 38ef1dc10aa3
RM packaging bot <staff.rm@openbravo.com> [Fri, 11 Mar 2016 04:42:53 +0000] rev 28802
Added signature for changeset 38ef1dc10aa3

Fri, 11 Mar 2016 04:42:53 +0000Added tag 3.0PR16Q1 for changeset ee5383e07131
RM packaging bot <staff.rm@openbravo.com> [Fri, 11 Mar 2016 04:42:53 +0000] rev 28801
Added tag 3.0PR16Q1 for changeset ee5383e07131

Fri, 11 Mar 2016 04:42:53 +0000Update AD_MODULE version to 3.0PR16Q1 3.0PR16Q1
RM packaging bot <staff.rm@openbravo.com> [Fri, 11 Mar 2016 04:42:53 +0000] rev 28800
Update AD_MODULE version to 3.0PR16Q1

Thu, 10 Mar 2016 17:56:11 +0100Related to issue 32437: Code review improvements
Alvaro Ferraz <alvaro.ferraz@openbravo.com> [Thu, 10 Mar 2016 17:56:11 +0100] rev 28799
Related to issue 32437: Code review improvements

Use BigDecimal.ZERO instead of new BigDecimal(0).

Wed, 09 Mar 2016 18:53:24 -0500Fixes issue 32437: Wrong orders created by the Copy Record process
Mark <m.molina@nectus.com> [Wed, 09 Mar 2016 18:53:24 -0500] rev 28798
Fixes issue 32437: Wrong orders created by the Copy Record process

Fixed the wrong Tax Amount and Total Gross Amount calculation in orders created by the Copy Record process
if price list includes taxes. These amounts are calculated when related triggers are fired, due that when
the order is cloned from the original order was necessary to reset calculated amounts and then triggers updates
them again when lines are added to the cloned order.

Wed, 09 Mar 2016 16:11:53 +0100Related to issue 32332. Removed wrong part of the diff.
Antonio Moreno Perez <antonio.moreno@openbravo.com> [Wed, 09 Mar 2016 16:11:53 +0100] rev 28797
Related to issue 32332. Removed wrong part of the diff.

Mon, 07 Mar 2016 15:46:50 +0100Fixes issue 32399: cannot filter grid when it is grouped by a column.
Inigo Sanchez <inigo.sanchez@openbravo.com> [Mon, 07 Mar 2016 15:46:50 +0100] rev 28796
Fixes issue 32399: cannot filter grid when it is grouped by a column.

Having a column grouped, if a filter was applied in a grid, it was not possible to apply it.
A js error was thrown: Uncaught TypeError: this.data.willFetchData is not a function.

The problem was in "if (..... || (this.data.willFetchData(this.convertCriteria(criteria)))"
statement which incorrectly assumed this.data to be an object and willFetchData a function
within it. This is not true when in this situation where this.data is a Tree class.

It has been fixed by taking into account this case by checking that "this.data" defines the
function.

Tue, 01 Mar 2016 18:02:57 +0100Related to issue 32372: Code review improvements
Alvaro Ferraz <alvaro.ferraz@openbravo.com> [Tue, 01 Mar 2016 18:02:57 +0100] rev 28795
Related to issue 32372: Code review improvements

Call line.getProductCosts only when line.transaction != null in DocInventory.java.

Mon, 29 Feb 2016 17:00:12 +0530Fixes Issue 32372:NullPointerException when posting a Physical Inventory
Atul Gaware <atul.gaware@openbravo.com> [Mon, 29 Feb 2016 17:00:12 +0530] rev 28794
Fixes Issue 32372:NullPointerException when posting a Physical Inventory
with a line without an associated transaction (not stocked product)

- Avoid insertion of zero quantity products in inventory line having
stocked flag as No.
- Code improvement to handle line with null transaction.

Mon, 29 Feb 2016 23:51:51 +0100Fixes issue 32237: Payment In and Payment Out lines are not exported to CSV.
Inigo Sanchez <inigo.sanchez@openbravo.com> [Mon, 29 Feb 2016 23:51:51 +0100] rev 28793
Fixes issue 32237: Payment In and Payment Out lines are not exported to CSV.

The problem was that export to CSV does not work properly in some subtabs without
link to parent column (e.g.Lines subtab of Payment In/Out). Before, It was used
"tabId" to obtaing data for export to CSV and the value of the "tabId" was sent
in a variable called "tab". The Criteria that is run when it is displayed the tab
uses a property named "tabId" instead of "tab".

The solution for this case (and other related cases) is to adapt the code that
exports to CSV to use the same Criteria run when displaying the tab. Now export to
CSV uses tabId property. Besides it has been refactored some piece of code related
with export data in DataSourceServlet to use "tabId" instead of "tab".

Mon, 29 Feb 2016 17:34:08 +0100Fixed issue 32332. Added method to check if importentry has status 'Error'
Antonio Moreno <antonio.moreno@openbravo.com> [Mon, 29 Feb 2016 17:34:08 +0100] rev 28792
Fixed issue 32332. Added method to check if importentry has status 'Error'

Wed, 24 Feb 2016 18:05:08 +0530Fixes Issue 32327:"Generate invoice from receipt" button is not working
Atul Gaware <atul.gaware@openbravo.com> [Wed, 24 Feb 2016 18:05:08 +0530] rev 28791
Fixes Issue 32327:"Generate invoice from receipt" button is not working

In case tax not included in price list, gross std price and list price
was set will null value which is not allowed by db table. now they are
initiated to value zero first.

Thu, 25 Feb 2016 00:33:12 +0100Fixes issue 32247: Read only doesn't work on some columns in grid view
Inigo Sanchez <inigo.sanchez@openbravo.com> [Thu, 25 Feb 2016 00:33:12 +0100] rev 28790
Fixes issue 32247: Read only doesn't work on some columns in grid view

The problem is caused because it was not take into account read only when other
logic (e.g. display logic) was being applied in an editing grid view.

In order to prevent this, it take into account when a field is checks as read
only. In this case, the field is show properly.

Tue, 23 Feb 2016 16:37:30 +0100fixed bug 32309: error on update if an observer loaded current object in memory
Asier Lostalé <asier.lostale@openbravo.com> [Tue, 23 Feb 2016 16:37:30 +0100] rev 28789
fixed bug 32309: error on update if an observer loaded current object in memory

In case an entity observer loaded current object in memory (ie. observing orderLine)
doing orderLine.getSalesOrder().getOrderLineList() there were two different instances
in memory representing the same DB row. This caused problems when trying to evict it.
Causing an exception to be thrown when updating from UI in this case.

As solution eviction is no longer performed, object is forced to be fetched from DB by
executing a Criteria.

Mon, 22 Feb 2016 15:33:27 +0530Fixes Issue 32298: Wrong payment status when unmatching bankstatement line
Atul Gaware <atul.gaware@openbravo.com> [Mon, 22 Feb 2016 15:33:27 +0530] rev 28788
Fixes Issue 32298: Wrong payment status when unmatching bankstatement line
manually matched against an invoice

Incase a finTransaction is unmatched which has finPayment,status of finPayment
is also updated accordingly as per isReceipt flag