Tue, 21 Oct 2014 13:40:33 +0200Fixed bug 27461: Sales invoice Dimensional Report improvements for Credit Memo
Víctor Martínez Romanos <victor.martinez@openbravo.com> [Tue, 21 Oct 2014 13:40:33 +0200] rev 25067
Fixed bug 27461: Sales invoice Dimensional Report improvements for Credit Memo

In case of credit memo documents, the following columns in the report should reflect a negative number:
Quantity
Amount
Cost
Profit
Margin

Before this fix, only the Amount column reflected a negative number. Besides the Profit and Margin were wrongly calculated in credit memo scenario, because they are based on the Cost which had a wrong possitive sign for credit memos.
After this fix all these columns show a negative number in case of credit memo. Thus the Profit and Margin are properly calculated based on the right sign of the Cost column.

Note that the Margin formula has been also updated to reflect a negative sign in case the Profit is also negative:
Profit = Amount - Cost
Margin = 100 * ((Profit) / Amount) * sign(Profit)

That means the Margin will now be shown as a negative percentage for credit memo and negative invoices.

Tue, 21 Oct 2014 13:09:51 +0200Fixes issue 27918, fixes issue 27930. Prevents breaking the int-inc tests
Augusto Mauch <augusto.mauch@openbravo.com> [Tue, 21 Oct 2014 13:09:51 +0200] rev 25066
Fixes issue 27918, fixes issue 27930. Prevents breaking the int-inc tests

The problem was that due to this design defect [1], the oracle and postgres int-inc tests were failing. This is because a value 'AR' was being set to the treetype of a table and then being set to null in other table whose treetype was also 'AR'. Treetype has a unique constraint that was enabled when the application data was updated, so the constraint failed.

To prevent this error, the treetype of the second table is going to be set to null in a modulescript, that is executed before updating the application data.

[1] https://issues.openbravo.com/view.php?id=12577

Tue, 21 Oct 2014 11:28:25 +0200Fixes issue 27918: User Defined Accounting Report Setup shows tree view
Augusto Mauch <augusto.mauch@openbravo.com> [Tue, 21 Oct 2014 11:28:25 +0200] rev 25065
Fixes issue 27918: User Defined Accounting Report Setup shows tree view

The problem was that the tree configuration previous to the new tree implementation was wrong. The Table table had a field called Type Area which was originally used to specify the Tree type of the table. The FinancialMgmtAccountingRptElement table had this field empty, and instead the FinancialMgmtAccountingReport had this field set to Accounting Report, which is the value that should have been assigned to FinancialMgmtAccountingRptElement.

The configuration of the new implementation was done based on the Tree Type field, so it was wrong for the FinancialMgmtAccountingRptElement table. Now it has been properly done (it has been flagged as Is Tree, a record has been added to the Table Tree Category subtab and a value has been selected in the Table Tree Category field of the Tab tab.

Also, a module script has been modified to fix the data of ad_tree. The ad_tree table has a column called ad_table_id, which points to the table that the tree belongs to. The accounting report tree was mistakenly pointing to FinancialMgmtAccountingReport, and the updated modulescript fixes it so that now it points to FinancialMgmtAccountingRptElement.

Mon, 20 Oct 2014 18:54:45 +0200Fixes issue 27919: Match Landed Cost P&E raises an error in Postgres 8.4
Unai Martirena <unai.martirena@openbravo.com> [Mon, 20 Oct 2014 18:54:45 +0200] rev 25064
Fixes issue 27919: Match Landed Cost P&E raises an error in Postgres 8.4

Mon, 20 Oct 2014 18:39:02 +0200Related to issue 27913 Add convertToUTC to obdateutils
Sandra Huguet <sandra.huguet@openbravo.com> [Mon, 20 Oct 2014 18:39:02 +0200] rev 25063
Related to issue 27913 Add convertToUTC to obdateutils

Mon, 20 Oct 2014 18:23:44 +0200Fixed bug 27913 variable updated properly formatted in match statement
Sandra Huguet <sandra.huguet@openbravo.com> [Mon, 20 Oct 2014 18:23:44 +0200] rev 25062
Fixed bug 27913 variable updated properly formatted in match statement

After fixed issue 27912, variable updated in match statement should formatted as
a date and the conversion to utc should not be performed.

Mon, 20 Oct 2014 17:54:22 +0200Fixes Issue 27884: New lines created in costing tab which should not be there
Unai Martirena <unai.martirena@openbravo.com> [Mon, 20 Oct 2014 17:54:22 +0200] rev 25061
Fixes Issue 27884: New lines created in costing tab which should not be there

Mon, 20 Oct 2014 16:44:30 +0200Fixes issue 27912: Time&DateTime fields are properly handled in P&E Windows
Augusto Mauch <augusto.mauch@openbravo.com> [Mon, 20 Oct 2014 16:44:30 +0200] rev 25060
Fixes issue 27912: Time&DateTime fields are properly handled in P&E Windows

The values of Time and DateTime fields were not being properly handled, as they where not converted from the server timezone offset to UTC before being sent to the client. This happened
because the DataToJsonConverter.convertToJsonObjects method did not perform the conversion.

Now it does, when possible. For the conversion to be done properly, the Property associated with the column value must be passed to the convertPrimitiveValue method. This will be done a
s long as the tableId parameter is sent in the datasource request, and as long as the property name can be inferred from the column name.

The QueryListDataSource extends ReadOnlyDataSourceService, but the tableId is not passed, so this changeset does not fix this case, that will be address in a separate issue.

Mon, 20 Oct 2014 12:34:58 +0200Fixes Issue 27905:Error when assigning subsets to product characteristics
Daniel Ruiz <daniel.ruiz@openbravo.com> [Mon, 20 Oct 2014 12:34:58 +0200] rev 25059
Fixes Issue 27905:Error when assigning subsets to product characteristics

Fri, 17 Oct 2014 15:29:57 +0530Fixes Issue 27604:Cannot create return material twice for same Goods Shipment
Atul Gaware <atul.gaware@openbravo.com> [Fri, 17 Oct 2014 15:29:57 +0530] rev 25058
Fixes Issue 27604:Cannot create return material twice for same Goods Shipment

It was possible to process Return From Customer / Return To Vendor for
respective Goods Shipment / Goods Receipt. Now a check is provided in
C_Order_Post1 Method to check whether qty in Return Document line
exceeds the sum of other processed return line qty with same shipment or
Receipt line reference. Message shows line no which exceeds such qtys.