Fri, 04 Mar 2016 08:51:01 +0100related to bug 32375: added test case covering preference's client visibility
Asier Lostalé <asier.lostale@openbravo.com> [Fri, 04 Mar 2016 08:51:01 +0100] rev 28697
related to bug 32375: added test case covering preference's client visibility

Fri, 04 Mar 2016 08:50:01 +0100fixed bug 32375: preferences incorrectly resolve client visibility
Asier Lostalé <asier.lostale@openbravo.com> [Fri, 04 Mar 2016 08:50:01 +0100] rev 28696
fixed bug 32375: preferences incorrectly resolve client visibility

Reimplemented client visibility resolution to correctly handle the case of
2 preference candidates with different client visibility.

Fri, 04 Mar 2016 08:48:31 +0100related to bug 32375: make preference resolution more consistent
Asier Lostalé <asier.lostale@openbravo.com> [Fri, 04 Mar 2016 08:48:31 +0100] rev 28695
related to bug 32375: make preference resolution more consistent

In case of several preferences defined for a given property/attribute, the
result of getting value could be undetermistic.

Solved by sorting by preference's id in these cases.

Fri, 04 Mar 2016 08:45:40 +0100related to bug 32375: preferences incorrectly resolve client visibility
Asier Lostalé <asier.lostale@openbravo.com> [Fri, 04 Mar 2016 08:45:40 +0100] rev 28694
related to bug 32375: preferences incorrectly resolve client visibility

Small code clean up:
-isHigherPriority renamed to getHighestPriority: by convention is* are boolean
getters which was not the case of this one
-removed unneded brackets in condition which didn't help to make the code more
readable

Thu, 11 Feb 2016 13:03:59 +0100Fixes issue 32386: Set Final good C product as isquantityvariable in QA client
Alvaro Ferraz <alvaro.ferraz@openbravo.com> [Thu, 11 Feb 2016 13:03:59 +0100] rev 28693
Fixes issue 32386: Set Final good C product as isquantityvariable in QA client

Tue, 01 Mar 2016 13:24:31 +0100Fixes bug 32083: Move Service Price Rule menu entry under Pricing Setup menu entry
Unai Martirena <unai.martirena@openbravo.com> [Tue, 01 Mar 2016 13:24:31 +0100] rev 28692
Fixes bug 32083: Move Service Price Rule menu entry under Pricing Setup menu entry

Mon, 29 Feb 2016 18:07:19 +0530Fixes Issue 32337:Division by zero error when completing an invoice
Atul Gaware <atul.gaware@openbravo.com> [Mon, 29 Feb 2016 18:07:19 +0530] rev 28691
Fixes Issue 32337:Division by zero error when completing an invoice
associated to a closed order (quantity 0) with a promotion

While calculating promotion if qty ordered is non zero then only
use divide by statement else set values to zero

Tue, 01 Mar 2016 18:02:57 +0100Related to issue 32364: Code review improvements
Alvaro Ferraz <alvaro.ferraz@openbravo.com> [Tue, 01 Mar 2016 18:02:57 +0100] rev 28690
Related to issue 32364: Code review improvements

Call line.getProductCosts only when line.transaction != null in DocInventory.java.

Mon, 29 Feb 2016 17:00:12 +0530Fixes Issue 32364:NullPointerException when posting a Physical Inventory
Atul Gaware <atul.gaware@openbravo.com> [Mon, 29 Feb 2016 17:00:12 +0530] rev 28689
Fixes Issue 32364:NullPointerException when posting a Physical Inventory
with a line without an associated transaction (not stocked product)

- Avoid insertion of zero quantity products in inventory line having
stocked flag as No.
- Code improvement to handle line with null transaction.

Tue, 01 Mar 2016 13:19:21 +0100Fixes issue 0032381: missing upload image icon
Adrián Romero <adrianromero@openbravo.com> [Tue, 01 Mar 2016 13:19:21 +0100] rev 28688
Fixes issue 0032381: missing upload image icon
* Restoring upload icon and erase icon

Mon, 29 Feb 2016 23:49:20 +0100Fixes issue 32233: Payment In and Payment Out lines are not exported to CSV.
Inigo Sanchez <inigo.sanchez@openbravo.com> [Mon, 29 Feb 2016 23:49:20 +0100] rev 28687
Fixes issue 32233: Payment In and Payment Out lines are not exported to CSV.

The problem was that export to CSV does not work properly in some subtabs without
link to parent column (e.g.Lines subtab of Payment In/Out). Before, It was used
"tabId" to obtaing data for export to CSV and the value of the "tabId" was sent
in a variable called "tab". The Criteria that is run when it is displayed the tab
uses a property named "tabId" instead of "tab".

The solution for this case (and other related cases) is to adapt the code that
exports to CSV to use the same Criteria run when displaying the tab. Now export
to CSV uses tabId property. Besides it has been refactored some piece of code
related with export data in DataSourceServlet to use "tabId" instead of "tab".

Thu, 18 Feb 2016 13:23:15 +0100Fixed issue 0032044: Ensure stable ids in docs send from WebPOS to the server (Payment API)
Miguel de Juana <miguel.dejuana@openbravo.com> [Thu, 18 Feb 2016 13:23:15 +0100] rev 28686
Fixed issue 0032044: Ensure stable ids in docs send from WebPOS to the server (Payment API)

- Set some entities ids related to order loading in Web POS to ensure stable ids

Tue, 26 Jan 2016 17:24:27 +0100Fixed bug 31419: Add parameter to control flushes in some APRM methods
Víctor Martínez Romanos <victor.martinez@openbravo.com> [Tue, 26 Jan 2016 17:24:27 +0100] rev 28685
Fixed bug 31419: Add parameter to control flushes in some APRM methods

Added a parameter doFlush to some APRM methods to control whether to flush inside the method. By default it continues to have the same behavior as before (to flush inside the method) so we should avoid any possible regression.
These flushes inside the method makes the process of several payments in a batch really slow, which is a common scenario for the remittance module. With this change (and with the necessary modifications in the remittance module), the time to process a remittance line has been decreased from 900ms to 15ms.

The idea is to create this "self-protected" methods and adapt the flows with performance problems. When the time goes by, we should clean the duplicated methods.

Fri, 26 Feb 2016 08:57:54 +0100fixed bug 32354: field edit access doesn't allow to save if tab contains audit
Asier Lostalé <asier.lostale@openbravo.com> [Fri, 26 Feb 2016 08:57:54 +0100] rev 28684
fixed bug 32354: field edit access doesn't allow to save if tab contains audit

For tabs that explicitly define their audit (updated/updated by) fields, roles
with access to edit only some fields couldn't save unless in those fields audit
were also included.

Now audit fields are not checked for this validation as they are always updated
on any allowed modification.

Fri, 26 Feb 2016 08:20:01 +0100[ChangePassword] Merge ChangePassword development
Guillermo Gil <guillermo.gil@openbravo.com> [Fri, 26 Feb 2016 08:20:01 +0100] rev 28683
[ChangePassword] Merge ChangePassword development

Mon, 22 Feb 2016 15:30:30 +0100[ChangePassword] Merge with pi
Jonathan Bueno <jonathan.bueno@openbravo.com> [Mon, 22 Feb 2016 15:30:30 +0100] rev 28682
[ChangePassword] Merge with pi

Mon, 22 Feb 2016 11:31:04 +0100[ChangePassword] Applied code review.
Jonathan Bueno <jonathan.bueno@openbravo.com> [Mon, 22 Feb 2016 11:31:04 +0100] rev 28681
[ChangePassword] Applied code review.

Now client messages are translated.
Used === for javascript comparison

Fri, 19 Feb 2016 13:42:53 +0100[ChangePassword] Renamed trigger to AD_USER_EXPIRATIONPASS_TRG
Jonathan Bueno <jonathan.bueno@openbravo.com> [Fri, 19 Feb 2016 13:42:53 +0100] rev 28680
[ChangePassword] Renamed trigger to AD_USER_EXPIRATIONPASS_TRG

Fri, 19 Feb 2016 12:56:49 +0100[ChangePassword] Applied code review.
Jonathan Bueno <jonathan.bueno@openbravo.com> [Fri, 19 Feb 2016 12:56:49 +0100] rev 28679
[ChangePassword] Applied code review.

Renamed trigger to be consistent, used expiration instead of expiry.
Used === to compare strings in Login.html.
Renamed getUpdatePasswordDate method to checkIfPasswordExpired in DefaultAuthenticationManager class.
Added throws in signature and javadoc for checkIfPasswordExpired and updatePassword methods.
Removed static parameter from checkIfPasswordExpired and updatePassword methods.
Removed extra brackets in expression in checkIfPasswordExpired method.
Exception AuthenticationExpirationPasswordException fixed. Removed extra variables, error is now loaded in the subclass AuthenticationException.
Removed empty line in checkIfPasswordExpired.
Removed check to support 2.50.
LoginUtils file keep unmodified.

Wed, 17 Feb 2016 09:56:42 +0100[ChangePassword] Merge with pi
Jonathan Bueno <jonathan.bueno@openbravo.com> [Wed, 17 Feb 2016 09:56:42 +0100] rev 28678
[ChangePassword] Merge with pi

Wed, 17 Feb 2016 09:52:43 +0100[ChangePassword] Applied code review.Fixed security problem.
Jonathan Bueno <jonathan.bueno@openbravo.com> [Wed, 17 Feb 2016 09:52:43 +0100] rev 28677
[ChangePassword] Applied code review.Fixed security problem.

Mon, 15 Feb 2016 13:16:35 +0100[ChangePassword] Added text interfaces from login.html
Jonathan Bueno <jonathan.bueno@openbravo.com> [Mon, 15 Feb 2016 13:16:35 +0100] rev 28676
[ChangePassword] Added text interfaces from login.html

Mon, 15 Feb 2016 12:28:37 +0100[ChangePassword] Merge with pi
Jonathan Bueno <jonathan.bueno@openbravo.com> [Mon, 15 Feb 2016 12:28:37 +0100] rev 28675
[ChangePassword] Merge with pi

Mon, 15 Feb 2016 12:11:46 +0100[ChangePassword] Code review applied.
Jonathan Bueno <jonathan.bueno@openbravo.com> [Mon, 15 Feb 2016 12:11:46 +0100] rev 28674
[ChangePassword] Code review applied.

Updated javadocs of methods.
Added check to avoid security problem when updating password.

Fri, 12 Feb 2016 13:44:48 +0100[ChangePassword] Updated year of license in some files. Updated referenced data with new name of the column
Jonathan Bueno <jonathan.bueno@openbravo.com> [Fri, 12 Feb 2016 13:44:48 +0100] rev 28673
[ChangePassword] Updated year of license in some files. Updated referenced data with new name of the column

Fri, 12 Feb 2016 11:41:37 +0100[ChangePassword] Code review applied.
Jonathan Bueno <jonathan.bueno@openbravo.com> [Fri, 12 Feb 2016 11:41:37 +0100] rev 28672
[ChangePassword] Code review applied.

Solved camel case in Days To Password Expiration column.
Labels in Login.html are now translatable.
Last Password Update column is now updated in case user didn't have a password and is set for the first time.
Messages are now set correctly from the beginning and are not overwritten.
Refactor code, now check for expiration date is made in the method, exception is thrown in the method also.
AuthenticationExpirationPasswordException now log a single line.

Tue, 09 Feb 2016 09:45:56 +0100[Change Password] Merge with pi
Alberto Santos <alberto.santos@openbravo.com> [Tue, 09 Feb 2016 09:45:56 +0100] rev 28671
[Change Password] Merge with pi

Mon, 08 Feb 2016 16:14:49 +0100Correct the column updated in AD_USER_EXPIRYPASS_TRG and the message name.
Alberto Santos <alberto.santos@openbravo.com> [Mon, 08 Feb 2016 16:14:49 +0100] rev 28670
Correct the column updated in AD_USER_EXPIRYPASS_TRG and the message name.

Tue, 02 Feb 2016 14:11:27 +0100[Change Password] Code review applied:
Alberto Santos <alberto.santos@openbravo.com> [Tue, 02 Feb 2016 14:11:27 +0100] rev 28669
[Change Password] Code review applied:
Rename property Lastupdatepassworddate to lastPasswordUpdate.
Be consistent in naming: change expiry to expiration.
Use 'userID' instead of username in getUpdatePasswordDate function.
Check sameOldPassword in the rigth place.

Thu, 28 Jan 2016 12:40:57 +0100[ChangePassword] Solved security problem, added check to change user password
Jonathan Bueno <jonathan.bueno@openbravo.com> [Thu, 28 Jan 2016 12:40:57 +0100] rev 28668
[ChangePassword] Solved security problem, added check to change user password