Wed, 04 Mar 2015 16:09:33 +0100Fixes bug 29487: Performance improved in Costing Background process.
Unai Martirena <unai.martirena@openbravo.com> [Wed, 04 Mar 2015 16:09:33 +0100] rev 26515
Fixes bug 29487: Performance improved in Costing Background process.

There are two methods in Costing Background process in which an ScrollableResult is built and iterated. 'setCalculatedTransactionsAsProcessed' and 'setCalculatedTransactionsAsProcessed'. This loops where causing Out of memory issues because they were not flushing and clearing session every little amount of iterations. Apart from this, the two ScrollableResults were leaving opened, which may cause lot of issues especially in Oracle.

Finally, these methods have been implemented in another way. Directly updating all the records on a single update in hql. In this way the performance is improved even adding flush and clear on the previously loops.

Tue, 31 Mar 2015 13:11:57 +0200Fixed bug 29471: Invoice's entry Currency Balancing instead of Vendor Prepayment
Unai Martirena <unai.martirena@openbravo.com> [Tue, 31 Mar 2015 13:11:57 +0200] rev 26514
Fixed bug 29471: Invoice's entry Currency Balancing instead of Vendor Prepayment


The selectPrepayments method now searches by FIN_PAYMENT_SCHEDULEDETAIL.FIN_PAYMENT_SCHEDULE_ORDER instead of FIN_PAYMENT_SCHEDULEDETAIL.FIN_PAYMENT_SCHEDULE_INVOICE, because a prepayment is linked to an order.

Fri, 17 Apr 2015 13:02:02 +0000Merge temporary head for 3.0PR15Q1.3
RM packaging bot <staff.rm@openbravo.com> [Fri, 17 Apr 2015 13:02:02 +0000] rev 26513
Merge temporary head for 3.0PR15Q1.3

Fri, 17 Apr 2015 08:43:35 +0000Added signature for changeset 4d63b001f637
RM packaging bot <staff.rm@openbravo.com> [Fri, 17 Apr 2015 08:43:35 +0000] rev 26512
Added signature for changeset 4d63b001f637

Fri, 17 Apr 2015 08:43:35 +0000Added tag 3.0PR15Q1.3 for changeset ad409516bfa0
RM packaging bot <staff.rm@openbravo.com> [Fri, 17 Apr 2015 08:43:35 +0000] rev 26511
Added tag 3.0PR15Q1.3 for changeset ad409516bfa0

Fri, 17 Apr 2015 08:43:34 +0000Update AD_MODULE version to 3.0PR15Q1.3 3.0PR15Q1.3
RM packaging bot <staff.rm@openbravo.com> [Fri, 17 Apr 2015 08:43:34 +0000] rev 26510
Update AD_MODULE version to 3.0PR15Q1.3

Thu, 16 Apr 2015 18:33:31 +0200Fixes issue 29617: Error in GLJournalAccountingCheck validation
Alvaro Ferraz <alvaro.ferraz@openbravo.com> [Thu, 16 Apr 2015 18:33:31 +0200] rev 26509
Fixes issue 29617: Error in GLJournalAccountingCheck validation

Query in GLJournalAccountingCheck build validation has been changed to avoid build validation fail, when exists a negative gl journal line and system is configured to "not allow negative amount" during posting, although accounting information is correct

Tue, 14 Apr 2015 19:04:24 +0200Fixes bug 29546: Accounting Date is updated when Transaction Date changes
Unai Martirena <unai.martirena@openbravo.com> [Tue, 14 Apr 2015 19:04:24 +0200] rev 26508
Fixes bug 29546: Accounting Date is updated when Transaction Date changes

A callout has been added in Transaction Date field of transaction tab under Financial Account.

An onchange function has been added in Transaction Date in Add Transaction Process Definition.

Tue, 14 Apr 2015 18:18:57 +0200Fixed issue 29585: It is not possible to reactivate a Landed Cost
Jorge Garcia <jorge.garcia@openbravo.com> [Tue, 14 Apr 2015 18:18:57 +0200] rev 26507
Fixed issue 29585: It is not possible to reactivate a Landed Cost

It is not possible to reactivate a Landed Cost under some circunstances.
The problem was fixed from the LandedCostDistributionAlgorithm.java

When you try to reactivate a Landed Cost, an error message appears and
the process was cancelled

Now the process is done succesfully and the Landed Cost can be reactivated.

Tue, 14 Apr 2015 13:42:07 +0200fixes issue 29568: onChange event does not work fine
Carlos Aristu <carlos.aristu@openbravo.com> [Tue, 14 Apr 2015 13:42:07 +0200] rev 26506
fixes issue 29568: onChange event does not work fine
using Date parameters in Process Definition

There were two different problems:
1) When changing the value manually, the _textChanged attribute was always true after the first change. This prevented the date value to be updated properly. This has been solved by creating a new method, setDateParameterValue, which avoids this problem when setting the date parameter values. The following documentation has been updated with this information: http://wiki.openbravo.com/wiki/How_to_create_a_Standard_Process_Definition#Advanced_Topics
2) When changing the value from the date picker, the onblur event was not being called after the first time. This has been solved by calling the handleItemChange method of the OBParameterWindowForm class after choosing the value from the picker.

Mon, 13 Apr 2015 12:50:12 +0200Fixes issue 29511: Duplicated amount when cancelled payment
Eduardo Argal Guibert <eduardo.argal@openbravo.com> [Mon, 13 Apr 2015 12:50:12 +0200] rev 26505
Fixes issue 29511: Duplicated amount when cancelled payment
Removes canceled payment schedule details when posting

Thu, 09 Apr 2015 18:27:45 +0200Fixes bug 29547: Cannot be reserved more than available Stock.
Eduardo Argal Guibert <eduardo.argal@openbravo.com> [Thu, 09 Apr 2015 18:27:45 +0200] rev 26504
Fixes bug 29547: Cannot be reserved more than available Stock.

Few more issues have been fixed also:

1) Prereservation lines will never have Warehouse field filled until they are received.

2) Filter of Purchase Order Line now is working having reservation completed or in draft status.

3) Prereservation Lines are displayed when the reservation is in draft status and they are not still reserved.

Thu, 09 Apr 2015 17:09:16 +0200Related to bug 29536: Fix copyright
Unai Martirena <unai.martirena@openbravo.com> [Thu, 09 Apr 2015 17:09:16 +0200] rev 26503
Related to bug 29536: Fix copyright

Thu, 09 Apr 2015 16:35:44 +0200Fixes bug 29536: Transaction can be created from Add transaction for Bank Fee
Eduardo Argal Guibert <eduardo.argal@openbravo.com> [Thu, 09 Apr 2015 16:35:44 +0200] rev 26502
Fixes bug 29536: Transaction can be created from Add transaction for Bank Fee

Thu, 09 Apr 2015 11:30:57 +0200Fixes bug 29542: Payment Out can be reactivated without bp purchase pricelist
Unai Martirena <unai.martirena@openbravo.com> [Thu, 09 Apr 2015 11:30:57 +0200] rev 26501
Fixes bug 29542: Payment Out can be reactivated without bp purchase pricelist

The problem is that the method 'getConversionRateDocumentForInvoice' tries to get a conversion using the currency of Purchase PriceList of the business partner, and it could happen to be empty, so it fails.

Starting from 3.0PR14Q4 the Currency field in the business partner is mandatory, so it can be used for Sales/Purchase flow.

It could be that at this point while reactivating the Payment to be the Currency of the Business Partner null, because it was created long time ago and no currency set yet, so, if this is the case an error will be raised to the user in order to fix this.

Thu, 09 Apr 2015 12:38:55 +0200Related to bug 29449: Avoid exception when filtering by number
Unai Martirena <unai.martirena@openbravo.com> [Thu, 09 Apr 2015 12:38:55 +0200] rev 26500
Related to bug 29449: Avoid exception when filtering by number

Avoid exceptions when retrieving the value of the filter in number-type columns and the value is not a number

Thu, 09 Apr 2015 12:32:22 +0200Related to bug 29449: Avoid exception
Unai Martirena <unai.martirena@openbravo.com> [Thu, 09 Apr 2015 12:32:22 +0200] rev 26499
Related to bug 29449: Avoid exception

Avoid exceptions in getOrderLineSetValueFilterData and getAttributeSetValueFilterData methods

Thu, 09 Apr 2015 12:30:22 +0200Related to issue 29448: Empty filter when there is no attribute set value.
Unai Martirena <unai.martirena@openbravo.com> [Thu, 09 Apr 2015 12:30:22 +0200] rev 26498
Related to issue 29448: Empty filter when there is no attribute set value.

When records are created in Stock Reservation pick and edit, the 0 value retrieved from default attribute set instance, defined in reservation's tables, is now set to null, when creating filter criteria.
Now if there is no attribute set defined for reservation's products, the attribute set value filter is empty.

Thu, 09 Apr 2015 12:26:23 +0200Fixes bug 29448, Fixes bug 29447, Fixes bug 29449
Unai Martirena <unai.martirena@openbravo.com> [Thu, 09 Apr 2015 12:26:23 +0200] rev 26497
Fixes bug 29448, Fixes bug 29447, Fixes bug 29449

The following changes was made in Stock Reservation pick and edit:
When filters are executed, a Reservation entity is created from the json parameter @MaterialMgmtReservation.id@. This works fine when the pop-up is called from Stock Reservation window, but from Sales Order, this parameter does not exists, and the filter process fails. Now is included a code line that puts a @MaterialMgmtReservation.id@ into the json parameters before the filters are applied.
Array critera filtering was bad created when getting grid's data, so was changed, to allow filter's multiple selection.
An hibernate exception is launched when typing wrong filters and the expression 'in ()' is included in the query to be executed. So this expression was replaced by one which returns a false value: '1 = 2'
Were included also, changes to allow filtering quantity's column. Other changes were included to avoid exceptions comparing to null values.

Wed, 08 Apr 2015 10:51:35 +0200Fixed issue 29461: It is possible to create a payment in/out
Jorge Garcia <jorge.garcia@openbravo.com> [Wed, 08 Apr 2015 10:51:35 +0200] rev 26496
Fixed issue 29461: It is possible to create a payment in/out

It is possible to create a payment header when a payment method or a financial
account is disabled in a given financial account.

Now only active payment methods of financial accounts and active financial
accounts are showing in the payment in / payment out window.

In addition, if the user selects a business partner in these windows and the
default payment method and/or the default financial account is/are inactive,
a warning message is shown to the user, indicating which one is inactive.

These warning messages are also included in the fix.

Tue, 07 Apr 2015 10:00:20 +0200Related to bug 29498: Code review
Unai Martirena <unai.martirena@openbravo.com> [Tue, 07 Apr 2015 10:00:20 +0200] rev 26495
Related to bug 29498: Code review

Use ParameterType instead of InputType for CONSTANT String.

Wed, 01 Apr 2015 15:55:26 +0200Fixed bug 29498: Several issues in Match Statement
Víctor Martínez Romanos <victor.martinez@openbravo.com> [Wed, 01 Apr 2015 15:55:26 +0200] rev 26494
Fixed bug 29498: Several issues in Match Statement

1) Wrong management of default parameters in automatic execution process:
ParameterType was used where InputType was expected (and the opposite)

2) NPE when working with default parameters in execution process
constantParameters attribute wasn't initialized before being used. Fixed also parameters attribute with the same potential issue

3) Impossible to create a new payment from transaction when the payment method has an automatic execution process and automatic deposit/withdrawn
We now pass an internal parameter "comingFrom" to know if we come from a transaction. In this case we don't create automatically the transaction (regardless the payment method is automatic deposit/withdrawn) to avoid breaking the unique constraint FIN_FINACC_TRANSACTION_UN inside FIN_FINACC_TRANSACTION table

Tue, 31 Mar 2015 12:45:26 +0200fixed bug 29467: list reference are validated while typing
Asier Lostalé <asier.lostale@openbravo.com> [Tue, 31 Mar 2015 12:45:26 +0200] rev 26493
fixed bug 29467: list reference are validated while typing

This caused to see the field in red as non valid while typing to filter a value.

It has been fixed in the same way selector reference does: preventing validation
on filterComplete. A new OBComboBoxItem class has been implemented in order to
make both list and selectors (including table and tableDir) extend it preventing
in this manner code duplicities.

Thu, 26 Mar 2015 15:21:18 +0100fixed bug 29428: Distinct parameter is not working in JSON REST web services
Asier Lostalé <asier.lostale@openbravo.com> [Thu, 26 Mar 2015 15:21:18 +0100] rev 26492
fixed bug 29428: Distinct parameter is not working in JSON REST web services

Using _distinct property in JSON REST webservices resulted in an incorrectly
generated query. There were 2 problems:

- Entity name for was set in the fetch method, after the refactor done to fix
issue #25182, entity is different in case of using _distinct, and it is managed
by QueryService.
- This refactor also requires of using aliases to work

Mon, 30 Mar 2015 10:07:10 +0200fixed bug 29453: Process Definition without params popup is not closed
Asier Lostalé <asier.lostale@openbravo.com> [Mon, 30 Mar 2015 10:07:10 +0200] rev 26491
fixed bug 29453: Process Definition without params popup is not closed

When a process defintion has no parameters, it is not closed after execution/failure.

The problem was due the invokation of allRequiredParametersSet which now is performed
after validation, this method incorretly assumed there was a form with paramters.

Thu, 26 Mar 2015 10:26:30 +0100fixed bug 29416, related to issue 29424: Done can be clicked more than once
Asier Lostalé <asier.lostale@openbravo.com> [Thu, 26 Mar 2015 10:26:30 +0100] rev 26490
fixed bug 29416, related to issue 29424: Done can be clicked more than once

In process definition Done button was enabled and clickable while client side
validations were being evaluated. This was specially noticeable if those validations
perform backend requests to be completed (which is the case of Add Payment).

Fixed by disabling Done button as first step before executing any validation.

Wed, 01 Apr 2015 17:28:03 +0200Fixes bug 29473: Bank Statement Line amount maintained in Add Payment from FA
Unai Martirena <unai.martirena@openbravo.com> [Wed, 01 Apr 2015 17:28:03 +0200] rev 26489
Fixes bug 29473: Bank Statement Line amount maintained in Add Payment from FA

If exists bslamount this means that Add Payment window has been opened from Match Statement window, so, when selecting a line in Order/Invoices grid, this amount will be set in the line when is smaller than outstanding amount.

If Outstanding amount is smaller, then outstanding amount will be assigned.

Mon, 30 Mar 2015 10:15:36 +0200Fixes bug 29454: Initialize dateacct column is always been done.
Unai Martirena <unai.martirena@openbravo.com> [Mon, 30 Mar 2015 10:15:36 +0200] rev 26488
Fixes bug 29454: Initialize dateacct column is always been done.

At the beginning of costing background a process to initialize dateacct column of m_transaction_cost has being added. This process is independant from Costing Background, but it was added here to avoid the performance problems that it was causing when executing as a modulescript.

It this columns are not initialized it will not be possible to launch 'Sales Invoice Dimensional Report' and 'Valued Stock Report'. The problem happens when the Costing Background process fails for the first transaction that is calculating, because it rollbacks everything, including the process to initialize dateacct column, so, it is not possible to launch the two reports.

Mon, 02 Mar 2015 13:45:56 +0100Fixes bug 29097: A menu tree node can be moved with a template in development
Augusto Mauch <augusto.mauch@openbravo.com> [Mon, 02 Mar 2015 13:45:56 +0100] rev 26487
Fixes bug 29097: A menu tree node can be moved with a template in development

When the Openbravo Trees were reimplemented [1], there was a problem reimplementing the logic done when a Menu tree item is moved. Before the reimplementation, it was possible to move a menu tree item if the module it belonged to was in development or if there was any template module in development. The reimplementation did not take into account the templates, so from then on it has not been possible to moved menu tree nodes having a template in development.

To fix this, templates are taken into accout in the MenuTreeOperationManager class.

[1] https://issues.openbravo.com/view.php?id=25906

Mon, 30 Mar 2015 15:20:12 +0200Fixed bug 29456: Invoice's entry Currency Balancing instead of Vendor Prepayment
Víctor Martínez Romanos <victor.martinez@openbravo.com> [Mon, 30 Mar 2015 15:20:12 +0200] rev 26486
Fixed bug 29456: Invoice's entry Currency Balancing instead of Vendor Prepayment

The selectPrepayments method now searches by FIN_PAYMENT_SCHEDULEDETAIL.FIN_PAYMENT_SCHEDULE_ORDER instead of FIN_PAYMENT_SCHEDULEDETAIL.FIN_PAYMENT_SCHEDULE_INVOICE, because a prepayment is linked to an order.