Fri, 12 Jun 2015 12:05:42 +0200Related to issue 30116: code review improvements
Víctor Martínez Romanos <victor.martinez@openbravo.com> [Fri, 12 Jun 2015 12:05:42 +0200] rev 26965
Related to issue 30116: code review improvements
Reduced useless query complexity to update outstanding amount.
It's only necessary to check fin_payment_detail_id is null (not associated payment) or isinvoicepaid='N' (associated payment but in a non paid yet status)

Wed, 10 Jun 2015 10:52:18 +0200Fixed issue 30116: Outstanding amount of sales order payment plan is not updated
Jorge Garcia <jorge.garcia@openbravo.com> [Wed, 10 Jun 2015 10:52:18 +0200] rev 26964
Fixed issue 30116: Outstanding amount of sales order payment plan is not updated

The problem was that the outstanding amount of sales order payment plan is not
updated when payment method is set as automatic receipt.

Before the commit which introduces this regression, the function checked the
status of the payment. With the changes, the function checks if the payment
schedule detail is paid.

The problem was in the update of the payment plan of the sales order,
specifically in WHERE clause for outstanding amount.

Now, the where clause works as expected, and the outstanding amount is updated
properly.

Wed, 10 Jun 2015 16:55:01 +0200Fixes issue 30140: Error when generating credit and adding a negative line
Alvaro Ferraz <alvaro.ferraz@openbravo.com> [Wed, 10 Jun 2015 16:55:01 +0200] rev 26963
Fixes issue 30140: Error when generating credit and adding a negative line

Add Payment was raising an error if credit used was greater than total amount.
Now, this comprobation will only be done if some record has been selected in Credit To Use grid.

Wed, 10 Jun 2015 10:32:27 +0200Fixes issue 30114: Critical bug with decimals only in PostgreSQL 9.3
Carlos Aristu <carlos.aristu@openbravo.com> [Wed, 10 Jun 2015 10:32:27 +0200] rev 26962
Fixes issue 30114: Critical bug with decimals only in PostgreSQL 9.3

A new build validation has been added. This way, when executing update.database the result returned by the to_number() procedure is evaluated.
n case it does not return the expected result, the task will fail, showing a message with the link to the documentation.

Wed, 10 Jun 2015 10:18:39 +0200Fixes issue 30091: Select Payments Pick&Edit window is not working properly
Carlos Aristu <carlos.aristu@openbravo.com> [Wed, 10 Jun 2015 10:18:39 +0200] rev 26961
Fixes issue 30091: Select Payments Pick&Edit window is not working properly

When selecting a record in a P&E grid, the request done to the FIC was not using the correct mode. Now, when selecting a record, the request is properly done using the EDIT mode.

Thu, 04 Jun 2015 17:47:14 +0200Fixes issue 30099: BP current balance not properly updated
Alvaro Ferraz <alvaro.ferraz@openbravo.com> [Thu, 04 Jun 2015 17:47:14 +0200] rev 26960
Fixes issue 30099: BP current balance not properly updated

Change condition in FIN_PaymentProcess to take into account when the paymend does not have order nor invoice related (when it only has a g/l item, when we are genereting credit or when we are refunding amount).

Thu, 04 Jun 2015 17:02:09 +0200Related to issue 30105: updated copyright
Víctor Martínez Romanos <victor.martinez@openbravo.com> [Thu, 04 Jun 2015 17:02:09 +0200] rev 26959
Related to issue 30105: updated copyright

Tue, 02 Jun 2015 09:06:32 +0200Fixed issue 30105: Completed quantity in the Work Requirement is not updated
Jorge Garcia <jorge.garcia@openbravo.com> [Tue, 02 Jun 2015 09:06:32 +0200] rev 26958
Fixed issue 30105: Completed quantity in the Work Requirement is not updated

Completed quantity in the Work Requirement is not updated under some
circumstances.

The problem was that the ma_workeffort_validate wasn't updated the UPDATED
column of the ma_wrpahse table and you can save even if the line had changed in
the work effort window.

The solution is to update the column with the actual date. Now, when you try to
save it, a error appears in the grid and the save is canceled.

Thu, 04 Jun 2015 14:54:06 +0200Fixes issue 30064: Grid is properly loaded after refreshing with a selected row
Augusto Mauch <augusto.mauch@openbravo.com> [Thu, 04 Jun 2015 14:54:06 +0200] rev 26957
Fixes issue 30064: Grid is properly loaded after refreshing with a selected row

The problem was caused by this code (the this attribute is a ResultSet), which is contained in the fetchRemoteData function:

} else if (this.grid.refreshingWithSelectedRecord) {
// if the grid was refreshed with a record selected, use the range that contained that record
// instead of using targetRecordId to improve the performance
startRow = this.grid.selectedRecordInitInterval;
endRow = this.grid.selectedRecordEndInterval;
}

If the grid is refreshed while one of its records is selected, then the startRow and endRow will be set so that the requested page contains the selected record. The problem was that the ResultSet.localData attribute was not being properly set, as at this points it was expected to contain the 'loading' value for all the rows that are being requested. As a result of this the localData attribute became malformed when the response was processed, and this caused the grid to misbehave.

To fix this, the localData is configured to wait for the proper records:

this.localData = [];
this.setRangeLoading(startRow, endRow);

Thu, 28 May 2015 12:33:42 +0200Fixes issue 30020: Payment schedule amount incorrectly calculated.
Alvaro Ferraz <alvaro.ferraz@openbravo.com> [Thu, 28 May 2015 12:33:42 +0200] rev 26956
Fixes issue 30020: Payment schedule amount incorrectly calculated.

Payment schedule amount incorrectly calculated when adding a payment from reconcile window to a sales order.
FIN_TransactionProcess and PaidStatusEventHandler have been changed in order to set invoicepaid=true only when FIN_PaymentScheduleDetail has a related InvoicePaymentSchedule.
FIN_PaymentProcess.java has also been changed, in order to check invoicePaidAmounts only if FIN_PaymentScheduleDetail has a related InvoicePaymentSchedule.
In case of a payment to a order without an invoice, updatePaymentAmounts will be called only once.
Name of preference in UpdatePaymentPlan modulescript has been update to run it again and fix wrong data created by the issue.

Wed, 20 May 2015 14:06:47 +0200Fixes issue 29981: NPE in Add Payment process request
Alvaro Ferraz <alvaro.ferraz@openbravo.com> [Wed, 20 May 2015 14:06:47 +0200] rev 26955
Fixes issue 29981: NPE in Add Payment process request

When selecting a business partner with the magnifying glass in Add Payment process request, which does not match to the type of the document (a Vendor when the type is Received In); the payment method of the business partner was null and when accessing to its id, a NPE was raised.
Now, if payment method is null will be checked.

Fri, 22 May 2015 10:58:48 +0530Fixes Issue 29996:Role without access to currency entity can not post a
Atul Gaware <atul.gaware@openbravo.com> [Fri, 22 May 2015 10:58:48 +0530] rev 26954
Fixes Issue 29996:Role without access to currency entity can not post a
purchase invoice

Entity Currency not readable issue is fixed by using switching context
to Admin mode and restoring it back again.

Tue, 19 May 2015 13:26:52 +0200Fixes bug 29987: Correct trx status assigned while deleting from reconciliation
Unai Martirena <unai.martirena@openbravo.com> [Tue, 19 May 2015 13:26:52 +0200] rev 26953
Fixes bug 29987: Correct trx status assigned while deleting from reconciliation

while checking or unchecking lines in Reconcile popup 'updateTransactionStatus' method is called to assign the proper status to the transaction. While unchecking 'Withdrawn not Cleared' or 'Deposited not Cleared' statuses has to be assigned to the transactions. This part is was wrong. When the transaction was of BP Deposit 'Withdrawn not Cleared' was being assigned and when the transaction was BP Withdrawal 'Deposited not Cleared' was being assigned.

Thu, 21 May 2015 19:24:22 +0200Fixes issue 29974: Description not transferred from G/L Journal header to lines
Alvaro Ferraz <alvaro.ferraz@openbravo.com> [Thu, 21 May 2015 19:24:22 +0200] rev 26952
Fixes issue 29974: Description not transferred from G/L Journal header to lines

Default value was removed in Description column of GL_JournalLine table. Now, it is setted correctly.
Also, an auxiliary input has been added to have the same default value in Description field of Simple G/L Journal window - Lines tab.

Thu, 21 May 2015 09:39:04 +0200fixed bug 29952: ProcessBundle.setCloseConnection(false) closes connection
Asier Lostalé <asier.lostale@openbravo.com> [Thu, 21 May 2015 09:39:04 +0200] rev 26951
fixed bug 29952: ProcessBundle.setCloseConnection(false) closes connection

When a process is invoked through ProcessRunner and its bundle is set as
setCloseConnection(false) there were 2 problems:
- connection was close after execution so it could not be reused by another
process invoking it
- ProcessRunner tried to update the process run status on a closed connection
causing an error

The problem is caused by the fix for issue #27878 which correctly closes the
connection in DalConnectionProvider when invoking releaseCommitConnection. But
when setCloseConnection it relied in that bug not closing the connection to
leave it open.

The solution consists in doing directly the commit or rollback in DalBaseProcess
without closing the connection.

Thu, 21 May 2015 17:44:34 +0200fixed bug 29961: field changes to Id in editable P&E when adding new rows
Asier Lostalé <asier.lostale@openbravo.com> [Thu, 21 May 2015 17:44:34 +0200] rev 26950
fixed bug 29961: field changes to Id in editable P&E when adding new rows

In P&E with editable grid, if adding new records with default value for a drop
down reference, existing records with different values for that field were changed
from identifier to uuid.

The problem was in how value map was set in this case. Instead of setting it for
the edit form it was done at grid level.

It has been fixed by setting the value map only to the field in the edit form.

Fri, 19 Jun 2015 12:54:35 +0200Fixes issue 29675: check DB and Tomcat have the same time at Tomcat start
Carlos Aristu <carlos.aristu@openbravo.com> [Fri, 19 Jun 2015 12:54:35 +0200] rev 26949
Fixes issue 29675: check DB and Tomcat have the same time at Tomcat start

Wed, 17 Jun 2015 18:53:46 +0200Fixes issue 30007: Payment schedule amount incorrectly calculated
Alvaro Ferraz <alvaro.ferraz@openbravo.com> [Wed, 17 Jun 2015 18:53:46 +0200] rev 26948
Fixes issue 30007: Payment schedule amount incorrectly calculated

FIN_PaymentProcess was not setting isinvoicepaid = true when processing a payment related to an order.
Also, APRM_ISPAYMENTCONFIRMED function, was not taking into account isinvoicepaid when checking if a payment related to an order was confirmed.
Name of preference in UpdatePaymentPlan modulescript has been update to run it again and fix wrong data created by the issue.

Thu, 18 Jun 2015 16:31:55 +0000CI: merge back from main
RM packaging bot <staff.rm@openbravo.com> [Thu, 18 Jun 2015 16:31:55 +0000] rev 26947
CI: merge back from main

Thu, 18 Jun 2015 16:15:58 +0000CI: update AD_MODULE to version 26943
RM packaging bot <staff.rm@openbravo.com> [Thu, 18 Jun 2015 16:15:58 +0000] rev 26946
CI: update AD_MODULE to version 26943

Thu, 18 Jun 2015 16:59:22 +0200Fixes issue 30187: prevent build in unsupported PG versions
Carlos Aristu <carlos.aristu@openbravo.com> [Thu, 18 Jun 2015 16:59:22 +0200] rev 26945
Fixes issue 30187: prevent build in unsupported PG versions

Thu, 18 Jun 2015 13:07:42 +0200related to issue 29904
Sandra Huguet <sandra.huguet@openbravo.com> [Thu, 18 Jun 2015 13:07:42 +0200] rev 26944
related to issue 29904

Wed, 17 Jun 2015 13:50:39 +0200Related to issue 30007: Backout changeset aed0c66779e9
Alvaro Ferraz <alvaro.ferraz@openbravo.com> [Wed, 17 Jun 2015 13:50:39 +0200] rev 26943
Related to issue 30007: Backout changeset aed0c66779e9

Wed, 17 Jun 2015 13:49:30 +0200Related to issue 30095: Backout changeset 195dff675189
Alvaro Ferraz <alvaro.ferraz@openbravo.com> [Wed, 17 Jun 2015 13:49:30 +0200] rev 26942
Related to issue 30095: Backout changeset 195dff675189

Tue, 16 Jun 2015 17:59:58 +0000CI: merge back from main
RM packaging bot <staff.rm@openbravo.com> [Tue, 16 Jun 2015 17:59:58 +0000] rev 26941
CI: merge back from main

Tue, 16 Jun 2015 17:40:14 +0000CI: update AD_MODULE to version 26933
RM packaging bot <staff.rm@openbravo.com> [Tue, 16 Jun 2015 17:40:14 +0000] rev 26940
CI: update AD_MODULE to version 26933

Tue, 16 Jun 2015 18:52:11 +0200Related to issue 30189: Adapt process handler to retrieve objects without id
Carlos Aristu <carlos.aristu@openbravo.com> [Tue, 16 Jun 2015 18:52:11 +0200] rev 26939
Related to issue 30189: Adapt process handler to retrieve objects without id

Tue, 16 Jun 2015 18:13:08 +0200Fixes issue 30189: Values could be overwritten in Modify Payment Plan
Carlos Aristu <carlos.aristu@openbravo.com> [Tue, 16 Jun 2015 18:13:08 +0200] rev 26938
Fixes issue 30189: Values could be overwritten in Modify Payment Plan

In the Modify Payment Plan grid an add function is creating an object to set the values for the new records. This function is setting an empty string for the id property, i.e., every new created record is generated with the same id. This causes that the selection record change is not handled properly under some circumstances in the _startEditing method of the ListGrid class.
To avoid this problem, the id property is not included in the object instead of leaving it empty.

Tue, 16 Jun 2015 17:46:25 +0200merge heads
Víctor Martínez Romanos <victor.martinez@openbravo.com> [Tue, 16 Jun 2015 17:46:25 +0200] rev 26937
merge heads

Tue, 16 Jun 2015 17:43:17 +0200Related to issue 29848: code review improvements
Víctor Martínez Romanos <victor.martinez@openbravo.com> [Tue, 16 Jun 2015 17:43:17 +0200] rev 26936
Related to issue 29848: code review improvements

Fixed v_invoicepaidstatus variable type

Moved query code from the HqlQueryTransformer to the Application Dictionary