Thu, 02 Mar 2017 14:17:25 -0500Fixes issue 35419:Cannot remove an orphan line in Return to/from vendor/customer
Miguel <martencobasmiguel@gmail.com> [Thu, 02 Mar 2017 14:17:25 -0500] rev 31677
Fixes issue 35419:Cannot remove an orphan line in Return to/from vendor/customer

Was not able to remove an orphan line from a return to vendor or a return from
customer document because an incorrect casting to boolean.

When is validating tha Last record is selected inside the Orphan grid lines, the
lastRecord.get("obSelected") object gets as String instead of a Boolean object,
in other case it gets as Boolean.

Now, conditions are rightly validated depending of the class of the object.

Thu, 02 Mar 2017 09:22:31 +0100fixes issue 35398: Check readable clients for child properties using DAL WS
Carlos Aristu <carlos.aristu@openbravo.com> [Thu, 02 Mar 2017 09:22:31 +0100] rev 31676
fixes issue 35398: Check readable clients for child properties using DAL WS

Fix for issue #29683 was introducing a security check to avoid showing child properties which belong to a client different from the current client. But this fix was preventing to display some readable objects like master data defined at system level (client 0).

Therefore this security check has been improved and now it is verified if the child property is defined for a client which is readable for the current role.

Tue, 28 Feb 2017 08:00:23 +0100Fixed issue 35373. Reenable automatic discounts in purchase flows.
Antonio Moreno <antonio.moreno@openbravo.com> [Tue, 28 Feb 2017 08:00:23 +0100] rev 31675
Fixed issue 35373. Reenable automatic discounts in purchase flows.

Tue, 28 Feb 2017 08:00:11 +0100Fixed issue 35373. Reenable automatic discounts in purchase flows.
Antonio Moreno <antonio.moreno@openbravo.com> [Tue, 28 Feb 2017 08:00:11 +0100] rev 31674
Fixed issue 35373. Reenable automatic discounts in purchase flows.

Mon, 27 Feb 2017 10:46:35 +0100Fixed issue 35349:Callout problem when working with comma as decimal separator
Inigo Sanchez <inigo.sanchez@openbravo.com> [Mon, 27 Feb 2017 10:46:35 +0100] rev 31673
Fixed issue 35349:Callout problem when working with comma as decimal separator

The problem was raised when a default format were switched, it means, when
decimal and group separator were switched. In this situation, when
SimpleCalloutInformationProvider class was used to obtain the current element
value and this current element was a BigDecimal, the format was not managed
properly. This occurred because getCurrentElementValue method always retrieved
a String element instead of Object element, in tyhis case BigDecimal.

In this situation, managesUpdatedValuesForCallout method of FIC class compare
if element is a String or not. If a BigDecimal is retrieved as String element,
in this part of the code the format is not managed properly when decimal separator
is comma. The code manage the comma separator as group separator and removed it.

When the decimal separator is dot (.) the format is managed as expected although
this method retrieves a String object (e.g. "1.23"). When decimal separator is
comma (,) this BigDecimal (e.g. 1,24) is retrieved by getCurrentElementValue method
as String value and the format is missed.

This problem has been fixed by take into account type of current element inside
getCurrentElementValue method. Now this method retrieves an object value. In this
case, a BigDecimal is retrieved. Now the format is managed properly.

Tue, 21 Feb 2017 14:16:33 +0100fixes issue 35318: documents were not being attached after send them by e-mail
Carlos Aristu <carlos.aristu@openbravo.com> [Tue, 21 Feb 2017 14:16:33 +0100] rev 31672
fixes issue 35318: documents were not being attached after send them by e-mail

The CoreAttachImplementation class is deleting the original report file after completing the upload process. When attaching a document using the e-mail pop-up this is done before attaching the document into the e-mail. This explains why the document was not being received on the e-mail.

To avoid this problem, now a copy of the original document is sent to the AttachImplementationManager, this way the original file will never be deleted by an upload process handler.

Together with this, now when attaching a document after printing (not by e-mail) we have to delete the original file because in other case it will be kept on disk.

Thu, 16 Feb 2017 11:42:21 -0500Fixes issue 35276: General Ledger filter changes with pagination in JE Report
Armaignac <collazoandy4@gmail.com> [Thu, 16 Feb 2017 11:42:21 -0500] rev 31671
Fixes issue 35276: General Ledger filter changes with pagination in JE Report

Selected General Ledger filter value changes when pagination is executed in the
Journal Entries report

The General Ledger filter is not kept in the session to make use in the pagination.
For the solution, was saved the General Ledger Filter in the session every time
the search is executed (FIND action). By default, if there is any GL in the
session, the GL field will use the defaulted for the selected org. When paginating
always is used the account schema id stored in the session.

Wed, 15 Feb 2017 19:43:11 -0500Fix for issue 35273: General Ledger filter removed when paginating in GL Report
Armaignac <collazoandy4@gmail.com> [Wed, 15 Feb 2017 19:43:11 -0500] rev 31670
Fix for issue 35273: General Ledger filter removed when paginating in GL Report

The General Ledger filter was removed when paginating in General Ledger Report
in HTML view

Now the General Ledger filter it's save in the session by the FIND action and get in the DEFAULT action
for showing in the report page

Wed, 08 Feb 2017 14:07:20 +0100fixes bug 35197: Can't attach using manual role having modules in indevelopment
Carlos Aristu <carlos.aristu@openbravo.com> [Wed, 08 Feb 2017 14:07:20 +0100] rev 31669
fixes bug 35197: Can't attach using manual role having modules in indevelopment

It was not possible to attach a document with a role that hasn't got access to ADTab entity having modules in indevelopment. This was happening because when there are modules in indevelopemnt status, the getTab method of the ADCS class does not store the tab information in cache and uses DAL to retrieve the tab every time it is being called.

Under this circumstances, the getTab method in AttachImplementationManager must be invoked in admin mode to ensure that the role can generate the attachment even when not having access to the ADTab entity.

Tue, 07 Feb 2017 09:48:12 +0100fixes issue 35177: Initialize callout's connection pool on init
Carlos Aristu <carlos.aristu@openbravo.com> [Tue, 07 Feb 2017 09:48:12 +0100] rev 31668
fixes issue 35177: Initialize callout's connection pool on init

Tue, 31 Jan 2017 11:19:49 -0500Fixes issue 35092: Set value in a warehouse document line with empty attribute
Armaignac <collazoandy4@gmail.com> [Tue, 31 Jan 2017 11:19:49 -0500] rev 31667
Fixes issue 35092: Set value in a warehouse document line with empty attribute

In a warehouse document line now can set value in a warehouse document line in case
it does not contain an instance attribute

Fri, 27 Jan 2017 01:47:07 +0100Fixed issue 35064: A deactivated organization can not be activated again.
Inigo Sanchez <inigo.sanchez@openbravo.com> [Fri, 27 Jan 2017 01:47:07 +0100] rev 31666
Fixed issue 35064: A deactivated organization can not be activated again.

When an organization was disabled you could not activate it again as the row was not ediable. This
problem was introduced in a fix related with the code of addWritableAttribute() method of
DefaultJsonDataService class. Before this fix, It was managing the reported case properly (Activate
again a deactivated organization) because this method was handling the particular case of Organizations.

Now is taking into account this particular case (deactivate organizations) in order to manages this
particular case properly. Now it is possible to activate again a deactivate organization.

Mon, 23 Jan 2017 12:33:28 +0100fixes issue 35026: Incorrect styling in Chrome 56
Carlos Aristu <carlos.aristu@openbravo.com> [Mon, 23 Jan 2017 12:33:28 +0100] rev 31665
fixes issue 35026: Incorrect styling in Chrome 56

Wed, 18 Jan 2017 16:47:36 +0100Fixed issue 34998: Limits of buildvalidations haven't defined properly.
Inigo Sanchez <inigo.sanchez@openbravo.com> [Wed, 18 Jan 2017 16:47:36 +0100] rev 31664
Fixed issue 34998: Limits of buildvalidations haven't defined properly.

Some of the execution limits of platform buildvalidations haven't defined properly. Now the problem have
been resolved by updating the following buildvalidations:

- CheckUpdateConnectionPoolMerge: Execution limit should be defined between [null, 3.0.27659].
- DatabaseDecimalNumberCheck: Should't have any execution limit because it should be executed allways.
- DatabaseVersionCheck: Should't have any execution limit because it should be executed allways.
- JdkVersionCheck: Should't have any execution limit because it should be executed allways.
- RemoveCostingRuleProcessExecutions: Execution limit should be defined between [null, 3.0.25161].

Mon, 26 Dec 2016 14:22:32 -0500Fixes issue 34875: Labels need to be changed in some reports if using AUM
Nono Carballo <nonofce@gmail.com> [Mon, 26 Dec 2016 14:22:32 -0500] rev 31663
Fixes issue 34875: Labels need to be changed in some reports if using AUM

- Label 'Quantity in AUM' was changed to 'Qty in AUM'
- Label 'Unit' was changed to 'UOM'
- Some non reachable and needless code was removed

Wed, 18 Jan 2017 09:49:04 -0500Backed out changeset: 99278e1d0451
Mark <markmm82@gmail.com> [Wed, 18 Jan 2017 09:49:04 -0500] rev 31662
Backed out changeset: 99278e1d0451

Tue, 17 Jan 2017 10:10:12 -0500Related to issue 34806: Backed out changeset 3d0a5d2000e4
Mark <markmm82@gmail.com> [Tue, 17 Jan 2017 10:10:12 -0500] rev 31661
Related to issue 34806: Backed out changeset 3d0a5d2000e4

Backed out this patch due to some code formats errors.

Fri, 13 Jan 2017 10:03:39 +0100Fixed bug 34939: 3.0 selectors cannot be used in classic mode
Asier Lostalé <asier.lostale@openbravo.com> [Fri, 13 Jan 2017 10:03:39 +0100] rev 31660
Fixed bug 34939: 3.0 selectors cannot be used in classic mode

When a 3.0 selector was included within classic mode, the JS failed to load.

The problem was cancelAndReplace.js was included within classic mode JS but it
depends on resources not available in this mode.

Because cancel and replace is not designed to work in classic mode, its JS is
now not included in this mode.

Fri, 13 Jan 2017 10:37:15 -0500Fixed issue 34878: Some changes needed to improve the performance in Pending GR
Mark <markmm82@gmail.com> [Fri, 13 Jan 2017 10:37:15 -0500] rev 31659
Fixed issue 34878: Some changes needed to improve the performance in Pending GR

To improve the performance in Pending Goods Receipt window, the extra query was
remove and the message was corrected.

Wed, 11 Jan 2017 16:00:39 +0100Fixed issue 34891: The GL item section of add payment was not working fine
Naroa Iriarte <naroa.iriarte@openbravo.com> [Wed, 11 Jan 2017 16:00:39 +0100] rev 31658
Fixed issue 34891: The GL item section of add payment was not working fine

The grid of the G/L item section of the Add payment process was not workinf fine. The problem was that it was shown as sortable and as filterable and it must not be filterable nor sortable. This has been caused by the changeset[1]. This proyect set every column as sortable and as filterable and so was the problem.
To fix this the values of "canSort" and "canFilter" have been changed in the needed cases, which are the ones that satisfy the condition of having the canDelete property or the canAdd property set to yes and are in Pick and Execute window.
The code which handles the logic has been moved from the OBViewFieldHandler.getGridFieldProperties() to UIDefinition.getGridFieldProperties().

[1]http://code.openbravo.com/erp/devel/pi/rev/afa165be3e5900d1114d33e5106114d0e089876a

Wed, 11 Jan 2017 13:25:36 +0100Fixed issue 34914: The year of the copyright of the ERP has been updated
Naroa Iriarte <naroa.iriarte@openbravo.com> [Wed, 11 Jan 2017 13:25:36 +0100] rev 31657
Fixed issue 34914: The year of the copyright of the ERP has been updated

The year of the copyright of the ERP has been updated from 2016 to 2017.

Mon, 26 Dec 2016 14:22:32 -0500Fixes issue 34875: Labels need to be changed in some reports if using AUM
Nono Carballo <nonofce@gmail.com> [Mon, 26 Dec 2016 14:22:32 -0500] rev 31656
Fixes issue 34875: Labels need to be changed in some reports if using AUM

- Label 'Quantity in AUM' was changed to 'Qty in AUM'
- Label 'Unit' was changed to 'UOM'
- Some non reachable and needless code was removed

Mon, 09 Jan 2017 12:43:41 -0500Backout changeset: f52faf69b245
Mark <markmm82@gmail.com> [Mon, 09 Jan 2017 12:43:41 -0500] rev 31655
Backout changeset: f52faf69b245

Fri, 06 Jan 2017 16:40:10 -0500Related to issue 34806: Updated copyright
Mark <markmm82@gmail.com> [Fri, 06 Jan 2017 16:40:10 -0500] rev 31654
Related to issue 34806: Updated copyright

Mon, 26 Dec 2016 14:22:32 -0500Fixes issue 34806: Labels need to be changed in some reports if using AUM
Nono Carballo <nonofce@gmail.com> [Mon, 26 Dec 2016 14:22:32 -0500] rev 31653
Fixes issue 34806: Labels need to be changed in some reports if using AUM

- Label 'Quantity in AUM' was changed to 'Qty in AUM'
- Label 'Unit' was changed to 'UOM'
- Some non reachable and needless code was removed

Thu, 05 Jan 2017 09:21:26 -0500Fixed issue 34851: Not possible to select a GS in RFC not created from an order
Rafael Queralta Pozo <rqueralta@nauta.cu> [Thu, 05 Jan 2017 09:21:26 -0500] rev 31652
Fixed issue 34851: Not possible to select a GS in RFC not created from an order

Restructured HQL inserter query for discount to select a GS in RFC has not been
created from an order

Tue, 14 Mar 2017 17:48:14 +0100Fixes issue 35241: Random failure in TestCosting when executing it in Oracle
Alvaro Ferraz <alvaro.ferraz@openbravo.com> [Tue, 14 Mar 2017 17:48:14 +0100] rev 31651
Fixes issue 35241: Random failure in TestCosting when executing it in Oracle

Fix testCostingGM5 adding new sleeps.

Sat, 11 Mar 2017 00:46:09 +0530Fixes Issue 35137: Concurrency problem: current balance wrongly calculated
Atul Gaware <atul.gaware@openbravo.com> [Sat, 11 Mar 2017 00:46:09 +0530] rev 31650
Fixes Issue 35137: Concurrency problem: current balance wrongly calculated
when 2 transactions are processed at same time

Lock added at database level for financial account being used while processing
or reactivating transaction.

Tue, 14 Mar 2017 16:55:41 +0100fixes bug 35509: OBQuery without an alias and a select clause is not working
Carlos Aristu <carlos.aristu@openbravo.com> [Tue, 14 Mar 2017 16:55:41 +0100] rev 31649
fixes bug 35509: OBQuery without an alias and a select clause is not working

Mon, 13 Mar 2017 14:22:51 +0100Fixed issue 35489: Wrong priority between different possible translations
Inigo Sanchez <inigo.sanchez@openbravo.com> [Mon, 13 Mar 2017 14:22:51 +0100] rev 31648
Fixed issue 35489: Wrong priority between different possible translations

The problem was when you have an especific translation for a static text in a report (registered
in ad_textinterfaces with the filename column pointing to the repport) and there was a general
translation for the same static text. In this situation, the query that returns the possible
translations prioritizes the general translation over the specific translation.

The problem has been fixed by edit the query and prioritizes a especific translation for a static
text in a report instead of the general translation. Besides it have been removed some unnecessary
lines of code.