Thu, 25 Jun 2015 17:04:28 +0200Fixed issue 30249: Error get when the Set New Currency process def. is executed
Naroa Iriarte <naroa.iriarte@openbravo.com> [Thu, 25 Jun 2015 17:04:28 +0200] rev 27065
Fixed issue 30249: Error get when the Set New Currency process def. is executed

The problem was that a error was got when clicking the "Done" button of the "Set New Currency"
process definition.

"Uncaught TypeError: Cannot read property '_handleSelect' of null"

The problem was in the "ob-parameter-window-view.js" in the handleResponse function.
It was executing "this.showProcessing(false)" even when the "retryExecution" parameter
was false.
Now the "this.showProcessing(false)" is executed only if the "retryExecution" parameter is true.

This affected to the process definition execution because as we were executing the "this.showProcessing(false)"
even when the retryExecution parameter was false, an ob-selector was deleted and after that, it was trying to
get the "._handleSelect" of that selector.

Fri, 03 Jul 2015 16:04:19 +0200Fixes issue 30308: Use get instead of refresh when saving or updating a record
Carlos Aristu <carlos.aristu@openbravo.com> [Fri, 03 Jul 2015 16:04:19 +0200] rev 27064
Fixes issue 30308: Use get instead of refresh when saving or updating a record

We use now OBDal.getInstance().get() instead of OBDal.getInstance().getSession().refresh(). To ensure that the get() methods retrieves the last changes in the object from database, we call evict() to remove the bob from the cache

Thu, 02 Jul 2015 10:54:26 +0200Related to issue 29731: Updated AD_TEXTINTERFACES
Víctor Martínez Romanos <victor.martinez@openbravo.com> [Thu, 02 Jul 2015 10:54:26 +0200] rev 27063
Related to issue 29731: Updated AD_TEXTINTERFACES

Thu, 02 Jul 2015 10:16:44 +0530Fixes Issue 29731:Value Stock Report needs to be enhanced.
Atul Gaware <atul.gaware@openbravo.com> [Thu, 02 Jul 2015 10:16:44 +0530] rev 27062
Fixes Issue 29731:Value Stock Report needs to be enhanced.

Column name Average cost changed to Cost.

Wed, 01 Jul 2015 13:42:51 +0200Related to issue 28645: Applied Code Review changes.
David Miguelez <david.miguelez@openbravo.com> [Wed, 01 Jul 2015 13:42:51 +0200] rev 27061
Related to issue 28645: Applied Code Review changes.

Mon, 22 Jun 2015 19:38:05 +0200Related to issue 28645: Create new reservation when voiding shipment
Alvaro Ferraz <alvaro.ferraz@openbravo.com> [Mon, 22 Jun 2015 19:38:05 +0200] rev 27060
Related to issue 28645: Create new reservation when voiding shipment

When voiding a goods shipment with a line related to a order line which has a related closed reservation, a new reservation will be created in Completed status with the quantity of the order line.

Fri, 22 May 2015 13:13:16 +0200Fixed bug 28645: reservations and product quantity variable
Víctor Martínez Romanos <victor.martinez@openbravo.com> [Fri, 22 May 2015 13:13:16 +0200] rev 27059
Fixed bug 28645: reservations and product quantity variable

Improved javascript validation in stock reservation P&E to work with product quantity variable
Activated the reservation close status as a way to control and properly close the cycle for reservations related to quantity variable products
Modified M_RESERVATION_POST to set the line's quantity = releasedQty when closing the reservation
Modified C_ORDERLINE2_TRG trigger (on update event) to close reservations where QtyDelivered >= qtyordered
Button close is hidden when reservation status is closed
Added default filter to Stock Reservations window to hide closed records

Thu, 02 Jul 2015 09:40:16 +0200Fixes issue 30274: uuid appear in saved views with multiple criteria on a field
Carlos Aristu <carlos.aristu@openbravo.com> [Thu, 02 Jul 2015 09:40:16 +0200] rev 27058
Fixes issue 30274: uuid appear in saved views with multiple criteria on a field

When a view is saved while any of its filters are currently using the 'id' filter type, the id and identifier of the selected options are stored in a cache. If we have multiple criteria on one field, an internal loop is executed to retrieve all the criterias in the getFKFilterAuxiliaryCache function.

The problem was that this internal loop was using the same variable as the external one to insert those criterias into the cache. This caused that the subsequent filters for next fields were not being handled properly as the condition of the external loop was not being fulfilled anymore due to the increment done in the internal loop.

This has been solved just using a new variable 'j' in the internal loop.

Tue, 30 Jun 2015 18:43:16 +0000CI: merge back from main
RM packaging bot <staff.rm@openbravo.com> [Tue, 30 Jun 2015 18:43:16 +0000] rev 27057
CI: merge back from main

Tue, 30 Jun 2015 18:27:51 +0000CI: update AD_MODULE to version 27055
RM packaging bot <staff.rm@openbravo.com> [Tue, 30 Jun 2015 18:27:51 +0000] rev 27056
CI: update AD_MODULE to version 27055

Tue, 30 Jun 2015 14:19:30 +0200Related to issue 30143: Synchronize Terminology
Víctor Martínez Romanos <victor.martinez@openbravo.com> [Tue, 30 Jun 2015 14:19:30 +0200] rev 27055
Related to issue 30143: Synchronize Terminology

Tue, 30 Jun 2015 11:40:10 +0200Related to issue 29042: Backout changeset e8bebe16d4bf
Víctor Martínez Romanos <victor.martinez@openbravo.com> [Tue, 30 Jun 2015 11:40:10 +0200] rev 27054
Related to issue 29042: Backout changeset e8bebe16d4bf

The reverted changeset creates a mutanting trigger in Oracle

Tue, 30 Jun 2015 10:27:33 +0200Related to issue 30143. Filters Add Payments Pop up by Financial Account
David Miguelez <david.miguelez@openbravo.com> [Tue, 30 Jun 2015 10:27:33 +0200] rev 27053
Related to issue 30143. Filters Add Payments Pop up by Financial Account
If a different Financial Account is selected it is taken into account
when creating the Transacion.

Tue, 30 Jun 2015 10:27:55 +0200Related to issue 29414: Updated browser supported/recommended list for PR15Q3
David Baz Fayos <david.baz@openbravo.com> [Tue, 30 Jun 2015 10:27:55 +0200] rev 27052
Related to issue 29414: Updated browser supported/recommended list for PR15Q3

* Chrome. Supported 42, Recommended 43 or higher.
* Firefox. Supported 31, Recommended 38 or higher.
* Internet Explorer. Supported 9, Recommended 11 or higher.
* Safari. Supported 7, Recommended 8 or higher.

Tue, 30 Jun 2015 09:08:18 +0200Related to issue 29675: fix in comment
Carlos Aristu <carlos.aristu@openbravo.com> [Tue, 30 Jun 2015 09:08:18 +0200] rev 27051
Related to issue 29675: fix in comment

Tue, 30 Jun 2015 09:04:31 +0200Related to issue 29675: improvements in log messages
Carlos Aristu <carlos.aristu@openbravo.com> [Tue, 30 Jun 2015 09:04:31 +0200] rev 27050
Related to issue 29675: improvements in log messages

Mon, 29 Jun 2015 22:53:12 +0000CI: merge back from main
RM packaging bot <staff.rm@openbravo.com> [Mon, 29 Jun 2015 22:53:12 +0000] rev 27049
CI: merge back from main

Mon, 29 Jun 2015 22:37:53 +0000CI: update AD_MODULE to version 27047
RM packaging bot <staff.rm@openbravo.com> [Mon, 29 Jun 2015 22:37:53 +0000] rev 27048
CI: update AD_MODULE to version 27047

Mon, 29 Jun 2015 17:28:49 +0200Fixed 30282: Suppress 'unused object allocation' warnings where done intentionally.
Stefan Hühner <stefan.huehner@openbravo.com> [Mon, 29 Jun 2015 17:28:49 +0200] rev 27047
Fixed 30282: Suppress 'unused object allocation' warnings where done intentionally.

In some cases existing code does create objects without using them just to check for
side-effects. I.e. new BigDecimal(someString) to check if that string can be parsed
as a number.
Supress the warning in those cases.

Fri, 26 Jun 2015 13:56:56 +0000CI: merge back from main
RM packaging bot <staff.rm@openbravo.com> [Fri, 26 Jun 2015 13:56:56 +0000] rev 27046
CI: merge back from main

Fri, 26 Jun 2015 13:40:13 +0000CI: update AD_MODULE to version 27038
RM packaging bot <staff.rm@openbravo.com> [Fri, 26 Jun 2015 13:40:13 +0000] rev 27045
CI: update AD_MODULE to version 27038

Thu, 25 Jun 2015 10:20:46 +0200Fixed bug 30143: Add Multiple Payments in Financial Account
Víctor Martínez Romanos <victor.martinez@openbravo.com> [Thu, 25 Jun 2015 10:20:46 +0200] rev 27044
Fixed bug 30143: Add Multiple Payments in Financial Account

Due to the Add Transaction refactor, the ability to create transactions from several payments in a batch was missed.
This development adds a new button in Financial Account window (Add Multiple Payments) where the user must enter a transaction date and select one or more payments. The system will create a transaction per selected payment and it will process all of them. If any exception is raised at any point in time, no transactions will be created.

The payments shown in the P&E are exactly the same as in the payment selector at Transaction tab.
The great advantage of this process is that you can select multiple payments at the same time, and that the transactions are automatically processed, so it is very agile from the user point of view.

Thu, 25 Jun 2015 16:37:07 +0200Fixed issue 30134: Error executing a process definition if a param. is numeric
Naroa Iriarte <naroa.iriarte@openbravo.com> [Thu, 25 Jun 2015 16:37:07 +0200] rev 27043
Fixed issue 30134: Error executing a process definition if a param. is numeric

The problem was that if a parameter was defined as default with a numeric value,
an error was got.

The problem was in the "ob-parameter-window-view.js", there is a function called
getTypeSafeValue which was not taking into account the fact of having the "value"
argument as a numeric value. That was why it was not working fine.

To fix this a new condition has been added. Now it is checked if the "value" parameter
is a number.

Fri, 26 Jun 2015 13:47:10 +0200Fixes Issue 30259. When a Transaction is set as Permanent, avoid to modify
David Miguelez <david.miguelez@openbravo.com> [Fri, 26 Jun 2015 13:47:10 +0200] rev 27042
Fixes Issue 30259. When a Transaction is set as Permanent, avoid to modify
it's Unitary Cost, since it will not be possible (it is checked later in the code)

Fri, 26 Jun 2015 13:44:06 +0200Backed out changeset f5b89bd131a9
David Miguelez <david.miguelez@openbravo.com> [Fri, 26 Jun 2015 13:44:06 +0200] rev 27041
Backed out changeset f5b89bd131a9

Fri, 26 Jun 2015 13:43:05 +0200Fixes Issue 30259. When a Transaction is set as Permanent, avoid to modify
David Miguelez <david.miguelez@openbravo.com> [Fri, 26 Jun 2015 13:43:05 +0200] rev 27040
Fixes Issue 30259. When a Transaction is set as Permanent, avoid to modify
it's Unitary Cost, since it will not be possible (it is checked later in the code)

Fri, 26 Jun 2015 13:14:29 +0200Fixes Issue 30201. Fixes issue with more than 1000 Transactions in
David Miguelez <david.miguelez@openbravo.com> [Fri, 26 Jun 2015 13:14:29 +0200] rev 27039
Fixes Issue 30201. Fixes issue with more than 1000 Transactions in
Skip Status.
Also, removes Transactions in Skip Status from the Query to improve
performance.

Thu, 25 Jun 2015 18:56:49 +0200Related to issue 30057: code review preview
Víctor Martínez Romanos <victor.martinez@openbravo.com> [Thu, 25 Jun 2015 18:56:49 +0200] rev 27038
Related to issue 30057: code review preview

Removed flushes from RoleEventHandler because they create conflicts. As a consequence we lose the ability to clear the session, but this shouldn't be a problem because it's very unlikely to have environments with great amount of organizations.
In RoleEventHandler we only create access to * organization when access level is Client (before this changeset it created also records for other organizations and it is useless).
Reverted changes for Initial Client/Organization Setup. RoleEventHandler won't do anything if executed from an Initial Client/Organization Setup (this change is a way to isolate the problems reported at #30253)
Added log4j to RoleEventHandler.
Removed admin mode from RoleEventHandler because it's not needed (the user always has access t the entities involved in the process).

Fri, 05 Jun 2015 15:21:15 +0200Fixes issue 30057: Org Access added automatically to automatic roles
Alvaro Ferraz <alvaro.ferraz@openbravo.com> [Fri, 05 Jun 2015 15:21:15 +0200] rev 27037
Fixes issue 30057: Org Access added automatically to automatic roles

Org Access will be automatically created when creating a new no manual role following this rule:
System user level: * organization with Organization Administrator flag = N.
Client user level: * organization with Organization Administrator flag = N and all the rest of organizations of the client with Organization Administrator flag = Y.
Client+Organization user level: * organization with Organization Administrator flag = N and all the rest of organizations of the client with Organization Administrator flag = Y.
Organization user level: all the rest of organizations of the client (excluding * organization) with Organization Administrator flag = Y.

Thu, 25 Jun 2015 15:59:05 +0000CI: merge back from main
RM packaging bot <staff.rm@openbravo.com> [Thu, 25 Jun 2015 15:59:05 +0000] rev 27036
CI: merge back from main