Thu, 05 Nov 2015 16:19:46 +0100fixes issue 31274: current combo value is not selected when opening drop down
Carlos Aristu <carlos.aristu@openbravo.com> [Thu, 05 Nov 2015 16:19:46 +0100] rev 27835
fixes issue 31274: current combo value is not selected when opening drop down
The problem is caused because after the combo refactor project table and tabledir references make use of a class with different behavior (OBFKComboItem).

Together with this, currently in the FormItem class there is a logic on the _shouldSelectOnFocus method which performs the selection just when tabbing through the form, or on programmatic focus, but not on mouse click. This is the main reason why the text is not being selected when clicking on the drop-down in form view for any reference.

In order to have a common behavior for all the combos in both grid and form view, we are overriding the showPicker() method of OBComboBoxItem to ensure that we select the text after clicking on the drop-down

Thu, 05 Nov 2015 11:28:55 +0100Fixed issue 31344: The email option does not work wih attach by default.
Naroa Iriarte <naroa.iriarte@openbravo.com> [Thu, 05 Nov 2015 11:28:55 +0100] rev 27834
Fixed issue 31344: The email option does not work wih attach by default.

When the attach by default preference was set, the email option was not working.
To fix this some classes have bennchanged:
OBViewTab.java to have a new parameter "emailButton" or "printButton" in the view.
In the ob-toolbar.js, in the OB.ToolbarUtils.print function now takes the new parameter and puts
it in the popupParams.
Thanks to that in the PrinterReports.java it is possible to catch that parameter from the
vars variable and if it is "emailButton" the logic which was failing at first is avoided.
That logic is only for the direct print and the attach by default and this has no sense in the case
of an email.

Thu, 05 Nov 2015 12:40:18 +0100fixed bug 31373: UI frozen if calendar data request fails
Asier Lostalé <asier.lostale@openbravo.com> [Thu, 05 Nov 2015 12:40:18 +0100] rev 27833
fixed bug 31373: UI frozen if calendar data request fails

When a request to calendar datasource fails, don't try to execute it again as
it most probably, will continue failing.

Thu, 15 Oct 2015 22:11:30 +0530Fixes Issue 30782:Report's currency should be defaulted to organization's
Atul Gaware <atul.gaware@openbravo.com> [Thu, 15 Oct 2015 22:11:30 +0530] rev 27832
Fixes Issue 30782:Report's currency should be defaulted to organization's
currency

In following reports default currency filter value is obtained from
Organization select, if not then from Organization's legal entity
else Clients Currency.
- Sales Dimensional Report
- Shipment Dimensional Report
- Sales Invoice Dimensional Report
- Goods Receipt Dimensional Report

Wed, 04 Nov 2015 18:55:33 +0100Fixed bug 31193: code review improvements
Víctor Martínez Romanos <victor.martinez@openbravo.com> [Wed, 04 Nov 2015 18:55:33 +0100] rev 27831
Fixed bug 31193: code review improvements

Changes in the solution:
1. When a payment in awaiting execution is reactivated or voided, we immediately delete the associated APRMPendingPaymentFromInvoice record. This is a way to ensure the same behavior as when creating the payment manually, where no APRMPendingPaymentFromInvoice record is created and the user must process manually the payment.
2. In case the payment is in awaiting execution, and there is any update, we update the APRMPendingPaymentFromInvoice record to point to the current Payment Process. This is a way to ensure the payment originally created by the system can be processed by the background process with the right payment process.
3. In case the payment is in awaiting execution, and the payment method is updated to any other without a payment process, then the APRMPendingPaymentFromInvoice record is deleted. This is done to ensure the payment is not processed by the background process with the Payment Process associated before.
4. The changes in the FIN_PaymentProcess have been reverted, because there is no need to create always a APRMPendingPaymentFromInvoice record before processing the payment
5. The ExecutePendingPayments class, which is the background process that processes the payments in the APRMPendingPaymentFromInvoice entity, will remove any APRMPendingPaymentFromInvoice record linked to a payment in Voided status, and it will execute only the payments in Awaiting Execution.
6. The code in the ExecutePendingPayments will probably require a deeper review to properly write it.

Thu, 29 Oct 2015 14:26:35 +0530Fixes Issue 0031193:Execute Pending Payments background process is taken into
Atul Gaware <atul.gaware@openbravo.com> [Thu, 29 Oct 2015 14:26:35 +0530] rev 27830
Fixes Issue 0031193:Execute Pending Payments background process is taken into
account payments that are not Awaiting Execution

- Remove lines from APRMPendingPaymentFromInvoice when payment does not have
status as Awaiting Execution
- While processing payment check whether records exists in
APRMPendingPaymentsFromInvoice if no create them, if yes check whether they
have proper execution process, if not set it.

Thu, 05 Nov 2015 10:32:23 +0100fixed bug 31366: SqlCallableStatement test cases fail in try-ret-checks-oracle
Asier Lostalé <asier.lostale@openbravo.com> [Thu, 05 Nov 2015 10:32:23 +0100] rev 27829
fixed bug 31366: SqlCallableStatement test cases fail in try-ret-checks-oracle

Retail oracle try infrastructure is executed in parallel for different DB users.
When querying as DBA for open cursors, cursors only for current user should be
checked, other way different executions can cause clashes.

Thu, 05 Nov 2015 08:17:46 +0100Related to issue 31340: Many warnings in log generated by import entry code when a cashup can not be processed
Martin Taal <martin.taal@openbravo.com> [Thu, 05 Nov 2015 08:17:46 +0100] rev 27828
Related to issue 31340: Many warnings in log generated by import entry code when a cashup can not be processed
Make the wait slightly longer and fit to 1800 records/min

Wed, 04 Nov 2015 23:32:41 +0100Related to issue 31340: Many warnings in log generated by import entry code when a cashup can not be processed
Martin Taal <martin.taal@openbravo.com> [Wed, 04 Nov 2015 23:32:41 +0100] rev 27827
Related to issue 31340: Many warnings in log generated by import entry code when a cashup can not be processed
More log statements for debugging, add a minimum 1 second wait before re-reading entries

Thu, 05 Nov 2015 00:24:35 +0100Related to issue 30986:Problem adding to a role a process definition access
Inigo Sanchez <inigo.sanchez@openbravo.com> [Thu, 05 Nov 2015 00:24:35 +0100] rev 27826
Related to issue 30986:Problem adding to a role a process definition access

The problem was when it is tried to translated a "process definition". In
a "Role" window it can be added a "process definition" access and it is
not translated.

The process "generate.entities" has thrown an error because a column that
is call process definition in obuiapp_process_trl has "Link to Parent
Column" unselected.

This check had been forgotten to set properly.Now, It has been resolved
with this fix.

Tue, 03 Nov 2015 21:18:14 +0100Fixes issue 31347: Error when validating a Costing Rule with backdated enabled
Alvaro Ferraz <alvaro.ferraz@openbravo.com> [Tue, 03 Nov 2015 21:18:14 +0100] rev 27825
Fixes issue 31347: Error when validating a Costing Rule with backdated enabled

When checking for the current validated costing rule, it should have an ending date greater or equal than current date.

Tue, 03 Nov 2015 18:00:53 +0100Fixed issue 31317: The error shown in the log is fixed.
Naroa Iriarte <naroa.iriarte@openbravo.com> [Tue, 03 Nov 2015 18:00:53 +0100] rev 27824
Fixed issue 31317: The error shown in the log is fixed.

There was an error shown in the log because the servlet was interpreting that it was an email.
That was caused because a condition was not taking into account nothing else but the request.getServletPath as
"print.html".
This has been changed and now "printoptions.html" is taken into account.

Mon, 02 Nov 2015 08:33:06 +0100related to bug 30891: query open cursors as DBA
Asier Lostalé <asier.lostale@openbravo.com> [Mon, 02 Nov 2015 08:33:06 +0100] rev 27823
related to bug 30891: query open cursors as DBA

Fri, 30 Oct 2015 12:03:10 +0100related to bug 30891: added test case
Asier Lostalé <asier.lostale@openbravo.com> [Fri, 30 Oct 2015 12:03:10 +0100] rev 27822
related to bug 30891: added test case

Fri, 30 Oct 2015 11:41:50 +0100related to bug 30891: added test case
Asier Lostalé <asier.lostale@openbravo.com> [Fri, 30 Oct 2015 11:41:50 +0100] rev 27821
related to bug 30891: added test case

Fri, 30 Oct 2015 11:22:17 +0100fixed bug 30891: sqlc transactional callable statemts not released in Oracle
Asier Lostalé <asier.lostale@openbravo.com> [Fri, 30 Oct 2015 11:22:17 +0100] rev 27820
fixed bug 30891: sqlc transactional callable statemts not released in Oracle

Working with Oracle transactional callable statements are not closed after
invokation, causing the number of open cursors to increase unnecessarily.

There was already code in sqlc to release the statement, but there was an
extra incorrect check not to do it in case of callable when in transactional
mode.

This check has been removed, being now transactional and non transactional cases
handled in the same way.

Fri, 30 Oct 2015 13:15:08 +0100Fixed bug 31198:RO logic doesn't work properly in grid view with combo fields
Inigo Sanchez <inigo.sanchez@openbravo.com> [Fri, 30 Oct 2015 13:15:08 +0100] rev 27819
Fixed bug 31198:RO logic doesn't work properly in grid view with combo fields

The problem was that Read Only logic did not work properly in grid view with
combo type fields. If there were two fields on a grid, one having 'List' as
a reference and the second one been a 'TableDir' and the second one had a read
only logic based on the value of the first one, the second one did not work
properly. This happend when 'List' field was next to (leftside) of the
'TableDir' field or if there were intermediate fields between 'List' and
'TableDir' fields that were not editables (RO).

The problem has been fixed overriding a 'refreshCell()' method to use
'allowEditCellRefresh' parameter. This parameter is taking into account in
'refreshCellValue()' method of SC and if there is a visible editor in the
cell with the focus on it, redrawing and update it's value.

This fix take into account when 'refreshCell()' method is called with a value
in 'allowEditCellRefresh' parameter and in this case it will not be called
the overridden method to avoid delete some preexisting correct fluxes.

Mon, 02 Nov 2015 11:28:15 +0100related to issue 31254: Add missing opacity for toolbar icon
Carlos Aristu <carlos.aristu@openbravo.com> [Mon, 02 Nov 2015 11:28:15 +0100] rev 27818
related to issue 31254: Add missing opacity for toolbar icon

Fri, 30 Oct 2015 13:08:22 +0100fixes issue 30800: Filter on Property field in a table ref column doesn't work
Carlos Aristu <carlos.aristu@openbravo.com> [Fri, 30 Oct 2015 13:08:22 +0100] rev 27817
fixes issue 30800: Filter on Property field in a table ref column doesn't work
Now the value used to filter a column based on a table reference is set on the client. We make use an attribute called displayProperty which is only set for Table references. This way, the change is transparent for the rest of FK references.
By setting this value in the client, the replacement done in the server (in AvanceQueryBuilder.parseSimpleClause() method) is not needed anymore.

Fri, 23 Oct 2015 13:28:16 +0200Fixes Issue 31176. Changes old selector with new one in M_InoutLine Table.
David Miguelez <david.miguelez@openbravo.com> [Fri, 23 Oct 2015 13:28:16 +0200] rev 27816
Fixes Issue 31176. Changes old selector with new one in M_InoutLine Table.

Replaces the old selector for Storage Bins with a new OBUISEL_Selector
in M_InoutLine Table.
In Sales flow it shows only Storage Bins that are available to the selected
Organization and that are also On Hand Warehouses.
In the Purchase flow it shows Storage Bins that are available to the selected
Organization.
Also, the selector is pre-filtered using the Warehouse in the Document Header
and it has as a default value a Storage Bin of that Warehouse.

Tue, 27 Oct 2015 11:20:34 +0100Fixed issue 30783: Reduce the number of clicks to print Documents.
Naroa Iriarte <naroa.iriarte@openbravo.com> [Tue, 27 Oct 2015 11:20:34 +0100] rev 27815
Fixed issue 30783: Reduce the number of clicks to print Documents.

Before, when a document was going to be printed, several clicks were needed.
That was because when you click on the print button, a popup which asks if
you wanted to attach the document or just print it appear, and after it was possible to print.

The number of clicks needed for that task could be bothering if it was often repeated:.

To fix this two new preferences have been added.
The first one "Attach by default": If this preference is set to "N" then, the popup is not
shown when clicking the print button, and the document is not attached.
If this preference is set to "Y" then, the popup is not shown when clicking the print button
and the document is attached.
If this preference is undefined, then, the popup which asks for attaching the document or just printing
it appears when clicking the print button.

The other preference "Direct Print": If this is set as "Y" then the printing popup will be
opened.
If this is set as "N" or undefined, then the document is downloaded, but the printing popup is not shown.
The "ReportingUtils.java" has been modified, now if the direct print preference is set, the "this.print()" js function
is executed.
The "PrinterReports.java" has been modified for handling the new functionality with the preference which
attaches the documents directly.
The "PrintController.java" has been modified for handling the new functionality with the Direct print
preference.

The index.jsp has been changed because there was a problem with some browsers and the "Direct print" preference
it was not possible to display the printer popup in Internet Explorer nor Firefox.
This was because we were using a hidden frame for putting the pdf there. Chrome was able to take what there was in
that frame, but Firefox and Internet Explorer were not able.
To fix this the style="display:none" of the frame "background_target" has been removed.
Now, it is possible to use the Direct Print preference in the Firefox, Safari, Internet Explorer and Chrome browsers.

Tue, 27 Oct 2015 13:37:18 +0100fixes issue 31254: The style of the toolbar button looks different in MS Edge
Carlos Aristu <carlos.aristu@openbravo.com> [Tue, 27 Oct 2015 13:37:18 +0100] rev 27814
fixes issue 31254: The style of the toolbar button looks different in MS Edge

The transparency of the border defined in the CSS properties of the button was not being interpreted properly by MS Edge. To solve this problem, a solution has been added for this particular browser, by setting the transparency of the border using CSS3

Tue, 27 Oct 2015 08:28:58 +0100fixed bug 31187: Lazy filtering does not work when filtering the first time
Asier Lostalé <asier.lostale@openbravo.com> [Tue, 27 Oct 2015 08:28:58 +0100] rev 27813
fixed bug 31187: Lazy filtering does not work when filtering the first time

Having lazy filtering configured, if a filter was applied in a grid as first
action, it was not possible to apply it. A js error was thrown:
Uncaught TypeError: this.data.willFetchData is not a function

The problem was in "if (this.data.willFetchData(this.convertCriteria(criteria)))"
statement which incorrectly assumed this.data to be an object and willFetchData
a function within it. This is not true when in this situation where this.data is
an array.

It has been fixed by taking into account this case by checking wether this.data
is an array.

Mon, 26 Oct 2015 11:56:37 +0100related to issue 30919: fixed logic to check if JNDIConnectionProvider is used
Asier Lostalé <asier.lostale@openbravo.com> [Mon, 26 Oct 2015 11:56:37 +0100] rev 27812
related to issue 30919: fixed logic to check if JNDIConnectionProvider is used

Old JNDIConnectionProvider should be used if JNDI is configured and there is
no external pool in use.

Mon, 26 Oct 2015 11:07:45 +0100fixes issue 30534: Some pop-ups are not displayed properly on MS Edge
Carlos Aristu <carlos.aristu@openbravo.com> [Mon, 26 Oct 2015 11:07:45 +0100] rev 27811
fixes issue 30534: Some pop-ups are not displayed properly on MS Edge

Mon, 19 Oct 2015 17:11:49 +0200Fixes issue 31041: Insuffient stock error message when processing an inventory
Alvaro Ferraz <alvaro.ferraz@openbravo.com> [Mon, 19 Oct 2015 17:11:49 +0200] rev 27810
Fixes issue 31041: Insuffient stock error message when processing an inventory

Avoid "insufficient stock" error message when processing an Inventory Amount Update created in the past.
Now, when processing related closing and opening inventories, negative stock will not be checked.

Fri, 23 Oct 2015 14:14:37 +0200related to issue 30931: recalculate child permissions with different parents
Carlos Aristu <carlos.aristu@openbravo.com> [Fri, 23 Oct 2015 14:14:37 +0200] rev 27809
related to issue 30931: recalculate child permissions with different parents
When recalculating all the permissions of a role, it was not being deleted the child permissions inherited from a role different than the one used to inherit the parent. This is not fixed. Note that this case only applies in Tab Access and Field Access.

Fri, 23 Oct 2015 10:45:30 +0200Related to issue 30986:Code review improvements.
Inigo Sanchez <inigo.sanchez@openbravo.com> [Fri, 23 Oct 2015 10:45:30 +0200] rev 27808
Related to issue 30986:Code review improvements.

The problem was when creating new language code has been included in AD_LANGUAGE_CREATE
which is in core, being insertions for a table in client.application module, the code
managing them should be within that module (OBUIAPP_LANGUAGE_CREATE) where parameters
are also handled.

Now it has been resolved the problem by moving the code to the correct function
(OBUIAPP_LANGUAGE_CREATE).

Fri, 23 Oct 2015 09:39:33 +0200related to issue 30986: Process Def > Parameter tab marked as trl
Asier Lostalé <asier.lostale@openbravo.com> [Fri, 23 Oct 2015 09:39:33 +0200] rev 27807
related to issue 30986: Process Def > Parameter tab marked as trl

In this way it will not be shown unless "Show Trl Tabs" prefrence is enabled

Thu, 22 Oct 2015 20:06:52 +0200Related to issue 30986:updated column type in obuiapp_process_trl table.
Inigo Sanchez <inigo.sanchez@openbravo.com> [Thu, 22 Oct 2015 20:06:52 +0200] rev 27806
Related to issue 30986:updated column type in obuiapp_process_trl table.

The problem was that testTrlColumnsOraTyp was failling. It has been updated column
types in obuiapp_process_trl table and now it has been resolved the problem.