Mon, 30 May 2016 17:26:21 +0200Related to issue 33073: A test has been added.
Naroa Iriarte <naroa.iriarte@openbravo.com> [Mon, 30 May 2016 17:26:21 +0200] rev 29565
Related to issue 33073: A test has been added.

A test that checks the correct behavior has been added.

Mon, 30 May 2016 15:28:06 +0200Fixed issue 33073: It was not possible to use _where param in JSON webservices
Naroa Iriarte <naroa.iriarte@openbravo.com> [Mon, 30 May 2016 15:28:06 +0200] rev 29564
Fixed issue 33073: It was not possible to use _where param in JSON webservices

It was not possible to filter using the "_where" parameter. The "whereAndFilterClause"
parameter was needed instead.
This was not correct because in the Webservices we must mantain the use of the "_where"
parameter to filter the data.
This has been fixed in the "JSONRestServlet" class. Before calling the fetch method, the
"whereAndFilterClause" has been overwritten with the value of the "_where" parameter. Now
when a user uses "_where" in a query of a JSON webService, that value will be set in the
"whereAndFilterClause" parameter and will work properly.

Tue, 31 May 2016 10:44:19 +0200related to issue 32951: fixed build validation for Oracle
Asier Lostalé <asier.lostale@openbravo.com> [Tue, 31 May 2016 10:44:19 +0200] rev 29563
related to issue 32951: fixed build validation for Oracle

Used mask as special case for PG is not valid in Oracle, using standard
to_number when in Oracle.

Tue, 31 May 2016 09:03:00 +0200fixed bug 32951: in pg to_number truncates decimal to 6 positionsi
Asier Lostalé <asier.lostale@openbravo.com> [Tue, 31 May 2016 09:03:00 +0200] rev 29562
fixed bug 32951: in pg to_number truncates decimal to 6 positionsi

To_Number function now does not use masks to do the conversion, so now it
considers always dot as decimal separator regardless DB's locale.

In any case build validation should prevent locales with other decimal separator
than dot, so mask is used to do the validation now.

Tue, 31 May 2016 07:51:51 +0200[JSBeautifier] Put bin/bash definition before license
Miguel de Juana <miguel.dejuana@openbravo.com> [Tue, 31 May 2016 07:51:51 +0200] rev 29561
[JSBeautifier] Put bin/bash definition before license

Mon, 30 May 2016 18:33:13 +0200Related to issue 33043: Code review improvements
Alvaro Ferraz <alvaro.ferraz@openbravo.com> [Mon, 30 May 2016 18:33:13 +0200] rev 29560
Related to issue 33043: Code review improvements

Fri, 27 May 2016 12:53:49 -0400Fixes issue 33043: Permissions problems after process payment solved
Mark <markmm82@gmail.com> [Fri, 27 May 2016 12:53:49 -0400] rev 29559
Fixes issue 33043: Permissions problems after process payment solved

Role defined for an specific org is not able to see data from sister orgs.

Regression was introduced by the commit associated to issue 28931:
http://code.openbravo.com/erp/devel/pi/rev/78fd9bade67beea0399977fcdc05fd267c4af8c4

Changes were rolled back.
Also this patch includes fix for the issue 28931, avoiding to remove from the Writable Organizations List of the OBContext object, the Organization of the sequence of the payment's document type, if this organization is already in the list of accesible organizations of the current logged role.

Wed, 25 May 2016 15:57:12 +0200Fixed issue 33051: The "hasGeneralAccess" method is called twice
Naroa Iriarte <naroa.iriarte@openbravo.com> [Wed, 25 May 2016 15:57:12 +0200] rev 29558
Fixed issue 33051: The "hasGeneralAccess" method is called twice

The HttpSecureAppServlet.hasGeneralAccess method is called twice
when a window is refresed or opened, for example "Sales Order".
This is not rigth because it executes more queries than needed.
To fix this a piece of code have been refactored in the "DataSourceServlet"
class.
In the "doPost" method, there is a call to the "hasAccess" method, this method
is the one which calls the "hasGeneralAccess" and this is the one that is called twice.
The problem was that inside the "doPost" method exists also a call to the "doFetch" method,
this method calls the "hasAccess" method and this calls the "hasGeneralAccess" method.
So, when the doPost method called the fetch method, the "hasGeneralAcces" method was executed
twice because of the call inside the "doPost" and the call inside the "doFetch" method.

This has been fixed by moving the code which was doing the call to "hasAccess" inside
the "doPost" method, now it has been placed after the call to the "doFetch".

Thu, 26 May 2016 20:02:26 +0200Related to issue 32535: Code review improvements
Alvaro Ferraz <alvaro.ferraz@openbravo.com> [Thu, 26 May 2016 20:02:26 +0200] rev 29557
Related to issue 32535: Code review improvements

- Set login organization general ledger if report organization is empty in Balance Sheet and P&L structure report.
- Avoid change general ledger after click on search button in General Ledger Report, Journal Entries Report and Trial Balance reports.

Thu, 26 May 2016 15:55:44 +0200backed out previous changesets
Asier Lostalé <asier.lostale@openbravo.com> [Thu, 26 May 2016 15:55:44 +0200] rev 29556
backed out previous changesets

accidentally commited to pi

Thu, 26 May 2016 09:50:08 +0200TRY_PARAMS###JOBS_TO_BUILD=try-gui-oracle+try-gui-pgsql###DESC=more-log5
Asier Lostalé <asier.lostale@openbravo.com> [Thu, 26 May 2016 09:50:08 +0200] rev 29555
TRY_PARAMS###JOBS_TO_BUILD=try-gui-oracle+try-gui-pgsql###DESC=more-log5

Thu, 26 May 2016 07:40:47 +0200delay again
Asier Lostalé <asier.lostale@openbravo.com> [Thu, 26 May 2016 07:40:47 +0200] rev 29554
delay again

Wed, 25 May 2016 17:10:33 +0200remove delay for row count
Asier Lostalé <asier.lostale@openbravo.com> [Wed, 25 May 2016 17:10:33 +0200] rev 29553
remove delay for row count

Wed, 25 May 2016 17:03:16 +0200related to issue 32663: instabilities in int-gui job
Asier Lostalé <asier.lostale@openbravo.com> [Wed, 25 May 2016 17:03:16 +0200] rev 29552
related to issue 32663: instabilities in int-gui job

Added stack trace when error about invalid client/org is logged

Tue, 24 May 2016 15:26:38 +0200Fixed issue 31769: The unnecessary left joins have been deleted
Naroa Iriarte <naroa.iriarte@openbravo.com> [Tue, 24 May 2016 15:26:38 +0200] rev 29551
Fixed issue 31769: The unnecessary left joins have been deleted


There were a lot of unused left joins.
The decission of deleting the joins have been taken after the research
of two options:
1- Transforming the joins into fetch joins
2- Deleting the joins.

The results obtained in the Product (Product by Price and Warehouse) selector
have been deterministics for the decision of removing the joins.
It penalizes more having a fetch join because of the data transfer than not
having a fetch join and accessing the database afterwards.

Wed, 25 May 2016 12:42:09 +0200fixed bug 32951: in pg to_number truncates decimal to 6 positions
Asier Lostalé <asier.lostale@openbravo.com> [Wed, 25 May 2016 12:42:09 +0200] rev 29550
fixed bug 32951: in pg to_number truncates decimal to 6 positions

To_Number function in PostgreSQL (created to emulate the same from Oracle),
truncates the number to 6 decimal positions. Internally the conversion text ->
numeric is implemetned with a text mask with 6 decimal positions.

This is fixed by not using pg's to_number with mask but to directly cast, in
this way precission is not lost. Tested also to properly work with scientific
notation.

Wed, 25 May 2016 13:45:25 +0200related to issue 33015: prevent warning on DefaultJsonDataService
Carlos Aristu <carlos.aristu@openbravo.com> [Wed, 25 May 2016 13:45:25 +0200] rev 29549
related to issue 33015: prevent warning on DefaultJsonDataService

After reopening the selector pop-up having a selected record, a bad request was being identified by the DefaultJsonDataService: the request included the _targetRecordId parameter but the _directNavigation parameter was not present.

This was happening because the selection information was not being cleared by the changes introduced on the openSelectorWindow function. Before [1], this cleaning was done by the invalidateCache method. Now we are cleaning the selection by explicitly calling to deselectAllRecords().

[1] http://code.openbravo.com/erp/devel/pi/rev/9105dfe33d79e5b7ba39a2680064f7c48c402701

Tue, 24 May 2016 12:05:23 +0200Related to issue 32954: Code review improvements
Alvaro Ferraz <alvaro.ferraz@openbravo.com> [Tue, 24 May 2016 12:05:23 +0200] rev 29548
Related to issue 32954: Code review improvements

Tue, 17 May 2016 13:37:09 +0530Fixes issue 32954: Payment Report in Excel format is not setting ","
Atul Gaware <atul.gaware@openbravo.com> [Tue, 17 May 2016 13:37:09 +0530] rev 29547
Fixes issue 32954: Payment Report in Excel format is not setting ","
(comma) as decimal separator, although it is defined in Format.xml file

Numberformat parameter added inorder to apply formats on transactional and base amount values

Tue, 24 May 2016 18:11:55 +0200Related to issue 32937: Code review improvements
Alvaro Ferraz <alvaro.ferraz@openbravo.com> [Tue, 24 May 2016 18:11:55 +0200] rev 29546
Related to issue 32937: Code review improvements

Tue, 17 May 2016 11:39:36 -0400Fixes issue 32937: Correct parameter is passed to the c_uom_convert function
Mark <markmm82@gmail.com> [Tue, 17 May 2016 11:39:36 -0400] rev 29545
Fixes issue 32937: Correct parameter is passed to the c_uom_convert function

The correct parameter is passed to the c_uom_convert function: it is the c_uom_id associated to the m_product_uom_id instead the m_product_uom_id.

Tue, 24 May 2016 15:06:23 +0200Merge back from main
RM packaging bot <staff.rm@openbravo.com> [Tue, 24 May 2016 15:06:23 +0200] rev 29544
Merge back from main

Tue, 24 May 2016 12:13:22 +0000Merge temporary head for 3.0PR16Q1.2
RM packaging bot <staff.rm@openbravo.com> [Tue, 24 May 2016 12:13:22 +0000] rev 29543
Merge temporary head for 3.0PR16Q1.2

Tue, 24 May 2016 06:46:25 +0000Added signature for changeset 98bdf9167a3d
RM packaging bot <staff.rm@openbravo.com> [Tue, 24 May 2016 06:46:25 +0000] rev 29542
Added signature for changeset 98bdf9167a3d

Tue, 24 May 2016 06:46:25 +0000Added tag 3.0PR16Q1.2 for changeset ec73935a2c83
RM packaging bot <staff.rm@openbravo.com> [Tue, 24 May 2016 06:46:25 +0000] rev 29541
Added tag 3.0PR16Q1.2 for changeset ec73935a2c83

Tue, 24 May 2016 06:46:25 +0000Update AD_MODULE version to 3.0PR16Q1.2 3.0PR16Q1.2
RM packaging bot <staff.rm@openbravo.com> [Tue, 24 May 2016 06:46:25 +0000] rev 29540
Update AD_MODULE version to 3.0PR16Q1.2

Mon, 23 May 2016 12:36:08 +0200fixes issue 33024: Cannot export CSV from Widgets
Carlos Aristu <carlos.aristu@openbravo.com> [Mon, 23 May 2016 12:36:08 +0200] rev 29539
fixes issue 33024: Cannot export CSV from Widgets

The name of the parameter used to sent the tab ID when exporting to CSV changed, this
affected a check on DataSourceServlet that was always true when exporting widgets until now.

Created an utility method to check whether a json value can be considered as
empty which takes into account common cases of null and undefined literals.

Fri, 20 May 2016 10:08:11 +0200Fixes issue 33007: Stock before costing rule not shown in Valued Stock Report
Alvaro Ferraz <alvaro.ferraz@openbravo.com> [Fri, 20 May 2016 10:08:11 +0200] rev 29538
Fixes issue 33007: Stock before costing rule not shown in Valued Stock Report

Convert current costing rule starting date with to_timestamp instead of with to_date function to avoid date truncation.
Before, current costing rule starting date was truncated and closing and opening inventories created by costing rule validation were taken, so stock was zero.
Now, current costing rule starting date will not be truncated and only opening inventory created by costing rule validation will be taken, then stock will be the same as before the costing rule.

Fri, 20 May 2016 11:08:28 +0200fixed bug 33014: error in Instance Activation when using an expired license
Asier Lostalé <asier.lostale@openbravo.com> [Fri, 20 May 2016 11:08:28 +0200] rev 29537
fixed bug 33014: error in Instance Activation when using an expired license

When using a license within an erroneous state (such as expired), message severity
was incorrectly obtained from the enum, causing an exception to be thrown.

Fixed by using MsgSeverity.forType method instead of valueOf. forType method
was designed with this purpose.

In addition, some other changes have been done on MsgSeverity enum:
* valueOf method is static so no need to invoke it on an instance (to may be
another one, which is weird).
* checking with actual type rather than with toString (which might change)
* reversed comparision order to prevent NPE in case param in null

Tue, 03 May 2016 11:36:04 +0200Related to issue 32983: Code review improvements
Alvaro Ferraz <alvaro.ferraz@openbravo.com> [Tue, 03 May 2016 11:36:04 +0200] rev 29536
Related to issue 32983: Code review improvements