Thu, 04 Oct 2018 01:14:57 +0530Fixes Issue 39386: Goods Shipment IsCompletelyInvoiced
Atul Gaware <atul.gaware@openbravo.com> [Thu, 04 Oct 2018 01:14:57 +0530] rev 35324
Fixes Issue 39386: Goods Shipment IsCompletelyInvoiced
flag is not properly updated when voiding Sales Invoice

IsCompletelyInvoiced flag is set to No for the shipments
that have shipment line linked with the invoice lines of
the invoice that is being voided.

Wed, 16 Jan 2019 13:32:57 +0100fixes issue 37940: Clean up unused shortcuts in the Login page
Carlos Aristu <carlos.aristu@openbravo.com> [Wed, 16 Jan 2019 13:32:57 +0100] rev 35323
fixes issue 37940: Clean up unused shortcuts in the Login page

Thu, 22 Nov 2018 17:36:26 +0100Fixes Issue 0039163:QueryTimeoutException is no longer
David Miguelez <david.miguelez@openbravo.com> [Thu, 22 Nov 2018 17:36:26 +0100] rev 35322
Fixes Issue 0039163:QueryTimeoutException is no longer
thrown in Oracle after Hibernate 5.3 upgrade

** Use split to show proper message in catch block
for GenericJDBCException.
** Catch block for QueryTimeOutException not required any longer.

Wed, 16 Jan 2019 11:06:26 +0100related to issue 37940: minor code cleanup
Carlos Aristu <carlos.aristu@openbravo.com> [Wed, 16 Jan 2019 11:06:26 +0100] rev 35321
related to issue 37940: minor code cleanup

- Removed unused variables
- Declared "obj" variables on top of the function
- Remove unreachable "return false"

Wed, 16 Jan 2019 09:37:56 +0100related to issue 39885: add test case
Carlos Aristu <carlos.aristu@openbravo.com> [Wed, 16 Jan 2019 09:37:56 +0100] rev 35320
related to issue 39885: add test case

Tue, 15 Jan 2019 17:24:40 +0100related to issue 39896: minor code cleanup
Carlos Aristu <carlos.aristu@openbravo.com> [Tue, 15 Jan 2019 17:24:40 +0100] rev 35319
related to issue 39896: minor code cleanup

Removed unused variables

Tue, 15 Jan 2019 13:57:46 +0100fixes issue 39896: Not possible to filter by characteristic in Create Lines
Carlos Aristu <carlos.aristu@openbravo.com> [Tue, 15 Jan 2019 13:57:46 +0100] rev 35318
fixes issue 39896: Not possible to filter by characteristic in Create Lines

The changeset[1] was not taking into account the possibility of having a field with a name that already contains 'product'. This can happen when having a property field like: product.characteristicDescription.

In that case an extra 'product' was being added to the propery path which resulted in a wrong HQL where clause definition for the characteristic filter.

Now we do not append 'product' to the property path in case it already starts with it.

[1] https://code.openbravo.com/erp/devel/pi/rev/f2979bad688953ced9571ab74cf312c989a0f81b

Mon, 14 Jan 2019 12:10:40 +0100Related to Issue 39822. Added previously deleted method and set it as deprecated
David Miguelez <david.miguelez@openbravo.com> [Mon, 14 Jan 2019 12:10:40 +0100] rev 35317
Related to Issue 39822. Added previously deleted method and set it as deprecated
to avoid API Change.

This method however should be avoided as it should be removed in the future,
as the other deprecated methods in this issue.

Mon, 14 Jan 2019 09:40:46 +0100Fixes Issue 39888. When canceling a cost adjustment:
David Miguelez <david.miguelez@openbravo.com> [Mon, 14 Jan 2019 09:40:46 +0100] rev 35316
Fixes Issue 39888. When canceling a cost adjustment:

* Keep the Negative Stock Correction and Backdated Transactions
flags with the same values as the original record
* When retrieving the lines of the Adjustment, retrieve also the lines
from Adjusments in Voided Status

Wed, 26 Dec 2018 17:28:40 +0100Related to Issue 39822. Code Review Changes:
David Miguelez <david.miguelez@openbravo.com> [Wed, 26 Dec 2018 17:28:40 +0100] rev 35315
Related to Issue 39822. Code Review Changes:

* Fixed typo in Message value
* Changed name of class variable from costAdjusted to adjustmentAmt (changed getter too)
* Added currency variable for parameters class
* If not specified, it uses the currency of the transaction
* If specified, it is used to create the line and to search
for existing adjustment lines