Fri, 27 Apr 2018 10:55:13 +0200Related to issue 33650: code review improvements
Víctor Martínez Romanos <victor.martinez@openbravo.com> [Fri, 27 Apr 2018 10:55:13 +0200] rev 33894
Related to issue 33650: code review improvements
Properly format modulescript
Removed info message in module script
Increased limits
Ensure we don't work with * org and any organization where the persist org is already available

Fri, 27 Apr 2018 09:59:55 +0200Related to issue 33650: code review improvements
Víctor Martínez Romanos <victor.martinez@openbravo.com> [Fri, 27 Apr 2018 09:59:55 +0200] rev 33893
Related to issue 33650: code review improvements
Renamed field group to Inherited Information
Reordered fields

Fri, 27 Apr 2018 09:51:48 +0200Related to issue 33650: code review improvements
Víctor Martínez Romanos <victor.martinez@openbravo.com> [Fri, 27 Apr 2018 09:51:48 +0200] rev 33892
Related to issue 33650: code review improvements
Improved functions documentation and comments

Thu, 26 Apr 2018 16:25:58 +0200Related to issue 33650: code review improvements
Víctor Martínez Romanos <victor.martinez@openbravo.com> [Thu, 26 Apr 2018 16:25:58 +0200] rev 33891
Related to issue 33650: code review improvements
Removed new reference Organization Selector for Persist Information and use instead existing Organization Simple Selector

Fri, 27 Apr 2018 07:58:20 +0530Related to issue 33650:Make use of persist org info column
Atul Gaware <atul.gaware@openbravo.com> [Fri, 27 Apr 2018 07:58:20 +0530] rev 33890
Related to issue 33650:Make use of persist org info column

Use ad_inheritedcalendar_id

Thu, 26 Apr 2018 22:17:42 +0530Related to issue 33650:Sample data updated with persist org info
Atul Gaware <atul.gaware@openbravo.com> [Thu, 26 Apr 2018 22:17:42 +0530] rev 33889
Related to issue 33650:Sample data updated with persist org info

Existing organization are updated with persist org info as part
of sample data.

Thu, 26 Apr 2018 22:49:57 +0530Related to issue 33650:Added junit test cases for persist org info task
Atul Gaware <atul.gaware@openbravo.com> [Thu, 26 Apr 2018 22:49:57 +0530] rev 33888
Related to issue 33650:Added junit test cases for persist org info task

** Added junit tests to verify persist info data in organization
for corner case orgs (*, null, org that does not exists)
** Added junit tests which creates a complex org tree, sets org as ready
with cascade Yes and No option and verifies persist org info.
** Added junit tests which create single org, two orgs one under another,
sets org as ready with cascade = Yes, Cascade = No option.

Thu, 26 Apr 2018 23:45:59 +0530Related to issue 33650:Modulescript to set persist org info
Atul Gaware <atul.gaware@openbravo.com> [Thu, 26 Apr 2018 23:45:59 +0530] rev 33887
Related to issue 33650:Modulescript to set persist org info

** Added Modulescript to populate AD_Org persist info columns
** Variables are used to get persist org info and then sent
to update method to avoid trigger mutating error in orcl
instance

Thu, 26 Apr 2018 18:54:30 +0530Fixes Issue 33650:Add columns in AD_Org table to persist data in order
Atul Gaware <atul.gaware@openbravo.com> [Thu, 26 Apr 2018 18:54:30 +0530] rev 33886
Fixes Issue 33650:Add columns in AD_Org table to persist data in order
to improve performance

** Add columns to store calendar owner org, period control allowed org,
legal entity org, business unit org and calendar of the period
control allowed org of the organization, Add field group and ready only
fields in organization window tab to show persist org information.
Field group is collapse by default.
** Added new function AD_ORG_GETCALENDAROWNERTN and
AD_ORG_GETPERIODCONTROLALLOWTN, AD_GET_ORG_LE_BU_TREENODE
from the original one with performance issues notes in it to only use
when organization are not set ready else use persist info from AD_Org
directly.
** Refactor AD_ORG_GETCALENDAROWNER, AD_ORG_GETPERIODCONTROLALLOW and
AD_GET_ORG_LE_BU to make use of respective new columns to use
AD_CALENDAROWNER_ORG_ID, AD_PERIODCONTROLALLOWED_ORG_ID,
AD_LEGALENTITY_ORG_ID or AD_BUSINESSUNIT_ORG_ID from AD_ORG directly.
** Modified AD_ORG_READY to set persist info columns in AD_ORG.
** To avoid triggers mutating error in oracle instance, instead of
calling directly functions to get persist org info in
update query, variables are used to get persist org info from ad_org
and then ad_org is updated.
** Modified AD_GET_ORG_LE_BU_TREENODE, remove condition
v_org_header_id<>'0' from while clause in p_type='BU' block.

Mon, 23 Apr 2018 09:17:37 +0200Related to Issue 38288. Code review changes
David Miguelez <david.miguelez@openbravo.com> [Mon, 23 Apr 2018 09:17:37 +0200] rev 33885
Related to Issue 38288. Code review changes

* Moved validation of Payment Plan before performing any logic
* Changed logic to retrieve messages, it now usses API from OBMessageUtils