Wed, 28 Jan 2015 14:19:04 +0100[Costing] Fix assertDocumentPost in Costing automated tests
Alvaro Ferraz <alvaro.ferraz@openbravo.com> [Wed, 28 Jan 2015 14:19:04 +0100] rev 25765
[Costing] Fix assertDocumentPost in Costing automated tests

Mon, 26 Jan 2015 23:28:17 -0500Fixed bug 27822: Price List is not created and no error message is shown.
Reinaldo Guerra <reinaldo.guerra@peoplewalking.com> [Mon, 26 Jan 2015 23:28:17 -0500] rev 25764
Fixed bug 27822: Price List is not created and no error message is shown.

Create Price List stored procedure, was changed to launch an error message when the price list schema, defined in the price list version, have no lines defined.
Now, when creating a price list for a schema without lines, no product prices are added and an error message indicating that price list schema lines are required to execute the process.

Tue, 27 Jan 2015 13:16:28 +0100Fixed bug 28755 It is impossible leaving credit when adding a payment in match statement
Sandra Huguet <sandra.huguet@openbravo.com> [Tue, 27 Jan 2015 13:16:28 +0100] rev 25763
Fixed bug 28755 It is impossible leaving credit when adding a payment in match statement

Properly default value in actual payment field when add payment popup
runs from match statement.

Disabled "+" button and "magnifying glass" when line record is
linked to a transaction.

Tue, 27 Jan 2015 20:10:56 +0100Related to issue 28792: Uncomment a piece of code
Unai Martirena <unai.martirena@openbravo.com> [Tue, 27 Jan 2015 20:10:56 +0100] rev 25762
Related to issue 28792: Uncomment a piece of code

Tue, 27 Jan 2015 20:08:23 +0100Fixes bug 28792: Null Pointer exception now is avoided in Costing Background
Unai Martirena <unai.martirena@openbravo.com> [Tue, 27 Jan 2015 20:08:23 +0100] rev 25761
Fixes bug 28792: Null Pointer exception now is avoided in Costing Background


The problem was in AverageCostAdjustment java process while calling AverageAlgorithm.getProductCost method. While returning null, Null Pointer Exception error was raised.

Tue, 27 Jan 2015 17:19:36 +0100Fixed bug 28780: Return to Vendor fails when unit price is zero or empty
Sandra Huguet <sandra.huguet@openbravo.com> [Tue, 27 Jan 2015 17:19:36 +0100] rev 25760
Fixed bug 28780: Return to Vendor fails when unit price is zero or empty

after refactoring, when Unit Price is empty in the pick&edit
in SRMOPickEditLines.java class UnitPrice value comes as empty string,
before refactoring this value was null.

Tue, 27 Jan 2015 15:23:16 +0100Related with issue 28684: dbsourcemanager includes previous change
Augusto Mauch <augusto.mauch@openbravo.com> [Tue, 27 Jan 2015 15:23:16 +0100] rev 25759
Related with issue 28684: dbsourcemanager includes previous change

In this changeset [1] a change was done to the dbsourcemanager that was not pushed to its repo. This other changeset [2], which fixes issue 28684, contains a copy of dbsourcemanager.jar that does not included [1].

[1] has just been pushed to the dbsm-main repo, and the dbsourcemanager.jar included in the present changeset contains all the dbsm-main changes up to date.

[1] https://code.openbravo.com/erp/devel/pi/rev/8c34cbb6b4adab030bd7e8c9cf7da00646b54ab2
[2] https://code.openbravo.com/erp/devel/pi/rev/b44f867c1a6b464b78b6954647ad130e0ad00a29

Mon, 26 Jan 2015 14:13:56 +0100fixed issue 28143: proper support for DB sequences
Asier Lostalé <asier.lostale@openbravo.com> [Mon, 26 Jan 2015 14:13:56 +0100] rev 25758
fixed issue 28143: proper support for DB sequences

Several fixes for supporting DB sequences both in Oracle and PostgreSQL.

-Oracle min number is properly obtained instead of current value
-PG min and increment are properly obtained instead of hardcoding them to 1
-Both changes in min and increment do not cause sequence recreation

Mon, 26 Jan 2015 13:13:50 +0100Fixed issue 28766: Updated the list of recommended browsers:
David Baz Fayos <david.baz@openbravo.com> [Mon, 26 Jan 2015 13:13:50 +0100] rev 25757
Fixed issue 28766: Updated the list of recommended browsers:
Mozilla Firefox 31 (latest ESR)
Google Chrome: 40
Internet Explorer: 11
Apple Safari: 8

Mon, 26 Jan 2015 12:39:25 +0100Fixes bug 28747,related with bug 28427: Number entered with formula is rounded
Augusto Mauch <augusto.mauch@openbravo.com> [Mon, 26 Jan 2015 12:39:25 +0100] rev 25756
Fixes bug 28747,related with bug 28427: Number entered with formula is rounded

The problem was that if a number was entered using a formula (i.e. by entering =1/3 in the form item), the value was not rounded using the numeric field mask. For non-formula inputs the validation is done at the beginning of the blur function. For formula inputs it is not possible to do it at that point, because the value of the field is still the formula, not the result of evaluating the formula. The formula is evaluated in the validate function(), so the rounding for formula inputs is done after invoking it.

Mon, 26 Jan 2015 10:04:44 +0100fixed issue 28605: allow to overwrite properties per instance
Asier Lostalé <asier.lostale@openbravo.com> [Mon, 26 Jan 2015 10:04:44 +0100] rev 25755
fixed issue 28605: allow to overwrite properties per instance

Support for propreties overwriting in instances running in tomcat clustering

More details:
http://wiki.openbravo.com/wiki/Projects:Share_Openbravo.properties

Wed, 21 Jan 2015 13:09:39 +0100[share props] host.name task uses System.out instead of log4j
Asier Lostalé <asier.lostale@openbravo.com> [Wed, 21 Jan 2015 13:09:39 +0100] rev 25754
[share props] host.name task uses System.out instead of log4j

In this way it can be executed without having compiled appenders defined for
log4j.

Wed, 21 Jan 2015 12:58:16 +0100[share props] make classes dir before execute host.name task
Asier Lostalé <asier.lostale@openbravo.com> [Wed, 21 Jan 2015 12:58:16 +0100] rev 25753
[share props] make classes dir before execute host.name task

Wed, 21 Jan 2015 12:56:19 +0100[share props] added ant taks to know host name
Asier Lostalé <asier.lostale@openbravo.com> [Wed, 21 Jan 2015 12:56:19 +0100] rev 25752
[share props] added ant taks to know host name

to be executed by ant host.name

Tue, 20 Jan 2015 16:41:17 +0100[share props] allow to reset Openbravo.properties
Asier Lostalé <asier.lostale@openbravo.com> [Tue, 20 Jan 2015 16:41:17 +0100] rev 25751
[share props] allow to reset Openbravo.properties

This flow is used when restarting Tomcat from MMC. Do not fail nor show warn
message.

Tue, 20 Jan 2015 09:33:56 +0100[share props] fixed build dependencies
Asier Lostalé <asier.lostale@openbravo.com> [Tue, 20 Jan 2015 09:33:56 +0100] rev 25750
[share props] fixed build dependencies

Previous changeset made an indirect depencency from OBPropertiesProvider to
dal generated code, which caused not to be possible to generete entities.

The problem has been fixed by accessing ServletContext from OBConfigFileProvider
which has no this dependency.

Tue, 20 Jan 2015 09:24:01 +0100[share props] define different properties in Tomcat clustering environments
Asier Lostalé <asier.lostale@openbravo.com> [Tue, 20 Jan 2015 09:24:01 +0100] rev 25749
[share props] define different properties in Tomcat clustering environments

Thu, 15 Jan 2015 12:19:06 +0100[share props] removed unused variable
Asier Lostalé <asier.lostale@openbravo.com> [Thu, 15 Jan 2015 12:19:06 +0100] rev 25748
[share props] removed unused variable

Fri, 23 Jan 2015 15:00:12 +0100Fixes issue 28427: Numbers are always rounded on blur
Augusto Mauch <augusto.mauch@openbravo.com> [Fri, 23 Jan 2015 15:00:12 +0100] rev 25747
Fixes issue 28427: Numbers are always rounded on blur

The blur function of the OBNumberItems only did the rounding when the getValue function of the item returned a string. This worked in most of the cases (i.e. standard grids and forms, d
ue to the edit form of the grid having a setTextualValue function, see [1]), but not in the parameter windows. In those windows, both numeric parameters and numeric columns in grid para
meters did not round the entered numbers before saving them.

To fix this, now the numbers are rounded on blur even if the value entered is already a number. To found the number these two functions are invoked:

value = OB.Utilities.Number.JSToOBMasked(this.getValue(), this.typeInstance.maskNumeric, this.typeInstance.decSeparator, this.typeInstance.groupSeparator);
this.setValue(OB.Utilities.Number.OBMaskedToJS(value, this.typeInstance.decSeparator, this.typeInstance.groupSeparator));

The first one converts the number to a string representation of the rounded number. The second one converts the rounded string number to a javascript number.

Fri, 23 Jan 2015 12:21:36 +0100Fixed issue 28722: Not possible to create invoiced receipts for customers created in WebPOS
Aaron Calero <aaron.calero@openbravo.com> [Fri, 23 Jan 2015 12:21:36 +0100] rev 25746
Fixed issue 28722: Not possible to create invoiced receipts for customers created in WebPOS

Modified the event handler used to set the BP currency to work not only on update events, but on save events too.
Now when BPs are saved from the POS, the currency is automatically assigned to these business partners and they can be used to generate invoices.

Fri, 23 Jan 2015 12:02:44 +0100Fixed bug 28456 Return orders does not appear in Create Invoices From Orders
Sandra Huguet <sandra.huguet@openbravo.com> [Fri, 23 Jan 2015 12:02:44 +0100] rev 25745
Fixed bug 28456 Return orders does not appear in Create Invoices From Orders

It has been deleted return= 'N' filter in the query because the filter
it is not necessary.

Thu, 22 Jan 2015 17:34:24 +0100Fix issue 28154: Accounting Dimensions are not shown in Expense Sheet Lines
Alvaro Ferraz <alvaro.ferraz@openbravo.com> [Thu, 22 Jan 2015 17:34:24 +0100] rev 25744
Fix issue 28154: Accounting Dimensions are not shown in Expense Sheet Lines

An Auxiliary Input of type DOCBASETYPE has been added in order to be able to show accounting dimensions in Expense Sheet Lines tab

Tue, 13 Jan 2015 12:59:52 +0530Fixes Issue 27289:"Not Balance" error received when posting a multi-currency
Atul Gaware <atul.gaware@openbravo.com> [Tue, 13 Jan 2015 12:59:52 +0530] rev 25743
Fixes Issue 27289:"Not Balance" error received when posting a multi-currency
OUT transaction (although suspense balancing no needs to be used)

Problem was a negate value (in case of payments where isReceipt=No) was being
subtracted.

Thu, 22 Jan 2015 17:05:07 +0100Fixes bug 28640:Res. line with amt released not duplicated in Manage Reservation
Unai Martirena <unai.martirena@openbravo.com> [Thu, 22 Jan 2015 17:05:07 +0100] rev 25742
Fixes bug 28640:Res. line with amt released not duplicated in Manage Reservation

The problem is that when opening Manage Reservations P&E from sales order line, the property 'reservationStock' comes blank, even when a reservation stock line exists (When there is no reservation for the sales orderline a temporary one is created just to display lines in the selector selected correctly, and after that is deleted. This happens in the datasource of the P&E). In this cases the Manage Reservations action handler deletes these lines y they exists and creates new ones. But this is not possible for already released lines, so it was creating a duplicate of those.

In order to fix this, the property 'id' is used (allways comes with a value) in the case that the reservation is released, because in this case for sure that the reservation stock line exists, so it will update the existing one instead of creating a new one.

Thu, 22 Jan 2015 11:14:24 +0100fixed bug 28720: callouts incorrectly set big non integer numbers
Asier Lostalé <asier.lostale@openbravo.com> [Thu, 22 Jan 2015 11:14:24 +0100] rev 25741
fixed bug 28720: callouts incorrectly set big non integer numbers

When a big non integer number was set by a callout, decimal separator was removed
resulting in a different number, ie. 10200500.45 resulted in 1020050045.00.

The problem was in the OB.Utilities.Number.ScientificToDecimal JavaScript function
which wrongly assumed scientific exponent always added zeroes to coefficient, which
is not true in this case where exponent determines where the decimal separator is
inserted in the coefficient.

Tue, 20 Jan 2015 09:23:02 -0500Fixed bug 28331: After completing a G/L Journal Reactivate should be the option.
Reinaldo Guerra <reinaldo.guerra@peoplewalking.com> [Tue, 20 Jan 2015 09:23:02 -0500] rev 25740
Fixed bug 28331: After completing a G/L Journal Reactivate should be the option.

Gl_journal_post stored procedure now updates required field in Gl_Journal table to pass from Complete to Reactivate Document Action. So now when GL/Journal is completed, DocAction field is updated with RE value and the button option in GL/Journal header window will be Reactivate. Also default option will be Reactivate, instead of Close, when clicking the button.

Wed, 21 Jan 2015 13:29:26 +0530Related to Issue 28591:Removed unwanted code from the modulescript to update
Atul Gaware <atul.gaware@openbravo.com> [Wed, 21 Jan 2015 13:29:26 +0530] rev 25739
Related to Issue 28591:Removed unwanted code from the modulescript to update
payment plan and payment plan details

Tue, 20 Jan 2015 15:59:49 +0100fixed bug 28684: incorrect check constraint export in pg 9.3 and 9.4
Asier Lostalé <asier.lostale@openbravo.com> [Tue, 20 Jan 2015 15:59:49 +0100] rev 25738
fixed bug 28684: incorrect check constraint export in pg 9.3 and 9.4

The differences appear for check constraints in character varying columns,
restoring DB adds extra casting in this case.

The fix takes care of these cases.

Tue, 20 Jan 2015 14:57:35 +0530Fixes Issue 28591:Reversing a payment is creating wrong invoice payment plan
Atul Gaware <atul.gaware@openbravo.com> [Tue, 20 Jan 2015 14:57:35 +0530] rev 25737
Fixes Issue 28591:Reversing a payment is creating wrong invoice payment plan
details

Problem is Schedule detail was being updated by payment amount now it is taken
care to update using individual schedule detail amount while creating reverse
payment schedule and payment schedule details. Modulescript to fix errorneous data
consists of update invoice paid, outstanding amt, update payment schedule received
and outstanding amount, update payment credit generated info if in case required.

Wed, 21 Jan 2015 08:26:08 +0530Backout 9c12d1443b20 changeset
Atul Gaware <atul.gaware@openbravo.com> [Wed, 21 Jan 2015 08:26:08 +0530] rev 25736
Backout 9c12d1443b20 changeset

Breaks int-inc-oracle test and is a old fix sent during review.