related to bug 26734, related to bug 26683
authorAsier Lostalé <asier.lostale@openbravo.com>
Thu, 29 May 2014 14:40:23 +0200
changeset 23402 2ede1e6ee260
parent 23401 fabc81386bec
child 23403 bd7f8b6f935a
child 23660 8143c4c14f48
related to bug 26734, related to bug 26683

Do not fail for unpaged slector datasource requests till selectors are properly
fixed. This is done in order to complete CI
modules/org.openbravo.service.json/src/org/openbravo/service/json/DefaultJsonDataService.java
--- a/modules/org.openbravo.service.json/src/org/openbravo/service/json/DefaultJsonDataService.java	Wed May 28 18:09:28 2014 +0200
+++ b/modules/org.openbravo.service.json/src/org/openbravo/service/json/DefaultJsonDataService.java	Thu May 29 14:40:23 2014 +0200
@@ -44,7 +44,6 @@
 import org.openbravo.database.SessionInfo;
 import org.openbravo.erpCommon.utility.OBMessageUtils;
 import org.openbravo.service.json.JsonToDataConverter.JsonConversionError;
-import org.openbravo.userinterface.selector.SelectorConstants;
 
 /**
  * Implements generic data operations which have parameters and json as an input and return results
@@ -372,8 +371,12 @@
       log.warn("Fetching data without pagination, this can cause perfomance issues. Parameters: "
           + paramMsg);
 
-      if (parameters.containsKey(JsonConstants.TAB_PARAMETER)
-          || parameters.containsKey(SelectorConstants.DS_REQUEST_SELECTOR_ID_PARAMETER)) {
+      if (parameters.containsKey(JsonConstants.TAB_PARAMETER)) {
+        // || parameters.containsKey(SelectorConstants.DS_REQUEST_SELECTOR_ID_PARAMETER)
+        // FIXME: Some selectors working in 2.50 windows are incorrectly unpaged (see issue #26734)
+        // for now we are not preventing unpaged selector requests till this issue is properly fixed
+        // after that they should be prevented again
+
         // for standard tab and selector datasources pagination is mandatory
         throw new OBException(OBMessageUtils.messageBD("OBJSON_NoPagedFetch"));
       }