[validation] Some additional minor changes
authorAntonio Moreno <antonio.moreno@openbravo.com>
Wed, 31 Mar 2010 18:45:43 +0200
changeset 6907 544cfe0036ca
parent 6906 3d2e9c4893c5
child 6908 230f280b9b72
[validation] Some additional minor changes
src-core/src/org/openbravo/buildvalidation/BuildValidation.java
src-core/src/org/openbravo/buildvalidation/BuildValidationHandler.java
src-core/src/org/openbravo/modulescript/ModuleScript.java
src-core/src/org/openbravo/modulescript/ModuleScriptHandler.java
src-util/diagnostic/.classpath
src-util/diagnostic/.project
src-util/diagnostic/.settings/.jsdtscope
src-util/diagnostic/.settings/org.eclipse.jdt.core.prefs
src-util/diagnostic/.settings/org.eclipse.jst.common.project.facet.core.prefs
src-util/diagnostic/.settings/org.eclipse.wst.common.component
src-util/diagnostic/.settings/org.eclipse.wst.common.project.facet.core.xml
src-util/diagnostic/.settings/org.eclipse.wst.jsdt.ui.superType.container
src-util/diagnostic/.settings/org.eclipse.wst.jsdt.ui.superType.name
src-util/diagnostic/WebContent/META-INF/MANIFEST.MF
src-util/diagnostic/WebContent/WEB-INF/web.xml
src-util/diagnostic/build-create.xml
src-util/diagnostic/build.xml
src-util/diagnostic/build/.keep
src-util/diagnostic/check-ob-perms.sh
src-util/diagnostic/config/diagnostics.properties
src-util/diagnostic/config/log4j.properties
src-util/diagnostic/src/Test.java
src-util/diagnostic/src/org/openbravo/check/Check.java
src-util/diagnostic/src/org/openbravo/task/CheckDB.java
src-util/diagnostic/src/org/openbravo/task/CheckEnvironmentVariables.java
src-util/diagnostic/src/org/openbravo/task/CheckJVMVersion.java
src-util/diagnostic/src/org/openbravo/task/CheckMemory.java
src-util/diagnostic/src/org/openbravo/task/CheckTomcatAntExecution.java
src-util/diagnostic/src/org/openbravo/task/CheckTomcatFilePermissions.java
src-util/diagnostic/src/org/openbravo/task/CheckTomcatMemory.java
src-util/diagnostic/src/org/openbravo/task/CheckTomcatVersion.java
src-util/diagnostic/src/org/openbravo/task/CheckX.java
src-util/diagnostic/src/org/openbravo/task/CompareVersion.java
src-util/diagnostic/src/org/openbravo/utils/PropertiesManager.java
src-util/diagnostic/src/org/openbravo/utils/ServerConnection.java
src-util/diagnostic/src/org/openbravo/utils/Version.java
--- a/src-core/src/org/openbravo/buildvalidation/BuildValidation.java	Wed Mar 31 18:23:35 2010 +0200
+++ b/src-core/src/org/openbravo/buildvalidation/BuildValidation.java	Wed Mar 31 18:45:43 2010 +0200
@@ -35,7 +35,7 @@
    * 
    * @return a ConnectionProvider
    */
-  public ConnectionProvider getConnectionProvider() {
+  protected ConnectionProvider getConnectionProvider() {
     if (cp != null) {
       return cp;
     }
--- a/src-core/src/org/openbravo/buildvalidation/BuildValidationHandler.java	Wed Mar 31 18:23:35 2010 +0200
+++ b/src-core/src/org/openbravo/buildvalidation/BuildValidationHandler.java	Wed Mar 31 18:45:43 2010 +0200
@@ -61,7 +61,7 @@
         }
       } catch (Exception e) {
         log4j.info("Error executing build-validation: " + s, e);
-        log4j.error("The build validation " + s + " couldn't be properly executed" + e);
+        log4j.error("The build validation " + s + " couldn't be properly executed");
         System.exit(1);
       }
       if (errors.size() > 0) {
--- a/src-core/src/org/openbravo/modulescript/ModuleScript.java	Wed Mar 31 18:23:35 2010 +0200
+++ b/src-core/src/org/openbravo/modulescript/ModuleScript.java	Wed Mar 31 18:45:43 2010 +0200
@@ -27,7 +27,7 @@
    * 
    * @return a ConnectionProvider
    */
-  public ConnectionProvider getConnectionProvider() {
+  protected ConnectionProvider getConnectionProvider() {
     if (cp == null) {
       cp = new CPStandAlone("config/Openbravo.properties");
     }
--- a/src-core/src/org/openbravo/modulescript/ModuleScriptHandler.java	Wed Mar 31 18:23:35 2010 +0200
+++ b/src-core/src/org/openbravo/modulescript/ModuleScriptHandler.java	Wed Mar 31 18:45:43 2010 +0200
@@ -52,7 +52,7 @@
           callExecute(myClass, instance);
         }
       } catch (Exception e) {
-        log4j.info("Error executing moduleScript: " + s, e);
+        log4j.error("Error executing moduleScript: " + s);
         throw new BuildException("Execution of moduleScript " + s + "failed.");
       }
     }