Related to issue 28289: Little code review
authorUnai Martirena <unai.martirena@openbravo.com>
Wed, 17 Dec 2014 21:45:17 +0100
changeset 25627 81546bd2df3d
parent 25626 e6a74e90eb49
child 25628 4c0a99a3a5a4
Related to issue 28289: Little code review
src/org/openbravo/costing/CostingRuleProcessActionHandler.java
src/org/openbravo/costing/CostingRuleProcessOnProcessHandler.java
src/org/openbravo/costing/CostingUtils.java
--- a/src/org/openbravo/costing/CostingRuleProcessActionHandler.java	Wed Dec 17 13:56:07 2014 +0100
+++ b/src/org/openbravo/costing/CostingRuleProcessActionHandler.java	Wed Dec 17 21:45:17 2014 +0100
@@ -11,7 +11,7 @@
  * under the License.
  * The Original Code is Openbravo ERP.
  * The Initial Developer of the Original Code is Openbravo SLU
- * All portions are Copyright (C) 2012-2014 Openbravo SLU
+ * All portions are Copyright (C) 2014 Openbravo SLU
  * All Rights Reserved.
  * Contributor(s):  ______________________________________.
  *************************************************************************
--- a/src/org/openbravo/costing/CostingRuleProcessOnProcessHandler.java	Wed Dec 17 13:56:07 2014 +0100
+++ b/src/org/openbravo/costing/CostingRuleProcessOnProcessHandler.java	Wed Dec 17 21:45:17 2014 +0100
@@ -11,7 +11,7 @@
  * under the License.
  * The Original Code is Openbravo ERP.
  * The Initial Developer of the Original Code is Openbravo SLU
- * All portions are Copyright (C) 2012-2014 Openbravo SLU
+ * All portions are Copyright (C) 2014 Openbravo SLU
  * All Rights Reserved.
  * Contributor(s):  ______________________________________.
  *************************************************************************
--- a/src/org/openbravo/costing/CostingUtils.java	Wed Dec 17 13:56:07 2014 +0100
+++ b/src/org/openbravo/costing/CostingUtils.java	Wed Dec 17 21:45:17 2014 +0100
@@ -563,9 +563,8 @@
         log4j.error("Error parsing the date.", e);
         return null;
       }
-    } else {
-      return rule.getStartingDate();
     }
+    return rule.getStartingDate();
   }
 
   /**
@@ -581,8 +580,7 @@
         log4j.error("Error parsing the date.", e);
         return null;
       }
-    } else {
-      return rule.getStartingDate();
     }
+    return rule.getStartingDate();
   }
 }