Fixed issue 30249: Error get when the Set New Currency process def. is executed
authorNaroa Iriarte <naroa.iriarte@openbravo.com>
Thu, 25 Jun 2015 17:04:28 +0200
changeset 27065 e45f0f903a95
parent 27064 b26a24d2053e
child 27066 f6dcfa9328cf
Fixed issue 30249: Error get when the Set New Currency process def. is executed

The problem was that a error was got when clicking the "Done" button of the "Set New Currency"
process definition.

"Uncaught TypeError: Cannot read property '_handleSelect' of null"

The problem was in the "ob-parameter-window-view.js" in the handleResponse function.
It was executing "this.showProcessing(false)" even when the "retryExecution" parameter
was false.
Now the "this.showProcessing(false)" is executed only if the "retryExecution" parameter is true.

This affected to the process definition execution because as we were executing the "this.showProcessing(false)"
even when the retryExecution parameter was false, an ob-selector was deleted and after that, it was trying to
get the "._handleSelect" of that selector.
modules/org.openbravo.client.application/web/org.openbravo.client.application/js/process/ob-parameter-window-view.js
--- a/modules/org.openbravo.client.application/web/org.openbravo.client.application/js/process/ob-parameter-window-view.js	Fri Jul 03 16:04:19 2015 +0200
+++ b/modules/org.openbravo.client.application/web/org.openbravo.client.application/js/process/ob-parameter-window-view.js	Thu Jun 25 17:04:28 2015 +0200
@@ -405,7 +405,6 @@
     }
 
     this.setAllButtonEnabled(this.allRequiredParametersSet());
-    this.showProcessing(false);
     if (message) {
       if (this.popup) {
         if (!retryExecution) {
@@ -415,6 +414,7 @@
             this.buttonOwnerView.messageBar.setMessage(message.severity, message.text);
           }
         } else {
+          this.showProcessing(false);
           // Popup has no message bar, showing the message in a warn popup
           isc.warn(message.text);
         }