Wed, 19 Nov 2014 19:04:06 +0100Related with bug 25811: Show warn message if bad datasource request is issued
Augusto Mauch <augusto.mauch@openbravo.com> [Wed, 19 Nov 2014 19:04:06 +0100] rev 25292
Related with bug 25811: Show warn message if bad datasource request is issued

Datasource requests that contain the _targetRecordId parameter but not the _directNavigation parameter are known to have bad perfomance. A check has been added in DefaultJsonDataService to detect them.

Wed, 19 Nov 2014 18:37:44 +0100Related with bug 25811: Remove the undef variable as it was not used anywhere
Augusto Mauch <augusto.mauch@openbravo.com> [Wed, 19 Nov 2014 18:37:44 +0100] rev 25291
Related with bug 25811: Remove the undef variable as it was not used anywhere

Wed, 19 Nov 2014 18:36:41 +0100Related with bug 25811: Relaced double quotes with single quotes
Augusto Mauch <augusto.mauch@openbravo.com> [Wed, 19 Nov 2014 18:36:41 +0100] rev 25290
Related with bug 25811: Relaced double quotes with single quotes

Wed, 19 Nov 2014 18:35:34 +0100Related with bug 25811: Added small refactor and comments
Augusto Mauch <augusto.mauch@openbravo.com> [Wed, 19 Nov 2014 18:35:34 +0100] rev 25289
Related with bug 25811: Added small refactor and comments
>
> The scrollUp variable was not really needed, the code that was executed when its value was true could be placed in the place where scrollUp was set.

Wed, 19 Nov 2014 18:23:38 +0100Related with bug 25811: Move variable declaration to the top of the function
Augusto Mauch <augusto.mauch@openbravo.com> [Wed, 19 Nov 2014 18:23:38 +0100] rev 25288
Related with bug 25811: Move variable declaration to the top of the function

Wed, 19 Nov 2014 18:21:01 +0100Related with bug 25811: Remove useless function that did nothing
Augusto Mauch <augusto.mauch@openbravo.com> [Wed, 19 Nov 2014 18:21:01 +0100] rev 25287
Related with bug 25811: Remove useless function that did nothing

Wed, 19 Nov 2014 18:17:26 +0100Related with bug 25811: Remove message related with removed code
Augusto Mauch <augusto.mauch@openbravo.com> [Wed, 19 Nov 2014 18:17:26 +0100] rev 25286
Related with bug 25811: Remove message related with removed code

Tue, 18 Nov 2014 13:46:30 +0100Related with bug 25811: Process view should be refreshed after invoking process
Augusto Mauch <augusto.mauch@openbravo.com> [Tue, 18 Nov 2014 13:46:30 +0100] rev 25285
Related with bug 25811: Process view should be refreshed after invoking process

After a manual process is invoked, the closeProcessPopup function is called. This function is in charge, among other things, of refreshing the tabs. The problem was that it was doing it taking as the primery view the view that was active when the process was invoked, not the view that defines the button that opens the process, which is the one that most probably be affected by the process.

Fixing this also prevents an unneeded request when invoking a process from the subtab of the tab that defines the process (i.e. booking an order from the sales order line tab).

Tue, 18 Nov 2014 12:34:23 +0100In the changeset e670de099d88 a new parameter, refreshChildren, was added to the OBViewForm.refresh function. This parameter is the second parameter of the function, but in some point it was being passed as the first parameter.
Augusto Mauch <augusto.mauch@openbravo.com> [Tue, 18 Nov 2014 12:34:23 +0100] rev 25284
In the changeset e670de099d88 a new parameter, refreshChildren, was added to the OBViewForm.refresh function. This parameter is the second parameter of the function, but in some point it was being passed as the first parameter.

Tue, 18 Nov 2014 12:09:09 +0100Related with bug 25811: Set flags to prevent multiple requests in proper placei
Augusto Mauch <augusto.mauch@openbravo.com> [Tue, 18 Nov 2014 12:09:09 +0100] rev 25283
Related with bug 25811: Set flags to prevent multiple requests in proper placei

The refreshingWithRecordSelected and refreshingWithScrolledGrid, which are being used to prevent unneeded multiple requests, were being set to true in the wrong place. They were being set to true before ac
tually starting to refresh the grid, and that result that under some circumstances not even the first datasource request was done.

Now they are set to true right after starting the refresh, just after calling OBViewGrid.filterData. They are being reset in the same place as before, in the callback of the filter data function.